and verification textfield.
this fixes the issue that on the 'user menu' we accidentally showed
the qr code and verification field, even if the user already had a
totp code
now it shows 'Unchanged' like when opened via dc/UserView
Signed-off-by: Dominik Csapak
---
www/manager6/dc/TFAEdit.js |
On 2/5/20 10:29 AM, Fabian Grünbichler wrote:
On January 29, 2020 2:29 pm, Fabian Ebner wrote:
This function is intened to be used after doing a migration where some
of the volume IDs changed.
Signed-off-by: Fabian Ebner
---
PVE/AbstractConfig.pm | 61
On 2/5/20 10:38 AM, Fabian Grünbichler wrote:
On January 29, 2020 2:29 pm, Fabian Ebner wrote:
This function is intened to be used after doing a migration where some
of the volume IDs changed.
forgot to ask this - this is in AbstractConfig because you intend to
also re-use this for a similar f
On 2/5/20 11:50 AM, Fabian Grünbichler wrote:
On January 29, 2020 2:30 pm, Fabian Ebner wrote:
Extends the API so that 'volume' can also only be a storage identifier. In
that case the VMID needs to be specified as well. In 'import_volume' a new
name for the allocation is determined. This is usef
On February 6, 2020 9:42 am, Fabian Ebner wrote:
> On 2/5/20 10:29 AM, Fabian Grünbichler wrote:
>> On January 29, 2020 2:29 pm, Fabian Ebner wrote:
>>> This function is intened to be used after doing a migration where some
>>> of the volume IDs changed.
>>>
>>> Signed-off-by: Fabian Ebner
>>> ---
We were using some long deprecated QMP commands in our qemu-server module, most
of which can easily be replaced by their successors.
All of the changes are compatible down to QEMU 2.4[*] according to
docmentation, and since only QMP commands (no machine config) is affected, no
guarding is necessar
...and cleanup surrounding code a bit.
'change' is deprecated, and according to the qapi definition in QEMU it
is 'strongly recommended' to avoid using it.
Signed-off-by: Stefan Reiter
---
PVE/QemuServer.pm | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/PVE/Qem
The fixme got it right :)
Signed-off-by: Stefan Reiter
---
PVE/QemuServer.pm | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 9296634..9e00c8a 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -4865,7 +4865,7 @@ sub vmc
'device' is deprecated since 2.8 in favor of 'id' [0], but since we
always consistently set the id on our drives anyway we can substitute it
easily.
[0] see files qapi/block.json and qapi/block-core.json in QEMU source
code, the online documentation doesn't mention it AFAICT
Signed-off-by: Stefan
query-cpus has been deprecated since 2.12.0 [0] in favor of
query-cpus-fast, which no longer incurs a guest performance penalty on
the guest. The returned information is the same as far as our use case
is concerned.
[0] https://qemu.weilnetz.de/doc/qemu-doc.html#Deprecated-features
Signed-off-by:
migrate_set_downtime, migrate_set_speed and migrate-set-cachesize have
all been deprecated since 2.8 or 2.11 [0]. They still work, but no
reason not to use the correct version.
Note that the downtime-limit parameter switched from seconds to
milliseconds, so convert to that. Slightly improve log ou
hi,
any update here?
On Tue, Jan 14, 2020 at 05:47:01PM +0100, Oguz Bektas wrote:
> * rephrase some parts.
> * update old information
> * add info about pending changes and other "new" features
>
> Co-Authored-by: Aaron Lauterer
> Signed-off-by: Oguz Bektas
> ---
>
> v1->v2:
> changed some of
Signed-off-by: Fabian Ebner
---
www/manager6/window/Snapshot.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/window/Snapshot.js b/www/manager6/window/Snapshot.js
index 3b1070a2..32a66fda 100644
--- a/www/manager6/window/Snapshot.js
+++ b/www/manager6/window/Sna
Signed-off-by: Fabian Ebner
---
www/manager6/window/Snapshot.js | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/www/manager6/window/Snapshot.js b/www/manager6/window/Snapshot.js
index 32a66fda..e4355106 100644
--- a/www/manager6/window/Snapshot.js
++
Signed-off-by: Fabian Ebner
---
www/manager6/tree/SnapshotTree.js | 3 +++
www/manager6/window/Snapshot.js | 4 ++--
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/www/manager6/tree/SnapshotTree.js
b/www/manager6/tree/SnapshotTree.js
index 0636ef68..7b5ac3ed 100644
--- a/www/ma
There is no need to display 'Include RAM' when the VM is not running.
I thought it would make sense to warn users when they take a snapshot
where a file system freeze would be needed, but isn't possible.
Thanks to Oguz and Stefan for some JavaScript consulting.
Fabian Ebner (4):
Fix error mess
If a snapshot of a running VM is taken and the RAM is not included, the backend
checks whether the QEMU Guest Agent is running inside the VM. If it is, it
freezes
the file system, otherwise the snapshot is taken without freezing, which
could lead to an inconsistent file system state in the snapsho
On 2/6/20 10:53 AM, Stefan Reiter wrote:
> We were using some long deprecated QMP commands in our qemu-server module,
> most
> of which can easily be replaced by their successors.
>
> All of the changes are compatible down to QEMU 2.4[*] according to
> docmentation, and since only QMP commands (n
original commits and email can be found here[0]
A out-of-bounds heap buffer access issue was found in the SLiRP
networking implementation of the QEMU emulator. It occurs in tcp_emu()
routine while emulating IRC and other protocols due to unsafe usage of
snprintf(3) function.
A user/process could
lgtm, did not break anything obvious, and fixed my problem i reported
yesterday[0]
Tested-By: Dominik Csapak
0: https://pve.proxmox.com/pipermail/pve-devel/2020-February/041548.html
On 2/5/20 3:03 PM, Oguz Bektas wrote:
instead of calling it while iterating, inbetween the loops is a better
p
On 2/6/20 3:48 PM, Dominik Csapak wrote:
> lgtm, did not break anything obvious, and fixed my problem i reported
> yesterday[0]
>
> Tested-By: Dominik Csapak
>
Thanks, with your T-b applied. Oguz, the commit message lacked the total
"why it happens" and "why does it get solved" parts. Those ar
On Thu, Feb 06, 2020 at 04:53:04PM +0100, Thomas Lamprecht wrote:
> On 2/6/20 3:48 PM, Dominik Csapak wrote:
> > lgtm, did not break anything obvious, and fixed my problem i reported
> > yesterday[0]
> >
> > Tested-By: Dominik Csapak
> >
>
> Thanks, with your T-b applied. Oguz, the commit mess
On 2/6/20 5:13 PM, Oguz Bektas wrote:
>> Further, while this resolves the issue of a broken config in general the
>> underlying "when are config property values equal" is not solved. I can
>> still trigger a fake pending change. For example, assume the following
>> config property present and appli
On Thu, Feb 06, 2020 at 05:15:18PM +0100, Thomas Lamprecht wrote:
> On 2/6/20 5:13 PM, Oguz Bektas wrote:
> >> Further, while this resolves the issue of a broken config in general the
> >> underlying "when are config property values equal" is not solved. I can
> >> still trigger a fake pending chan
On 2/6/20 1:26 PM, Fabian Ebner wrote:
> There is no need to display 'Include RAM' when the VM is not running.
>
> I thought it would make sense to warn users when they take a snapshot
> where a file system freeze would be needed, but isn't possible.
>
> Thanks to Oguz and Stefan for some JavaScr
25 matches
Mail list logo
