On 2/6/20 1:26 PM, Fabian Ebner wrote: > There is no need to display 'Include RAM' when the VM is not running. > > I thought it would make sense to warn users when they take a snapshot > where a file system freeze would be needed, but isn't possible. > > Thanks to Oguz and Stefan for some JavaScript consulting. > > Fabian Ebner (4): > Fix error message > Use 'isCreate' instead of 'snapname' to determine window layout > Hide 'Include RAM' when VM isn't running > Warn about file system state when a freeze would be needed, but isn't > possible > > www/manager6/tree/SnapshotTree.js | 3 ++ > www/manager6/window/Snapshot.js | 68 +++++++++++++++++++++++++------ > 2 files changed, 58 insertions(+), 13 deletions(-) >
applied series, thanks! I made a small followup, moving the hint to the bottom (avoids other elements "jumping" around) and making the message shorter, while the meaning of yours was very good, users tend to not read longer message with a higher chance. _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
