[pve-devel] [RFC PATCH container] fix setting same netX value several times

2020-02-05 Thread Dominik Csapak
when setting a netX option that is semantically the same as the one already set but in a different order, e.g.: in config: net0: name=eth0,bridge=vmbr0,hwaddr=AA:AA:AA:AA:AA:AA,type=veth setting via api: net0: bridge=vmbr0,name=eth0,hwaddr=AA:AA:AA:AA:AA:AA,type=veth the code tries to 'hot-apply'

[pve-devel] [PATCH manager] gui: increase scsi value to that in the backend

2020-02-05 Thread Dominik Csapak
we now can have 31 scsi disks, so show/allow them in the gui Signed-off-by: Dominik Csapak --- www/manager6/Utils.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index 3c2a34d8..86951ed7 100644 --- a/www/manager6/Utils.js +++ b

[pve-devel] [PATCH manager] gui: lxc/Network: add a virtual 'none' option

2020-02-05 Thread Dominik Csapak
sometimes, if users do not want a ipv4/6 address, they set the network mode to 'dhcp' instead of 'static' (with no ip set), in believe this will result in no ip in reality, often no ipv6 dhcp server exists in the environment, and the container start stalls for ~5min trying to get a ipv6 to improv

[pve-devel] applied: [PATCH storage 2/16] Remove unused string

2020-02-05 Thread Fabian Grünbichler
On January 29, 2020 2:30 pm, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > PVE/Storage.pm | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/PVE/Storage.pm b/PVE/Storage.pm > index 0bd103e..5fefa06 100755 > --- a/PVE/Storage.pm > +++ b/PVE/Storage.pm > @@ -573,7 +573,6 @@ sub st

[pve-devel] applied: [PATCH storage 4/16] storage_migrate: also log with an insecure connection if there is a log function

2020-02-05 Thread Fabian Grünbichler
with the following follow-up: commit 8e55b4f28838115c9cb3b85637d6b614da759cf6 Author: Fabian Grünbichler storage_migrate: only set errfunc for send stream since we redirect the output to our (insecure) socket, logfunc is only used for STDERR anyway, so we might as well make

[pve-devel] applied: [PATCH qemu-server 10/16] rename 'volid' to 'drivestr' where it's not only a volume ID

2020-02-05 Thread Fabian Grünbichler
On January 29, 2020 2:30 pm, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > PVE/QemuMigrate.pm | 10 +- > PVE/QemuServer.pm | 4 ++-- > 2 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm > index 49848e8..d025b09 100644 >

[pve-devel] applied: [PATCH qemu-server 11/16] Extract volume ID before calling 'parse_volume_id'

2020-02-05 Thread Fabian Grünbichler
with slight re-grouping and blank lines added, thanks for catching this before it bit us! On January 29, 2020 2:30 pm, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > PVE/QemuMigrate.pm | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/PVE/QemuMigrate.pm

Re: [pve-devel] [PATCH manager] gui: lxc/Network: add a virtual 'none' option

2020-02-05 Thread Thomas Lamprecht
Am 2/5/20 um 9:37 AM schrieb Dominik Csapak: > sometimes, if users do not want a ipv4/6 address, they set the network mode > to 'dhcp' instead of 'static' (with no ip set), in believe > this will result in no ip > > in reality, often no ipv6 dhcp server exists in the environment, and > the contain

Re: [pve-devel] [PATCH manager] gui: increase scsi value to that in the backend

2020-02-05 Thread Thomas Lamprecht
Am 2/5/20 um 9:30 AM schrieb Dominik Csapak: > we now can have 31 scsi disks, so show/allow them in the gui > > Signed-off-by: Dominik Csapak > --- > www/manager6/Utils.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js > in

Re: [pve-devel] [RFC guest-common 1/16] Implement update_volume_ids and add required helpers: foreach_volume and print_volume

2020-02-05 Thread Fabian Grünbichler
On January 29, 2020 2:29 pm, Fabian Ebner wrote: > This function is intened to be used after doing a migration where some > of the volume IDs changed. > > Signed-off-by: Fabian Ebner > --- > PVE/AbstractConfig.pm | 61 +++ > 1 file changed, 61 insertions(+

Re: [pve-devel] [RFC qemu-server 12/16] Implement abstract foreach_volume and print_volume

2020-02-05 Thread Fabian Grünbichler
On January 29, 2020 2:30 pm, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > PVE/QemuConfig.pm | 12 > 1 file changed, 12 insertions(+) > > diff --git a/PVE/QemuConfig.pm b/PVE/QemuConfig.pm > index 1ba728a..a983e52 100644 > --- a/PVE/QemuConfig.pm > +++ b/PVE/QemuConfig.p

Re: [pve-devel] [RFC guest-common 1/16] Implement update_volume_ids and add required helpers: foreach_volume and print_volume

2020-02-05 Thread Fabian Grünbichler
On January 29, 2020 2:29 pm, Fabian Ebner wrote: > This function is intened to be used after doing a migration where some > of the volume IDs changed. forgot to ask this - this is in AbstractConfig because you intend to also re-use this for a similar feature for pve-container? else we could and

[pve-devel] applied: [PATCH v3 cluster 2/4] Enable support for up to 8 corosync links

2020-02-05 Thread Thomas Lamprecht
Am 1/9/20 um 4:31 PM schrieb Stefan Reiter: > add_corosync_link_properties/extract_corosync_link_args are introduced > as helpers to avoid hardcoding links in parameters=>properties on > several occasions, while still providing autocompletion with pvecm by > being seperate parameters instead of an

[pve-devel] applied: [PATCH v3 cluster 3/4] Add verification and fallback to cluster join/addnode

2020-02-05 Thread Thomas Lamprecht
Am 1/9/20 um 4:31 PM schrieb Stefan Reiter: > Verify that the config of the new node is valid and compatible with the > cluster (i.e. that the links for the new node match the currently > configured nodes). > > Additionally, fallback is provided via a new parameter to addnode, > 'new_node_ip'. Pre

Re: [pve-devel] [RFC qemu-server 14/16] Allow specifying targetstorage for offline migration

2020-02-05 Thread Fabian Grünbichler
On January 29, 2020 2:30 pm, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > PVE/API2/Qemu.pm | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm > index 89e2477..f21fb69 100644 > --- a/PVE/API2/Qemu.pm > +++ b/PVE/API2/Qemu.pm > @@ -3379,9 +3

Re: [pve-devel] [PATCH manager] gui: lxc/Network: add a virtual 'none' option

2020-02-05 Thread Dominik Csapak
On 2/5/20 10:13 AM, Thomas Lamprecht wrote: Am 2/5/20 um 9:37 AM schrieb Dominik Csapak: sometimes, if users do not want a ipv4/6 address, they set the network mode to 'dhcp' instead of 'static' (with no ip set), in believe this will result in no ip in reality, often no ipv6 dhcp server exists

Re: [pve-devel] [PATCH manager] gui: lxc/Network: add a virtual 'none' option

2020-02-05 Thread Thomas Lamprecht
Am 2/5/20 um 10:52 AM schrieb Dominik Csapak: >>> +boxLabel: Proxmox.Utils.noneText, >> >> noneText is not capitalized, stands out in a ugly way. > > mhmm.. do we want to add a new gettext for this? Proxmox.Utils.NoneText ? ^^ > we use that already in some contexts where it could be 

[pve-devel] applied: [PATCH apiclient] implement api token support

2020-02-05 Thread Thomas Lamprecht
Am 1/30/20 um 12:07 PM schrieb Fabian Grünbichler: > and add an example for it. > > Signed-off-by: Fabian Grünbichler > --- > PVE/APIClient/LWP.pm | 22 -- > examples/example3.pl | 24 > 2 files changed, 44 insertions(+), 2 deletions(-) > create mode

Re: [pve-devel] [RFC storage 3/16] volume_import: Use a new name when the the name to import with already exists

2020-02-05 Thread Fabian Grünbichler
On January 29, 2020 2:30 pm, Fabian Ebner wrote: > The ID of the new volume is returned and pvesm import prints it. This is > useful for migration, since the storage on the target might already contain > unused/orphaned disks. this is dangerous, and should be explicitly requested. (see patch #6)

Re: [pve-devel] [RFC storage 6/16] pvesm import: allow specifying storage+vmid instead of full volumeid

2020-02-05 Thread Fabian Grünbichler
On January 29, 2020 2:30 pm, Fabian Ebner wrote: > Extends the API so that 'volume' can also only be a storage identifier. In > that case the VMID needs to be specified as well. In 'import_volume' a new > name for the allocation is determined. This is useful for migration where > the storage on the

[pve-devel] [PATCH manager] gui: tree/SnapshotTree: fix gettext invocation

2020-02-05 Thread Dominik Csapak
our gettext extractor cannot handle such statements to extract the gettext, so change it to two gettexts Signed-off-by: Dominik Csapak --- www/manager6/tree/SnapshotTree.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/tree/SnapshotTree.js b/www/manager6/tree/

[pve-devel] [PATCH widget-toolkit] add capitalized NoneText

2020-02-05 Thread Dominik Csapak
we want this in some cases Signed-off-by: Dominik Csapak --- Utils.js | 1 + 1 file changed, 1 insertion(+) diff --git a/Utils.js b/Utils.js index e9dcd79..8f8c55f 100644 --- a/Utils.js +++ b/Utils.js @@ -42,6 +42,7 @@ Ext.define('Proxmox.Utils', { utilities: { enabledText: gettext('Enable

[pve-devel] [PATCH manager v2 2/2] gui: lxc/Network: remove trailing whitespace

2020-02-05 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- new in v2 www/manager6/lxc/Network.js | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/www/manager6/lxc/Network.js b/www/manager6/lxc/Network.js index bfa61180..7610f598 100644 --- a/www/manager6/lxc/Network.js +++ b/www/manager6/lxc/Net

[pve-devel] [PATCH manager v2 1/2] gui: lxc/Network: add a virtual 'none' option

2020-02-05 Thread Dominik Csapak
sometimes, if users do not want a ipv4/6 address, they set the network mode to 'dhcp' instead of 'static' (with no ip set), in believe this will result in no ip in reality, often no ipv6 dhcp server exists in the environment, and the container start stalls for ~5min trying to get a ipv6 to improv

Re: [pve-devel] [RFC PATCH container] fix setting same netX value several times

2020-02-05 Thread Fabian Grünbichler
On February 5, 2020 9:29 am, Dominik Csapak wrote: > when setting a netX option that is semantically the same as the > one already set but in a different order, e.g.: > > in config: > net0: name=eth0,bridge=vmbr0,hwaddr=AA:AA:AA:AA:AA:AA,type=veth > setting via api: > net0: bridge=vmbr0,name=eth0,

Re: [pve-devel] [RFC PATCH container] fix setting same netX value several times

2020-02-05 Thread Dominik Csapak
On 2/5/20 12:20 PM, Fabian Grünbichler wrote: On February 5, 2020 9:29 am, Dominik Csapak wrote: when setting a netX option that is semantically the same as the one already set but in a different order, e.g.: in config: net0: name=eth0,bridge=vmbr0,hwaddr=AA:AA:AA:AA:AA:AA,type=veth setting via

[pve-devel] [PATCH container] apply_pending: call cleanup_pending between change/delete loops

2020-02-05 Thread Oguz Bektas
instead of calling it while iterating, inbetween the loops is a better place in terms of similarity with qemu side (also this should fix the bug that dominik found[0]) [0]: https://pve.proxmox.com/pipermail/pve-devel/2020-February/041573.html Signed-off-by: Oguz Bektas --- src/PVE/LXC/Config.pm

Re: [pve-devel] [PATCH pve-guest-common 1/1] vzdump: added "includename" option

2020-02-05 Thread Alwin Antreich
On Thu, Nov 14, 2019 at 03:01:37PM +0100, Thomas Lamprecht wrote: > On 11/14/19 6:30 AM, Dietmar Maurer wrote: > >> The main reason for this is to identify backups residing on an old backup > >> store like an archive. > >> > >> But I am open. Would you prefer having a manifest included in the ar

[pve-devel] [PATCH v3 docs 01/10] Overhaul Getting Help

2020-02-05 Thread Aaron Lauterer
general overhaul of the documentation, improving phrasing, move open source info Signed-off-by: Aaron Lauterer --- v2 -> v3: rebased on current master v1 -> v2: feedback from thomas[0]: * moved open source hint to mailing list for devs * added suggestions * regarding spaces around dashes (--):

[pve-devel] [PATCH v3 docs 03/10] Overhaul Translation

2020-02-05 Thread Aaron Lauterer
improve phrasing Signed-off-by: Aaron Lauterer --- v2 -> v3: rebased on current master v1 -> v2: applied suggestion from oguz [0] [0] https://pve.proxmox.com/pipermail/pve-devel/2019-September/038952.html translation.adoc | 37 +++-- 1 file changed, 19 insertion

[pve-devel] [PATCH v3 docs 00/10] Documenation overhaul chapt. 1.9 to 3.2

2020-02-05 Thread Aaron Lauterer
This is the first patch series aimed to overhaul our documentation. The main goal is to make it easier to understand and more consistent. Therefore the phrasing is changed in a lot of places, sometimes the ordering of content as well. I tried to align the source to the 80 characters per line wherev

[pve-devel] [PATCH v3 docs 06/10] Overhaul Install from USB flash drive

2020-02-05 Thread Aaron Lauterer
improve phrasing, align style of CLI commands, OSX is now macOS, Rufus with dd mode is preferred to etcher Signed-off-by: Aaron Lauterer --- v2 -> v3: rebased on current master pve-usbstick.adoc | 109 +++--- 1 file changed, 54 insertions(+), 55 deletions

[pve-devel] [PATCH v3 docs 05/10] Overhaul System Requirements

2020-02-05 Thread Aaron Lauterer
improve phrasing, align headlines, rearrange requirement lists Signed-off-by: Aaron Lauterer --- v2 -> v3: rebased on current master v1 -> v2: applied (some) suggestions from oguz [0], IO performance is based on the whole system, not just disks [0] https://pve.proxmox.com/pipermail/pve-devel/20

[pve-devel] [PATCH v3 docs 09/10] OVerhaul System Software Updates

2020-02-05 Thread Aaron Lauterer
improve phrasing, align style of CLI commands Signed-off-by: Aaron Lauterer --- v2 -> v3: rebased on current master v1 -> v2: applied suggestions from oguz [0] [0] https://pve.proxmox.com/pipermail/pve-devel/2019-September/038965.html system-software-updates.adoc | 25 ++--

[pve-devel] [PATCH v3 docs 02/10] Overhaul How To Improve Docs

2020-02-05 Thread Aaron Lauterer
general overhauling, improve phrasing Signed-off-by: Aaron Lauterer --- v2 -> v3: rebased on current master v1 -> v2: applied suggestion from oguz [0] [0] https://pve.proxmox.com/pipermail/pve-devel/2019-September/038952.html howto-improve-pve-docs.adoc | 38 +

[pve-devel] [PATCH v3 docs 08/10] Overhaul Package Repositories

2020-02-05 Thread Aaron Lauterer
improve phrasing, align style of CLI commands Signed-off-by: Aaron Lauterer --- v2 -> v3: rebased on current master pve-package-repos.adoc | 143 + 1 file changed, 74 insertions(+), 69 deletions(-) diff --git a/pve-package-repos.adoc b/pve-package-repos.

[pve-devel] [PATCH v3 docs 07/10] Overhaul Sysadmin

2020-02-05 Thread Aaron Lauterer
improve phrasing Signed-off-by: Aaron Lauterer --- v2 -> v3: rebased on current master v1 -> v2: applied suggestions from oguz [0] [0] https://pve.proxmox.com/pipermail/pve-devel/2019-September/038966.html sysadmin.adoc | 38 ++ 1 file changed, 14 insertion

[pve-devel] [PATCH v3 docs 04/10] Overhaul Installation

2020-02-05 Thread Aaron Lauterer
improve phrasing, align style of CLI commands Signed-off-by: Aaron Lauterer --- v2 -> v3: rebased on current master v1 -> v2: applied suggestions from oguz [0] [0] https://pve.proxmox.com/pipermail/pve-devel/2019-September/038964.html pve-installation.adoc | 260 --

[pve-devel] [PATCH v3 docs 10/10] Fix whitespace and line length

2020-02-05 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- v2 -> v3: rebased on current master getting-help.adoc| 9 - howto-improve-pve-docs.adoc | 4 ++-- pve-installation.adoc| 14 +++--- pve-package-repos.adoc | 11 +-- pve-system-requirements.adoc | 4 ++-- sysa

[pve-devel] [PATCH docs] network: add note for possible fix/workaround in NAT setup

2020-02-05 Thread Oguz Bektas
apparently sometimes users have problems reaching outside internet with some network setups. this is the workaround a user suggested that we should add in the wiki. Signed-off-by: Oguz Bektas --- pve-network.adoc | 9 + 1 file changed, 9 insertions(+) diff --git a/pve-network.adoc b/pve

[pve-devel] [PATCH qemu-server] fix efidisks on storages with minimum sizes bigger than OVMF_VARS.fd

2020-02-05 Thread Dominik Csapak
on storages where the minimum size of images is bigger than the real OVMF_VARS.fd file, they get padded to their minimum size when using such an image, qemu maps it fully to the vm, but the efi does not find the vars region and creates a file on the first efi partition it finds this breaks some s

Re: [pve-devel] [PATCH docs] network: add note for possible fix/workaround in NAT setup

2020-02-05 Thread Stoiko Ivanov
On Wed, 5 Feb 2020 15:57:13 +0100 Oguz Bektas wrote: > apparently sometimes users have problems reaching outside internet with > some network setups. this is the workaround a user suggested that > we should add in the wiki. Thanks for the initiative - that does come up indeed every now and then

[pve-devel] applied: [PATCH firewall] logging: Add missing logmsg for inbound rules

2020-02-05 Thread Thomas Lamprecht
On 1/28/20 5:57 PM, Christian Ebner wrote: > Signed-off-by: Christian Ebner > --- > src/PVE/Firewall.pm | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm > index 255bb9a..d22b15a 100644 > --- a/src/PVE/Firewall.pm > +++ b/src/PVE/Firewall.pm > @@

[pve-devel] applied: [PATCH widget-toolkit] add capitalized NoneText

2020-02-05 Thread Thomas Lamprecht
On 2/5/20 11:59 AM, Dominik Csapak wrote: > we want this in some cases > > Signed-off-by: Dominik Csapak > --- > Utils.js | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Utils.js b/Utils.js > index e9dcd79..8f8c55f 100644 > --- a/Utils.js > +++ b/Utils.js > @@ -42,6 +42,7 @@ Ext.define

[pve-devel] applied: [PATCH manager] gui: tree/SnapshotTree: fix gettext invocation

2020-02-05 Thread Thomas Lamprecht
On 2/5/20 11:58 AM, Dominik Csapak wrote: > our gettext extractor cannot handle such statements to extract the > gettext, so change it to two gettexts > > Signed-off-by: Dominik Csapak > --- > www/manager6/tree/SnapshotTree.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --g

Re: [pve-devel] LDAP integration with G Suite?

2020-02-05 Thread Victor Hooi
Hi, Just a quick update on this - is there any issues with having the cert and certkey point to files on /etc/pve (clustered config filesystem): ldap: anguslab.io > base_dn dc=anguslab,dc=io > server1 ldap.google.com > user_attr uid > cert /etc/pve/Google_2022_05_2

Re: [pve-devel] LDAP integration with G Suite?

2020-02-05 Thread Dominik Csapak
On 2/6/20 5:05 AM, Victor Hooi wrote: Hi, Just a quick update on this - is there any issues with having the cert and certkey point to files on /etc/pve (clustered config filesystem): hi, should not be a problem (we have the nodes api certificates/keys also there) but be aware that those fil