[pve-devel] [PATCH container 1/4] add mknod feature flag

2020-01-30 Thread Wolfgang Bumiller
This causes char and blockdev mknod() and mknodat() calls to be forwarded to the seccomp proxy, so unprivileged containers can finally create /dev/null by themselves. For now this is experimental and therefore added to `features`. Ideally, if this works as intended, we can make it the default in p

[pve-devel] [PATCH container 4/4] set lxc.seccomp.notify.cookie to the vmid

2020-01-30 Thread Wolfgang Bumiller
Signed-off-by: Wolfgang Bumiller --- src/PVE/LXC.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index b4d3b7d..cb2531f 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -496,7 +496,7 @@ sub check_kernel_release { # # This returns a

[pve-devel] [PATCH container 3/4] mask 'mknod' feature by kernel version

2020-01-30 Thread Wolfgang Bumiller
Signed-off-by: Wolfgang Bumiller --- src/PVE/LXC.pm | 5 + 1 file changed, 5 insertions(+) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 9e25ad4..b4d3b7d 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -534,6 +534,11 @@ sub make_seccomp_config { # leave up to the kernel. We may

[pve-devel] [PATCH container 2/4] add a check_kernel_release helper

2020-01-30 Thread Wolfgang Bumiller
Should this go to pve-common? Signed-off-by: Wolfgang Bumiller --- src/PVE/LXC.pm | 24 1 file changed, 24 insertions(+) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index c590fc8..9e25ad4 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -464,6 +464,30 @@ sub get_cgr

[pve-devel] [PATCH container 0/4] use seccomp proxy to handle mknod for

2020-01-30 Thread Wolfgang Bumiller
This series adds an `mknod` feature flag for unprivileged containers which is handled by setting `lxc.seccomp.proxy.notify` to point to the socket where pve-lxc-syscalld is listening (and `….proxy.cookie` to the vmid for possible future use). Currently the daemon handles `mknod()` with the followi

[pve-devel] [PATCH apiclient] implement api token support

2020-01-30 Thread Fabian Grünbichler
and add an example for it. Signed-off-by: Fabian Grünbichler --- PVE/APIClient/LWP.pm | 22 -- examples/example3.pl | 24 2 files changed, 44 insertions(+), 2 deletions(-) create mode 100755 examples/example3.pl diff --git a/PVE/APIClient/LWP.pm b/P

[pve-devel] applied: [PATCH] fix networking.service ordering

2020-01-30 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- I mean what are other services even thinking on depending on network-online.target and thelike.. -.- ...ervice-fix-dependencies-and-ordering.patch | 32 +++ debian/patches/series | 1 + 2 files changed, 33 insertions(+

[pve-devel] applied: [PATCH manager] ui: fix disk controllers sortByPreviousUsage iteration

2020-01-30 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- www/manager6/form/ControllerSelector.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/form/ControllerSelector.js b/www/manager6/form/ControllerSelector.js index e1e9369b..8ba46f17 100644 --- a/www/manager6/form/Controller

[pve-devel] [PATCH docs 2/2] include allowtoken info in api-viewer

2020-01-30 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- api-viewer/PVEAPI.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/api-viewer/PVEAPI.js b/api-viewer/PVEAPI.js index 2416161..53bc36c 100644 --- a/api-viewer/PVEAPI.js +++ b/api-viewer/PVEAPI.js @@ -354,6 +354,9 @@ Ext.onReady(function() {

[pve-devel] [PATCH docs 1/2] document API tokens

2020-01-30 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- Note: we don't yet have a basic 'intro to REST API' section in the user docs. it might make sense to copy some of the related wiki content, explain the ticketing mechanism, etc.pp. pveum.adoc | 53 ++--- 1 file

[pve-devel] applied: [PATCH proxmox-widget-toolkit] window: edit: allow to set submit text for data binding

2020-01-30 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- window/Edit.js | 4 1 file changed, 4 insertions(+) diff --git a/window/Edit.js b/window/Edit.js index aeb8019..ac122c5 100644 --- a/window/Edit.js +++ b/window/Edit.js @@ -100,6 +100,10 @@ Ext.define('Proxmox.window.Edit', { }); }, +se

[pve-devel] [PATCH manager 2/3] gui: refator SnapshotTree

2020-01-30 Thread Dominik Csapak
using the better View, ViewModel, Controller style, while doing this, make it generic so that we can use it for qemu and lxc Signed-off-by: Dominik Csapak --- www/manager6/Makefile | 3 +- www/manager6/lxc/Config.js| 3 +- www/manager6/lxc/SnapshotTree.js | 330 -

[pve-devel] [PATCH manager 0/3] improve SnapshotTree and Window

2020-01-30 Thread Dominik Csapak
series improves the SnapshotTree and window, by removing duplicated code between qemu/lxc, and also reusing the edit window for the snapshot window this also fixes #2572 Guest snapshots not visible with VM.Audit Dominik Csapak (3): gui: refactor snapshot window gui: refator SnapshotTree fix

[pve-devel] [PATCH manager 3/3] fix #2572: gui: make snapshot panel visible for VM.Audit

2020-01-30 Thread Dominik Csapak
with the now rewritten panels, this works as expected Signed-off-by: Dominik Csapak --- www/manager6/lxc/Config.js | 3 ++- www/manager6/qemu/Config.js | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/www/manager6/lxc/Config.js b/www/manager6/lxc/Config.js index 29464706.

[pve-devel] [PATCH manager 1/3] gui: refactor snapshot window

2020-01-30 Thread Dominik Csapak
using an Proxmox.window.Edit, which does many of the things we did manually, also rewrite is in such way that we can use it for qemu and lxc Signed-off-by: Dominik Csapak --- www/manager6/Makefile | 3 +- www/manager6/lxc/Snapshot.js | 206 www/man

[pve-devel] applied: [PATCH proxmox-widget-toolkit] add vlan interface support

2020-01-30 Thread Thomas Lamprecht
On 1/28/20 11:24 AM, Alexandre Derumier wrote: > vlan-raw-device && vlan-id field are only > enabled if interface name is different than interfaceX.Y > > I have added a listener on iface, > to enable them live if user want a custom name for vlan interface > > Signed-off-by: Alexandre Derumier >

[pve-devel] applied: [PATCH widget-toolkit 1/6] ComboGrid: fix on-load validation for blank values

2020-01-30 Thread Thomas Lamprecht
On 1/29/20 11:27 AM, Stefan Reiter wrote: > Commit f32aa3df74 fixed marking multi-select fields with where the store > did not contain a valid value after loading. > > However, it introduced a bug for single-select fields where the value > (before the store-load) was explicitly set to be empty (wh

[pve-devel] applied: [PATCH manager 2/6] gui/cluster: validate cluster name length on create

2020-01-30 Thread Thomas Lamprecht
On 1/29/20 11:27 AM, Stefan Reiter wrote: > API limits this to 15, validate in GUI as well for instant user > feedback. > > Signed-off-by: Stefan Reiter > --- > www/manager6/dc/ClusterEdit.js | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/www/manager6/dc/ClusterEdit.js b/www/manager6/

[pve-devel] applied: [PATCH manager 3/6] gui/cluster: show cluster name from joinInfo in join dialog

2020-01-30 Thread Thomas Lamprecht
On 1/29/20 11:27 AM, Stefan Reiter wrote: > To help a user identify if they put in the joinInfo for the correct > cluster. > > Signed-off-by: Stefan Reiter > --- > www/manager6/dc/ClusterEdit.js | 17 +++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > applied, but followed

Re: [pve-devel] applied: [PATCH proxmox-widget-toolkit] add vlan interface support

2020-01-30 Thread Alexandre DERUMIER
>>applied, thanks! Tried to add some note about the different VLAN >>combinations, >>I hope I made it not even more confusing ^^ I wonder if pve-docs could be improve with some screenshots of network gui ? Currently we only have /etc/network/interfaces text config. BTW, some sdn news: I'm go

[pve-devel] applied: [PATCH manager 0/3] improve SnapshotTree and Window

2020-01-30 Thread Thomas Lamprecht
On 1/30/20 4:58 PM, Dominik Csapak wrote: > series improves the SnapshotTree and window, > by removing duplicated code between qemu/lxc, > and also reusing the edit window for the snapshot window > > this also fixes #2572 Guest snapshots not visible with VM.Audit > applied series, thanks! I did

Re: [pve-devel] [PATCH manager 2/3] gui: refator SnapshotTree

2020-01-30 Thread Thomas Lamprecht
On 1/30/20 4:58 PM, Dominik Csapak wrote: > using the better View, ViewModel, Controller style, > while doing this, make it generic so that we can use it for qemu and lxc > > Signed-off-by: Dominik Csapak > --- > www/manager6/Makefile | 3 +- > www/manager6/lxc/Config.js|

Re: [pve-devel] applied: [PATCH proxmox-widget-toolkit] add vlan interface support

2020-01-30 Thread Thomas Lamprecht
On 1/30/20 6:11 PM, Alexandre DERUMIER wrote: >>> applied, thanks! Tried to add some note about the different VLAN >>> combinations, >>> I hope I made it not even more confusing ^^ > > I wonder if pve-docs could be improve with some screenshots of network gui ? > Currently we only have /etc/net

[pve-devel] applied: [PATCH qemu-server] hotplug_pending: make 'ssd' option non-hotpluggable

2020-01-30 Thread Thomas Lamprecht
On 1/16/20 4:06 PM, Oguz Bektas wrote: > from hotplug_pending we go into 'vmconfig_update_disk', where we check the > hotpluggability of options. > > add 'ssd' there as a non-hotpluggable option (since we'd have to unplug/plug > to > change the drive type) > > Signed-off-by: Oguz Bektas > --- >

[pve-devel] applied: [PATCH v3 cluster 1/4] corosync: add verify_conf

2020-01-30 Thread Thomas Lamprecht
On 1/9/20 4:31 PM, Stefan Reiter wrote: > It does some basic sanity checking, warns the user about encryption > settings and unresolved hostnames, and finally makes sure that all nodes > have the same links configured (as well as comparing the configured > links to specified interfaces, if there ar