On 1/30/20 4:58 PM, Dominik Csapak wrote: > series improves the SnapshotTree and window, > by removing duplicated code between qemu/lxc, > and also reusing the edit window for the snapshot window > > this also fixes #2572 Guest snapshots not visible with VM.Audit >
applied series, thanks! I did a few followup, where two are relevant: 1. fixes for grave style issues (tried to separate that followup from "opinionated style changes") 2. a fix for a TypeError exception due to the delayed load task trying to set on a viewmodel which view has been already destroyed. See reply to patch and git for details. All in all it got quite a bit nicer, so thanks! > Dominik Csapak (3): > gui: refactor snapshot window > gui: refator SnapshotTree > fix #2572: gui: make snapshot panel visible for VM.Audit > > www/manager6/Makefile | 6 +- > www/manager6/lxc/Config.js | 6 +- > www/manager6/lxc/Snapshot.js | 206 ----------------- > www/manager6/lxc/SnapshotTree.js | 326 --------------------------- > www/manager6/qemu/Config.js | 6 +- > www/manager6/qemu/Snapshot.js | 215 ------------------ > www/manager6/qemu/SnapshotTree.js | 316 -------------------------- > www/manager6/tree/SnapshotTree.js | 361 ++++++++++++++++++++++++++++++ > www/manager6/window/Snapshot.js | 131 +++++++++++ > 9 files changed, 502 insertions(+), 1071 deletions(-) > delete mode 100644 www/manager6/lxc/Snapshot.js > delete mode 100644 www/manager6/lxc/SnapshotTree.js > delete mode 100644 www/manager6/qemu/Snapshot.js > delete mode 100644 www/manager6/qemu/SnapshotTree.js > create mode 100644 www/manager6/tree/SnapshotTree.js > create mode 100644 www/manager6/window/Snapshot.js > _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
