On 9/10/19 7:11 PM, Stefan Reiter wrote:
> Signed-off-by: Stefan Reiter
> ---
> www/manager6/form/CPUModelSelector.js | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/www/manager6/form/CPUModelSelector.js
> b/www/manager6/form/CPUModelSelector.js
> index dea6c44c..55532a0d 100644
> ---
On 9/10/19 7:11 PM, Stefan Reiter wrote:
> Uses code from ExtJS 6.0.1 ComboBox.js to overwrite 'doLocalQuery',
> adding a new property 'searchFields' which allows to specify fields from
> the bound store which will all be searched (OR filter, i.e. the searched
> value can appear in any column speci
Thanks for the review, I'll prepare a v3 :)
Just some clarifications inline for this patch.
On 10/2/19 7:49 AM, Thomas Lamprecht wrote:
On 9/30/19 12:58 PM, Stefan Reiter wrote:
Turn CPUConfig into a SectionConfig with parsing/writing support for
custom CPU models. IO is handled using cfs.
Th
On 10/1/19 6:12 PM, Thomas Lamprecht wrote:
On 9/30/19 12:58 PM, Stefan Reiter wrote:
The package will be used for custom CPU models as a SectionConfig, hence
the name. For now we simply move some CPU related helper functions and
declarations over from QemuServer to reduce clutter there.
Singl
On 10/2/19 10:24 AM, Stefan Reiter wrote:
> On 10/1/19 6:12 PM, Thomas Lamprecht wrote:
>> On 9/30/19 12:58 PM, Stefan Reiter wrote:
>>> The package will be used for custom CPU models as a SectionConfig, hence
>>> the name. For now we simply move some CPU related helper functions and
>>> declaratio
On 10/2/19 10:24 AM, Stefan Reiter wrote:
> Thanks for the review, I'll prepare a v3 :)
>
> Just some clarifications inline for this patch.
>
> On 10/2/19 7:49 AM, Thomas Lamprecht wrote:
>> On 9/30/19 12:58 PM, Stefan Reiter wrote:
>>> Turn CPUConfig into a SectionConfig with parsing/writing sup
adds feature parity between qm/pct 'listsnapshot' w.r.t. showing
snapshot tree ordered by date.
Signed-off-by: Oguz Bektas
---
src/PVE/CLI/pct.pm | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm
index 35ad72f..705a015 100755
moved code to GuestHelpers for feature parity with pct
Signed-off-by: Oguz Bektas
---
PVE/CLI/qm.pm | 53 +--
1 file changed, 1 insertion(+), 52 deletions(-)
diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm
index 17935d0..bc9e227 100755
--- a/PVE/CLI/qm
On 9/30/19 2:44 PM, Oguz Bektas wrote:
> Signed-off-by: Oguz Bektas
> ---
> PVE/API2/Qemu.pm | 35 +--
> 1 file changed, 1 insertion(+), 34 deletions(-)
>
> diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
> index 267a08e..aa1cd16 100644
> --- a/PVE/API2/Qemu.pm
>
your commit subject is so general that it is completely of no use..
after reading it one has not idea at all about which function with
was use gets refactored out..
How about:
> abstract config: add general load_current_config implementation
On 9/30/19 2:44 PM, Oguz Bektas wrote:
> since this met
Introduces a timeout parameter for shutting a resource down.
If the parameter is 0, we perform a hard stop instead of a shutdown.
Signed-off-by: Fabian Ebner
---
src/PVE/HA/LRM.pm | 4 ++--
src/PVE/HA/Resources.pm | 2 +-
src/PVE/HA/Resources/PVECT.pm | 14 ++
src
This makes it easier to update the resource configuration from within the
CRM/LRM stack,
which is needed for the new 'stop' command.
Signed-off-by: Fabian Ebner
---
src/PVE/API2/HA/Resources.pm | 34 +
src/PVE/HA/Config.pm | 37 +++
Signed-off-by: Fabian Ebner
---
src/PVE/HA/Env.pm | 6 ++
src/PVE/HA/Env/PVE2.pm | 6 ++
src/PVE/HA/Sim/Env.pm | 6 ++
3 files changed, 18 insertions(+)
diff --git a/src/PVE/HA/Env.pm b/src/PVE/HA/Env.pm
index bb37486..ac569a9 100644
--- a/src/PVE/HA/Env.pm
+++ b/src/PVE/HA/Env
Signed-off-by: Fabian Ebner
---
src/PVE/HA/LRM.pm | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/PVE/HA/LRM.pm b/src/PVE/HA/LRM.pm
index e5eee94..95ec351 100644
--- a/src/PVE/HA/LRM.pm
+++ b/src/PVE/HA/LRM.pm
@@ -774,7 +774,11 @@ sub exec_resource_agent {
r
This should reduce confusion between the old 'set --state stopped' and
the new 'stop' command by making it explicit that it is sent as a crm command.
Signed-off-by: Fabian Ebner
---
src/PVE/CLI/ha_manager.pm | 46 +--
1 file changed, 44 insertions(+), 2 delet
Signed-off-by: Fabian Ebner
---
src/test/test-stop-command1/README | 2 +
src/test/test-stop-command1/cmdlist | 8 +++
src/test/test-stop-command1/hardware_status | 5 ++
src/test/test-stop-command1/log.expect | 69 +
src/test/test-stop-command1/manage
Signed-off-by: Fabian Ebner
---
src/PVE/HA/Sim/Hardware.pm | 8
1 file changed, 8 insertions(+)
diff --git a/src/PVE/HA/Sim/Hardware.pm b/src/PVE/HA/Sim/Hardware.pm
index 3cdc85b..121cd1b 100644
--- a/src/PVE/HA/Sim/Hardware.pm
+++ b/src/PVE/HA/Sim/Hardware.pm
@@ -541,6 +541,7 @@ sub ge
This patch series introduces a new 'stop' command for ha-manager.
The command takes a timeout parameter and in case it is 0, it performs a hard
stop.
The series also includes a test for the new command.
A few changes to how parameters were handled in CRM/LRM were necessary
as well as allowing the
Signed-off-by: Fabian Ebner
---
src/PVE/HA/Sim/Hardware.pm | 14 ++
1 file changed, 14 insertions(+)
diff --git a/src/PVE/HA/Sim/Hardware.pm b/src/PVE/HA/Sim/Hardware.pm
index 9c0ad05..3cdc85b 100644
--- a/src/PVE/HA/Sim/Hardware.pm
+++ b/src/PVE/HA/Sim/Hardware.pm
@@ -109,6 +109,20
Not every command parameter is 'target' anymore, so
it was necessary to modify the parsing of $sd->{cmd}.
Just changing the state to request_stop is not enough,
we need to actually update the service configuration as well.
Signed-off-by: Fabian Ebner
---
src/PVE/HA/Manager.pm | 27 +
container hasn't any pending calls to factor out at this point,
subject makes no sense?
Also hows "refactor code from somwhere" a telling subject?
how about:
> helpers: add pending-aware guest config printer from qemu-server
On 9/30/19 2:44 PM, Oguz Bektas wrote:
> Signed-off-by: Oguz Bektas
On 9/30/19 2:44 PM, Oguz Bektas wrote:
> we overwrite the load_current_config method from AbstractConfig, in
> order to handle cipassword.
>
see my reply to 05/18 regarding squashing, as when thinking about a
sense full commit message for this the felling that this does not
deserves to be a stand
subject:
> use new config helpers from guest-common for pending changes
from a quick glance: OK besides that
On 9/30/19 2:44 PM, Oguz Bektas wrote:
> most of the pending changes related code has been moved into
> AbstractConfig, so we have to call them as class methods from QemuConfig
> inste
On 9/30/19 2:44 PM, Oguz Bektas wrote:
> Signed-off-by: Oguz Bektas
Acked-by: Thomas Lamprecht
Reviewed-by: Thomas Lamprecht
> ---
> PVE/CLI/qm.pm | 28 +---
> 1 file changed, 1 insertion(+), 27 deletions(-)
>
> diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm
> index 17935
On 9/30/19 2:44 PM, Oguz Bektas wrote:
> config parser can now read/write [pve:pending] section. this was named
> such, instead of [PENDING], after on- and offline discussion regarding
> namespacing the pending section and snapshots.
>
> this also adds an optional non-capturing regex group into th
subject proposal:
> api: config: add 'current' param to get config without pending changes
commit message:
> container can now also have pending changes, thus we want to have a method
> to get the current applied config and the one with pending changes. This
> makes the GET config API more consi
some rationale here would be great, e.g.:
> we only can clone from the current applied state, as else
> the on-disk state may not match the one from the config. Further
> this makes it more consistent with the qemu-server behavior.
On 9/30/19 2:44 PM, Oguz Bektas wrote:
> Signed-off-by: Oguz Be
On 9/30/19 2:44 PM, Oguz Bektas wrote:
> Signed-off-by: Oguz Bektas
> ---
> src/PVE/LXC.pm | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
> index 475d9be..65c41f5 100644
> --- a/src/PVE/LXC.pm
> +++ b/src/PVE/LXC.pm
> @@ -1930,6 +1930,13 @@ sub us
On 9/30/19 2:44 PM, Oguz Bektas wrote:
> Signed-off-by: Oguz Bektas
> ---
> src/PVE/API2/LXC/Config.pm | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/src/PVE/API2/LXC/Config.pm b/src/PVE/API2/LXC/Config.pm
> index 7eaef74..2c036f5 100644
> --- a/src/PVE/API2/LXC/Config.pm
> +++ b/
On 9/30/19 2:44 PM, Oguz Bektas wrote:
> use vmconfig_hotplug_pending or vmconfig_apply_pending to apply the
> pending changes, depending on whether the CT is on- or offline.
>
> Signed-off-by: Oguz Bektas
> ---
> src/PVE/LXC/Config.pm | 334 ++
> 1 file c
On September 30, 2019 2:44 pm, Oguz Bektas wrote:
> also use a better naming scheme for methods:
>
> split_flagged_list -> parse_pending_delete
> join_flagged_list -> print_pending_delete
> vmconfig_delete_pending_option -> add_to_pending_delete
> vmconfig_undelete_pending_option -> remove_from_pe
On September 30, 2019 2:44 pm, Oguz Bektas wrote:
> since this method will be both used by qemu and lxc config GET calls, it
> makes sense to move it into AbstractConfig. only difference is that qemu
> also hides the cipassword when it's set. this can be handled by having
> qemu overwrite the metho
you completely ignored my comments for v1 of this patch? the whole code
is identical to qemu-server's, except for cipassword handling. pending
changes are also encoded identically for both pve-container and
qemu-server, so it makes sense to move this to AbstractConfig or
GuestHelpers.pm with an
On September 30, 2019 2:44 pm, Oguz Bektas wrote:
> config parser can now read/write [pve:pending] section. this was named
> such, instead of [PENDING], after on- and offline discussion regarding
> namespacing the pending section and snapshots.
>
> this also adds an optional non-capturing regex gr
On October 2, 2019 12:22 pm, Thomas Lamprecht wrote:
> On 9/30/19 2:44 PM, Oguz Bektas wrote:
>> config parser can now read/write [pve:pending] section. this was named
>> such, instead of [PENDING], after on- and offline discussion regarding
>> namespacing the pending section and snapshots.
>>
>>
On September 30, 2019 2:44 pm, Oguz Bektas wrote:
> we don't need to extract 'delete' here, instead we pass it all as $param
> and extract 'delete', 'revert' and most other things in
> update_pct_config
I already asked that in v1 - wouldn't it make sense to keep the
parameter checks in the API ca
On September 30, 2019 2:44 pm, Oguz Bektas wrote:
> use vmconfig_hotplug_pending or vmconfig_apply_pending to apply the
> pending changes, depending on whether the CT is on- or offline.
>
> Signed-off-by: Oguz Bektas
> ---
> src/PVE/LXC/Config.pm | 334 ++
On September 30, 2019 2:44 pm, Oguz Bektas wrote:
> vmconfig_hotplug_pending is responsible for checking if a key/value pair in
> the
> pending section can be hotplugged, if yes; perform a generic replace,
> or perform specific actions for hotplugging the special cases.
>
> vmconfig_apply_pending
On September 30, 2019 2:44 pm, Oguz Bektas wrote:
> this series makes it possible to add/delete/revert pending changes in
> the backend for containers.
>
> this v2 took longer than expected, mainly because there were small bugs
> popping up everywhere, everytime i tried to change anything :)
>
>
On 9/10/19 7:11 PM, Stefan Reiter wrote:
> Uses a ComboGrid with search feature and a column for vendor. Can be
> sorted by both columns.
>
> Default sort is as given in this file, I tried to align it as
> * AMD
> * Intel
> * Other
> alphabetically and in QEMU order (as before, seems to be release
Hi,
I'm trying to build the current pve-kernel from git, but apparently
this needs some extra tarballs? Am I holding it wrong?
Log (after git clone, git submodule update --init):
$ git describe --always
9e3f73d
$ make
test -f "submodules/ubuntu-disco/README" || git submodule update --init
submo
On 10/2/19 4:46 PM, Chris Hofstaedtler | Deduktiva wrote:
> Hi,
>
> I'm trying to build the current pve-kernel from git, but apparently
> this needs some extra tarballs? Am I holding it wrong?
we have no tarballs anymore, it's submodules all the way down.
>
> Log (after git clone, git submodule
On 10/2/19 4:46 PM, Chris Hofstaedtler | Deduktiva wrote:
> PS: the README still says things about bionic, while this is
> building a disco-based kernel.
>
Thanks for the hint, fixed.
Note that we switched over to Eoan based Kernel on master just today,
you may want to use the pve-kernel-5.0 bra
* Thomas Lamprecht [191002 16:58]:
> On 10/2/19 4:46 PM, Chris Hofstaedtler | Deduktiva wrote:
> Either don't do the initial "git submodule update --init" yourself and
> let the makefile handle that or add the "--recursive" flag..
>
> But a fresh
> # git clone git://git.proxmox.com/git/pve-kernel
- Le 30 Sep 19, à 11:52, Thomas Lamprecht t.lampre...@proxmox.com a écrit :
>
> Depends on the outcome of above, but effectively we would like to
> not have the choice between "working or not", so ideally we can
> just either fix it in QEMU or set the respective (working) option
> for all new
45 matches
Mail list logo
