Re: [pve-devel] [PATCH v6 pve-storage 0/6] FreeNAS storage plugin

2017-06-20 Thread Michael Rasmussen
On Tue, 20 Jun 2017 09:22:52 +0200 Fabian Grünbichler wrote: > once you are happy with your commits: > "git format-patch -v7 --signoff --cover-letter HEAD~N" (where N is the > number of commits) > Just realized that FreeNAS 11 was released last week ;-) So when this first version is acceptet and

Re: [pve-devel] [PATCH v6 pve-storage 0/6] FreeNAS storage plugin

2017-06-20 Thread datanom.net
On 2017-06-20 12:59, datanom.net wrote: s/Are first commit!/After first commit!/ Strange, works now after starting over. To optimistic. If I cherry pick code in the first commit I am only able to add new code which is considered new if this code is in the original file is below the first chun

Re: [pve-devel] [PATCH v6 pve-storage 0/6] FreeNAS storage plugin

2017-06-20 Thread datanom.net
s/Are first commit!/After first commit!/ Strange, works now after starting over. -- Hilsen/Regards Michael Rasmussen Get my public GnuPG keys: michael rasmussen cc http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xD3C9A00E mir datanom net http://pgp.mit.edu:11371/pks/lookup?op=get&search=

Re: [pve-devel] [PATCH v6 pve-storage 0/6] FreeNAS storage plugin

2017-06-20 Thread datanom.net
On 2017-06-20 11:14, datanom.net wrote: On 2017-06-20 09:22, Fabian Grünbichler wrote: followed by the following for each commit: "git add -p PVE/Storage/FreeNASPlugin.pm" (to selectively add parts of the plugin code to the staging area) "git diff --cached" (to review what you are about to commi

Re: [pve-devel] [PATCH v6 pve-storage 0/6] FreeNAS storage plugin

2017-06-20 Thread datanom.net
On 2017-06-20 09:22, Fabian Grünbichler wrote: followed by the following for each commit: "git add -p PVE/Storage/FreeNASPlugin.pm" (to selectively add parts of the plugin code to the staging area) "git diff --cached" (to review what you are about to commit) "git commit" (to create a commit) Do

Re: [pve-devel] [PATCH v6 pve-storage 0/6] FreeNAS storage plugin

2017-06-20 Thread Fabian Grünbichler
On Mon, Jun 19, 2017 at 05:13:18PM +0200, m...@datanom.net wrote: > From: Michael Rasmussen > > (Resending, Diregard previous) this is almost the opposite of what I requested (I haven't looked at the actual changes, I am talking about the organization of the patches). I'll do further review once

[pve-devel] [PATCH v6 pve-storage 0/6] FreeNAS storage plugin

2017-06-19 Thread mir
From: Michael Rasmussen (Resending, Diregard previous) This patch series adds a storage plugin for FreeNAS using the FreeNAS API. The plugin supports both Qemu and LXC VM. Features supported, see below: VM CT create YES YES delete

Re: [pve-devel] [PATCH v6 pve-storage 0/6] FreeNAS storage plugin

2017-06-19 Thread Michael Rasmussen
On Mon, 19 Jun 2017 16:50:43 +0200 Michael Rasmussen wrote: > Hi all, > > I do not know why this '[PATCH v6 pve-storage 1/1] A lot of bug fixes > and clean-ups' is part of the series!!?? It is identical to '[PATCH v6 > pve-storage 6/6] Bug fixes and clean-ups in response to review from Fabian.'

[pve-devel] [PATCH v6 pve-storage 0/6] FreeNAS storage plugin

2017-06-19 Thread mir
From: Michael Rasmussen This patch series adds a storage plugin for FreeNAS using the FreeNAS API. The plugin supports both Qemu and LXC VM. Features supported, see below: VM CT create YES YES delete YES YES resize

Re: [pve-devel] [PATCH v6 pve-storage 0/6] FreeNAS storage plugin

2017-06-19 Thread Michael Rasmussen
Hi all, I do not know why this '[PATCH v6 pve-storage 1/1] A lot of bug fixes and clean-ups' is part of the series!!?? It is identical to '[PATCH v6 pve-storage 6/6] Bug fixes and clean-ups in response to review from Fabian.' -- Hilsen/Regards Michael Rasmussen Get my public GnuPG keys: michae