Re: [pve-devel] [PATCH storage 1/4] base plugin: Increase test coverage

2020-04-09 Thread Dominic Jäger
On Thu, Apr 09, 2020 at 09:37:37AM +0200, Alwin Antreich wrote: > On Thu, Apr 02, 2020 at 01:34:11PM +0200, Dominic Jäger wrote: > > Signed-off-by: Dominic Jäger > > + > > +is (($plugin->parse_volname($iso_volname))[$type_index], > > +$iso_type, 'parse_volname: type for iso'); > > +is (($plugi

Re: [pve-devel] [PATCH storage 1/4] base plugin: Increase test coverage

2020-04-09 Thread Alwin Antreich
On Thu, Apr 02, 2020 at 01:34:11PM +0200, Dominic Jäger wrote: > Signed-off-by: Dominic Jäger > --- > This did not exist separately in RFC > > test/Makefile| 5 +- > test/run_plugin_tests.pl | 184 +++ > 2 files changed, 188 insertions(+), 1 dele

Re: [pve-devel] [PATCH storage 1/4] base plugin: Increase test coverage

2020-04-08 Thread Dominik Csapak
sry for taking so long with the review, i am looking over now, after that i will test comments inline On 4/2/20 1:34 PM, Dominic Jäger wrote: Signed-off-by: Dominic Jäger --- This did not exist separately in RFC test/Makefile| 5 +- test/run_plugin_tests.pl | 184

[pve-devel] [PATCH storage 1/4] base plugin: Increase test coverage

2020-04-02 Thread Dominic Jäger
Signed-off-by: Dominic Jäger --- This did not exist separately in RFC test/Makefile| 5 +- test/run_plugin_tests.pl | 184 +++ 2 files changed, 188 insertions(+), 1 deletion(-) create mode 100755 test/run_plugin_tests.pl diff --git a/test/Makef