Re: [pve-devel] [PATCH manager 1/2] vzdump: handle backup to stdout correctly

2017-09-12 Thread Dietmar Maurer
> - my $logfile = $task->{logfile} = "$opts->{dumpdir}/$basename.log"; > + my $logfile = $task->{logfile} = !$opts->{stdout} ? > "$opts->{dumpdir}/$basename.log" : ''; Why don't we want logs here? > > my $ext = $vmtype eq 'qemu' ? '.vma' : '.tar'; > my ($comp, $comp_ext) =

[pve-devel] [PATCH manager 1/2] vzdump: handle backup to stdout correctly

2017-09-12 Thread Philip Abernethy
Checks for dumpdir or tmpdir backups don't apply to stdout, so we can skip the checks involved in those methods. --- PVE/VZDump.pm | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm index 004672d1..e5777ea5 100644 --- a/PVE/VZDump.pm +++ b/PVE