Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-30 Thread Alexandre DERUMIER
It's works fine for me with pve-kernel 4.1 from today git - Mail original - De: "dietmar" À: "aderumier" Cc: "pve-devel" Envoyé: Jeudi 30 Juillet 2015 13:09:35 Objet: Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3 > >>I tested w

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-30 Thread Dietmar Maurer
> >>I tested with debian kernel: > > >>linux-image-4.1.0-trunk-amd64_4.1.2-1~exp1_amd64.deb > > >>that works. > > >>I also update pve-kernel to 4.1.3 (ubuntu wily): > > >>https://git.proxmox.com/?p=pve-kernel.git;a=summary > > >>but got same problem with this kernel. > > that's strange, any

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-30 Thread Alexandre DERUMIER
's strange, any difference in CONFIG files between both kernel ? >>Anyway, I will commit the changes, so that more people can test. I'll try it today. - Mail original - De: "dietmar" À: "aderumier" Cc: "pve-devel" Envoyé: Jeudi 30 Juil

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-30 Thread Dietmar Maurer
> > . sysctl tuning maybe ? > > >>I cannot find any relevant difference. > > I'm out of ideas I tested with debian kernel: linux-image-4.1.0-trunk-amd64_4.1.2-1~exp1_amd64.deb that works. I also update pve-kernel to 4.1.3 (ubuntu wily): https://git.proxmox.com/?p=pve-kernel.git;

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-30 Thread Alexandre DERUMIER
- Mail original - De: "dietmar" À: "aderumier" Cc: "pve-devel" Envoyé: Jeudi 30 Juillet 2015 06:07:45 Objet: Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3 > >>OK, it works perfectly inside a newly installed VM, but not on my host :-/ >

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Dietmar Maurer
> >>OK, it works perfectly inside a newly installed VM, but not on my host :-/ > > . sysctl tuning maybe ? I cannot find any relevant difference. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/p

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Alexandre DERUMIER
iller" Cc: "pve-devel" Envoyé: Mercredi 29 Juillet 2015 17:43:03 Objet: Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3 maybe this iproute2 (4.1) patch http://git.kernel.org/cgit/linux/kernel/git/shemminger/iproute2.git/commit/?id=c079e121a73af5eb49e003b13607e8a690331df6

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Alexandre DERUMIER
>>OK, it works perfectly inside a newly installed VM, but not on my host :-/ . sysctl tuning maybe ? - Mail original - De: "dietmar" À: "aderumier" Cc: "pve-devel" Envoyé: Mercredi 29 Juillet 2015 19:00:12 Objet: Re: [pve-devel] [PATC

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Dietmar Maurer
> > >>Tested with totally empty /etc/network/interfaces, and > > >>I do not get above entry for testbridge. > > >> > > >>I am a bit out of ideas. > > > > Damn, I really don't known. > > (and it seem that it's working for wolfgang ?) > > yes. But it does not work for me. Will try on a new install

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Dietmar Maurer
> >>Tested with totally empty /etc/network/interfaces, and > >>I do not get above entry for testbridge. > >> > >>I am a bit out of ideas. > > Damn, I really don't known. > (and it seem that it's working for wolfgang ?) yes. But it does not work for me. Will try on a new installation. ___

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Alexandre DERUMIER
uot;aderumier" Cc: "pve-devel" Envoyé: Mercredi 29 Juillet 2015 17:56:49 Objet: Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3 > Damn, with an empty /etc/network/interfaces > > > #brctl addbr testbridge > #echo 1 > /sys/class/net/testbridge/bridge/vl

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Dietmar Maurer
> Damn, with an empty /etc/network/interfaces > > > #brctl addbr testbridge > #echo 1 > /sys/class/net/testbridge/bridge/vlan_filtering > #bridge vlan add dev testbridge vid 100 self > > #bridge -c vlan > > testbridge 1 PVID Egress Untagged >100 Tested with totally empty /etc/network/

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Alexandre DERUMIER
low, when the vm is starting. If user want to tag inside the vm, we could add an option "vlans filter" or something like that. - Mail original - De: "aderumier" À: "Wolfgang Bumiller" Cc: "pve-devel" Envoyé: Mercredi 29 Juillet 2015 14:08:59

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Alexandre DERUMIER
;something like that. I have the "message truncated" warning when I have defined around 1800vlans. (can be 1-1800 on 1 interface, or 1-900 + 1-900 on 2 interfaces,...). - Mail original - De: "aderumier" À: "Wolfgang Bumiller" Cc: "pve-devel&q

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Alexandre DERUMIER
warning when I have defined around 1800vlans. (can be 1-1800 on 1 interface, or 1-900 + 1-900 on 2 interfaces,...). - Mail original - De: "aderumier" À: "Wolfgang Bumiller" Cc: "pve-devel" Envoyé: Mercredi 29 Juillet 2015 16:08:34 Objet: Re: [pve-

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Alexandre DERUMIER
;aderumier" À: "Wolfgang Bumiller" Cc: "pve-devel" Envoyé: Mercredi 29 Juillet 2015 14:08:59 Objet: Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3 >>both the testbridge >>>>and dum0 interface disappear even from the output of `ip link` wh

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Alexandre DERUMIER
el/git/torvalds/linux.git/commit/?id=fed0a159c8c5e453d79d6a73897c576efea0a8a5 "bridge: fix link notification skb size calculation to include vlan ranges" ? - Mail original - De: "aderumier" À: "Wolfgang Bumiller" Cc: "pve-devel" Envoyé: Mercredi 29 Juillet 2015 13:59:15 Objet: Re

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Alexandre DERUMIER
, "pve-devel" Envoyé: Mercredi 29 Juillet 2015 13:47:20 Objet: Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3 The manual way works for me on my host. The /etc/network/interfaces way doesn't. Presumably because I didn't `apt-get purge vlan`. In my test VMs where

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Wolfgang Bumiller
vid 2-4094 > > eth0 1PVID Egress Untagged > 2-4094 > testbridge 1 PVID Egress Untagged >100 > > > can you reproduce it ? > > > ----- Mail original ----- > De: "dietmar" > À: "aderumier" > Cc: "pve-devel&q

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Dietmar Maurer
> Damn, with an empty /etc/network/interfaces why is that required? > #brctl addbr testbridge > #echo 1 > /sys/class/net/testbridge/bridge/vlan_filtering > #bridge vlan add dev testbridge vid 100 self > > #bridge -c vlan > > testbridge 1 PVID Egress Untagged >100 > With non-empty /etc

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Alexandre DERUMIER
uot;aderumier" Cc: "pve-devel" Envoyé: Mercredi 29 Juillet 2015 12:47:32 Objet: Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3 > does it work better if you setup the ip on bridge vlan interface ? no ___ pve-devel m

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Dietmar Maurer
> does it work better if you setup the ip on bridge vlan interface ? no ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Alexandre DERUMIER
: Mercredi 29 Juillet 2015 12:25:41 Objet: Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3 > I tested your config, and it's working fine for me > > #iproute2 4.0.0-1 > > #kernel 3.19.8-1-pve (with vlan-range patches) same versions here > simply enabling vlan

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Dietmar Maurer
> I tested your config, and it's working fine for me > > #iproute2 4.0.0-1 > > #kernel 3.19.8-1-pve (with vlan-range patches) same versions here > simply enabling vlan filtering > > echo 1 > /sys/class/net/vmbr0/bridge/vlan_filtering > > should at least give you vmbr0 with default vlan 1 VID

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Alexandre DERUMIER
ult vlan 1 VID # bridge -c vlan port vlan ids vmbr0 1 PVID Egress Untagged - Mail original - De: "dietmar" À: "aderumier" Cc: "pve-devel" Envoyé: Mercredi 29 Juillet 2015 11:18:56 Objet: Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3 >

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Michael Rasmussen
On Wed, 29 Jul 2015 04:42:42 +0200 Alexandre Derumier wrote: > This add support to enable vlan aware bridge, > and management interfaces > I don't know whether this is related to the new network scripts. I have recently been doing some experiments with the openvswitch-switch package from Debian

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Dietmar Maurer
> #ip addr ? > > #brctl show ? > those are quite normal. > can you post your /etc/network/interfaces ? see previous post, but here it is: auto vmbr0 iface vmbr0 inet static address 192.168.2.35 netmask 255.255.240.0 gateway 192.168.2.1 bridg

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Alexandre DERUMIER
#ip addr ? #brctl show ? can you post your /etc/network/interfaces ? - Mail original - De: "dietmar" À: "aderumier" Cc: "pve-devel" Envoyé: Mercredi 29 Juillet 2015 09:43:05 Objet: Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3 > but

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Dietmar Maurer
> but you should see the bridge itself: > > port vlan ids > vmbr0 1 PVID Egress Untagged >100 I only see: # bridge -c vlan portvlan ids eth0 1 PVID Egress Untagged 2-4094 ?? ___ pve-devel mailing list pve-devel@pve.proxmox

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Alexandre DERUMIER
lanport script #ifup vmbr0.100 should do it - Mail original - De: "dietmar" À: "aderumier" Cc: "pve-devel" Envoyé: Mercredi 29 Juillet 2015 09:28:00 Objet: Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3 > we need to use #bridge -c vlan >

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Dietmar Maurer
> we need to use #bridge -c vlan > > to display range. (compressed format). Ah (that is also not mentioned in the manual page). > If not, I think it's trying to display line by line each vlan, and it's too > much for the buffer or something like that. > (No idea how to tune that) So I get the

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Alexandre DERUMIER
t;pve-devel" Envoyé: Mercredi 29 Juillet 2015 09:22:58 Objet: Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3 On Wed, Jul 29, 2015 at 09:09:18AM +0200, Alexandre DERUMIER wrote: > >>The vlan package also provides a file I'd like to keep (iow. provide > >>

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Wolfgang Bumiller
On Wed, Jul 29, 2015 at 09:09:18AM +0200, Alexandre DERUMIER wrote: > >>The vlan package also provides a file I'd like to keep (iow. provide > >>with pve-manager): > >> > >>- if-up.d/ip > > I wonder why it's in vlan package ? Well, there's that comment in the file: # This should probably go in

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Alexandre DERUMIER
Envoyé: Mercredi 29 Juillet 2015 08:56:40 Objet: Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3 > replace current vlan package, without vconfig usage and cleanups > It's only needed to create vlan interface from bridge_ports. The vlan package also provides a file I'd l

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-28 Thread Wolfgang Bumiller
> replace current vlan package, without vconfig usage and cleanups > It's only needed to create vlan interface from bridge_ports. The vlan package also provides a file I'd like to keep (iow. provide with pve-manager): - if-up.d/ip This one provides options to set proxy_arp and rp_filter. Of cour

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-28 Thread Alexandre DERUMIER
t;aderumier" , "pve-devel" Envoyé: Mercredi 29 Juillet 2015 08:46:53 Objet: Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3 after reboot, I get: # bridge vlan port vlan ids Message truncated using iproute2 4.0.0-1. Does that work for you? > On July 29, 2015 at 8:35 AM

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-28 Thread Dietmar Maurer
after reboot, I get: # bridge vlan portvlan ids Message truncated using iproute2 4.0.0-1. Does that work for you? > On July 29, 2015 at 8:35 AM Dietmar Maurer wrote: > > > > test you patches with the following config: > > ignore me - i forgot to reboot with latest kernel patches ... >

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-28 Thread Dietmar Maurer
> test you patches with the following config: ignoreme - i forgot to reboot with latest kernel patches ... ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-28 Thread Dietmar Maurer
test you patches with the following config: auto vmbr0 iface vmbr0 inet static address 192.168.2.35 netmask 255.255.240.0 gateway 192.168.2.1 bridge_vlan_aware yes bridge_ports eth0 bridge_stp off bridge_fd 0 auto vmbr0.1

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-28 Thread Wolfgang Bumiller
On Wed, Jul 29, 2015 at 07:36:35AM +0200, Dietmar Maurer wrote: > Maybe we can simply skip ports with dots? > > diff --git a/bridgevlan b/bridgevlan > index 2e7612c..bf9cf82 100755 > --- a/bridgevlan > +++ b/bridgevlan > @@ -38,16 +38,20 @@ do >for port in $i >do > if [ "$MODE" = "sta

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-28 Thread Dietmar Maurer
Maybe we can simply skip ports with dots? diff --git a/bridgevlan b/bridgevlan index 2e7612c..bf9cf82 100755 --- a/bridgevlan +++ b/bridgevlan @@ -38,16 +38,20 @@ do for port in $i do if [ "$MODE" = "start" ] && [ -d /sys/class/net/$IFACE/brif/$port ]; then - #we allow vlan to pass

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-28 Thread Dietmar Maurer
> > - if [[ $port =~ ^(eth|bond|wlan)[0-9]{1,2}$ ]] > > + if [[ $port =~ "^(eth|bond|wlan)[0-9]{1,2}$" ]] > > OK, this does not work because dash does not have [[ ]] syntax, > and 'test' have no regex support. Do we really need that regex? What if we simply use all ports? _

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-28 Thread Dietmar Maurer
> - if [[ $port =~ ^(eth|bond|wlan)[0-9]{1,2}$ ]] > + if [[ $port =~ "^(eth|bond|wlan)[0-9]{1,2}$" ]] OK, this does not work because dash does not have [[ ]] syntax, and 'test' have no regex support. ___ pve-devel mailing list pve-devel@pve.pr

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-28 Thread Dietmar Maurer
lintian reports a syntax error: E: pve-manager: shell-script-fails-syntax-check etc/network/if-up.d/bridgevlan # sh -n bridgevlan bridgevlan: 42: bridgevlan: Syntax error: "(" unexpected (expecting "then") I wonder if we can simply quote the regex? diff --git a/bridgevlan b/bridgevlan index 2e7

[pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-28 Thread Alexandre Derumier
This add support to enable vlan aware bridge, and management interfaces example: 1 bridge and 1 administration port on vlan 100 auto vmbr0 iface vmbr0 inet manual bridge_ports eth0 bridge_stp off bridge_fd 0 bridge_vlan_aware yes bridge_vids 10-15 auto vmb