Re: [pve-devel] [PATCH] Added translations

2013-08-29 Thread Damien PIQUET
Yes, I'll do this as soon as I can. Sorry you had to make so much cleanups. 2013/8/29 Dietmar Maurer : > Just committed you patches, and applied further cleanups: > > https://git.proxmox.com/?p=pve-manager.git;a=summary > > Many thanks for the patch! > > Do you also plan to provide an updated fr.p

Re: [pve-devel] [PATCH] Added translations

2013-08-29 Thread Damien PIQUET
How is it possible ? I pulled the last version from git before resending the patch. Did I do something wrong when creating it? 2013/8/29 Dietmar Maurer : > Just to Note, this patch removes the whole GlusterFS functionaliy silently! > > Will try to apply anyways an re-add it. >

Re: [pve-devel] [PATCH 768/768] Added translations

2013-08-19 Thread Damien PIQUET
Implementing a translatable string is not only for French or German versions of the translations. Each language has its own way to translate things, and there's never only one way to to this. I just wanted to give the translators the ability to translate every word of the interface to adapt. "Pont

Re: [pve-devel] [PATCH 768/768] Added translations

2013-08-19 Thread Damien PIQUET
That piece of code was a previous test, i did not want to send it, sorry for that. Why don't you want to translate those expressions ? I think the interface should be completely in the user's language, or not translated at all. An half translation does not look very "professional". 2013/8/19 Dietm

[pve-devel] [PATCH] INotify.pm: use domain instead of search in /etc/resolv.conf

2013-03-18 Thread Damien PIQUET
This version uses the first entry of search if no domain is found. When edited, it creates or replaces domain entry. It does not update search entries at all. Signed-off-by: Damien PIQUET --- data/PVE/INotify.pm | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff

[pve-devel] [PATCH] Replace "search" with "domain" in /etc/resolv.conf

2013-03-09 Thread Damien PIQUET
Signed-off-by: Damien PIQUET --- proxinstall |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proxinstall b/proxinstall index 0b9e3b0..8bed1e6 100755 --- a/proxinstall +++ b/proxinstall @@ -782,7 +782,7 @@ sub extract_data { # configure dns - my

[pve-devel] [PATCH] Changed 'Search' to 'Domain' in web interface DNS edition

2013-03-09 Thread Damien PIQUET
Signed-off-by: Damien PIQUET --- www/manager/node/DNSEdit.js |2 +- www/manager/node/DNSView.js |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager/node/DNSEdit.js b/www/manager/node/DNSEdit.js index d402ef5..a8c6f7d 100644 --- a/www/manager/node/DNSEdit.js

Re: [pve-devel] [PATCH] pve-manager: use domain instead of search in /etc/resolv.conf

2013-03-08 Thread damien piquet
3/3/8 Damien PIQUET : > > Signed-off-by: Damien PIQUET > --- > data/PVE/INotify.pm | 20 +++- > 1 file changed, 15 insertions(+), 5 deletions(-) > > diff --git a/data/PVE/INotify.pm b/data/PVE/INotify.pm > index 850668a..35c71b9 100644 > --- a/data

[pve-devel] [PATCH] pve-manager: use domain instead of search in /etc/resolv.conf

2013-03-08 Thread Damien PIQUET
Signed-off-by: Damien PIQUET --- data/PVE/INotify.pm | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/data/PVE/INotify.pm b/data/PVE/INotify.pm index 850668a..35c71b9 100644 --- a/data/PVE/INotify.pm +++ b/data/PVE/INotify.pm @@ -532,13 +532,18 @@ sub

Re: [pve-devel] [PATCH] INotify.pm: Correct read_etc_resolv_conf search filter

2013-03-08 Thread damien piquet
Yes this is the default. The problem is when we got two entries in search and no domain. Le 8 mars 2013 13:35, "Dietmar Maurer" a écrit : > > I am not sure this is useful because in most cases search value will be > equal to > > domain value but we would be sure we don't break anything > > fom ma

Re: [pve-devel] [PATCH] INotify.pm: Correct read_etc_resolv_conf search filter

2013-03-08 Thread damien piquet
Maybe it would be better to duplicate and keep the first entry? If a configuration uses it already, we should avoid destroying that configuration: #cat /etc/resolv.conf search domain1.com domain2.com nameserver 1.2.3.4 would give: search domain1.com domain2.com domain domain1.com nameserver 1.2.

Re: [pve-devel] [PATCH] INotify.pm: Correct read_etc_resolv_conf search filter

2013-03-08 Thread damien piquet
That seems a good idea. We should also change the field name in web interface to keep it clear. 2013/3/8 Dietmar Maurer : >> That's what I think too. We are using search as if it was domain. In fact, >> domain >> defines the domain the computer is actually on, search field defines the >> domain

Re: [pve-devel] [PATCH] INotify.pm: Correct read_etc_resolv_conf search filter

2013-03-08 Thread damien piquet
That's what I think too. We are using search as if it was domain. In fact, domain defines the domain the computer is actually on, search field defines the domain where to resolve relatives names. I think we must not use search field when creating ssl certificates ! So we need to modify resolv.con

[pve-devel] [PATCH] pve-manager: Added format to search value in update_dns method

2013-03-07 Thread Damien PIQUET
Signed-off-by: Damien PIQUET --- PVE/API2/Nodes.pm |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 0dac6af..e5c28e2 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm @@ -610,7 +610,7 @@ __PACKAGE__->register_met

[pve-devel] [PATCH] INotify.pm: Correct read_etc_resolv_conf search filter

2013-03-07 Thread Damien PIQUET
Signed-off-by: Damien PIQUET --- data/PVE/INotify.pm |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/PVE/INotify.pm b/data/PVE/INotify.pm index 850668a..0d871d9 100644 --- a/data/PVE/INotify.pm +++ b/data/PVE/INotify.pm @@ -536,7 +536,7 @@ sub read_etc_resolv_conf

Re: [pve-devel] [PATCH] Add dns name format to search value for update_dns method

2013-03-06 Thread damien piquet
Oh yes, got it ! check_format function right ? Thanks for your help 2013/3/6 Dietmar Maurer : >> That's right. I can't find dns-name-list in JSONSchema. Should we add it ? > > That works out of the box - magically ;-) Just try. > ___ pve-devel mailing li

Re: [pve-devel] [PATCH] Add dns name format to search value for update_dns method

2013-03-06 Thread damien piquet
That's right. I can't find dns-name-list in JSONSchema. Should we add it ? 2013/3/4 Dietmar Maurer : >> diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 0dac6af..e35f01b >> 100644 >> --- a/PVE/API2/Nodes.pm >> +++ b/PVE/API2/Nodes.pm >> @@ -610,13 +610,13 @@ __PACKAGE__->register_method({

Re: [pve-devel] [PATCH] Minor french translation corrections

2013-03-04 Thread damien piquet
2013/3/5 Dietmar Maurer : > The whole fr.po file contains many 'fuzzy' entries - why? > > Note: fuzzy entries are simply skipped and not used. > > Can we fix that also? > >> -Original Message- >> From: pve-devel-boun...@pve.proxmox.com [mailto:pve-deve

[pve-devel] [PATCH] Minor french translation corrections

2013-03-04 Thread Damien PIQUET
Signed-off-by: Damien PIQUET --- po/fr.po | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/po/fr.po b/po/fr.po index 72c7cb0..2ae7add 100644 --- a/po/fr.po +++ b/po/fr.po @@ -65,7 +65,7 @@ msgid "" "data." msgstr &q

[pve-devel] [PATCH] Minor translation corrections Added Hostname and DNS domain translations in openVZ DNS settings

2013-03-02 Thread Damien PIQUET
Signed-off-by: Damien PIQUET --- po/fr.po | 44 www/manager/openvz/DNS.js |4 ++-- 2 files changed, 30 insertions(+), 18 deletions(-) diff --git a/po/fr.po b/po/fr.po index 72c7cb0..4e0407d 100644 --- a/po/fr.po +++ b/po/fr.po

[pve-devel] [PATCH] Add Search domain validation in node DNS settings

2013-03-01 Thread Damien PIQUET
Signed-off-by: Damien PIQUET --- www/manager/node/DNSEdit.js |9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/www/manager/node/DNSEdit.js b/www/manager/node/DNSEdit.js index d402ef5..21015b6 100644 --- a/www/manager/node/DNSEdit.js +++ b/www/manager/node/DNSEdit.js

[pve-devel] [PATCH] Add DNS search value validation in create CT interface

2013-03-01 Thread Damien PIQUET
Signed-off-by: Damien PIQUET --- www/manager/openvz/CreateWizard.js |7 +++ 1 file changed, 7 insertions(+) diff --git a/www/manager/openvz/CreateWizard.js b/www/manager/openvz/CreateWizard.js index 28f0114..fb5a136 100644 --- a/www/manager/openvz/CreateWizard.js +++ b/www/manager

[pve-devel] [PATCH] Add dns name format to search value for update_dns method

2013-03-01 Thread Damien PIQUET
Signed-off-by: Damien PIQUET --- PVE/API2/Nodes.pm |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 0dac6af..e35f01b 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm @@ -610,13 +610,13 @@ __PACKAGE__->register_met

[pve-devel] [PATCH] bugfix #301 Add container hostname validation in GUI

2013-02-28 Thread Damien PIQUET
Signed-off-by: Damien PIQUET --- www/manager/openvz/CreateWizard.js | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/www/manager/openvz/CreateWizard.js b/www/manager/openvz/CreateWizard.js index d30f743..28f0114 100644 --- a/www/manager/openvz/CreateWizard.js

Re: [pve-devel] [PATCH] Host IP validation using Net::IP

2013-02-26 Thread damien piquet
This time I used Net::IP. I used a hash to convert netmask into CIDR format (eg: 255.0.0.0 into 8). PS: I just saw I forgot to remove the qw(:PROC) in use Net::IP statement. Sorry about that. 2013/2/26 Damien PIQUET : > > Signed-off-by: Damien PIQUET > --- > PVE/API2/Netwo

[pve-devel] [PATCH] Host IP validation using Net::IP

2013-02-26 Thread Damien PIQUET
Signed-off-by: Damien PIQUET --- PVE/API2/Network.pm | 52 +++ 1 file changed, 52 insertions(+) diff --git a/PVE/API2/Network.pm b/PVE/API2/Network.pm index 979063c..ea0c734 100644 --- a/PVE/API2/Network.pm +++ b/PVE/API2/Network.pm @@ -12,6

[pve-devel] [PATCH] Added ipv4 validation, forbid network and broadcast addresses

2013-02-26 Thread Damien PIQUET
Signed-off-by: Damien PIQUET --- PVE/API2/Network.pm | 16 1 file changed, 16 insertions(+) diff --git a/PVE/API2/Network.pm b/PVE/API2/Network.pm index 979063c..850470e 100644 --- a/PVE/API2/Network.pm +++ b/PVE/API2/Network.pm @@ -12,6 +12,7 @@ use PVE::RPCEnvironment

[pve-devel] [PATCH] Added check_ipv4_settings function to verify if given address and mask makes a valid host address

2013-02-25 Thread Damien PIQUET
Signed-off-by: Damien PIQUET --- PVE/API2/Network.pm | 14 ++ 1 file changed, 14 insertions(+) diff --git a/PVE/API2/Network.pm b/PVE/API2/Network.pm index 979063c..7b3969b 100644 --- a/PVE/API2/Network.pm +++ b/PVE/API2/Network.pm @@ -12,6 +12,7 @@ use PVE::RPCEnvironment; use

Re: [pve-devel] [PATCH] Added check_ipv4_settings function to verify if given address and mask makes a valid host address

2013-02-25 Thread damien piquet
Hi, Here is the patch to check if given address is a valid host IP depending on the netmask. With this additionnal check, we are sure that the ip parameters entered via the interface are OK. 2013/2/25 root : > > Signed-off-by: root > --- > PVE/API2/Network.pm | 14 ++ > 1 file

[pve-devel] [PATCH] Modified IPv4 validation function, included Net::IP

2013-02-23 Thread Damien PIQUET
Signed-off-by: Damien PIQUET --- data/PVE/JSONSchema.pm |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/data/PVE/JSONSchema.pm b/data/PVE/JSONSchema.pm index 4b33646..6866f18 100644 --- a/data/PVE/JSONSchema.pm +++ b/data/PVE/JSONSchema.pm @@ -8,6 +8,7 @@ use

Re: [pve-devel] [PATCH] Improved ipv4 addresses validation (sub pve_verify_ipv4 line 139)

2013-02-22 Thread damien piquet
mask to this function, or should we merge the two functions in a new one ? Damien 2013/2/22 Damien PIQUET : > > Signed-off-by: Damien PIQUET > --- > data/PVE/JSONSchema.pm | 45 +++-- > 1 file changed, 39 insertions(+), 6 deletions(-) &

[pve-devel] [PATCH] Improved ipv4 addresses validation (sub pve_verify_ipv4 line 139)

2013-02-22 Thread Damien PIQUET
Signed-off-by: Damien PIQUET --- data/PVE/JSONSchema.pm | 45 +++-- 1 file changed, 39 insertions(+), 6 deletions(-) diff --git a/data/PVE/JSONSchema.pm b/data/PVE/JSONSchema.pm index 4b33646..d0d11f8 100644 --- a/data/PVE/JSONSchema.pm +++ b/data/PVE

[pve-devel] [PATCH] Modified pve_verify_ipv4mask

2013-02-21 Thread Damien PIQUET
fixed class A validation failure Improved validation filtering see https://bugzilla.proxmox.com/show_bug.cgi?id=335 for details Signed-off-by: Damien PIQUET --- data/PVE/JSONSchema.pm |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/data/PVE/JSONSchema.pm b/data