On 6/12/19 4:35 PM, Fabian Grünbichler wrote:
>> -# FIXME: handle all links (0-7), they're all independent now
>> -$link0->{address} //= $name if exists($totem_cfg->{interface}->{0});
>> +for my $id (keys %{$totem_cfg->{interface}}) {
>> +die "corosync: totem int
first, thanks for the patch, comments inline.
On 6/12/19 4:52 PM, Stefan Reiter wrote:
> Signed-off-by: Stefan Reiter
> ---
> PVE/API2/Storage/Status.pm | 25 +
> 1 file changed, 21 insertions(+), 4 deletions(-)
>
> diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Stor
Signed-off-by: Stefan Reiter
---
PVE/API2/Storage/Status.pm | 25 +
1 file changed, 21 insertions(+), 4 deletions(-)
diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm
index 9a5a952..8649a7d 100644
--- a/PVE/API2/Storage/Status.pm
+++ b/PVE/API2/Storage/
sent some comments as replies to individual patches, rest LGTM - but
only read and build-tested so far. I'll try to give this (or a
subsequent v3) an actual spin this week as well if time permits.
On Tue, Jun 11, 2019 at 07:36:25PM +0200, Thomas Lamprecht wrote:
> v2 with a few more patches and so
On Tue, Jun 11, 2019 at 07:36:33PM +0200, Thomas Lamprecht wrote:
> allows to join clusters with more than the two links/rings we and
> corosync supported earlier, further it reduced the special treatment
> of link0 a lot.
see previous patch for some RE-related comments
>
> Signed-off-by: Thomas
On Tue, Jun 11, 2019 at 07:36:28PM +0200, Thomas Lamprecht wrote:
> Preparation for enhanced compatibility with new corosync 3/knet
> transport. Pretty straight forward switch from ringX_addr to links,
> *but*, for configuration backward compatibility corosync still uses
> "ringX_addr" as "link add
On Tue, Jun 11, 2019 at 07:36:32PM +0200, Thomas Lamprecht wrote:
> This adds basic infrastructure for link[0..7] parameters and allows
> to use it for the create cluster call. Try to be as link independent
> as possible, i.e., no real link0 special handling, it'll only get set
> if there's no sing
On Tue, Jun 11, 2019 at 07:36:30PM +0200, Thomas Lamprecht wrote:
> Similar to the change to cluster creation use now also the
> corosync-link definition for the rest of the cluster join/add calls.
>
> As link0, former ring0, is not special anymore allow that it's not
> passed and only default bac
Polished the phrasing in order to make it easer to read and understand.
Signed-off-by: Aaron Lauterer
---
pve-usbstick.adoc | 87 +--
1 file changed, 47 insertions(+), 40 deletions(-)
diff --git a/pve-usbstick.adoc b/pve-usbstick.adoc
index 5eb9132..c
Polished the phrasing in order to make it easer to read and understand.
Signed-off-by: Aaron Lauterer
---
translation.adoc | 33 ++---
1 file changed, 18 insertions(+), 15 deletions(-)
diff --git a/translation.adoc b/translation.adoc
index ff99296..4fb927e 100644
---
Polished the phrasing in order to make it easer to read and understand.
Signed-off-by: Aaron Lauterer
---
howto-improve-pve-docs.adoc | 29 ++---
1 file changed, 14 insertions(+), 15 deletions(-)
diff --git a/howto-improve-pve-docs.adoc b/howto-improve-pve-docs.adoc
inde
Polished the phrasing in order to make it easer to read and understand.
Signed-off-by: Aaron Lauterer
---
pve-system-requirements.adoc | 64
1 file changed, 35 insertions(+), 29 deletions(-)
diff --git a/pve-system-requirements.adoc b/pve-system-requirements
Polished the phrasing in order to make it easer to read and understand.
Signed-off-by: Aaron Lauterer
---
getting-help.adoc | 31 +++
1 file changed, 15 insertions(+), 16 deletions(-)
diff --git a/getting-help.adoc b/getting-help.adoc
index 850d7a3..f2ac532 100644
--
Polished the phrasing in order to make it easer to read and understand.
Signed-off-by: Aaron Lauterer
---
pve-installation.adoc | 230 ++
1 file changed, 119 insertions(+), 111 deletions(-)
diff --git a/pve-installation.adoc b/pve-installation.adoc
index
Polished the phrasing in order to make it easer to read and understand.
Some parts are rearranged.
Signed-off-by: Aaron Lauterer
---
pve-intro.adoc | 237 +++--
1 file changed, 112 insertions(+), 125 deletions(-)
diff --git a/pve-intro.adoc b/pve-intr
On 6/12/19 3:25 PM, Aaron Lauterer wrote:
> Added .swp for VIM
>
> Signed-off-by: Aaron Lauterer
> ---
> .gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.gitignore b/.gitignore
> index 04257db..36e2dd5 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -4,3 +4,4 @@
> *.xml
>
Added .swp for VIM
Signed-off-by: Aaron Lauterer
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index 04257db..36e2dd5 100644
--- a/.gitignore
+++ b/.gitignore
@@ -4,3 +4,4 @@
*.xml
*.tmp
*.epub
+*.swp
--
2.20.1
__
Signed-off-by: Stefan Reiter
---
pve-installation.adoc | 2 +-
pve-intro.adoc | 6 +++---
pve-network.adoc| 28 ++--
pve-package-repos.adoc | 2 +-
qm-pci-passthrough.adoc | 12 ++--
5 files changed, 25 insertions(+), 25 deletions(-)
diff --
On 6/12/19 2:35 PM, Wolfgang Bumiller wrote:
On Wed, Jun 12, 2019 at 01:48:57PM +0200, Thomas Lamprecht wrote:
On 6/12/19 1:12 PM, Wolfgang Bumiller wrote:
On Tue, Jun 11, 2019 at 06:02:22AM +0200, Thomas Lamprecht wrote:
+
+ char *val = _get_property_value(tmp, prop, prop_len);
On Wed, Jun 12, 2019 at 01:48:57PM +0200, Thomas Lamprecht wrote:
> On 6/12/19 1:12 PM, Wolfgang Bumiller wrote:
> > On Tue, Jun 11, 2019 at 06:02:22AM +0200, Thomas Lamprecht wrote:
> >> +
> >> + char *val = _get_property_value(tmp, prop, prop_len);
> >> + if (val == NULL) {
> >>
On 6/12/19 1:12 PM, Wolfgang Bumiller wrote:
> On Tue, Jun 11, 2019 at 06:02:22AM +0200, Thomas Lamprecht wrote:
>> [snip]
>>
>> +// checks the conf for a line starting with '$prop:' and returns the value
>> +// afterwards, whitout initial whitespace(s), we only deal with the format
>> +// restri
On Tue, Jun 11, 2019 at 06:02:22AM +0200, Thomas Lamprecht wrote:
> This adds a new method to our IPCC interface.
> It's a helper to get a property of a single or all guests.
>
> It is restricted to only look at the current config state only, i.e.,
> no PENDING changes and no snapshots, this is by
On 6/12/19 10:56 AM, Tim Marx wrote:
> Signed-off-by: Tim Marx
> ---
> changes in v4:
> * fixed load event function signature
> * handle case ipv6 only
>
> Makefile| 1 +
> form/NetworkSelector.js | 131
>
> 2 files changed, 132
On 6/12/19 10:56 AM, Tim Marx wrote:
> Signed-off-by: Tim Marx
> ---
> www/manager6/ceph/CephInstallWizard.js | 7 +++
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/www/manager6/ceph/CephInstallWizard.js
> b/www/manager6/ceph/CephInstallWizard.js
> index 65d71006..bb786
Since ceph-fuse is called directly in the CephFS storage plugin, which
can not process the _netdev option, mounting the CephFS storage fails
when fuse is set in the storage.cfg.
This patch moves the _netdev option into the else part of the if fuse is
set statement. _netdev is only added if the Cep
On Tue, Jun 11, 2019 at 02:17:49PM +0200, Thomas Lamprecht wrote:
> On 5/29/19 10:50 AM, Fabian Grünbichler wrote:
> > I wonder whether we should support clusters without link0 as well? might
> > happen easily:
> >
> > cluster only has link0 configured
> > network topology change, add new link1
>
When Move Disk is called for a container rsync starts copying it to a
new destination. This initial rsync process gets killed when the Stop
button gets pressed. At this moment the destination file is not fully
copied and useless as a consequence. Our code already tries to remove
it. However, rsync
On 6/12/19 11:10 AM, Dominic Jäger wrote:
> I'll make more detailed commit messages from now on.
>
> On 6/12/19 7:59 AM, Thomas Lamprecht wrote:
>> On 6/6/19 11:52 AM, Dominic Jäger wrote:
>>> When cancelling the move disk operation for containers the partly
>>> finished destination and thus usele
I'll make more detailed commit messages from now on.
On 6/12/19 7:59 AM, Thomas Lamprecht wrote:
On 6/6/19 11:52 AM, Dominic Jäger wrote:
When cancelling the move disk operation for containers the partly
finished destination and thus useless files now get removed.
I really do not understand th
Signed-off-by: Tim Marx
---
changes in v4:
* fixed load event function signature
* handle case ipv6 only
Makefile| 1 +
form/NetworkSelector.js | 131
2 files changed, 132 insertions(+)
create mode 100644 form/NetworkSelector.js
Signed-off-by: Tim Marx
---
www/manager6/ceph/CephInstallWizard.js | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/www/manager6/ceph/CephInstallWizard.js
b/www/manager6/ceph/CephInstallWizard.js
index 65d71006..bb7868f2 100644
--- a/www/manager6/ceph/CephInstallWizard.
On 6/12/19 10:17 AM, Christian Ebner wrote:
> replace Ressource by Resource
>
> Signed-off-by: Christian Ebner
> ---
> debian/pve-ha-crm.service | 2 +-
> debian/pve-ha-lrm.service | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
applied, thanks!
__
replace Ressource by Resource
Signed-off-by: Christian Ebner
---
debian/pve-ha-crm.service | 2 +-
debian/pve-ha-lrm.service | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/debian/pve-ha-crm.service b/debian/pve-ha-crm.service
index 800ce9b..b54992f 100644
--- a/debian/pve
> On June 12, 2019 at 7:59 AM Thomas Lamprecht wrote:
>
>
> On 6/6/19 11:52 AM, Dominic Jäger wrote:
> > When cancelling the move disk operation for containers the partly
> > finished destination and thus useless files now get removed.
>
> I really do not understand the commit message, could y
> Dominik Csapak hat am 11. Juni 2019 um 16:58
> geschrieben:
>
>
> high level looks ok, some comments inline
>
> On 6/11/19 2:04 PM, Tim Marx wrote:
> > Signed-off-by: Tim Marx
> > ---
> > Makefile| 1 +
> > form/NetworkSelector.js | 121
> > +++
35 matches
Mail list logo
