Re: [pve-devel] [PATCH manager v2 2/3] ui: ObjectPendingGrid: slightly refactor renderValue

2017-09-01 Thread Thomas Lamprecht
On 09/01/2017 11:31 AM, Fabian Grünbichler wrote: On Thu, Aug 31, 2017 at 02:26:00PM +0200, Thomas Lamprecht wrote: --- new in v2 www/manager6/grid/PendingObjectGrid.js | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/www/manager6/grid/PendingObjectGrid.js b/www/m

[pve-devel] [PATCH qemu-server 5/6] vzdump: warn if non-template backups contains no disk

2017-09-01 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- PVE/VZDump/QemuServer.pm | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm index ba15d48..527b66f 100644 --- a/PVE/VZDump/QemuServer.pm +++ b/PVE/VZDump/QemuServer.pm @@ -253,7 +253,

[pve-devel] [PATCH qemu-server 4/6] vzdump: use 'warn' level for warranted log calls

2017-09-01 Thread Thomas Lamprecht
Switch those loginfo calls which log possible implications from info to warn to inform the user Signed-off-by: Thomas Lamprecht --- PVE/VZDump/QemuServer.pm | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm index 65ca0

[pve-devel] [PATCH guest-common 3/6] vzdump: add common log submethod

2017-09-01 Thread Thomas Lamprecht
Add a general log method here which supports to pass on the "log to syslog too" functionallity and makes it more clearn what each param of logerr and logginfo means. Further we can now also log wlith a 'warn' level, which can be useful to notice an backup user of a possible problem which isn't a er

[pve-devel] [PATCH container 6/6] vzdump: use 'warn' level for warranted log calls

2017-09-01 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- src/PVE/VZDump/LXC.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/VZDump/LXC.pm b/src/PVE/VZDump/LXC.pm index 45a851c..818eac3 100644 --- a/src/PVE/VZDump/LXC.pm +++ b/src/PVE/VZDump/LXC.pm @@ -142,7 +142,7 @@ sub prepare {

[pve-devel] [PATCH manager 1/6] vzdump: allow all defined log levels

2017-09-01 Thread Thomas Lamprecht
this allows to pass also the 'warn' log level to this method. Signed-off-by: Thomas Lamprecht --- PVE/VZDump.pm | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm index 004672d1..f29739bb 100644 --- a/PVE/VZDump.pm +++ b/PVE/VZDump.pm @@ -201,

[pve-devel] [PATCH manager 2/6] warn on very small backup size

2017-09-01 Thread Thomas Lamprecht
fixes #1468 - partially Signed-off-by: Thomas Lamprecht --- PVE/VZDump.pm | 4 1 file changed, 4 insertions(+) diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm index f29739bb..91258bc1 100644 --- a/PVE/VZDump.pm +++ b/PVE/VZDump.pm @@ -984,26 +984,30 @@ sub exec_backup_task { }

Re: [pve-devel] [PATCH pve-common] Extend JSON format schema with pve_base_snapshot.

2017-09-01 Thread Fabian Grünbichler
On Fri, Aug 25, 2017 at 09:09:40AM +0200, Wolfgang Link wrote: > --- > src/PVE/JSONSchema.pm | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm > index 3295599..92d60b9 100644 > --- a/src/PVE/JSONSchema.pm > +++ b/src/PVE/JSONSchema

Re: [pve-devel] [pve-container] Exclude .zfs dir on vzdump

2017-09-01 Thread Fabian Grünbichler
On Fri, Sep 01, 2017 at 01:38:03PM +0200, Wolfgang Link wrote: > The .zfs snapdir is normally hidden, but when it is set to 'visible' we back > it up. > On restore vzdump try to write .zfs dir what is always read only. but shouldn't the user of such a non-default config adapt exclude_dirs manuall

[pve-devel] applied: [PATCH common 1/2] api: fix rendering of filepath/string parameters

2017-09-01 Thread Fabian Grünbichler
On Fri, Aug 18, 2017 at 05:17:02PM +0200, Thomas Lamprecht wrote: > both patches - the fix and the refactoring - look good to me and are an > improvement, IMO. > > Reviewed-by: Thomas Lamprecht > thanks! ___ pve-devel mailing list pve-devel@pve.prox

[pve-devel] [pve-container] Exclude .zfs dir on vzdump

2017-09-01 Thread Wolfgang Link
The .zfs snapdir is normally hidden, but when it is set to 'visible' we back it up. On restore vzdump try to write .zfs dir what is always read only. --- src/PVE/VZDump/LXC.pm | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/PVE/VZDump/LXC.pm b/src/PVE/VZDump/LXC.pm index 45a851c..c

Re: [pve-devel] [PATCH manager v2 2/3] ui: ObjectPendingGrid: slightly refactor renderValue

2017-09-01 Thread Fabian Grünbichler
On Thu, Aug 31, 2017 at 02:26:00PM +0200, Thomas Lamprecht wrote: > --- > > new in v2 > > www/manager6/grid/PendingObjectGrid.js | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/www/manager6/grid/PendingObjectGrid.js > b/www/manager6/grid/PendingObjectGrid.js > i

[pve-devel] applied+cleanup: [PATCH manager v2 3/3] hide migrate in contextmenu when no cluster or no rights

2017-09-01 Thread Fabian Grünbichler
see below On Tue, Aug 29, 2017 at 11:41:19AM +0200, Thomas Lamprecht wrote: > From: Dominik Csapak > > Signed-off-by: Dominik Csapak > Signed-off-by: Thomas Lamprecht > --- > > changes v1 -> v2: > * remove confusing comment > * hidden check: switched from `inline trenary if' to simple boole

[pve-devel] applied: [PATCH manager v2 2/3] hide migrate button in lxc for non cluster setups

2017-09-01 Thread Fabian Grünbichler
___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH manager v2 1/3] hide not usable buttons for qemu

2017-09-01 Thread Fabian Grünbichler
___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied/comment: [PATCH manager 00/11] VM CreateWizard, HDedit, OSType queue

2017-09-01 Thread Fabian Grünbichler
On Tue, Aug 29, 2017 at 12:08:23PM +0200, Thomas Lamprecht wrote: > This series affects mainly the VM Create Wizard and its panels, which are > also used outside the Wizard. > > First four patches are trivial. applied > > Next tree patches improve the IOThread and Discard elements of the HDEdit

Re: [pve-devel] rfc : implementing a cloudinit metadata server

2017-09-01 Thread Dietmar Maurer
> and with a cluster, we need that on each host. (so need arp filtering) quite complicated :-/ > So,I wonder if using iso images is not more simple. (BTW, microsoft azure use > also iso images for cloudinit) yes, lets keep the current approach using iso images. _

Re: [pve-devel] rfc : implementing a cloudinit metadata server

2017-09-01 Thread Alexandre DERUMIER
>>Also, does this method work for windows guest? this windows cloudinit implementation https://cloudbase.it/cloudbase-init/ support both http and configdrive methods - Mail original - De: "dietmar" À: "aderumier" , "pve-devel" Envoyé: Vendredi 1 Septembre 2017 06:35:02 Objet: Re: [p

Re: [pve-devel] rfc : implementing a cloudinit metadata server

2017-09-01 Thread Alexandre DERUMIER
I have done some tests, It's a little bit more complicated that I thinked. It's working fine with openstack,amazon, because they don't use vlan and all is routed by default. (they have 1 central metadataserver outside compute node, and traffic is routed to it) The guest vm have an ip in

Re: [pve-devel] [PATCH stable-4 guest-common] Fix #1480: die if snapshot name is not found before set_lock is used

2017-09-01 Thread Fabian Grünbichler
I am not sure we need to cherry-pick this, it's a minor inconvenience, but not a serious bug.. On Mon, Aug 28, 2017 at 11:23:39AM +0200, Alwin Antreich wrote: > Signed-off-by: Alwin Antreich > --- > PVE/AbstractConfig.pm | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --gi

[pve-devel] applied: [PATCH guest-common] Fix #1480: die if snapshot name is not found before set_lock is used

2017-09-01 Thread Fabian Grünbichler
___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH container v2 0/4] improve ostype checks and small updates

2017-09-01 Thread Fabian Grünbichler
___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH container v4] close #1478: add check for unsupported config

2017-09-01 Thread Fabian Grünbichler
but dropped the unused $uses_quota ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel