Re: [pve-devel] [RFC v2 pve-cluster 1/4] prefer 'name' subkey over 'ring0_addr' for nodename

Am 07.10.2015 um 14:26 schrieb Wolfgang Bumiller: On Wed, Oct 07, 2015 at 01:34:57PM +0200, Thomas Lamprecht wrote: @@ -97,6 +97,13 @@ cmap_read_clusternodes( cfs_critical("cmap_get %s failed %d", key_name, result); } } e

Re: [pve-devel] [RFC v2 pve-cluster 1/4] prefer 'name' subkey over 'ring0_addr' for nodename

On Wed, Oct 07, 2015 at 01:34:57PM +0200, Thomas Lamprecht wrote: > @@ -97,6 +97,13 @@ cmap_read_clusternodes( > cfs_critical("cmap_get %s failed %d", key_name, > result); > } > } else if (strcmp(subkey, "ring0_addr") == 0) { > +

[pve-devel] [PATCH pve-storage 1/2] add zfs_get_subvol_size: on container we are useing subvol.

--- PVE/Storage/ZFSPoolPlugin.pm | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/PVE/Storage/ZFSPoolPlugin.pm b/PVE/Storage/ZFSPoolPlugin.pm index 8002dda..72dfd0f 100644 --- a/PVE/Storage/ZFSPoolPlugin.pm +++ b/PVE/Storage/ZFSPoolPlugin.pm @@ -308,6 +308,

[pve-devel] [PATCH pve-storage 2/2] refactor volunme_resize to differentiate subvol and zvol

--- PVE/Storage/ZFSPoolPlugin.pm | 19 +++ 1 file changed, 19 insertions(+) diff --git a/PVE/Storage/ZFSPoolPlugin.pm b/PVE/Storage/ZFSPoolPlugin.pm index 72dfd0f..b8bd509 100644 --- a/PVE/Storage/ZFSPoolPlugin.pm +++ b/PVE/Storage/ZFSPoolPlugin.pm @@ -577,11 +577,30 @@ sub volume

Re: [pve-devel] [PATCH v3 pve-container] Add new pct fsck command, to check the rootfs of a container for consistency

thanks, looks good now! But we also need to handle bind mounts and subvol correctly before i can commit this patch. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve-common] don't reorder unknown interface types

applied, thanks. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [RFC v2 pve-cluster 2/4] clean up some error handling

Does not change functionality, makes some code a bit more readable and lessens code reuse. Signed-off-by: Thomas Lamprecht --- data/src/dcdb.c | 6 +++--- data/src/dfsm.c | 21 + data/src/quorum.c | 23 +++ 3 files changed, 23 insertions(+), 27 deleti

[pve-devel] [RFC v2 pve-cluster 4/4] improve RRP support and use 'name' subkey as default

This patches allows to configure RRP (= redundant ring protocol) at cluster creation time. Also setting ring 0 and 1 addresses when adding a new node. This helps and fixes some bugs when corosync runs completely separated on an own network. Changing rrp configs, or the bindnet addresses automatical

[pve-devel] [RFC v2 pve-cluster 0/4] prefer 'name' subkey for nodename and improve RRP support

This series has the intention to simplify and solve some bugs when running corosync on a completely independent network. Also enables the use of ring 0 and 1 for pvecm node addition commands (also useful when corosync is on its own network). *NOTE*: the fourth patch is _not_ fully tested yet, wi

[pve-devel] [RFC v2 pve-cluster 1/4] prefer 'name' subkey over 'ring0_addr' for nodename

Use the name subkey from the cmap keys by default, if not set fallback to the ring0_addr. This fixes some issues when we move the corosync communication to a different network and use an specific address or an new hostname for that. Withouth this patch the nodename in the .members special file chan

[pve-devel] [RFC v2 pve-cluster 3/4] use 'name' over 'ring0_addr' and prepare for rrp

Adapt some functions to prefer 'name' subkey over 'ring0_addr'. Add a function to get a hash representatiion of the totem corosync config item. Signed-off-by: Thomas Lamprecht --- data/PVE/CLI/pvecm.pm | 51 +-- 1 file changed, 45 insertions(+), 6

Re: [pve-devel] [PATCH] Shorter implementation of random_ether_addr().

> First, many thanks for the patch! > > > +my $mac = sprintf("%02X:" x 6, unpack("C6", $rand)); > > + > > +# remove superfluous ":" at end > > +chop($mac); > > I wonder if it would be simpler to use a static format string instead? > > my $mac = sprintf("%02X:%02X:%02X:%02X:%02X:%02X"

Re: [pve-devel] [PATCH] Shorter implementation of random_ether_addr().

First, many thanks for the patch! > +my $mac = sprintf("%02X:" x 6, unpack("C6", $rand)); > + > +# remove superfluous ":" at end > +chop($mac); I wonder if it would be simpler to use a static format string instead? my $mac = sprintf("%02X:%02X:%02X:%02X:%02X:%02X", unpack("C6", $rand

[pve-devel] [PATCH] Shorter implementation of random_ether_addr().

--- src/PVE/Tools.pm | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm index 3f3958e..cda0797 100644 --- a/src/PVE/Tools.pm +++ b/src/PVE/Tools.pm @@ -940,21 +940,13 @@ sub random_ether_addr { my $rand = Digest::SHA

[pve-devel] [PATCH pve-common] don't reorder unknown interface types

Giving unknown interfaces an order-id of 0 caused them to always be on top of the interfaces file. This is often undesired. Instead we now only take type-ordering into account when both interfaces which are being compared have a known type, and otherwise only use the priority attribute. This should

[pve-devel] [PATCH v3 pve-container] Add new pct fsck command, to check the rootfs of a container for consistency

* the filesystem specific command will be called automatically by fsck (at the moment ext4) * the -y flag ensures that the filesystem can be fixed automcatically in a non-interactive session * the -f flag forces a filesystem check even if the fs seems clean --- src/PVE/CLI/pct.pm | 42

[pve-devel] add pct fcsk command

Changed: usei PVE::LXC::lock_container() instead of managing the lock ourselves ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel