First, many thanks for the patch!

> +    my $mac = sprintf("%02X:" x 6, unpack("C6", $rand));
> +
> +# remove superfluous ":" at end
> +    chop($mac);

I wonder if it would be simpler to use a static format string instead?

    my $mac = sprintf("%02X:%02X:%02X:%02X:%02X:%02X", unpack("C6", $rand));

_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to