[pve-devel] [PATCH v2] Fixed OpenVZ noVNC console not showing in PVE3.4

2015-07-29 Thread Thomas Lamprecht
In commit 8d70213 we started to generate pveui.js from include/ui.js with a patch, but the same patch was applied to master and stable 3 branch. So there was only lxc and when we try to open a noVNC console on a OpenVZ container a "implement me" exception gets thrown and the window shows nothing. T

Re: [pve-devel] bridge vlan range, kernel 4.1 : "message truncated" warning when too much vlans defined

2015-07-29 Thread Alexandre DERUMIER
Thanks Ronen, I have tested - char buf[16384]; + char buf[3*16384]; and It's working fine to handle 4096 vlans numbers. (The problem was really the number of vlans ids defined, could be 1 interface with 2-4095vlans, or 100 interfaces with same 2-4095vlans). With this buffer size it's worki

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Dietmar Maurer
> >>OK, it works perfectly inside a newly installed VM, but not on my host :-/ > > . sysctl tuning maybe ? I cannot find any relevant difference. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/p

Re: [pve-devel] bridge vlan range, kernel 4.1 : "message truncated" warning when too much vlans defined

2015-07-29 Thread Arad, Ronen
The easiest fix is in iproute2. Increasing the buffer size used in rtnl_dump_filter_l 3x empirically resolves the issue. The root-cause is due to the buffer size calculation of dump request in the kernel. It is based on the total number of VLANs and does not account for compressed vlan requests.

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Alexandre DERUMIER
>>maybe this iproute2 (4.1) patch Still don't work with iproute2 4.1. (+kernel 4.1) I have send a mail to roopa from cumulus netwrk, she tell me that she 'll look at this bug as soon as possible. - Mail original - De: "aderumier" À: "Wolfgang Bumiller" Cc: "pve-devel" Envoyé: Mercr

[pve-devel] bridge vlan range, kernel 4.1 : "message truncated" warning when too much vlans defined

2015-07-29 Thread Alexandre DERUMIER
Hi, I'm currently testing vlan range on bridge filtering with kernel 4.1. If I defined too much vlans, or too big vlan range, I have a warning "message truncated", even if I'm using "-c" # bridge -c vlan Message truncated port vlan ids eth2 1 PVID Egress Untagged bond0 1 PVID Egress U

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Alexandre DERUMIER
>>OK, it works perfectly inside a newly installed VM, but not on my host :-/ . sysctl tuning maybe ? - Mail original - De: "dietmar" À: "aderumier" Cc: "pve-devel" Envoyé: Mercredi 29 Juillet 2015 19:00:12 Objet: Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3 > > >>Test

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Dietmar Maurer
> > >>Tested with totally empty /etc/network/interfaces, and > > >>I do not get above entry for testbridge. > > >> > > >>I am a bit out of ideas. > > > > Damn, I really don't known. > > (and it seem that it's working for wolfgang ?) > > yes. But it does not work for me. Will try on a new install

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Dietmar Maurer
> >>Tested with totally empty /etc/network/interfaces, and > >>I do not get above entry for testbridge. > >> > >>I am a bit out of ideas. > > Damn, I really don't known. > (and it seem that it's working for wolfgang ?) yes. But it does not work for me. Will try on a new installation. ___

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Alexandre DERUMIER
>>Tested with totally empty /etc/network/interfaces, and >>I do not get above entry for testbridge. >> >>I am a bit out of ideas. Damn, I really don't known. (and it seem that it's working for wolfgang ?) - Mail original - De: "dietmar" À: "aderumier" Cc: "pve-devel" Envoyé: Mercredi 2

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Dietmar Maurer
> Damn, with an empty /etc/network/interfaces > > > #brctl addbr testbridge > #echo 1 > /sys/class/net/testbridge/bridge/vlan_filtering > #bridge vlan add dev testbridge vid 100 self > > #bridge -c vlan > > testbridge 1 PVID Egress Untagged >100 Tested with totally empty /etc/network/

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Alexandre DERUMIER
maybe this iproute2 (4.1) patch http://git.kernel.org/cgit/linux/kernel/git/shemminger/iproute2.git/commit/?id=c079e121a73af5eb49e003b13607e8a690331df6 "libnetlink: add size argument to rtnl_talk There have been several instances where response from kernel has overrun the stack buffer from the cal

[pve-devel] [PATCH] Fixed OpenVZ noVNC console not showing in PVE3.4

2015-07-29 Thread Thomas Lamprecht
In commit 8d70213 we started to generate pveui.js from include/ui.js with a patch, but the same patch was applied to master and stable 3 branch. So there was only lxc and when we try to open a noVNC console on a OpenVZ container a "implement me" exception gets thrown and the window shows nothing. T

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Alexandre DERUMIER
from this similar redhat bugzilla https://bugzilla.redhat.com/show_bug.cgi?id=1086512 this is because the buffer in libnetlink (iproute2) is too short http://git.kernel.org/cgit/linux/kernel/git/shemminger/iproute2.git/tree/lib/libnetlink.c It's like each vlan (even if in a range, and not displa

[pve-devel] [PATCH 2/2] fix memory and swap size calculations

2015-07-29 Thread Wolfgang Bumiller
memory.limit_in_bytes limits memory usage, however memory.memsw.limit_in_bytes limits the *sum* of swap+memory which means we cannot separately change memory and swap in update_lxc_config as in order to keep the swap size unchanged when changing the memory value, the "total" value has to be recalcu

[pve-devel] [PATCH 1/2] Fix leftover OpenVZ call in lxc api

2015-07-29 Thread Wolfgang Bumiller
--- src/PVE/API2/LXC.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index f8ac02d..9e82bc4 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -833,7 +833,7 @@ __PACKAGE__->register_method({ my ($param) = @_;

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Alexandre DERUMIER
>>I could limit the number of vlans, with adding dynamicaly to ethX|bondX vlans >>to allow, when the vm is starting. >>If user want to tag inside the vm, we could add an option "vlans filter" or >>something like that. I have the "message truncated" warning when I have defined around 1800vlans.

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Alexandre DERUMIER
I have seen that too :( >>maybe >>https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=fed0a159c8c5e453d79d6a73897c576efea0a8a5 >> >>"bridge: fix link notification skb size calculation to include vlan ranges" >> >>? Still no luck with kernel 4.1. I could limit the nu

[pve-devel] [PATCH] ext5migrate: set buttons property directly instead of calling applyIf

2015-07-29 Thread Emmanuel Kasper
It seems that in ExtJS5 the prototype of the Window component already sets some default values to me.buttons and me.layout, hence calling applyIf on these properties will silently fail. me.layout is already set to 'auto' by the framework, we don't need to set that anymore. --- www/manager5/window

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Alexandre DERUMIER
>>both the testbridge and dum0 interface disappear even from the output of `ip link` which also throws that error. This is highly annoying. >>I have seen that too :( maybe https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=fed0a159c8c5e453d79d6a73897c576efea0a8a

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Alexandre DERUMIER
both the testbridge >>and dum0 interface disappear even from the output of `ip link` which >>also throws that error. This is highly annoying. I have seen that too :( - Mail original - De: "Wolfgang Bumiller" À: "aderumier" Cc: "dietmar" , "pve-devel" Envoyé: Mercredi 29 Juillet 201

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Wolfgang Bumiller
The manual way works for me on my host. The /etc/network/interfaces way doesn't. Presumably because I didn't `apt-get purge vlan`. In my test VMs where I purged vlan and pve-manager and reinstalled the patched pve-manager it all works fine. What I really hate about this is the whole "Message trunc

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Dietmar Maurer
> Damn, with an empty /etc/network/interfaces why is that required? > #brctl addbr testbridge > #echo 1 > /sys/class/net/testbridge/bridge/vlan_filtering > #bridge vlan add dev testbridge vid 100 self > > #bridge -c vlan > > testbridge 1 PVID Egress Untagged >100 > With non-empty /etc

[pve-devel] [PATCH] Move subscription tab to the outmost right of the node tab panel

2015-07-29 Thread Emmanuel Kasper
This brings consistency with the datacenter tab panel. --- www/manager/node/Config.js | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/www/manager/node/Config.js b/www/manager/node/Config.js index ff6d225..61bb4b2 100644 --- a/www/manager/node/Config.js +++ b/

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Alexandre DERUMIER
>>no Damn, with an empty /etc/network/interfaces #brctl addbr testbridge #echo 1 > /sys/class/net/testbridge/bridge/vlan_filtering #bridge vlan add dev testbridge vid 100 self #bridge -c vlan testbridge 1 PVID Egress Untagged 100 #brctl addif testbridge eth0 #bridge -c vlan eth0 1P

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Dietmar Maurer
> does it work better if you setup the ip on bridge vlan interface ? no ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH_V4] Insert capability for restore LXC- and OpenVZ- dumpfiles

2015-07-29 Thread Wolfgang Link
this patch recovers the config form the tarball. It will nt recover the nework setting if you recover from OVZ --- src/PVE/API2/LXC.pm | 30 +++- src/PVE/LXCCreate.pm | 105 +++--- src/PVE/VZDump/ConvertOVZ.pm | 319 +++ src/PVE/VZD

[pve-devel] [PATCH] Remove snapshots from LXC config, when you create LXC Backup

2015-07-29 Thread Wolfgang Link
--- src/PVE/VZDump/LXC.pm | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/PVE/VZDump/LXC.pm b/src/PVE/VZDump/LXC.pm index 21fb3c1..fc74007 100644 --- a/src/PVE/VZDump/LXC.pm +++ b/src/PVE/VZDump/LXC.pm @@ -221,14 +221,20 @@ sub resume_vm { sub assemble {

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Alexandre DERUMIER
> # bridge -c vlan > port vlan ids > vmbr0 1 PVID Egress Untagged >>Why is there no entry for eth0? Just have done a test with only a standalone bridge does it work better if you setup the ip on bridge vlan interface ? auto vmbr0 iface vmbr0 inet manual bridge_vlan_aware yes

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Dietmar Maurer
> I tested your config, and it's working fine for me > > #iproute2 4.0.0-1 > > #kernel 3.19.8-1-pve (with vlan-range patches) same versions here > simply enabling vlan filtering > > echo 1 > /sys/class/net/vmbr0/bridge/vlan_filtering > > should at least give you vmbr0 with default vlan 1 VID

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Alexandre DERUMIER
>>This does not work at all for me. I tested your config, and it's working fine for me #iproute2 4.0.0-1 #kernel 3.19.8-1-pve (with vlan-range patches) simply enabling vlan filtering echo 1 > /sys/class/net/vmbr0/bridge/vlan_filtering should at least give you vmbr0 with default vlan 1 VID

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Michael Rasmussen
On Wed, 29 Jul 2015 04:42:42 +0200 Alexandre Derumier wrote: > This add support to enable vlan aware bridge, > and management interfaces > I don't know whether this is related to the new network scripts. I have recently been doing some experiments with the openvswitch-switch package from Debian

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Dietmar Maurer
> #ip addr ? > > #brctl show ? > those are quite normal. > can you post your /etc/network/interfaces ? see previous post, but here it is: auto vmbr0 iface vmbr0 inet static address 192.168.2.35 netmask 255.255.240.0 gateway 192.168.2.1 bridg

[pve-devel] [PATCH] Fixed wrong UUID in Qemu VZDump backup

2015-07-29 Thread Thomas Lamprecht
As the format of the uuid which the qemu monitor returned changed, it is here adapted to fix errors with not matching uuids. Signed-off-by: Thomas Lamprecht --- PVE/VZDump/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/Qemu

Re: [pve-devel] Regression with latest qemu and iothreads option ?

2015-07-29 Thread Wolfgang Bumiller
On Wed, Jul 29, 2015 at 10:22:11AM +0200, Wolfgang Bumiller wrote: > On Wed, Jul 29, 2015 at 09:28:30AM +0200, Alexandre DERUMIER wrote: > > a fix patch series has been sent yesterday > > > > http://lists.nongnu.org/archive/html/qemu-devel/2015-07/msg05548.html > > Doesn't seem to fix it here. Ha

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Alexandre DERUMIER
#ip addr ? #brctl show ? can you post your /etc/network/interfaces ? - Mail original - De: "dietmar" À: "aderumier" Cc: "pve-devel" Envoyé: Mercredi 29 Juillet 2015 09:43:05 Objet: Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3 > but you should see the bridge itself:

Re: [pve-devel] Regression with latest qemu and iothreads option ?

2015-07-29 Thread Wolfgang Bumiller
On Wed, Jul 29, 2015 at 09:28:30AM +0200, Alexandre DERUMIER wrote: > a fix patch series has been sent yesterday > > http://lists.nongnu.org/archive/html/qemu-devel/2015-07/msg05548.html Doesn't seem to fix it here. Have you tested it successfully? ___

[pve-devel] [PATCH] replace /sbin/vconfig with /sbin/ip call

2015-07-29 Thread Wolfgang Bumiller
--- src/PVE/Network.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Network.pm b/src/PVE/Network.pm index e51099e..c6583d8 100644 --- a/src/PVE/Network.pm +++ b/src/PVE/Network.pm @@ -355,7 +355,7 @@ sub activate_bridge_vlan_slave { # create vlan on $if

Re: [pve-devel] [PATCH] add memory_unplug support V2

2015-07-29 Thread Dietmar Maurer
applied, thanks! ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH] cluster typo bug #588 fix

2015-07-29 Thread Alen Grizonic
Signed-off-by: Alen Grizonic --- data/PVE/pvecm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/PVE/pvecm b/data/PVE/pvecm index 8efbb1d..2cd13e5 100755 --- a/data/PVE/pvecm +++ b/data/PVE/pvecm @@ -379,7 +379,7 @@ __PACKAGE__->register_method ({ my $vmlist

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Dietmar Maurer
> but you should see the bridge itself: > > port vlan ids > vmbr0 1 PVID Egress Untagged >100 I only see: # bridge -c vlan portvlan ids eth0 1 PVID Egress Untagged 2-4094 ?? ___ pve-devel mailing list pve-devel@pve.proxmox

Re: [pve-devel] javascript error since upgrade to novnc0.5-2

2015-07-29 Thread Dietmar Maurer
> > https://git.proxmox.com/?p=pve-manager.git;a=commit;h=960fea8c77243495536bb44b696dda8cb0056065 > > https://git.proxmox.com/?p=pve-manager.git;a=commit;h=c03d35f0247603cbb60ff39536f0801a03f11699 > > Strange have to check why it' working on some hosts and why not on others. Please try to clear

Re: [pve-devel] javascript error since upgrade to novnc0.5-2

2015-07-29 Thread Stefan Priebe - Profihost AG
Am 29.07.2015 um 09:31 schrieb Alexandre DERUMIER: > Hi Stefan, > >>> still on stable-3. > > they are new parameters in NoVncIndex.pm, in pve-manager > > https://git.proxmox.com/?p=pve-manager.git;a=commit;h=960fea8c77243495536bb44b696dda8cb0056065 > https://git.proxmox.com/?p=pve-manager.git

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Alexandre DERUMIER
>>But where is the information about vmbr0.100 ? As this is a special interface (bridge tagged interface), you'll not see it in "bridge -c vlan". but you should see the bridge itself: port vlan ids vmbr01 PVID Egress Untagged 100 This is done by bridgevlanport script #ifup vmbr

[pve-devel] [PATCH_V3] Insert capability for restore LXC- and OpenVZ- dumpfiles

2015-07-29 Thread Wolfgang Link
this patch recovers the config form the tarball. It will nt recover the nework setting if you recover from OVZ --- src/PVE/API2/LXC.pm | 30 +++- src/PVE/LXCCreate.pm | 136 +++--- src/PVE/VZDump/ConvertOVZ.pm | 319 +++ src/PVE

Re: [pve-devel] javascript error since upgrade to novnc0.5-2

2015-07-29 Thread Alexandre DERUMIER
Hi Stefan, >>still on stable-3. they are new parameters in NoVncIndex.pm, in pve-manager https://git.proxmox.com/?p=pve-manager.git;a=commit;h=960fea8c77243495536bb44b696dda8cb0056065 https://git.proxmox.com/?p=pve-manager.git;a=commit;h=c03d35f0247603cbb60ff39536f0801a03f11699 - Mail or

Re: [pve-devel] Regression with latest qemu and iothreads option ?

2015-07-29 Thread Alexandre DERUMIER
a fix patch series has been sent yesterday http://lists.nongnu.org/archive/html/qemu-devel/2015-07/msg05548.html - Mail original - De: "aderumier" À: "Emmanuel Kasper" Cc: "pve-devel" Envoyé: Mercredi 29 Juillet 2015 06:48:49 Objet: Re: [pve-devel] Regression with latest qemu and ioth

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Dietmar Maurer
> we need to use #bridge -c vlan > > to display range. (compressed format). Ah (that is also not mentioned in the manual page). > If not, I think it's trying to display line by line each vlan, and it's too > much for the buffer or something like that. > (No idea how to tune that) So I get the

[pve-devel] javascript error since upgrade to novnc0.5-2

2015-07-29 Thread Stefan Priebe - Profihost AG
Hi, still on stable-3. Sicne upgrading to novnc 0.5-2 i get on some hosts the following error in novnc. pveui.js:284 Uncaught TypeError: Cannot read property 'type' of null pveui.js:284UI.updateSetting @ pveui.js:304UI.pve_start.start_vnc_viewer @ pveui.js:1615UI.pve_start.UI.API2Request.success

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Alexandre DERUMIER
>>I agree with the first line, but not with the second one... Yes, exactly, don't understand the need of proxy_arp for vlans. I think it's a really old file not updated since years ;) - Mail original - De: "Wolfgang Bumiller" À: "aderumier" Cc: "pve-devel" Envoyé: Mercredi 29 Juillet

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Wolfgang Bumiller
On Wed, Jul 29, 2015 at 09:09:18AM +0200, Alexandre DERUMIER wrote: > >>The vlan package also provides a file I'd like to keep (iow. provide > >>with pve-manager): > >> > >>- if-up.d/ip > > I wonder why it's in vlan package ? Well, there's that comment in the file: # This should probably go in

Re: [pve-devel] [PATCH] add vlan aware ifupdown script v3

2015-07-29 Thread Alexandre DERUMIER
>>The vlan package also provides a file I'd like to keep (iow. provide >>with pve-manager): >> >>- if-up.d/ip I wonder why it's in vlan package ? - Mail original - De: "Wolfgang Bumiller" À: "aderumier" Cc: "pve-devel" Envoyé: Mercredi 29 Juillet 2015 08:56:40 Objet: Re: [pve-devel] [P