On Thu, Oct 19, 2023 at 02:18:56PM +0200, Filip Schauer wrote:
> Signed-off-by: Filip Schauer
> ---
> Is it reasonable to add a "dev[n]" argument to the pct.conf, given that
> device mount points only allow passing through block devices?
Why would they only allow block devices?
Also, Dominik rec
On Tue, Oct 24, 2023 at 02:55:54PM +0200, Filip Schauer wrote:
> Add a function to iterate over passthrough devices of a provided
> container config.
As container specific code this should be in pve-container.
>
> Signed-off-by: Filip Schauer
> ---
> src/PVE/AbstractConfig.pm | 44
On Tue, Oct 24, 2023 at 02:55:53PM +0200, Filip Schauer wrote:
> Add a dev[n] argument to the container config to pass devices through to
> a container. A device can be passed by its path. Alternatively a mapped
> USB device can be passed through with usbmapping=.
>
> Signed-off-by: Filip Schauer
On Mon, Oct 30, 2023 at 05:30:15PM +0100, Thomas Lamprecht wrote:
> I mean, the properties are relatively straight forward, but some commit
> message would be still nice to have – e.g., how did you check if the values
> propagate into the guest, can this
>
> On 25/10/2023 14:37, Hannes Duerr wrote
On Fri, Oct 27, 2023 at 01:53:28PM +0200, Alexandre Derumier wrote:
> Do it on vnet update instead throwing a warning at config generation.
>
> Signed-off-by: Alexandre Derumier
> ---
> src/PVE/Network/SDN/Zones/EvpnPlugin.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --gi
On Thu, Nov 02, 2023 at 03:28:22PM +0100, Filip Schauer wrote:
>
> On 30/10/2023 14:34, Wolfgang Bumiller wrote:
> > On Tue, Oct 24, 2023 at 02:55:53PM +0200, Filip Schauer wrote:
> > > Add a dev[n] argument to the container config to pass devices through to
> > >
On Tue, Nov 07, 2023 at 02:46:42PM +0100, Filip Schauer wrote:
> Add a dev[n] argument to the container config to pass devices through to
> a container. A device can be passed by its path. Additionally the access
> mode, uid and gid can be specified through their respective properties.
>
> Signed-
On Mon, Nov 13, 2023 at 03:14:47PM +0100, Thomas Lamprecht wrote:
> Am 13/11/2023 um 11:30 schrieb Filip Schauer:
> > Signed-off-by: Filip Schauer
> > ---
> > src/PVE/Tools.pm | 31 +++
> > 1 file changed, 31 insertions(+)
> >
> >
>
> applied this one already too, th
mostly LGTM, just minor things
On Tue, Nov 14, 2023 at 11:33:37AM +0100, Dominik Csapak wrote:
> a schema can now have the 'oneOf' property which is an array of regular
> schemas. In the default case any of that has to match. If the
> 'type-property'/'instance-types' are given, only the schema for
On Tue, Nov 14, 2023 at 11:33:38AM +0100, Dominik Csapak wrote:
> when using 'init(1)'. This saves the property lists per type instead of
> a big one, and using create/updateSchema creates a new schema with the
> options as 'oneOf' and/or 'instance-types' (depending if the schemas
> match).
>
> fo
On Tue, Nov 14, 2023 at 11:33:39AM +0100, Dominik Csapak wrote:
> more or less a copy from the normal section config test, but now with
> properties defined multiple times as well as conflicting options
>
> Signed-off-by: Dominik Csapak
> ---
> test/Makefile | 1 +
> te
On Wed, Nov 15, 2023 at 09:55:22AM +0100, Fabian Grünbichler wrote:
> On November 14, 2023 3:02 pm, Fiona Ebner wrote:
> > Currently, volume activation, PCI reservation and resetting systemd
> > scope happen in between and the 5 second expiretime used for port
> > reservation might not be enough.
>
On Wed, Nov 15, 2023 at 11:22:46AM +0100, Fiona Ebner wrote:
> Am 15.11.23 um 11:12 schrieb Wolfgang Bumiller:
> >
> > What about adding an option to `next_migrate_port()` to actually return
> > the open socket to keep the reservation?
> >
> > Also, did we con
On Wed, Nov 15, 2023 at 03:14:50PM +0100, Thomas Lamprecht wrote:
> concept wise this looks pretty much OK, but a few (mostly code-style)
> comments in line
>
> Am 13/11/2023 um 11:30 schrieb Filip Schauer:
> > diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
> > index 56e1f10..9f325f2
On Thu, Nov 16, 2023 at 12:50:44PM +0100, Filip Schauer wrote:
> Add a dev[n] argument to the container config to pass devices through to
> a container. A device can be passed by its path. Additionally the access
> mode, uid and gid can be specified through their respective properties.
>
> Signed-
On Fri, Nov 17, 2023 at 06:49:27AM +, DERUMIER, Alexandre wrote:
> Message initial
> De: "DERUMIER, Alexandre"
> À: pve-devel@lists.proxmox.com ,
> aderum...@odiso.com , s.hanre...@proxmox.com
>
> Objet: Re: [pve-devel] [PATCH dnsmasq 0/1] purge previous ip/mac lease
> of dh
On Thu, Nov 16, 2023 at 04:31:25PM +0100, Fabian Grünbichler wrote:
> with ACLs being inherited along the pool hierarchy.
>
> Signed-off-by: Fabian Grünbichler
> ---
> src/PVE/AccessControl.pm | 10 --
> src/test/perm-test6.pl | 16
> src/test/test6.cfg | 5
On Thu, Nov 16, 2023 at 04:31:26PM +0100, Fabian Grünbichler wrote:
> and ensure a missing intermediate pool exists at all times.
>
> Signed-off-by: Fabian Grünbichler
> ---
>
> Notes:
> a "missing link" should never happen when modifying via the API (both
> deletion
> with children and
minor issue
On Fri, Nov 17, 2023 at 08:09:10AM +0100, Fabian Grünbichler wrote:
> since poolid can now contain `/`, it's not possible to use it (properly) as
> path parameter anymore.
>
> accordingly:
> - merge `read_pool` (`GET /pools/{poolid}`) into 'index' (`GET
> /pools/?poolid={poolid}`) (
On Wed, Sep 27, 2023 at 11:04:26AM +0200, Friedrich Weber wrote:
> Lost track of this a bit, reviving due to user interest [1].
>
> As the series does not apply anymore, I'll send a new version in any
> case, but wanted to ask for feedback before I do.
>
> My questions from the cover letter still
Patch itself LGTM, just a note on sending patch series in general:
If you number patches throughout a whole series rather than the
individual repositories (as in, this one is labeled 4/4 instead of 1/1),
it would be nice if the order also helps determine dependencies.
Since the sub introduced her
On Thu, Jan 26, 2023 at 09:32:12AM +0100, Friedrich Weber wrote:
> The new `overrule-shutdown` parameter is boolean and defaults to 0. If
> it is 1, all active `vzshutdown` tasks by the current user for the same
> CT are aborted before attempting to stop the CT.
>
> Passing `overrule-shutdown=1` i
;
> Passing `overrule-shutdown=1` is forbidden for HA resources.
>
> Signed-off-by: Friedrich Weber
Acked-by: Wolfgang Bumiller
> ---
> PVE/API2/Qemu.pm | 16 +++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qem
just some thoughts from my side:
On Thu, May 11, 2023 at 11:46:20AM +0200, Christoph Heiss wrote:
> For nodes, VMs and CTs we can show the user a list of available network
> interfaces (as that information is available) when creating a new
> firewall rule, much like it is already done in similar p
applied, thanks
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied series, bumped access control and manager's dep on it
On Mon, Nov 20, 2023 at 08:22:38AM +0100, Fabian Grünbichler wrote:
> this series extends the poolname to allow (for now) two '/' inside the
> name to nest pools like this:
>
> parent/child/grandchild
>
> since '/' is a bad character
applied, thanks
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied both, thanks
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied container series with a small `$have_sdn` guard fixup
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied, thanks
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied qemu-server series (also with a small $have_sdn guard fixup ;-)
)
thanks
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
This is a major break for automation tools (the web UI already passed
the full config each time).
Cc: Alexandre Derumier
Signed-off-by: Wolfgang Bumiller
---
src/PVE/API2/Network/SDN/Zones.pm | 18 +++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/src/PVE/API2/Ne
Handle 'delete' parameter and partial updates.
See 2 commits earlier for explanation.
Cc: Alexandre Derumier
Signed-off-by: Wolfgang Bumiller
---
src/PVE/API2/Network/SDN/Subnets.pm | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/src/PVE/API2/N
Signed-off-by: Wolfgang Bumiller
---
src/PVE/API2/Network/SDN/Controllers.pm | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/PVE/API2/Network/SDN/Controllers.pm
b/src/PVE/API2/Network/SDN/Controllers.pm
index d8f18ab..0540a65 100644
--- a/src/PVE/API2/Network/SDN/Controllers.pm
; parameter, which is fixed in this series:
- /cluster/sdn/ipams/
- /cluster/sdn/dns/
- /cluster/sdn/controllers/
Wolfgang Bumiller (7):
Revert "sdn: require ipam in simple plugin for dhcp"
api: take partial configs for PUT /cluster/sdn/zones/
api: take partial configs for PUT /cluste
Handle 'delete' parameter and partial updates.
See previous commit for explanation.
Cc: Alexandre Derumier
Signed-off-by: Wolfgang Bumiller
---
src/PVE/API2/Network/SDN/Vnets.pm | 24
1 file changed, 20 insertions(+), 4 deletions(-)
diff --git a/src/PVE/AP
This reverts commit 53ab1495621f46c8af4dc560905f7e501bee75a7.
This also affects the updateSchema which is not intentional, since the
update API calls are supposed to take changes, not full replacements.
Signed-off-by: Wolfgang Bumiller
---
src/PVE/Network/SDN/Zones/SimplePlugin.pm | 1 -
1
Signed-off-by: Wolfgang Bumiller
---
src/PVE/API2/Network/SDN/Dns.pm | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/PVE/API2/Network/SDN/Dns.pm b/src/PVE/API2/Network/SDN/Dns.pm
index 3d08552..826d111 100644
--- a/src/PVE/API2/Network/SDN/Dns.pm
+++ b/src/PVE/API2/Network/SDN
this is for completeness, currently no plugin has optional
properties...
Signed-off-by: Wolfgang Bumiller
---
src/PVE/API2/Network/SDN/Ipams.pm | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/PVE/API2/Network/SDN/Ipams.pm
b/src/PVE/API2/Network/SDN/Ipams.pm
index d6e0bc8
applied, thanks
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied, thanks
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied, thanks
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied, thanks
On Wed, Jan 03, 2024 at 09:53:30AM +0100, Hannes Duerr wrote:
> Signed-off-by: Hannes Duerr
> ---
>
> The additional information can help with debugging firewall rules, as
> one can see how many times a specified rule got hit
>
> PVE/Report.pm | 2 +-
> 1 file changed, 1 insert
applied, thanks
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied series, thanks
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
On Wed, Dec 20, 2023 at 03:37:03PM +0100, Filip Schauer wrote:
> Decode non-ASCII character when syncing user attributes, since those
decode *how*?
> will be encoded later on. Without this fix the attributes where encoded
> twice, resulting in cases such as 'ü' turning into 'ü'.
>
> Signed-off-
applied series, thanks
not 100% sure about the `C` const - might be nice to instead have a
static Lazy C to get via `Locale::c()` but that can happen
later...
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mail
On Thu, Dec 14, 2023 at 01:42:07PM +0100, Lukas Wagner wrote:
> by a matcher.
^ this line should be part of the subject
>
> In the 'delete'-handler targets, we check if a
> target is still referenced by a matcher - if it is, we return an
> error. For built-in targets, this is actually not necess
On Wed, Dec 13, 2023 at 05:42:00PM +0100, Lukas Wagner wrote:
> For mails forwarded by `proxmox-mail-forward` to an SMTP target, the
> original message was nested as a 'message/rfc822' message part.
> Originally this approach was chosen to avoid having to rewrite
> message headers.
> Good email-cli
applied both patches, thanks
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied both patches, thanks
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied all 3 proxmox-notify patches, thanks
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
On Fri, Jan 26, 2024 at 12:39:17PM +0100, Folke Gleumes wrote:
> On Tue, 2024-01-23 at 10:51 +0100, Fabian Grünbichler wrote:
> > On January 22, 2024 11:12 am, Folke Gleumes wrote:
> > > proxmox-perl-rs set's SSL_CERT_{DIR,FILE}, which can break ssl in
> > > containers if their certificate store ca
applied, thanks
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied, thanks
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied, thanks
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
On Tue, Mar 05, 2024 at 12:13:05PM +0100, Thomas Lamprecht wrote:
> Am 23/02/2024 um 10:24 schrieb Roland Kammerer:
> > This passes the well known $scfg to parse_volname and bumps the API
> > versions accordingly. This allows plugins to access their configuration
> > if necessary.
>
> We discussed
On Tue, Mar 19, 2024 at 04:32:49PM +0100, Max Carrara wrote:
> +@contextmanager
> +def connect_to_esxi_host(args: EsxiConnectonArgs) -> vim.ServiceInstance:
> +"""Opens a connection to an ESXi host with the given username and
> password
> +contained in the password file.
> +"""
> +
applied series, thanks
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
On Tue, Apr 02, 2024 at 09:27:57AM +0200, Fabian Grünbichler wrote:
>
> > Jona Draaijer via pve-devel hat am 01.04.2024
> > 22:00 CEST geschrieben:
> > Hi,
> >
> > As per the title, that endpoint has an additionalProperties value that is
> > not a bool, but rather an object definition. (It's de
On Fri, Mar 15, 2024 at 11:24:54AM +0100, Fiona Ebner wrote:
> Similar to how Datastore.AllocateSpace is required for the backup
> storage, it should also be required for the fleecing storage.
>
> Removing a fleecing storage from a job does not require more
> permissions than for modifying the job
On Fri, Mar 15, 2024 at 11:24:48AM +0100, Fiona Ebner wrote:
> When a fleecing option is given, it is expected that each device has
> a corresponding "-fleecing" block device already attached, except for
> EFI disk and TPM state, where fleecing is never used.
>
> The following graph was adapted fr
looks mostly good, just the ExecStartPre= lines in the service files
should be dropped
On Mon, Mar 25, 2024 at 06:28:28PM +0100, Filip Schauer wrote:
> Set up an Apparmor profile to allow moving mounts for mount point
> hotplug.
>
> This fixes a regression caused by
> kernel commit 157a3537d6 ("a
applied, thanks
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied both patches, thanks
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied, thanks
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
On Wed, Apr 10, 2024 at 11:57:37AM +0200, Fiona Ebner wrote:
> Am 08.04.24 um 10:47 schrieb Wolfgang Bumiller:
> > On Fri, Mar 15, 2024 at 11:24:54AM +0100, Fiona Ebner wrote:
> >> @@ -52,6 +52,12 @@ sub assert_param_permission_common {
> >> if (grep { defined
On Wed, Apr 10, 2024 at 11:30:59AM +0200, Fiona Ebner wrote:
> Am 08.04.24 um 14:45 schrieb Wolfgang Bumiller:
> > On Fri, Mar 15, 2024 at 11:24:48AM +0100, Fiona Ebner wrote:
> >> @@ -581,6 +682,14 @@ static void create_backup_jobs_bh(void *opaque) {
> >> aio_c
lved properly.
Signed-off-by: Wolfgang Bumiller
---
...pect-msg_namelen-0-for-recvmsg-calls.patch | 31 +++
1 file changed, 31 insertions(+)
create mode 100644
patches/kernel/0012-apparmor-expect-msg_namelen-0-for-recvmsg-calls.patch
diff --git
a/patches/kernel/0012-apparmor-expec
On Wed, Apr 10, 2024 at 03:13:06PM +0200, Fabian Grünbichler wrote:
> one for combining the per-node broadcasted values, one for checking a pool's
> limit, and one specific helper for checking guest-related actions such as
> starting a VM.
>
> Signed-off-by: Fabian Grünbichler
> ---
> src/PVE/Gu
On Wed, Apr 10, 2024 at 03:13:07PM +0200, Fabian Grünbichler wrote:
> allow to set/update limits, and return them when querying individual pools.
>
> Signed-off-by: Fabian Grünbichler
> ---
>
> Notes:
> requires bumped pve-access-control
>
> PVE/API2/Pool.pm | 36 ++
On Wed, Apr 10, 2024 at 03:13:00PM +0200, Fabian Grünbichler wrote:
> these are similar to existing ones, but with slightly different semantics.
>
> Signed-off-by: Fabian Grünbichler
> ---
> src/PVE/LXC.pm | 29 +
> 1 file changed, 29 insertions(+)
>
> diff --git a/s
On Wed, Apr 10, 2024 at 03:13:08PM +0200, Fabian Grünbichler wrote:
> so that other nodes can query it and both block changes that would violate the
> limits, and mark pools which are violating it currently accordingly.
>
> Signed-off-by: Fabian Grünbichler
> ---
> PVE/Service/pvestatd.pm | 59 +
applied, thanks
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
On Thu, Apr 11, 2024 at 09:23:53AM +0200, Fabian Grünbichler wrote:
> On April 10, 2024 3:13 pm, Fabian Grünbichler wrote:
> > Signed-off-by: Fabian Grünbichler
> > ---
> > src/PVE/API2/LXC/Config.pm | 21 +
> > 1 file changed, 21 insertions(+)
> >
> > diff --git a/src/PVE/AP
applied series, thanks!
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
On Wed, Feb 09, 2022 at 06:35:33PM +0100, Thomas Lamprecht wrote:
> On 27.01.22 11:55, Dominik Csapak wrote:
> > we will need some extra parameters here, and instead of hardcoding them,
> > have the option to set a list of arbitrary parameters
> >
> > Signed-off-by: Dominik Csapak
> > ---
> > sr
ide property strings...
Signed-off-by: Wolfgang Bumiller
---
This is mostly a reaction to Hannes' maintenance mode series.
I think it would make more sense to improve our "property string
specification" (as much as there is one :P) to support quoted strings.
This way we can avoid th
applied, thanks
On Wed, Mar 02, 2022 at 10:05:16AM +0100, Fabian Ebner wrote:
> This is necessary for multi-disk backups where not all jobs are
> immediately started after they are created. QEMU commit
> 06e0a9c16405c0a4c1eca33cf286cc04c42066a2 did already part of the work,
> ensuring that new wri
applied, thanks
On Thu, Mar 03, 2022 at 01:31:18PM +0100, Fabian Ebner wrote:
> The recent changes to support setting target storage and allow
> renaming led to two problems with unused and unreferenced disks, as
> well as exposing a bug in ZFSPoolPlugin.pm's volume_import.
>
>
> container:
>
>
On Fri, Mar 11, 2022 at 08:42:29AM +, DERUMIER, Alexandre wrote:
> Hi,
> I would like to known if somebody is already working on nftables ?
Not actively in the pve code. I only have a few different variants of
possible nft rulesets around but there's always been something missing,
even with br
Signed-off-by: Wolfgang Bumiller
---
src/PVE/JSONSchema.pm | 24 +---
1 file changed, 21 insertions(+), 3 deletions(-)
diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm
index 65055e0..2caf109 100644
--- a/src/PVE/JSONSchema.pm
+++ b/src/PVE/JSONSchema.pm
@@ -1823,8
This extends PVE::JSONSchema::parse_config to have an optional "comment
key" to collect comments into and drops the node config parser and its
custom check_type helper to instead use the common parser.
And while I'm at it, I also add the return schema for get_config, since
I see no obvious reason
Signed-off-by: Wolfgang Bumiller
---
PVE/NodeConfig.pm | 75 +++
1 file changed, 10 insertions(+), 65 deletions(-)
diff --git a/PVE/NodeConfig.pm b/PVE/NodeConfig.pm
index df44410f..941e6009 100644
--- a/PVE/NodeConfig.pm
+++ b/PVE/NodeConfig.pm
Signed-off-by: Wolfgang Bumiller
---
PVE/API2/NodeConfig.pm | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/PVE/API2/NodeConfig.pm b/PVE/API2/NodeConfig.pm
index 9c48bcdb..961cd345 100644
--- a/PVE/API2/NodeConfig.pm
+++ b/PVE/API2/NodeConfig.pm
Sorry for the late reply.
On Fri, Sep 10, 2021 at 05:34:29PM +0200, Alexandre Derumier wrote:
> This new option allow filtering of destination macs for ingress traffic.
>
> This is a protection from bad/hosting networks (like hetzner) flooding
> traffic with non-hosted mac.
>
> To be fast, one r
Signed-off-by: Wolfgang Bumiller
---
The tokens are a mapping from tokenid to the token data, so let's
include this in the output specification.
We don't really make use of additionalProperties like this yet but it
*is* supported in PVE::JSONSchema, and it's the only way to clari
On Mon, Mar 21, 2022 at 02:24:54PM +0100, Mira Limbeck wrote:
> ureq has support for a HTTP proxy, but no support for HTTPS proxy yet.
>
> ureq doesn't query `all_proxy` and `ALL_PROXY` environment variables by
> itself the way curl does. So set the proxy in code if any of the above
> environment
On Fri, Mar 04, 2022 at 12:31:57PM +0100, Stefan Sterz wrote:
> add support for multi-line comments to node.cfg and the api, similar to
> how pve handles multi-line comments
>
> Signed-off-by: Stefan Sterz
Acked-by: Wolfgang Bumiller
_
On Mon, Apr 11, 2022 at 07:09:09AM +, Hannes Laimer wrote:
> If TFA was added and disabled afterwards it was not possible to login
> again.
>
> Signed-off-by: Hannes Laimer
> ---
> This was reported on the forum.
>
> src/PVE/API2/AccessControl.pm | 4 ++--
> 1 file changed, 2 insertions(+),
lgtm
While looking at the code again, I do find the error handling in
`extract_content` generally a bit lacking, though, eg. the `blk` var
moved down below is only set if `errp` is not set, but we still go ahead
with everything else, making me wonder if we shouldn't bail out then
instead...
But t
t; Signed-off-by: Fabian Ebner
Acked-by: Wolfgang Bumiller
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
this should fix an issue where users with custom id mappings
get bad ownership on intermediate directories caused by the
rootuid/gid being the string "10" in perl instead of the
number 10...
Signed-off-by: Wolfgang Bumiller
---
NOTE: I decided to go through them all, not just
> On 05/02/2022 9:20 AM Dominik Csapak wrote:
>
>
> On 5/2/22 09:04, Thomas Lamprecht wrote:
> > Am 5/2/22 um 08:48 schrieb Dominik Csapak:
> >> On 5/2/22 08:36, Thomas Lamprecht wrote:
> >>> Am 4/29/22 um 12:00 schrieb Dominik Csapak:
(...)
> >> not sure if thats a good idea though
> >>
> >> w
On Thu, Jun 02, 2022 at 09:14:59AM +0200, Thomas Lamprecht wrote:
> Am 27/05/2022 um 14:31 schrieb Dominik Csapak:
> > this allows setting notes+protected for backups on btrfs
> >
> > Signed-off-by: Dominik Csapak
> > ---
> > PVE/Storage/BTRFSPlugin.pm | 11 +--
> > 1 file changed, 9 ins
On Thu, Jun 02, 2022 at 10:03:32AM +0200, Wolfgang Bumiller wrote:
> On Thu, Jun 02, 2022 at 09:14:59AM +0200, Thomas Lamprecht wrote:
> > Am 27/05/2022 um 14:31 schrieb Dominik Csapak:
> > > this allows setting notes+protected for backups on btrfs
> > >
> >
On Wed, May 25, 2022 at 01:59:37PM +0200, Fabian Ebner wrote:
> The first call to job_cancel_sync() will cancel and free all jobs in
> the transaction, so ensure that it's called only once and get rid of
> the job_unref() that would operate on freed memory.
>
> It's also necessary to NULL backup_s
.patch
> +++
> b/debian/patches/pve/0055-PVE-Backup-ensure-jobs-in-di_list-are-referenced.patch
> @@ -17,26 +17,29 @@ freed. With unlucky timings it seems possible that:
> Signed-off-by: Fabian Ebner
> Signed-off-by: Wolfgang Bumiller
> ---
> - pve-backup.c | 13 +
tem-x86_64 + 0x6f8e6f)
> > #9 0x5641bcd32d65 job_unref (qemu-system-x86_64 + 0x6f9d65)
> > #10 0x5641bcd93b3d pvebackup_co_complete_stream (qemu-system-x86_64 +
> > 0x75ab3d)
> > #11 0x5641bce4e353 coroutine_trampoline (qemu-system-x86_64 + 0x815353)
>
&g
applied, thanks
On Wed, May 04, 2022 at 10:15:02AM +0200, Dominik Csapak wrote:
> not only when we want to remove it. Otherwise, if the old volume is
> mapped (e.g. ceph krbd), we don't unmap it when we're finished.
>
> We have to save if we deactivated successfully before attempting to
> remove
1 - 100 of 769 matches
Mail list logo
