On Thu, Jun 02, 2022 at 10:03:32AM +0200, Wolfgang Bumiller wrote: > On Thu, Jun 02, 2022 at 09:14:59AM +0200, Thomas Lamprecht wrote: > > Am 27/05/2022 um 14:31 schrieb Dominik Csapak: > > > this allows setting notes+protected for backups on btrfs > > > > > > Signed-off-by: Dominik Csapak <d.csa...@proxmox.com> > > > --- > > > PVE/Storage/BTRFSPlugin.pm | 11 +++++++++-- > > > 1 file changed, 9 insertions(+), 2 deletions(-) > > > > looks OK, but the whole situation with that and often also btrfs is > > sometimes > > a bit weird in subtle ways, so a quick look from you wolfgang would be > > appreciated. > > I'm a bit confused about the `get/update_volume_notes` subs. > You said they are deprecated and unused. However, the DirPlugin does > call it when `$attribute eq "notes"` in `get/update_volume_attribute`. > > Since BTRFSPlugin uses Plugin as a base and not DirPlugin and we pass > $class (== BTRFSPlugin) to it, setting notes should not work with this patch?
Nevermind, I didn't read the 1st patch properly, those aren't called via $class anymore. Acked-by: Wolfgang Bumiller <w.bumil...@proxmox.com> _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
