On 08.03.22 15:41, Dominik Csapak wrote:
> When writing into the file, explicitly utf8 encode it, and then try to
> utf8 decode it on read.
>
> If the notes are not valid utf8, we assume it was an iso-8859 comment
> and return is at is was.
>
> Technically this is a breaking change, since there a
On 11.03.22 13:55, Stoiko Ivanov wrote:
> updates the submodule to the recently release zfs-2.1.3
>
> * changeset does not look too exciting (kernel-compatibility fixes, testsuite,
> FreeBSD)
> * the addition of the systemd timer+service for regular scrubbing is something
> user-visible (but a
On 11.03.22 17:04, Stoiko Ivanov wrote:
> Since all our zfs installs use proxmox-boot-tool the compatibility is
> not an issue anymore
>
> Signed-off-by: Stoiko Ivanov
> ---
> tested the zstd option by pushing the updated proxinstall to the current
> 7.1-2 ISO
>
> proxinstall | 3 +--
> 1 file
On 14.03.22 17:49, Aaron Lauterer wrote:
> On 2/22/22 09:44, Thomas Lamprecht wrote:
>> On 18.02.22 12:38, Aaron Lauterer wrote:
> [...]
>
>>
>> In general I see lots of repetition, and in this case I'd rather have a
>> single
>> enpoint that accepts
On 15.03.22 08:31, Fabian Ebner wrote:
> Am 14.03.22 um 14:50 schrieb Oguz Bektas:
>> first call $rpcenv->get_user() if user was 'undef'. if that doesn't
>> return then we set it to root@pam.
this is just the "whats done" description, that's not really interesting for
such a short patch, as it can
On 15.03.22 12:21, Oguz Bektas wrote:
> On Tue, Mar 15, 2022 at 09:57:34AM +0100, Thomas Lamprecht wrote:
>> On 15.03.22 08:31, Fabian Ebner wrote:
>>> Am 14.03.22 um 14:50 schrieb Oguz Bektas:
>>>> first call $rpcenv->get_user() if user was 'undef'. if
On 15.03.22 12:52, Oguz Bektas wrote:
> call sites without a defined user parameter (found only push_file and
> pull_file from pve-container) were logging the user as 'root@pve' which
> doesn't exist.
>
> for clarity, also add a comment that this is only used for the task
> logs.
>
> Signed-off-b
higher level comment: We cannot do it this way as it adds a cyclic dependency
between pve-container <-> pve-manager and qemu-server <-> pve-manager, which
is not allowed (such things, besides being ugly, make bootstrapping *a lot*
harder, and as I'm most often doing the bootstrap effort I NAK this)
On 29.05.20 14:22, Mira Limbeck wrote:
> The combogrid contains all valid icmp types that iptables accepts. In
> addition to the names, the Type[/Code] value is shown as well. But
> specifying Type[/Code] is not supported.
>
> As the simple solution with setStore() does not work to change the stor
On 29.05.20 14:22, Mira Limbeck wrote:
> Signed-off-by: Mira Limbeck
> ---
> v2:
> - rebased on master
>
> pve-firewall-rules-opts.adoc | 4
> 1 file changed, 4 insertions(+)
>
>
applied, thanks!
___
pve-devel mailing list
pve-devel@lists.pro
On 25.01.21 15:54, Aaron Lauterer wrote:
> Signed-off-by: Aaron Lauterer
> ---
>
> v1->v3: nothing
>
> www/manager6/qemu/Options.js | 1 +
> 1 file changed, 1 insertion(+)
>
>
applied, thanks!
___
pve-devel mailing list
pve-devel@lists.proxmox.com
On 24.06.21 14:30, Stefan Reiter wrote:
> zfs_mirror_size_check is already called in get_zfs_raid_setup when
> necessary, so don't call it unconditionally, as this will cause a
> false-positive error on RAID0 devices (where size mismatches are fine).
>
> Signed-off-by: Stefan Reiter
> ---
> prox
On 05.07.21 12:15, Oguz Bektas wrote:
> sometimes the qdevice setup can fail when copying CA certificates if the
> node SSH keys are not matching for some reason.
>
> reported here:
> https://forum.proxmox.com/threads/pvecm-qdevice-setup-fails.88681
>
> Signed-off-by: Oguz Bektas
> ---
> pvecm.
On 13.08.21 11:10, Fabian Ebner wrote:
> The backend won't allow any edits in this case, so better just disable
> the edit button altogether.
>
> Co-developed-by: Fabian Grünbichler
> Signed-off-by: Fabian Ebner
> ---
>
> Changes from v1:
> * split cases based on 'key'
> * keep logic fo
On 05.09.21 09:37, Alexandre Derumier wrote:
> Signed-off-by: Alexandre Derumier
> ---
> www/manager6/sdn/zones/Base.js | 2 ++
> www/manager6/sdn/zones/EvpnEdit.js | 22 ++
> 2 files changed, 24 insertions(+)
>
>
applied, thanks!
_
On 24.09.21 10:50, Alexandre Derumier wrote:
> following pve-common
> https://lists.proxmox.com/pipermail/pve-devel/2021-September/050090.html
>
> Alexandre Derumier (4):
> vnets: fix get_vnet
> zones : tap_plug: add support for disable bridge learning
> zones: add add_bridge_fdb
> zones:
On 04.10.21 08:08, Alexandre Derumier wrote:
> - display zones list in global permissions management pathselector
> - remove vmbrX bridges from bridgeselector if user have permissions on vnets
>
>
> changelog v2:
>
> - check permission on /sdn/vnet/ too if user need access on both
> vnets && v
On 11.03.22 12:59, Markus Frank wrote:
> With "noerr => 1" the function does not abort, when one of the
> mountpoints is not fstrim compatible like zfs (has its own trim).
> I do not think it is necessary to warn or error, because fstrim
> tells when something is not trimmable and aborts.
>
> Sig
On 04.11.21 15:40, Dominik Csapak wrote:
> Series LGTM, looked closely at the regexes,
> and they match (semantically), tested around a bit
> and all seemed to work.
>
> one super small nit (not a blocker IMHO)
>
> the format/extension/compression handling in 2/2
> could maybe use a comment what
On 24.09.21 10:48, Alexandre Derumier wrote:
> Currently, if bridge receive an unknown dest mac (network bug/attack/..),
> we are flooding packets to all bridge ports.
>
> This can waste cpu time, even more with firewall enabled.
> Also, if firewall is used with reject action, the src mac of RST
>
On 12.11.21 12:28, Fabian Ebner wrote:
> Suggested-by: Thomas Lamprecht
> Signed-off-by: Fabian Ebner
> ---
> www/manager6/grid/BackupView.js| 22 +-
> www/manager6/storage/BackupView.js | 24 +++-
> 2 files changed, 44 insertio
On 15.11.21 13:37, Fabian Ebner wrote:
> by making sure the storage ID is part of the error. This can happen
> for (at least) CIFS, and GlusterFS with local server.
>
> Signed-off-by: Fabian Ebner
> ---
> PVE/Storage.pm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>
applied, tha
On 15.11.21 13:37, Fabian Ebner wrote:
> in the same manner as NT_STATUS_ACCESS_DENIED. It can be assumed to be
> a configuration error, so avoid showing the generic "storage
> is not online". Reported in the community forum:
> https://forum.proxmox.com/threads/storage-is-not-online-cifs.99201/pos
On 16.12.21 13:12, Fabian Ebner wrote:
> The ability to mark backups as protected broke the implicit assumption
> in vzdump that remove=1 and current number of backups being the limit
> (i.e. sum of all keep options) will result in a backup being removed.
>
> Introduce a new storage property 'max-
On 16.12.21 13:12, Fabian Ebner wrote:
> Otherwise, there is no storage-agnostic way to filter by backup group.
>
> Call it subtype, to not confuse it with content type, and to be able
> to re-use it for other content types than backup, if the need ever
> arises.
>
> Signed-off-by: Fabian Ebner
On 25.02.22 13:00, Markus Frank wrote:
> added a Parameter for vIOMMU so nobody has to use a github-script
> or change the kvm command on every vm boot.
> The args parameter doesn't work because the -device parameter(kvm)
> with intel-iommu has to be placed before the other arguments.
>
some shor
On 28.02.22 14:48, Dominik Csapak wrote:
> some systems[0] have pci domains longer than the default ('') of 4
> characters, so change the regex to allow at least 4.
>
> 0:
> https://forum.proxmox.com/threads/problem-with-gpu-passthrough-in-a-virtual-machine.105720/
>
> Signed-off-by: Dominik
On 06.03.22 13:46, Alexandre Derumier wrote:
> Allow balloon device driver to report hints of guest free pages to the host,
> for auto memory reclaim
>
> https://lwn.net/Articles/759413/
> https://events19.linuxfoundation.org/wp-content/uploads/2017/12/KVMForum2018.pdf
> Signed-off-by: Alexandre
On 28.02.22 14:48, Dominik Csapak wrote:
> by default, there is only one pci domain (''), but there are systems
> where there are more, and they don't need to be exactly 4 characters
> long (see [0]), so extend that regex to allow domains 4 characters or
> longer
>
> 0:
> https://forum.proxmo
On 16.03.22 12:04, Fabian Ebner wrote:
> Am 16.12.21 um 13:12 schrieb Fabian Ebner:
>> In command_line(), notes are printed, quoted, but otherwise as is,
>> which is a bit ugly for multi-line notes. But it is part of the
>> commandline.
>>
>> Signed-off-by: Fabian Ebner
>> ---
>> src/PVE/VZDump/C
On 17.03.22 08:51, Dominik Csapak wrote:
> On 3/16/22 17:16, Thomas Lamprecht wrote:
>> On 04.11.21 15:40, Dominik Csapak wrote:
>>> Series LGTM, looked closely at the regexes,
>>> and they match (semantically), tested around a bit
>>> and all seemed to work
On 17.03.22 08:57, Fabian Ebner wrote:
> Am 16.03.22 um 19:25 schrieb Thomas Lamprecht:
>> On 16.03.22 12:04, Fabian Ebner wrote:
>>> Am 16.12.21 um 13:12 schrieb Fabian Ebner:
>>>
>>> Fabian G.:
>>> we could offer something like a simple template s
On 17.03.22 09:03, Fabian Ebner wrote:
> Am 16.03.22 um 17:42 schrieb Thomas Lamprecht:
>> On 16.12.21 13:12, Fabian Ebner wrote:
>>> diff --git a/PVE/Storage.pm b/PVE/Storage.pm
>>> index d64019f..0643fad 100755
>>> --- a/PVE/Storage.pm
>>> +++
On 17.03.22 09:18, Fabian Ebner wrote:
>> Agree. So, to summarize, vzdump does the interpreting for a plain, new
>> `--notes`
>> CLI which it also prints (with variables already resolved) in the task log
>> and
>> sets that also as note for the (created) backup.
>>
>> The job config would get a n
On 16.03.22 20:32, DERUMIER, Alexandre wrote:
> From my tests:
> a already booted vm without the balloon freepage option enabled --->
> migrating to new vm with balloon freepage option enabled : works
>
> Then failback it to previous node : works
>
>
> But starting a new vm with the option enabl
On 17.03.22 11:26, Wolfgang Bumiller wrote:
> Signed-off-by: Wolfgang Bumiller
> ---
> src/PVE/JSONSchema.pm | 24 +---
> 1 file changed, 21 insertions(+), 3 deletions(-)
>
>
applied, thanks!
___
pve-devel mailing list
pve-devel@
On 17.03.22 13:16, Daniel Tschlatscher wrote:
> Signed-off-by: Daniel Tschlatscher
> ---
> Fixed indentation and trailing whitespace
> src/PVE/API2/LXC/Status.pm | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/src/PVE/API2/LXC/Status.pm b/src/PVE/API2/LXC/Status.pm
Hi,
On 17.03.22 13:23, Gilberto Ferreira wrote:
> Sorry to make noise in this thread but this is intended to be a GUI to qm
> importdisk CLI command?
yes, this series is a preparation for exactly that.
___
pve-devel mailing list
pve-devel@lists.proxm
On 17.03.22 11:26, Wolfgang Bumiller wrote:
> Signed-off-by: Wolfgang Bumiller
> ---
> PVE/NodeConfig.pm | 75 +++
> 1 file changed, 10 insertions(+), 65 deletions(-)
>
>
applied, thanks!
___
pve-devel mai
On 17.03.22 11:26, Wolfgang Bumiller wrote:
> Signed-off-by: Wolfgang Bumiller
> ---
> PVE/API2/NodeConfig.pm | 22 +++---
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
>
applied, thanks!
___
pve-devel mailing list
pve-devel@
On 18/03/2022 14:52, Matthias Heiserer wrote:
> Signed-off-by: Matthias Heiserer
> ---
> changes from v1:
> add "backup" to name
> return empty string instead of throwing
patch order is wrong though, you cannot use a helper in patch 1/x and only
introduce
it in a later patch. This break bisect
On 18/03/2022 11:00, Dominik Csapak wrote:
> otherwise firefox complains with a deprecation warning that the secureflag
> is not set but SameSite to 'None'. Since we cannot know how firefox will
> behave once that behaviour is no longer supported, add the secure flag
> now.
>
> we have to use the
On 21.03.22 15:29, Wolfgang Bumiller wrote:
> Signed-off-by: Wolfgang Bumiller
> ---
> The tokens are a mapping from tokenid to the token data, so let's
> include this in the output specification.
>
> We don't really make use of additionalProperties like this yet but it
> *is* supported in PVE::J
On 04.02.22 15:24, Dominik Csapak wrote:
> this deprecates the 'full' sync option and replaces it with
> a 'mode' option, where we add a third one that updates
> the current users (while retaining their custom set attributes not
> exisiting in the source) and removing users that don't exist anymore
On 22.03.22 10:41, Mira Limbeck wrote:
> ureq has support for a HTTP proxy, but no support for HTTPS proxy yet.
> ureq doesn't query `all_proxy` and `ALL_PROXY` environment variables by
> itself, the way curl does. So set the proxy in code if any of the above
> environment variables are set.
>
> S
On 22.03.22 09:42, Fabian Ebner wrote:
> Nit: for the commit title, prefixing like "ui: storage:" is preferred.
>
> I really think we should start with the tree fully expanded, or we will
> get shouted at by users relying on notes to find their backups ;)
+1, additionally add a toggle for expand/
On 22.03.22 07:11, Thomas Lamprecht wrote:
> On 04.02.22 15:24, Dominik Csapak wrote:
>> this deprecates the 'full' sync option and replaces it with
>> a 'mode' option, where we add a third one that updates
>> the current users (while retaining their cust
On 22.03.22 16:23, Dominik Csapak wrote:
> On 3/22/22 14:44, Thomas Lamprecht wrote:
>> On 22.03.22 07:11, Thomas Lamprecht wrote:
>>> On 04.02.22 15:24, Dominik Csapak wrote:
>>>> this deprecates the 'full' sync option and replaces it with
>>>
On 23.03.22 08:33, Thomas Lamprecht wrote:
>>> remove-vanished: [];[];[acls]
>>>
>>> I.e., those three flags would replace your new mode + purge like:
>>>
>>> +++-
On 04.03.22 12:31, Stefan Sterz wrote:
> add support for multi-line comments to node.cfg and the api, similar to
> how pve handles multi-line comments
>
> Signed-off-by: Stefan Sterz
> ---
> pbs-api-types/src/lib.rs | 9 +++
> src/api2/node/config.rs | 4 +++
> src/config/node.rs |
On 04.03.22 12:32, Stefan Sterz wrote:
> move these from pve to the widget toolkit to be ablte to use them in
> pbs
>
this is no 1:1 move but the commit messages fails to describe the changes
made nor the rationale.
> Signed-off-by: Stefan Sterz
> ---
> src/Makefile| 2 +
> src/p
On 04.03.22 12:31, Stefan Sterz wrote:
> since markdown notes might be rather long, this commit adds a tab
> similar to pve's datacenter or node notes.
>
> Signed-off-by: Stefan Sterz
> ---
> www/Makefile | 2 +
> www/NavigationTree.js | 6 ++
> www/NodeNotes.js
On 04.03.22 12:32, Stefan Sterz wrote:
> for better re-use between pbs and pve move the markdown notes panel
> and editor window to the widget kit and unify them there.
>
ah ok, now I get it, rather please just leave the intermediate addition of
a notes view and directly use the wtk version and j
On 14.03.22 10:35, Aaron Lauterer wrote:
> We already know that we are acting upon a disk / volume due to the
> submenu we are in.
ok with that in general, but some proposal over conveying better what "move" and
"reassign" respectively means while not getting a long label.
Also, a (separate) sugg
Thanks for the patch, some comments inline.
On 24.03.22 16:44, Daniel Tschlatscher wrote:
> The backup restore dialogue now displays size information and duration in a
> format more easily understandable for humans. The output was adapted to match
> the output of the backup restore dialogue wher
On 24.03.22 12:33, Matthias Heiserer wrote:
> The same code is used once in widget toolkit and twice in PVE already,
> so it makes sense to add it as a separate function.
>
> Signed-off-by: Matthias Heiserer
> ---
> src/Utils.js | 11 +++
> 1 file changed, 11 insertions(+)
>
> diff --gi
please add a prefixing tag to the comment subject:
apt repos: use new button max-width helper from utils
On 24.03.22 12:33, Matthias Heiserer wrote:
> Signed-off-by: Matthias Heiserer
> ---
> src/node/APTRepositories.js | 11 +--
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
> di
On 24.03.22 12:33, Matthias Heiserer wrote:
> The same code is used once in widget toolkit and twice in PVE already,
> so it makes sense to add it as a separate function.
>
FWIW, there'd be also the possibility of adding a new button class, derived
from proxmoxButton, that would be a bit more boi
as a v2 is required anyway, please adapt the subject:
"ui: tree-wide: use new button max-width helper from utils"
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
On 25.03.22 09:34, Daniel Tschlatscher wrote:
> The backup restore dialogue now displays size information and duration in a
> format more easily understandable for humans. The output was adapated to
> match the output of the backup create dialogue where possible.
> Added 2 helper methods for disp
(re-sending, seems you forgot to hit Reply-All and only sent it to me directly).
On 25.03.22 10:41, Daniel Tschlatscher wrote:
> On 3/25/22 09:29, Thomas Lamprecht wrote:
>> Thanks for the patch, some comments inline.
>> On 24.03.22 16:44, Daniel Tschlatscher wrote:
>> ple
On 25.03.22 13:39, Daniel Tschlatscher wrote:
> On 3/25/22 12:05, Thomas Lamprecht wrote:
>>>>> ++
>>>>> ++ if (delta != 0)
>>>>> ++ bps /= delta;
>>>> currently, if delta would be null you'd print
On 28.03.22 11:43, Matthias Heiserer wrote:
> On 25.03.2022 09:47, Thomas Lamprecht wrote:
>> On 24.03.22 12:33, Matthias Heiserer wrote:
>>> The same code is used once in widget toolkit and twice in PVE already,
>>> so it makes sense to add it as a separate function.
On 28.03.22 12:17, Matthias Heiserer wrote:
> On 28.03.2022 11:44, Thomas Lamprecht wrote:
>> On 28.03.22 11:43, Matthias Heiserer wrote:
>>> On 25.03.2022 09:47, Thomas Lamprecht wrote:
>>>> On 24.03.22 12:33, Matthias Heiserer wrote:
>>>>> The same
On 11.02.22 10:33, Alexandre Derumier wrote:
> add new bgp/evpn options
>
> Alexandre Derumier (6):
> ui: sdn: zones: evpn : add exitnodes-local-routing &&
> advertise-subnets
> ui: sdn: zones: evpn : add disable-arp-nd-suppression
> ui: sdn: zones: evpn : add exitnodes-primary
> ui: s
On 11.02.22 10:34, Alexandre Derumier wrote:
> Signed-off-by: Alexandre Derumier
> ---
> pvesdn.adoc | 22 ++
> 1 file changed, 18 insertions(+), 4 deletions(-)
>
>
applied, thanks!
___
pve-devel mailing list
pve-devel@lists.prox
On 29.03.22 16:04, Dominik Csapak wrote:
> they can not be removed nor are they visible, so don't count them.
>
> When having a prefilter, we now don't show anymore that there is an
> active filter, and don't enable the button anymore.
> This is the case for vms for example (vmid is a prefilter).
On 28.03.22 15:53, Dominik Csapak wrote:
> firing 'refresh' in 'clearLocalFilter' was wrong, since that triggers
> too often, for example when selecting an entry (since the field lost
> focus). This lead to the picker refreshing and not registering the
> click and thus not selecting the desired ent
On 28.03.22 13:10, Aaron Lauterer wrote:
> Returning the block devices is more useful than the device node. The
> device node usually points to the DM device for bluestore OSDs:
> /dev/dm-x
>
> In almost all situations one will be interested in the physical device
> underneath, /dev/sdX or /dev/nv
On 28.03.22 13:10, Aaron Lauterer wrote:
> Returning the block devices is more useful than the device node. The
> device node usually points to the DM device for bluestore OSDs:
> /dev/dm-x
>
> In almost all situations one will be interested in the physical device
> underneath, /dev/sdX or /dev/nv
On 28.03.22 10:06, Fabian Grünbichler wrote:
> there were two helpers that were not handling this correctly:
>
> ct_make_path
>
> since this never gets called with $opts, and there also is no 'owner'
> and 'group' in $self, the previous logic could never work, sometimes
> leaving nobody:nogroup f
On 30.03.22 10:19, Aaron Lauterer wrote:
>
>
> On 3/29/22 18:05, Thomas Lamprecht wrote:
>> On 28.03.22 13:10, Aaron Lauterer wrote:
>>> Returning the block devices is more useful than the device node. The
>>> device node usually points to the DM device
On 31.03.22 08:36, Fabian Ebner wrote:
> Am 30.03.22 um 14:59 schrieb Matthias Heiserer:
>> 8<
>>
+ onLoad: function(store, records, success, operation) {
+ let me = this;
+ let view = me.getView();
+ let selection = view.getSelection()?.[0];
+
On 01.04.22 11:44, Mira Limbeck wrote:
> Azure doesn't accept `Transfer-Encoding: chunked` on their token endpoint,
> but with the switch to ureq we always send requests with this set.
>
> Fix by switching to `Content-Length` in the header instead. ureq only
> sets `Transfer-Encoding: chunked` whe
On 01.04.22 13:24, Dominik Csapak wrote:
> if we have a schedule that has no 'next event' we should skip the scheduling
> instead of schedule every round
>
> this can happen if someone sets an schedule that has no next match.
> some examples:
> * 2-31 00:00 (there is not February 31st)
> * mon 202
On 01.04.22 16:07, Daniel Tschlatscher wrote:
> The taskviewer now has 2 more buttons which implement
> functionality for downloading the current tasklog as a file
> or copying it to the clipboard. The code for saving the log
> to a file was taken from the pve System Report class and
> moved to its
On 01.04.22 16:07, Daniel Tschlatscher wrote:
> with a function call to the newly added textToFile() function in
> the utils class (Proxmox.Utils).
please refer to the fact that it got moved to proxmox-widget-toolkit to imply
the required dependency bump more explicitly.
>
> Signed-off-by: Danie
Hi Josh,
On 31.03.22 22:39, Joshua Huber wrote:
...
>
> 1) The simplest: if there's no entry in storageSchema for value, just
> return value as the "formatted" storage type. This seems like a great
> low-cost, low-risk change.
>
> diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
> inde
On 01.04.22 08:14, Dominik Csapak wrote:
> on create we require either starttime (+dow) or a schedule, but when
> updating an existing job, this is not necessary
>
> before we changed to schedules, the starttime was not optional either on
> update, but i think there is no reason to require the use
On 04.04.22 11:25, Daniel Tschlatscher wrote:
>> note that in JavaScript we go for 100 characters text-width. Also,
>> template-strings can
>> make a mix of string literals plus variables often shorter or at least
>> easier to read:
>>
>> let fileName = `${rec.user}@${rec.node}-${rec.type}...`
>>
On 04.04.22 10:50, Fabian Ebner wrote:
> It's installed and enabled by default since PVE 6.1.
>
> Signed-off-by: Fabian Ebner
> ---
> local-zfs.adoc | 24 +---
> 1 file changed, 9 insertions(+), 15 deletions(-)
>
>
applied, thanks!
On 06.04.22 10:26, Stefan Sterz wrote:
> I realized that there are some more improvements to be made here, I'll
> send an updated version in a bit. Sorry for the inconvenience.
maybe use that to keep the changes separate from the move, i.e., do a 1:1
move (as close as possible/sensible) and then d
On 06.04.22 13:26, Fabian Ebner wrote:
> Am 04.04.22 um 15:02 schrieb Matthias Heiserer:
>> Depends on
>> https://lists.proxmox.com/pipermail/pve-devel/2022-March/052322.html
>>
>> Matthias Heiserer (4):
>> ui: Utils: Helpers for backup type and icon
>> ui: storage: Rewrite backup content view
On 05.04.22 10:22, Fabian Ebner wrote:
> It's only available since QEMU 6.2 and doing a check here rather than
> bumping the package dependency allows for easy downgrades.
>
> Suggested-by: Fabian Grünbichler
> Signed-off-by: Fabian Ebner
> ---
> PVE/QemuServer.pm | 7 ++-
> 1 file changed,
On 07.04.22 08:31, Fabian Ebner wrote:
>>> I feel like we should always filter by backup type in the guest view
>>> like is done currently. Otherwise, there is the possibility to try and
>>> restore e.g. an LXC backup over an existing VM. That probably isn't a
>>> common use case, and it just leads
On 07.04.22 14:15, Fabian Ebner wrote:
> Commit fa7980c2 ("ui: lxc resources: switch to vector based font
> awesome icons") seems like an innocent change, but it broke the
> (very brittle) logic here by removing the tdCls for rootfs.
holy moly, didn't really expect that the gui is using css classe
On 08.04.22 10:04, Fabian Grünbichler wrote:
> On April 6, 2022 1:46 pm, Aaron Lauterer wrote:
>> If two RBD storages use the same pool, but connect to different
>> clusters, we cannot say to which cluster the mapped RBD image belongs to
>> if krbd is used. To avoid potential data loss, we need to
On 05.04.22 14:30, Aaron Lauterer wrote:
> Aaron Lauterer (5):
> ui: utils: refactor mps to mp
> ui: utils: add nextFreeMP
> ui: lxc/qemu: add disk reassign and action submenu
> ui: BusTypeSelector: change noVirtIO to withVirtIO
> ui: hdmove: modernize/refactor
>
> www/manager6/Makefile
On 11.04.22 11:08, Aaron Lauterer wrote:
> On 4/11/22 09:39, Thomas Lamprecht wrote:
>> The obvious question to me is: why bother with this workaround when we can
>> make udev create the symlink now already?
>>
>> Patching the rules file and/or binary shipped by ceph-com
On 11.04.22 16:49, Aaron Lauterer wrote:
> On 4/11/22 14:17, Thomas Lamprecht wrote:
>> FWIW, with storage getting the following patch the symlinks get created (may
>> need
>> an trigger for reloading udev (or manually `udevadm control -R`).
>>
>> We'd onl
On 12.04.22 12:34, Stefan Sterz wrote:
> move them here from pve so we can maintain them across several
> products
>
> Signed-off-by: Stefan Sterz
> ---
> src/Makefile| 2 +
> src/panel/NotesView.js | 129
> src/window/NotesEdit.js | 38 ++
On 12.04.22 12:34, Stefan Sterz wrote:
> refactor them to make them more flexible and, thus, usable in pbs.
> adds parameters for enabling the TBar, setting the help section in the
> editing dialog and cleans up the code in some places
>
> Signed-off-by: Stefan Sterz
> ---
> src/panel/NotesView.
Hi,
> On Tue, Apr 19, 2022 at 3:49 AM Benjamin via pve-devel
>> I'd like to try developing a MooseFS storage plugin for Proxmox, ideally
>> getting it good enough to be A) included by the project B) supported in
>> some way by the MooseFS folks.
For Storage plugins the basic rules to be considere
On 19.04.22 14:02, Stoiko Ivanov wrote:
> noticed that these 2 bugs were still open in bugzilla (and assigned to me).
>
> The issues are independent of each other - but the fixes touch the same part
> of the code - hence I'm sending them in a common series.
>
> roughly tested with a VM (scp'ing t
On 17.03.22 09:37, Fabian Ebner wrote:
> The backend will pick an appropriate format when nothing is specified. The
> comment made it sound like 'raw' would be sent, but that didn't actually
> happen
> on file-based storages, and now no format is sent, so adapt the comment too.
>
> Signed-off-by:
On 18.03.22 08:51, Fabian Ebner wrote:
> Also cannot issue a guest agent command in that case.
>
> Reported in the community forum:
> https://forum.proxmox.com/threads/106618
>
> Signed-off-by: Fabian Ebner
> ---
>
> Best viewed with -w.
>
> PVE/QemuMigrate.pm | 54 ++-
On 25.02.22 17:29, Dylan Whyte wrote:
> Adds a section to the "Host System Administration" section of the
> Administration Guide, discussing KSM and its security risks
>
> Signed-off-by: Dylan Whyte
> ---
> kernel-samepage-merging.adoc | 54
> sysadmin.adoc
On 20.04.22 12:09, Daniel Tschlatscher wrote:
> to make it possible to reference it through the help button in the
> GUI.
>
> Signed-off-by: Daniel Tschlatscher
> ---
> pvenode.adoc | 2 ++
> 1 file changed, 2 insertions(+)
>
>
applied, thanks!
___
On 20.04.22 12:09, Daniel Tschlatscher wrote:
> Added a new file for displaying and editing the node config options
> which were not exposed through the GUI yet. Namely those are the
> settings for wakeonlan and startall-on-boot-delay.
Why is this in widget toolkit if it's only PVE specific? (see
On 22.04.22 13:03, Fabian Ebner wrote:
> Fixes: f9be9137 ("api: create/modify: add content type checks"
> Reported-by: Thomas Lamprecht
> Signed-off-by: Fabian Ebner
> ---
> PVE/API2/Qemu.pm | 28
> 1 file changed, 12 insertions(+), 1
601 - 700 of 4028 matches
Mail list logo
