[pve-devel] [PATCH widget-toolkit] dark-mode: set intentionally black icons to `$icon-color`

2023-10-16 Thread Stefan Sterz
-off-by: Stefan Sterz --- src/proxmox-dark/scss/other/_icons.scss | 9 + 1 file changed, 9 insertions(+) diff --git a/src/proxmox-dark/scss/other/_icons.scss b/src/proxmox-dark/scss/other/_icons.scss index d4dc316..c045cf4 100644 --- a/src/proxmox-dark/scss/other/_icons.scss +++ b/src

[pve-devel] [PATCH pve-kernel] backport exposing FLUSHBYASID when running nested VMs on AMD CPUs

2023-10-19 Thread Stefan Sterz
--- /dev/null +++ b/patches/kernel/0014-Revert-nSVM-Check-for-reserved-encodings-of-TLB_CONT.patch @@ -0,0 +1,49 @@ +From 379ad2e0326c55682d0bb9391f16f1072fe400d2 Mon Sep 17 00:00:00 2001 +From: Stefan Sterz +Date: Wed, 18 Oct 2023 10:45:45 +0200 +Subject: [PATCH 1/2] Revert "nSVM: Chec

Re: [pve-devel] [PATCH common] fix #5034 ldap attribute regex

2023-11-15 Thread Stefan Sterz
On 15.11.23 13:23, Markus Frank wrote: > Change regex from "m/^[a-zA-Z0-9]+$/" to "m/^[a-zA-Z0-9\-]+$/" > to allow hyphen in ldap attribute names for pve & pmg. > > Signed-off-by: Markus Frank > --- > There does not seem to be a regex for LDAP attributes in pbs. > Should a regex be added for this

Re: [pve-devel] [PATCH common] fix #5034 ldap attribute regex

2023-11-15 Thread Stefan Sterz
On 15.11.23 14:28, Stefan Sterz wrote: >> src/PVE/JSONSchema.pm | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm >> index 49e0d7a..ef58b62 100644 >> --- a/src/PVE/JSONSchema.pm >>

Re: [pve-devel] [PATCH common] fix #5034 ldap attribute regex

2023-11-15 Thread Stefan Sterz
On 15.11.23 15:49, Thomas Lamprecht wrote: > Am 15/11/2023 um 14:28 schrieb Stefan Sterz: >> On 15.11.23 13:23, Markus Frank wrote: -- >8 snip 8< -- >> >>> src/PVE/JSONSchema.pm | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>

[pve-devel] [PATCH installer] tui: bootdisk zfs config: add a maximum value to the `copies` option

2023-11-17 Thread Stefan Sterz
according to `man zfsprops` the copies option can only be 1, 2, or 3. limit the field to 3, as setting higher options can't work anyway. Signed-off-by: Stefan Sterz --- i would have added a `min_value` of 1 too, but `IntegerEditView` is based on `NumericEditView` and that doesn't offer

[pve-devel] [PATCH manager] sdn: add model based validation to dhcp ranges

2023-11-23 Thread Stefan Sterz
this patch re-works the validation the in the subnit edit panel to also validate whether the ip address version in a range match each other. Signed-off-by: Stefan Sterz --- not super proud of this, but couldn't really find another way to properly validate accross two columns and also hav

Re: [pve-devel] [PATCH docs] installation: reword `nomodeset` section a bit, add link to it

2024-02-26 Thread Stefan Sterz
On Mon Feb 26, 2024 at 12:20 PM CET, Christoph Heiss wrote: > The `nomodeset` section needs some massaging due to the text flow being > broken a bit. While at it, link to it above at the 'Terminal UI' > bootloader tip such that readers can find it more easily. > > Suggested-by: Alexander Zeidler >

Re: [pve-devel] [PATCH docs v2 1/5] package-repos: improve wording partly based on pmg-docs

2024-03-11 Thread Stefan Sterz
On Mon Mar 11, 2024 at 1:29 PM CET, Christoph Heiss wrote: > Some sentences are phrased better and more expansive in pmg-docs, so > take them from there and adapt them as needed. > > Rephrases some redundant parts (e.g. enterprise repo introduction) and > moves the email/changelog paragraph to the

Re: [pve-devel] [PATCH pve-manager 1/2] fix #5198: ceph: mon: fix mon existence check in mon removal assertion

2024-03-13 Thread Stefan Sterz
h/MON.pm > @@ -147,8 +147,8 @@ my $assert_mon_prerequisites = sub { > my $assert_mon_can_remove = sub { > my ($monhash, $monlist, $monid, $mondir) = @_; > > -if (!(defined($monhash->{"mon.$monid"}) || > - grep { $_->{name} && $_->{name} eq $monid } @$

Re: [pve-devel] [PATCH manager] ui: pool members: avoid setting request parameter for all edit windows

2024-03-14 Thread Stefan Sterz
On Wed Mar 13, 2024 at 9:44 AM CET, Friedrich Weber wrote: > Currently, after adding a storage to a pool, opening any edit window > will send a GET request with a superfluous `poolid` parameter and > cause a parameter verification error in the GUI. This breaks all edit > windows of the current sess

Re: [pve-devel] [PATCH docs] pveceph: document cluster shutdown

2024-03-19 Thread Stefan Sterz
On Tue Mar 19, 2024 at 4:00 PM CET, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > pveceph.adoc | 50 ++ > 1 file changed, 50 insertions(+) > > diff --git a/pveceph.adoc b/pveceph.adoc > index 089ac80..7b493c5 100644 > --- a/pveceph.a

Re: [pve-devel] [PATCH docs] system-requirements: mention that SSDs with PLP should be used

2024-03-20 Thread Stefan Sterz
On Wed Mar 20, 2024 at 10:49 AM CET, Aaron Lauterer wrote: > > > On 2024-03-20 10:30, Fiona Ebner wrote: > > Am 20.03.24 um 09:56 schrieb Aaron Lauterer: > >> Signed-off-by: Aaron Lauterer > >> --- > >> pve-system-requirements.adoc | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff -

Re: [pve-devel] [PATCH storage] esxi: detect correct os type in 'other' family

2024-03-21 Thread Stefan Sterz
-->8 snip 8<-- > diff --git a/src/PVE/Storage/ESXiPlugin.pm.tdy > b/src/PVE/Storage/ESXiPlugin.pm.tdy > new file mode 100644 > index 000..2a08986 > --- /dev/null > +++ b/src/PVE/Storage/ESXiPlugin.pm.tdy > @@ -0,0 +1,1216 @@ > +package PVE::Storage::ESXiPlugin; > + talked off list with gabri

[pve-devel] [PATCH docs 1/2] qm: multiqueue specify that it needs to be vCPUs not cores

2024-03-21 Thread Stefan Sterz
s. https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/7/html/virtualization_tuning_and_optimization_guide/sect-virtualization_tuning_optimization_guide-networking-techniques#sect-Virtualization_Tuning_Optimization_Guide-Networking-Multi-queue_virtio-net Signed-off-by: Stefan Sterz --- qm.

[pve-devel] [PATCH docs 2/2] qm: add documentation on configuring multiqueue for windows guests

2024-03-21 Thread Stefan Sterz
Signed-off-by: Stefan Sterz --- qm.adoc | 10 ++ 1 file changed, 10 insertions(+) diff --git a/qm.adoc b/qm.adoc index 8630419..711fa3f 100644 --- a/qm.adoc +++ b/qm.adoc @@ -780,6 +780,16 @@ ethtool command: where X is the number of the number of vCPUs of the VM. +To configure a

Re: [pve-devel] [PATCH qemu-server 3/3] api: include not mapped resources for running vms in migrate preconditions

2024-03-22 Thread Stefan Sterz
On Wed Mar 20, 2024 at 1:51 PM CET, Dominik Csapak wrote: > so that we can show a proper warning in the migrate dialog and check it > in the bulk migrate precondition check > > the unavailable_storages and allowed_nodes should be the same as before > > Signed-off-by: Dominik Csapak > --- > not sup

Re: [pve-devel] [PATCH widget-toolkit 3/3] window: edit: avoid shared object for extra request params

2024-04-04 Thread Stefan Sterz
On Wed Apr 3, 2024 at 11:10 AM CEST, Friedrich Weber wrote: > Currently, `Proxmox.window.Edit` initializes `extraRequestParams` to > an object that, if not overwritten, is shared between all instances of > subclasses. This bears the danger of modifying the shared object in a > subclass instead of o

Re: [pve-devel] [PATCH widget-toolkit 3/3] window: edit: avoid shared object for extra request params

2024-04-04 Thread Stefan Sterz
-- >8 snip 8< -- > > > > i did a quick an dirty test and using a constructor like this seems to > > rule out this class of bug completelly: > > > > ```js > > constructor: function(conf) { > > let me = this; > > me.extraRequestParams = {}; > > me.initConfig(conf); > >

Re: [pve-devel] [PATCH widget-toolkit 3/3] window: edit: avoid shared object for extra request params

2024-04-04 Thread Stefan Sterz
On Thu Apr 4, 2024 at 12:10 PM CEST, Friedrich Weber wrote: > On 04/04/2024 11:23, Stefan Sterz wrote: > > -- >8 snip 8< -- > >>> > >>> i did a quick an dirty test and using a constructor like this seems to > >>> rule out this class of bug c

Re: [pve-devel] [PATCH widget-toolkit 3/3] window: edit: avoid shared object for extra request params

2024-04-04 Thread Stefan Sterz
On Thu Apr 4, 2024 at 12:54 PM CEST, Stefan Sterz wrote: > On Thu Apr 4, 2024 at 12:10 PM CEST, Friedrich Weber wrote: > > On 04/04/2024 11:23, Stefan Sterz wrote: > > > -- >8 snip 8< -- > > >>> > > >>> i did a quick an dirty test and using

Re: [pve-devel] [PATCH widget-toolkit v3] window: edit: avoid sharing custom config objects between subclasses

2024-04-08 Thread Stefan Sterz
re, implement a constructor > that makes copies of `extraRequestParams` and `submitOptions`. This > ensures that any subclass instance modifies only its own copies, and > modifications do not leak to other subclass instances. > > Suggested-by: Stefan Sterz > Suggested-by: Thomas Lampre

Re: [pve-devel] [PATCH widget-toolkit v4] window: edit: avoid sharing custom config objects between subclasses

2024-04-09 Thread Stefan Sterz
re, implement a constructor > that makes copies of `extraRequestParams` and `submitOptions`. This > ensures that any subclass instance modifies only its own copies, and > modifications do not leak to other subclass instances. > > Suggested-by: Stefan Sterz > Suggested-by: Thomas Lampre

[pve-devel] [PATCH pve-storage] esxi: add mapping for windows server 2016/2019

2024-04-09 Thread Stefan Sterz
previously these were mapped to the linux 2.6 default Signed-off-by: Stefan Sterz --- src/PVE/Storage/ESXiPlugin.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage/ESXiPlugin.pm index 4212c36..e5082ea 100644 --- a/src/PVE/Storage

Re: [pve-devel] [PATCH widget-toolkit] dark-mode: set intentionally black icons to `$icon-color`

2024-04-10 Thread Stefan Sterz
On Mon Oct 16, 2023 at 6:28 PM CEST, Stefan Sterz wrote: > some icons intentionally use black as their color in the light theme. > this includes the little pencil and check mark icon in the acme > overview. change their color to the regular dark-mode icon-color. for > this to wor

Re: [pve-devel] [PATCH manager] pve7to8: reword and fix typos in description

2024-04-18 Thread Stefan Sterz
On Thu Apr 18, 2024 at 9:44 AM CEST, Alexander Zeidler wrote: > Signed-off-by: Alexander Zeidler > --- > bin/Makefile | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/bin/Makefile b/bin/Makefile > index 180a91b5..aa149c06 100644 > --- a/bin/Makefile > +++ b/bin/Mak

Re: [pve-devel] [PATCH manager] pveversion: show upgradable package version in verbose output

2024-04-18 Thread Stefan Sterz
On Thu Apr 18, 2024 at 9:44 AM CEST, Alexander Zeidler wrote: > when the state is "Installed", including not correctly installed, but > not for (residual) "ConfigFiles". > > The information > * can be inaccurate for offline nodes or when using POM. > * is included in pveversion so it can also be us

Re: [pve-devel] [PATCH manager] pve7to8: reword and fix typos in description

2024-04-18 Thread Stefan Sterz
On Thu Apr 18, 2024 at 10:13 AM CEST, Thomas Lamprecht wrote: > Am 18/04/2024 um 10:03 schrieb Stefan Sterz: > >> + before, and during the upgrade of a Proxmox VE system.\n" >> $@.tmp > > > > i know this is pre-existing, but since you are touching this anyway:

[pve-devel] [PATCH container 3/4] parse pct config: remove "\s*" from multi-line comment regex

2022-02-24 Thread Stefan Sterz
To be consistent with PBS's implementation of multi-line comments remove "\s*" here too. Since the regex isn't lazy .* matches everything \s* would anyway. (Note that new lines occurs after "$"). Signed-off-by: Stefan Sterz --- src/PVE/LXC/Config.pm | 2 +- 1 f

[pve-devel] [PATCH manager 2/4] parse node config: remove "\s*" from comment regex

2022-02-24 Thread Stefan Sterz
To be consistent with PBS's implementation of multi-line comments remove "\s*" here too. Since the regex isn't lazy .* matches everything \s* would anyway. (Note that new lines occurs after "$"). Signed-off-by: Stefan Sterz --- PVE/NodeConfig.pm | 2 +- 1 f

[pve-devel] [PATCH cluster 1/4] parse datacenter config: remove "\s*" from comment regex

2022-02-24 Thread Stefan Sterz
To be consistent with PBS's implementation of multi-line comments remove "\s*" here too. Since the regex isn't lazy .* matches everything \s* would anyway. (Note that new lines occurs after "$"). Signed-off-by: Stefan Sterz --- data/PVE/DataCenterConfig.pm | 2 +

[pve-devel] [PATCH qemu-server 4/4] parse vm config: remove "\s*" from multi-line comment regex

2022-02-24 Thread Stefan Sterz
To be consistent with PBS's implementation of multi-line comments remove "\s*" here too. Since the regex isn't lazy .* matches everything \s* would anyway. (Note that new lines occurs after "$"). Signed-off-by: Stefan Sterz --- PVE/QemuServer.pm | 4 ++-- 1 fi

[pve-devel] [PATCH qemu-server v2 4/4] parse vm config: remove "\s*" from multi-line comment regex

2022-02-24 Thread Stefan Sterz
To be consistent with PBS's implementation of multi-line comments remove "\s*" here too. Since the regex isn't lazy .* matches everything \s* would anyway. (Note that new lines occurs after "$"). Signed-off-by: Stefan Sterz --- There was a typo in the previous ve

Re: [pve-devel] [PATCH qemu-server v2 4/4] parse vm config: remove "\s*" from multi-line comment regex

2022-02-25 Thread Stefan Sterz
On 24.02.22 17:28, Dietmar Maurer wrote: > >> On 02/24/2022 3:49 PM Stefan Sterz wrote: >> >> >> To be consistent with PBS's implementation of multi-line comments >> remove "\s*" here too. Since the regex isn't lazy .* matches >> every

[pve-devel] [PATCH SERIES v3 0/6] fix #3607: add notes to functionality in webui

2022-03-04 Thread Stefan Sterz
remove superfluous "\s*" * better formatting of rust code proxmox-backup: Stefan Sterz (4): fix #3067: api: add support for multi-line comments in node.cfg fix #3607: docs: add markdown primer from pve to pbs fix #3607: ui: add a separate notes view for longer markdown notes fix

[pve-devel] [PATCH proxmox-backup v3 1/6] fix #3067: api: add support for multi-line comments in node.cfg

2022-03-04 Thread Stefan Sterz
add support for multi-line comments to node.cfg and the api, similar to how pve handles multi-line comments Signed-off-by: Stefan Sterz --- pbs-api-types/src/lib.rs | 9 +++ src/api2/node/config.rs | 4 +++ src/config/node.rs | 14 +- src/tools/config.rs | 56

[pve-devel] [PATCH proxmox-backup v3 5/6] fix #3607: ui: refactor notes by moving the panel/window to widget kit

2022-03-04 Thread Stefan Sterz
for better re-use between pbs and pve move the markdown notes panel and editor window to the widget kit and unify them there. Signed-off-by: Stefan Sterz --- www/Makefile | 1 - www/NodeNotes.js | 2 +- www/panel/MarkdownNotes.js | 130

[pve-devel] [PATCH proxmox-backup v3 3/6] fix #3607: ui: add a separate notes view for longer markdown notes

2022-03-04 Thread Stefan Sterz
since markdown notes might be rather long, this commit adds a tab similar to pve's datacenter or node notes. Signed-off-by: Stefan Sterz --- www/Makefile | 2 + www/NavigationTree.js | 6 ++ www/NodeNotes.js | 22 +++ www/panel/MarkdownNotes.js

[pve-devel] [PATCH widget-toolkit v3 4/6] toolkit: add markdown based NotesView and NotesEdit

2022-03-04 Thread Stefan Sterz
move these from pve to the widget toolkit to be ablte to use them in pbs Signed-off-by: Stefan Sterz --- src/Makefile| 2 + src/panel/NotesView.js | 155 src/window/NotesEdit.js | 38 ++ 3 files changed, 195 insertions(+) create

[pve-devel] [PATCH manager v3 6/6] ui: move NotesView panel and NotesEdit window to widget kit

2022-03-04 Thread Stefan Sterz
this removes the NotesView panel and NotesEdit and replaces them with with the version from the widget kit. Signed-off-by: Stefan Sterz --- www/manager6/Makefile | 2 - www/manager6/dc/Config.js | 2 +- www/manager6/node/Config.js| 2 +- www/manager6/panel

[pve-devel] [PATCH proxmox-backup v3 2/6] fix #3607: docs: add markdown primer from pve to pbs

2022-03-04 Thread Stefan Sterz
this copies the markdown primer from the pve docs to allow access to it via the help buttons in the gui Signed-off-by: Stefan Sterz --- docs/index.rst | 1 + docs/markdown-primer.rst | 178 +++ 2 files changed, 179 insertions(+) create mode

[pve-devel] [PATCH SERIES v4 0/4] add notes to functionality to pbs webui

2022-04-01 Thread Stefan Sterz
improvements changes v2 (thanks @ Wolfgang Bumiller): * performance improvements when parsing/writing a node configuration * adjusted multi-line regex to remove superfluous "\s*" * better formatting of rust code proxmox-backup: Stefan Sterz (2): fix #3067: docs: add markdown primer f

[pve-devel] [PATCH widget-toolkit v4 2/4] toolkit: add markdown based NotesView and NotesEdit

2022-04-01 Thread Stefan Sterz
. changes include: making the tbar configurable, setting the url differently in a pbs context, and allowing the caller to set the onlineHelp field. Signed-off-by: Stefan Sterz --- src/Makefile| 2 + src/panel/NotesView.js | 149 src/window

[pve-devel] [PATCH proxmox-backup v4 3/4] fix #3067: ui: add a separate notes view for longer markdown notes

2022-04-01 Thread Stefan Sterz
since markdown notes might be rather long, this commit adds a tab similar to pve's datacenter or node notes. requires a bump of the widget toolkit in order to use the `pmxNotesView`. Signed-off-by: Stefan Sterz --- the maxLength of a note in pbs is chosen to be 1022*64 because the server a

[pve-devel] [PATCH proxmox-backup v4 1/4] fix #3067: docs: add markdown primer from pve to pbs

2022-04-01 Thread Stefan Sterz
this copies the markdown primer from the pve docs to allow access to it via the help buttons in the gui Signed-off-by: Stefan Sterz --- docs/index.rst | 1 + docs/markdown-primer.rst | 178 +++ 2 files changed, 179 insertions(+) create mode

[pve-devel] [PATCH manager v4 4/4] ui: move NotesView panel and NotesEdit window to widget kit

2022-04-01 Thread Stefan Sterz
this removes the NotesView panel and NotesEdit and replaces them with with the version from the widget kit. Signed-off-by: Stefan Sterz --- www/manager6/Makefile | 2 - www/manager6/dc/Config.js | 2 +- www/manager6/node/Config.js| 2 +- www/manager6/panel

Re: [pve-devel] [PATCH widget-toolkit v4 2/4] toolkit: add markdown based NotesView and NotesEdit

2022-04-06 Thread Stefan Sterz
I realized that there are some more improvements to be made here, I'll send an updated version in a bit. Sorry for the inconvenience. On 01.04.22 12:19, Stefan Sterz wrote: > adds a universal version of NotesView and NotesEdit to the widget > toolkit that is compatible with pve an

[pve-devel] [PATCH proxmox-backup v5 5/5] fix #3067: ui: add a separate notes view for longer markdown notes

2022-04-12 Thread Stefan Sterz
since markdown notes might be rather long, this commit adds a tab similar to pve's datacenter or node notes. requires a bump of the widget toolkit in order to use the `pmxNotesView`. Signed-off-by: Stefan Sterz --- i chose the maxLength of a note in pbs to be 1022*64 because the server allo

[pve-devel] [PATCH proxmox-backup v5 0/5] fix 3067: add notes functionality in webui

2022-04-12 Thread Stefan Sterz
regex to remove superfluous "\s*" * better formatting of rust code Stefan Sterz (2): fix #3067: docs: add markdown primer from pve to pbs fix #3067: ui: add a separate notes view for longer markdown notes docs/index.rst | 1 + docs/markdown-primer

[pve-devel] [PATCH widget-toolkit v5 3/5] toolkit: refactor markdown based NotesView and NotesEdit

2022-04-12 Thread Stefan Sterz
refactor them to make them more flexible and, thus, usable in pbs. adds parameters for enabling the TBar, setting the help section in the editing dialog and cleans up the code in some places Signed-off-by: Stefan Sterz --- src/panel/NotesView.js | 135

[pve-devel] [PATCH manager v5 4/5] ui: move NotesView panel and NotesEdit window to widget kit

2022-04-12 Thread Stefan Sterz
this removes the NotesView panel and NotesEdit and replaces them with with the version from the widget kit. requires a bump of the widget toolkit. Signed-off-by: Stefan Sterz --- www/manager6/Makefile | 2 - www/manager6/dc/Config.js | 2 +- www/manager6/node/Config.js

[pve-devel] [PATCH widget-toolkit v5 2/5] toolkit: add NotesView panel and NotesEdit window

2022-04-12 Thread Stefan Sterz
move them here from pve so we can maintain them across several products Signed-off-by: Stefan Sterz --- src/Makefile| 2 + src/panel/NotesView.js | 129 src/window/NotesEdit.js | 38 3 files changed, 169 insertions(+) create

[pve-devel] [PATCH proxmox-backup v5 1/5] fix #3067: docs: add markdown primer from pve to pbs

2022-04-12 Thread Stefan Sterz
this copies the markdown primer from the pve docs to allow access to it via the help buttons in the gui Signed-off-by: Stefan Sterz --- docs/index.rst | 1 + docs/markdown-primer.rst | 178 +++ 2 files changed, 179 insertions(+) create mode

[pve-devel] [PATCH pve-cluster] cluster config: mark qdevice end point as protected

2022-05-11 Thread Stefan Sterz
this allows the end point to retrieve data from the qdevice properly by leveraging pve-daemon. fixes an issue where the api would return an empty object. Signed-off-by: Stefan Sterz --- data/PVE/API2/ClusterConfig.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/data/PVE/API2

[pve-devel] [PATCH docs] limit zfs arc: add '-k all' to 'update-initramfs' command

2022-06-23 Thread Stefan Sterz
add '-k all' to avoid confusion when older kernels are pinned or users switch between installed kernel versions Signed-off-by: Stefan Sterz --- local-zfs.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/local-zfs.adoc b/local-zfs.adoc index ab0f6ad..2dc25fd 10

[pve-devel] [PATCH manager] fix: make 'ceph-volume' conditional on quincy install

2022-07-04 Thread Stefan Sterz
when installing non-quincy versions, 'ceph-volume' is not contained in the respective repositories and, thus, the install process would fail. Signed-off-by: Stefan Sterz --- tested this by installing ceph pacific and quincy, but my setup wasn't really clean so i ran into some u

Re: [pve-devel] [PATCH manager] fix: make 'ceph-volume' conditional on quincy install

2022-07-04 Thread Stefan Sterz
erer > > On 7/4/22 17:05, Stefan Sterz wrote: >> when installing non-quincy versions, 'ceph-volume' is not contained in >> the respective repositories and, thus, the install process would fail. >> >> Signed-off-by: Stefan Sterz >> --- >> tested th

[pve-devel] [PATCH manager v2] fix: make 'ceph-volume' conditional on quincy install

2022-07-04 Thread Stefan Sterz
when installing non-quincy versions, 'ceph-volume' is not contained in the respective repositories and, thus, the install process would fail. Signed-off-by: Stefan Sterz --- tested this by installing octopus, pacific and quincy. same issues as before. PVE/CLI/pveceph.pm | 6

[pve-devel] [PATCH manager 1/2] fix: api2: add return type to nodes/{node}/execute endpoint

2022-07-27 Thread Stefan Sterz
fined. Signed-off-by: Stefan Sterz --- PVE/API2/Nodes.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 655493a3..ef946301 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm @@ -438,8 +438,9 @@ __PACKAGE__->registe

[pve-devel] [PATCH manager 2/2] api2: use JSONSchema to validate commands for "nodes/{node}/execute"

2022-07-27 Thread Stefan Sterz
this also makes it more explicit what the different values should be Signed-off-by: Stefan Sterz --- not sure how sensible this is because most of the information here won't show up in the api viewer. i couldn't figure out how to make it show up and not make breaking changes to the e

[pve-devel] [PATCH widget-toolkit] fix: toolkit: make email regex pattern match pve-common

2022-09-07 Thread Stefan Sterz
esttld" - "user@host" reported on the forum: https://forum.proxmox.com/threads/gui-bugulance-using-the-user-add-gui-interface.114743/ Signed-off-by: Stefan Sterz --- note that there are many many regex patterns that could be used (e.g.: [1]). im partial to w3c's approach [2

Re: [pve-devel] [pmg-devel] [PATCH pmg-api v2 5/7] revised task log download function in the PMG backend

2022-09-08 Thread Stefan Sterz
On 9/7/22 10:56, Daniel Tschlatscher wrote: > With the newly added button in the tasklog the implementation for the > PMG server needs to be adapted. I saw an opportunity here to clear > some redundant code for displaying the tasklog and replace it with a > call to dump_logfile(), akin to how this

Re: [pve-devel] [pmg-devel] [PATCH http/common/manager/wt/backup/pmg v2] fix: #3971 Tasklog download button

2022-09-08 Thread Stefan Sterz
nload button in TaskViewer > > src/Utils.js | 13 + > src/window/TaskViewer.js | 17 +++-- > src/window/FileBrowser.js | 11 +-- > 3 files changed, 38 insertions(+), 8 deletions(-) > Other than one bug in `pmg-api` (see my other email) this series seems to work as intended. The bug in `pmg-api` is fixed fairly easily by just calling the right function and I tested that locally already. So unless there are other considerations: Tested-by: Stefan Sterz ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager] ui: remove ceph-mgr pools from rbd pool selection

2022-10-12 Thread Stefan Sterz
their disks after a migration). hence, filter these pools from the list of available pools. Signed-off-by: Stefan Sterz --- www/manager6/form/CephPoolSelector.js | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/www/manager6/form/CephPoolSelector.js

Re: [pve-devel] [PATCH manager] ui: remove ceph-mgr pools from rbd pool selection

2022-10-14 Thread Stefan Sterz
On 10/13/22 16:11, Alwin Antreich wrote: > On October 12, 2022 3:22:18 PM GMT+02:00, Stefan Sterz > wrote: >> when using a hyper-converged cluster it was previously possible to add >> the pool used by the ceph-mgr modules (".mgr" since quincy or >> "devic

[pve-devel] [PATCH manager v2 2/2] ui: remove ceph-mgr pools from rbd pool selection

2022-10-19 Thread Stefan Sterz
their disks after a migration). hence, filter these pools from the list of available pools. Signed-off-by: Stefan Sterz --- similar to the previous api change this tries to fail gracefully if no applications are defined for a pool. www/manager6/form/CephPoolSelector.js | 14 -- 1 file ch

[pve-devel] [PATCH manager v2 1/2] api: ceph: add applications of each pool to the lspool endpoint

2022-10-19 Thread Stefan Sterz
since ceph luminous (ceph 12) pools need to be associated with at least one applicaton expose this information here too so that clients of this endpoint can use that information Signed-off-by: Stefan Sterz --- even though an application needs to be defined for a pool since luminous, i tried to

Re: [pve-devel] [PATCH manager v2 2/2] ui: remove ceph-mgr pools from rbd pool selection

2022-10-19 Thread Stefan Sterz
On 10/19/22 14:16, Stefan Sterz wrote: > when using a hyper-converged cluster it was previously possible to add > the pool used by the ceph-mgr modules (".mgr" since quincy or > "device_health_metrics" previously) as an RBD storage. this would lead > to all kinds

[pve-devel] [PATCH manager v3 1/2] api: ceph: add applications of each pool to the lspools endpoint

2022-10-20 Thread Stefan Sterz
since ceph luminous (ceph 12) pools need to be associated with at least one applicaton. expose this information here too so that clients of this endpoint can use it Signed-off-by: Stefan Sterz --- v3: add an api viewer entry for the applications object thanks @ alwin antreich for pointing out

[pve-devel] [PATCH manager v3 2/2] ui: only allow rbd pools to be added as rbd storage

2022-10-20 Thread Stefan Sterz
previous behavior if a pool has no application assigned to it. Signed-off-by: Stefan Sterz --- v3: changed the name of the filter function based on alwin antreich's suggestion www/manager6/form/CephPoolSelector.js | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff

Re: [pve-devel] [PATCH manager v2 2/2] ui: remove ceph-mgr pools from rbd pool selection

2022-10-20 Thread Stefan Sterz
On 10/20/22 06:07, Alwin Antreich wrote: > On October 19, 2022 2:16:44 PM GMT+02:00, Stefan Sterz > wrote: >> when using a hyper-converged cluster it was previously possible to add >> the pool used by the ceph-mgr modules (".mgr" since quincy or >> "devic

Re: [pve-devel] [PATCH manager v3 1/2] api: ceph: add applications of each pool to the lspools endpoint

2022-10-20 Thread Stefan Sterz
On 10/20/22 14:55, Thomas Lamprecht wrote: > Am 20/10/2022 um 09:17 schrieb Stefan Sterz: >> since ceph luminous (ceph 12) pools need to be associated with at >> least one applicaton. expose this information here too so that clients >> of this endpoint can use it >> >

Re: [pve-devel] [PATCH manager v3 2/2] ui: only allow rbd pools to be added as rbd storage

2022-10-21 Thread Stefan Sterz
On 10/20/22 15:00, Thomas Lamprecht wrote: > Am 20/10/2022 um 09:17 schrieb Stefan Sterz: >> previously the ui would allow adding all pools (even the default >> ceph-mon pools) as storage. this could lead to issues when users did >> use these pools as storage (e.g.: vms missin

Re: [pve-devel] [PATCH manager v3 1/2] api: ceph: add applications of each pool to the lspools endpoint

2022-10-21 Thread Stefan Sterz
On 10/21/22 09:04, Thomas Lamprecht wrote: > Am 21/10/2022 um 08:57 schrieb Stefan Sterz: >>> out of interest: how expensive is this, did you check the overhead? >>> >> do you want a specific metric? in my (admittedly small) test setup >> (three vm cluster with 4

Re: [pve-devel] [PATCH manager v3 1/2] api: ceph: add applications of each pool to the lspools endpoint

2022-10-21 Thread Stefan Sterz
On 10/21/22 09:59, Stefan Sterz wrote: > On 10/21/22 09:04, Thomas Lamprecht wrote: >> Am 21/10/2022 um 08:57 schrieb Stefan Sterz: >>>> out of interest: how expensive is this, did you check the overhead? >>>> >>> do you want a specific metric? in my (

[pve-devel] [PATCH manager v4 2/2] ui: only allow rbd pools to be added as rbd storage

2022-10-25 Thread Stefan Sterz
previous behavior if a pool has no application assigned to it. Signed-off-by: Stefan Sterz --- v3: changed the name of the filter function based on alwin antreich's suggestion. v4: renamed the filter function again a, adapted it to be more concise and make it work with the slightly ad

[pve-devel] [PATCH manager v4 1/2] api: ceph: add applications of each pool to the lspools endpoint

2022-10-25 Thread Stefan Sterz
since ceph luminous (ceph 12) pools need to be associated with at least one applicaton. expose this information here too so that clients of this endpoint can use it. Signed-off-by: Stefan Sterz --- v3: add an api viewer entry for the applications object. v4: re-use the 'osd dump'

[pve-devel] [PATCH manager v1 2/2] ui: add javascript source to `OnlineHelpInfo.js` prerequisites

2022-11-08 Thread Stefan Sterz
by adding the javascript files as prerequisites, the `OnlineHelpInfo.js` will get re-generated if a new `onlineHelp` key is used. thus, this avoids an issue were valid keys might not get mapped correctly because the info in `OnlineHelpInfo.js` wasn't updated. Signed-off-by: Stefan Sterz

[pve-devel] [PATCH manager v1 1/2] fix #4328: make help buttons in the markdown editor window work again

2022-11-08 Thread Stefan Sterz
one of the three usages of `pmxNotesView`, as then `asciidoc-pve` would add it to `OnlineHelpInfo.js` again. however, for consistency's sake i added it to all occurrences. Signed-off-by: Stefan Sterz --- so this issue doesn't only affect the markdown notes, there are also other compone

[pve-devel] [PATCH docs v2 2/2] asciidoc-pve: ignore anchor names in curly braces

2022-11-11 Thread Stefan Sterz
to just ignore all keys wrapped in curly braces. Signed-off-by: Stefan Sterz --- asciidoc-pve.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/asciidoc-pve.in b/asciidoc-pve.in index d638a38..c536371 100644 --- a/asciidoc-pve.in +++ b/asciidoc-pve.in @@ -465,7 +465,7 @@ sub

[pve-devel] [PATCH manager v2 1/1] fix #4328: ui: add widget toolkit to dependencies of OnlineHelpInfo.js

2022-11-11 Thread Stefan Sterz
previously the widget toolkit was not scanned when creating the mapping between `onlineHelp` keys and pve-doc anchors. this could lead to cases where help buttons didn't work because the necessary mapping wasn't present in `OnlineHelpInfo.js`. Signed-off-by: Stefan Sterz --- i took t

[pve-devel] [PATCH docs v2 1/2] pveum: add the "user_mgmt" reference to the documentation

2022-11-11 Thread Stefan Sterz
since this key was missing from the PVE documentation, the TFA ui's help buttons didn't work as they relied on it. Signed-off-by: Stefan Sterz --- pveum.adoc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pveum.adoc b/pveum.adoc index cbd553a..52de14d 100644 --- a/pveum.

[pve-devel] [PATCH docs v2 0/2] pve fix help buttons by accounting for keys in widget toolkit

2022-11-11 Thread Stefan Sterz
from v1 @ Thomas Lamprecht: * scan the widget toolkit too and not just components in `pve-manager` Stefan Sterz (2): pveum: add the "user_mgmt" reference to the documentation asciidoc-pve: ignore anchor names in curly braces asciidoc-pve.in | 2 +- pveum.adoc | 3 +++ 2 f

Re: [pve-devel] [PATCH docs v2 2/2] asciidoc-pve: ignore anchor names in curly braces

2022-11-14 Thread Stefan Sterz
On 11/11/22 19:22, Thomas Lamprecht wrote: > Am 11/11/2022 um 16:05 schrieb Stefan Sterz: >> previously the scanner would detect some `onlineHelp` keys that are >> set via CBind as anchor names. this would cause it to fail, as they >> cannot be present anywhere in the do

Re: [pve-devel] [PATCH docs v2 2/2] asciidoc-pve: ignore anchor names in curly braces

2022-11-14 Thread Stefan Sterz
On 11/14/22 11:07, Thomas Lamprecht wrote: > Am 14/11/2022 um 09:26 schrieb Stefan Sterz: >>> IIUC this indirectly raised the minimum length of references to two >>> characters, >>> not a deal breaker IMO as I don't really expect two characters to be used >&

[pve-devel] [PATCH manager v3 0/2] pve fix help buttons by accounting for keys in widget toolkit

2022-11-14 Thread Stefan Sterz
regex changes from v1, thanks @ Thomas Lamprecht: * scan the widget toolkit too and not just components in `pve-manager` Stefan Sterz (1): asciidoc-pve: disallow certain characters in onlineHelp keys asciidoc-pve.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Stefan Sterz (1

[pve-devel] [PATCH manager v3 2/2] fix #4328: ui: add widget toolkit to dependencies of OnlineHelpInfo.js

2022-11-14 Thread Stefan Sterz
previously the widget toolkit was not scanned when creating the mapping between `onlineHelp` keys and pve-doc anchors. this could lead to cases where help buttons didn't work because the necessary mapping wasn't present in `OnlineHelpInfo.js`. Signed-off-by: Stefan Sterz --- debi

[pve-devel] [PATCH docs v3 1/2] asciidoc-pve: disallow certain characters in onlineHelp keys

2022-11-14 Thread Stefan Sterz
safe. Signed-off-by: Stefan Sterz --- asciidoc-pve.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/asciidoc-pve.in b/asciidoc-pve.in index d638a38..49e54bd 100644 --- a/asciidoc-pve.in +++ b/asciidoc-pve.in @@ -465,7 +465,7 @@ sub scan_extjs_file { debug("scan-extjs

[pve-devel] [PATCH pve-cluster] datacenter config: remove typo in "user-tag-access" description

2022-11-18 Thread Stefan Sterz
Signed-off-by: Stefan Sterz --- data/PVE/DataCenterConfig.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/PVE/DataCenterConfig.pm b/data/PVE/DataCenterConfig.pm index 5a70722..4186195 100644 --- a/data/PVE/DataCenterConfig.pm +++ b/data/PVE/DataCenterConfig.pm

[pve-devel] [PATCH pve-cluster v2] datacenter config: remove typos in "user-tag-access" description

2022-11-18 Thread Stefan Sterz
Signed-off-by: Stefan Sterz --- data/PVE/DataCenterConfig.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/PVE/DataCenterConfig.pm b/data/PVE/DataCenterConfig.pm index 5a70722..925670d 100644 --- a/data/PVE/DataCenterConfig.pm +++ b/data/PVE/DataCenterConfig.pm

[pve-devel] [PATCH i18n] update german translation

2022-11-21 Thread Stefan Sterz
Signed-off-by: Stefan Sterz --- de.po | 185 +++--- 1 file changed, 72 insertions(+), 113 deletions(-) diff --git a/de.po b/de.po index ea6f50b..efd14c3 100644 --- a/de.po +++ b/de.po @@ -8,7 +8,7 @@ msgstr "" "Project-Id-V

[pve-devel] [PATCH manager] ui: fix minor typo in tag style gui

2022-11-21 Thread Stefan Sterz
Signed-off-by: Stefan Sterz --- www/manager6/Utils.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index df2f9631..4dd3cb93 100644 --- a/www/manager6/Utils.js +++ b/www/manager6/Utils.js @@ -1923,7 +1923,7 @@ Ext.define

[pve-devel] [PATCH i18n] update german translation

2022-11-21 Thread Stefan Sterz
Signed-off-by: Stefan Sterz --- thanks @ Daniel Tschlatscher and Dominik Csapak for the corrections! de.po | 28 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/de.po b/de.po index c7b21a3..c5ab411 100644 --- a/de.po +++ b/de.po @@ -8,7 +8,7

[pve-devel] [PATCH i18n 2/2] minor improves to the spanish translation

2022-11-29 Thread Stefan Sterz
Signed-off-by: Stefan Sterz --- just fixed some low-hanging fruits. this could use a lot more love, but i doubt i'll manage everything with my limited spanish skills. es.po | 68 +++ 1 file changed, 31 insertions(+), 37 deletions(-)

[pve-devel] [PATCH i18n 1/2] update german translation

2022-11-29 Thread Stefan Sterz
Signed-off-by: Stefan Sterz --- de.po | 31 +-- 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/de.po b/de.po index dc08a87..2b39b4b 100644 --- a/de.po +++ b/de.po @@ -7,8 +7,8 @@ msgid "" msgstr "" "Project-Id-Versio

Re: [pve-devel] [PATCH pve-docs v2] updated tags docs

2022-12-14 Thread Stefan Sterz
On 12/13/22 15:56, Noel Ullreich wrote: > updated the tags doc with slight rephrasing, corrected grammar, > and fixed typos. > > Signed-off-by: Noel Ullreich > --- > changes since v1: > * removed changes in datacenter.cfg.5-opts.adoc since it is an > autogenerated file (thanks @Dominik;) ) > pve

Re: [pve-devel] [PATCH manager] report: filter comments in VM/CT configs

2022-12-16 Thread Stefan Sterz
On 12/15/22 17:57, Mira Limbeck wrote: > Since some users keep their passwords in the VM/CT configs as comments > and those are most of the time unnecessary when looking through the > report, filter those. > > In addition to the comments, also filter the `cipassword` option > since it contains the

[pve-devel] [PATCH qemu-server] cdrom handling: default to "none" if no physical drive is available

2022-12-16 Thread Stefan Sterz
k to using "none" as media instead. note that the error was basically cosmetic as the vm would start just fine. forum thread: https://forum.proxmox.com/threads/use-of-uninitialized-value-path-in-pattern-match-m-at-usr-share-perl5-pve-qemuserver-pm-line-1622.119592/ Signed-off-by: St

Re: [pve-devel] [PATCH pve-docs v3] updated tags docs

2022-12-19 Thread Stefan Sterz
lgtm. consider this: Reviewed-by: Stefan Sterz On 12/15/22 15:20, Noel Ullreich wrote: > updated the tags doc with slight rephrasing, corrected grammar, > and fixed typos. > > Signed-off-by: Noel Ullreich > --- > changes since v1: > * removed changes in datacenter.cfg.5-

Re: [pve-devel] [PATCH qemu-server] cdrom handling: default to "none" if no physical drive is available

2022-12-19 Thread Stefan Sterz
On 12/19/22 10:23, Fiona Ebner wrote: > Am 16.12.22 um 16:08 schrieb Stefan Sterz: >> when a vm is configured to use the physical cd rom drive but there is >> no such drive a cryptic "uninitialized value" error is thrown. this >> is due to the `$

  1   2   >