On 10/13/23 15:33, Lukas Wagner wrote:
> - Additionally, it should be easy to run these integration tests locally
> on a developer's workstation in order to write new test cases, as well
> as troubleshooting and debugging existing test cases. The local
> test environment should match the
-by: Stefan Hanreich
---
src/PVE/Network/SDN/Subnets.pm | 25 +
src/PVE/Network/SDN/Vnets.pm | 27 +--
2 files changed, 26 insertions(+), 26 deletions(-)
diff --git a/src/PVE/Network/SDN/Subnets.pm b/src/PVE/Network/SDN/Subnets.pm
index 6bb42e5
Signed-off-by: Stefan Hanreich
---
PVE/API2/Network.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/PVE/API2/Network.pm b/PVE/API2/Network.pm
index 00d964a79..f39f04f52 100644
--- a/PVE/API2/Network.pm
+++ b/PVE/API2/Network.pm
@@ -660,6 +660,7 @@ __PACKAGE__->register_met
Those methods are used by the DHCP plugins to attain the next free
IP address for a given DHCP range, as well as delete all entries with
a certain MAC address.
Signed-off-by: Stefan Hanreich
---
src/PVE/Network/SDN/Ipams/PVEPlugin.pm | 64 ++
1 file changed, 64
: Stefan Hanreich
---
PVE/QemuServer.pm | 14 ++
vm-network-scripts/pve-bridge | 3 +++
vm-network-scripts/pve-bridgedown | 19 +++
3 files changed, 36 insertions(+)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 2cd8948..6c1e463 100644
--- a
reload that does
not disrupt the dnsmasq daemon in any way.
This plugin currently only works for simple Zones with subnets that
have a gateway configured, since I use the gateway as listening
address for dnsmasq.
Signed-off-by: Stefan Hanreich
---
debian/control | 1 +
s
Signed-off-by: Stefan Hanreich
---
src/PVE/Cluster.pm | 1 +
src/pmxcfs/status.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm
index cfa2583..aac4574 100644
--- a/src/PVE/Cluster.pm
+++ b/src/PVE/Cluster.pm
@@ -78,6 +78,7 @@ my $observed
Parse the dhcp-ranges when getting the configuration via the Subnet
class.
Signed-off-by: Stefan Hanreich
---
src/PVE/Network/SDN/SubnetPlugin.pm | 32 +
src/PVE/Network/SDN/Subnets.pm | 18
2 files changed, 50 insertions(+)
diff --git a/src
function configures the settings for a specific subnet (that can
contain multiple DHCP ranges). This sets global settings for a
specific subnet such as DNS server or gateway.
configure_range
This configures a DHCP range that is available for a given Subnet.
Signed-off-by: Stefan Hanreich
---
src/PVE
simplified DHCP configuration settings
pve-cluster:
Stefan Hanreich (1):
cluster files: add dhcp.cfg
src/PVE/Cluster.pm | 1 +
src/pmxcfs/status.c | 1 +
2 files changed, 2 insertions(+)
pve-network:
Stefan Hanreich (6):
subnets: vnets: preparations for DHCP plugins
dhcp: add abstract class f
Setup DHCP mappings if a container has interfaces on a SDN network
managed via DHCP.
Additionally remove the mapping in the stop_cleanup function so the
mapping gets removed when forcefully stopping the container.
Signed-off-by: Stefan Hanreich
---
src/PVE/LXC.pm| 10
Regenerate the configuration files for the different DHCP server
plugins when applying SDN settings by calling the respective hooks of
the plugin responsible for configuring a DHCP instance.
Signed-off-by: Stefan Hanreich
---
src/PVE/Network/SDN.pm | 11 +-
src/PVE/Network/SDN/Dhcp.pm
er thing: What happens when a user changes the MAC address via the
UI? I'd either disallow it completely or we need to update the DHCP
configuration files and IPAM
On 10/17/23 15:54, Stefan Hanreich wrote:
> This is a WIP patch series, since I will be gone for 3 weeks and wanted to
> share
> Maybe try to see if we can use pve ipam as cache in front of external
> ipam.
Yes, it would also be cool if you could look at implementing the two
newly added methods from the PVEPlugin for Netbox / Phpipam, since you
have more experience with those.
I also looked into merging those two methods
On 11/8/23 15:32, DERUMIER, Alexandre wrote:
> hi,
> I'm back from Holiday, and I'll finally time to work on dhcp.
>
Welcome back! It's also my first day after holiday today.
> I wonder if we couldn't add a property on subnet or dhcp,
> where user could choose between ephemeral ip (create a vm st
On 11/8/23 18:18, DERUMIER, Alexandre wrote:
> Also, currently, I'm not sure why we need to define the dhcp in
> /etc/pve/sdn/dhcp.cfg ?
>
> couldn't we simply add something like : "dhcp:1" or "dhcp:dnsmasq" on
> the zone ?
That sounds like a good idea and would simplify stuff a lot. I'll tr
On 11/13/23 11:04, Alexandre Derumier wrote:
> I have splitted the ipam add|del , from the dhcp lease reservation.
>
> The ipam add|del ip is done when creating|deleting vm, or add|del a vm nic
>
> The dhcp reservation is done at vm start.
>
> The delete of dhcp reservation is done at vm destr
On 11/13/23 16:44, DERUMIER, Alexandre wrote:
> I think it also need api to add dhcp-range in subnet, as for external
> ipam like netbox, It need to call netbox api to add the ip range.
>
> So, maybe a button in subnet panel :"add dhcp-range", allowing to add
> multiple range.
Yes, that's wha
On 11/13/23 11:04, Alexandre Derumier wrote:
> if ($have_sdn) {
> -PVE::Network::SDN::Dhcp::add_mapping($vmid, $net->{bridge},
> $net->{macaddr});
> +PVE::Network::SDN::Dhcp::add_mapping($net->{bridge}, $net->{macaddr});
>
> PVE::Network::SDN::Zones::tap_create($iface, $net->{br
From: Alexandre Derumier
use to cache mac-ip list association.
can be use by external ipam, firewall,etc for fast lookup
Signed-off-by: Alexandre Derumier
---
src/PVE/Cluster.pm | 1 +
src/pmxcfs/status.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/PVE/Cluster.pm b/src/PVE/Clus
Signed-off-by: Stefan Hanreich
---
src/PVE/Network/SDN/SubnetPlugin.pm | 29 +
src/PVE/Network/SDN/Subnets.pm | 23 +++
2 files changed, 52 insertions(+)
diff --git a/src/PVE/Network/SDN/SubnetPlugin.pm
b/src/PVE/Network/SDN/SubnetPlugin.pm
Co-Authored-By: Alexandre Derumier
Signed-off-by: Stefan Hanreich
---
src/PVE/Network/SDN/Dhcp/Makefile | 8
src/PVE/Network/SDN/Dhcp/Plugin.pm | 65 ++
src/PVE/Network/SDN/Makefile | 1 +
3 files changed, 74 insertions(+)
create mode 100644 src/PVE
Signed-off-by: Stefan Hanreich
---
PVE/API2/Network.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/PVE/API2/Network.pm b/PVE/API2/Network.pm
index 00d964a79..f39f04f52 100644
--- a/PVE/API2/Network.pm
+++ b/PVE/API2/Network.pm
@@ -660,6 +660,7 @@ __PACKAGE__->register_met
Signed-off-by: Stefan Hanreich
---
src/PVE/API2/Network/SDN.pm | 6 ++
src/PVE/API2/Network/SDN/Ipam.pm | 172 ++
src/PVE/API2/Network/SDN/Makefile | 2 +-
3 files changed, 179 insertions(+), 1 deletion(-)
create mode 100644 src/PVE/API2/Network/SDN
From: Alexandre Derumier
Signed-off-by: Stefan Hanreich
---
src/test/run_test_subnets.pl | 8 +++-
src/test/run_test_vnets.pl | 4 ++--
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/src/test/run_test_subnets.pl b/src/test/run_test_subnets.pl
index f6564e1..c98359a 100755
Co-Authored-By: Alexandre Derumier
Signed-off-by: Stefan Hanreich
---
debian/control | 1 +
src/PVE/Network/SDN/Dhcp/Dnsmasq.pm | 198
2 files changed, 199 insertions(+)
create mode 100644 src/PVE/Network/SDN/Dhcp/Dnsmasq.pm
diff --git a
From: Alexandre Derumier
Signed-off-by: Stefan Hanreich
---
vm-network-scripts/pve-bridge | 5 +
1 file changed, 5 insertions(+)
diff --git a/vm-network-scripts/pve-bridge b/vm-network-scripts/pve-bridge
index d37ce33..24efaad 100755
--- a/vm-network-scripts/pve-bridge
+++ b/vm-network
From: Alexandre Derumier
Co-Authored-By: Stefan Hanreich
Signed-off-by: Stefan Hanreich
---
PVE/QemuServer.pm | 17 +
1 file changed, 17 insertions(+)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index fecdb9c..c9c061c 100644
--- a/PVE/QemuServer.pm
+++ b/PVE
Co-Authored-By: Alexandre Derumier
Signed-off-by: Stefan Hanreich
---
src/PVE/Network/SDN/SubnetPlugin.pm | 3 +-
src/PVE/Network/SDN/Subnets.pm | 50 ++-
src/PVE/Network/SDN/Vnets.pm| 95 +
3 files changed, 92 insertions(+), 56 deletions
Signed-off-by: Stefan Hanreich
---
www/manager6/sdn/SubnetEdit.js | 161 -
1 file changed, 160 insertions(+), 1 deletion(-)
diff --git a/www/manager6/sdn/SubnetEdit.js b/www/manager6/sdn/SubnetEdit.js
index b9825d2a3..ab3b9d021 100644
--- a/www/manager6/sdn
Co-Authored-By: Alexandre Derumier
Signed-off-by: Stefan Hanreich
---
src/PVE/Network/SDN/Ipams.pm | 80 +++-
src/PVE/Network/SDN/Ipams/NetboxPlugin.pm | 86 --
src/PVE/Network/SDN/Ipams/PVEPlugin.pm | 85 +++--
src/PVE
Signed-off-by: Stefan Hanreich
---
www/css/ext6-pve.css| 10 +-
www/manager6/Makefile | 2 +
www/manager6/dc/Config.js | 12 +-
www/manager6/sdn/MappingEdit.js | 65 ++
www/manager6/tree/DhcpTree.js | 215
5 files
Co-Authored-By: Alexandre Derumier
Signed-off-by: Stefan Hanreich
---
src/PVE/Network/SDN/Zones/SimplePlugin.pm | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/PVE/Network/SDN/Zones/SimplePlugin.pm
b/src/PVE/Network/SDN/Zones/SimplePlugin.pm
index 4922903..f30278c
Signed-off-by: Stefan Hanreich
---
src/PVE/Network/SDN/Subnets.pm | 25 +
src/PVE/Network/SDN/Vnets.pm | 27 +--
src/PVE/Network/SDN/Zones.pm | 34 +-
3 files changed, 51 insertions(+), 35 deletions(-)
diff
fied DHCP configuration settings
pve-cluster:
Alexandre Derumier (1):
add priv/macs.db
src/PVE/Cluster.pm | 1 +
src/pmxcfs/status.c | 1 +
2 files changed, 2 insertions(+)
pve-network:
Alexandre Derumier (1):
sdn: fix tests
Stefan Hanreich (12):
sdn: preparations for DHCP plugin
subnet:
Signed-off-by: Stefan Hanreich
---
src/PVE/API2/Network/SDN/Subnets.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/PVE/API2/Network/SDN/Subnets.pm
b/src/PVE/API2/Network/SDN/Subnets.pm
index eb6b41b..c263cd5 100644
--- a/src/PVE/API2/Network/SDN/Subnets.pm
+++ b/src/PVE/API2/Network
Signed-off-by: Stefan Hanreich
---
src/PVE/API2/Network/SDN/Zones.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/PVE/API2/Network/SDN/Zones.pm
b/src/PVE/API2/Network/SDN/Zones.pm
index 4c8b7e1..1c3356e 100644
--- a/src/PVE/API2/Network/SDN/Zones.pm
+++ b/src/PVE/API2/Network/SDN
Co-Authored-By: Alexandre Derumier
Signed-off-by: Stefan Hanreich
---
src/PVE/Network/SDN/Dhcp.pm | 115 +++
src/PVE/Network/SDN/Makefile | 2 +-
2 files changed, 116 insertions(+), 1 deletion(-)
create mode 100644 src/PVE/Network/SDN/Dhcp.pm
diff --git a
Signed-off-by: Stefan Hanreich
---
src/PVE/Network/SDN.pm | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/src/PVE/Network/SDN.pm b/src/PVE/Network/SDN.pm
index 057034f..c306527 100644
--- a/src/PVE/Network/SDN.pm
+++ b/src/PVE/Network/SDN.pm
@@ -12,6 +12,7 @@ use PVE
From: Alexandre Derumier
Signed-off-by: Stefan Hanreich
---
PVE/QemuServer.pm | 38 ++
1 file changed, 38 insertions(+)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index c465fb6..1ae1cb0 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -64,6
Signed-off-by: Stefan Hanreich
---
www/manager6/sdn/zones/Base.js | 4 ++--
www/manager6/sdn/zones/SimpleEdit.js | 10 ++
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/www/manager6/sdn/zones/Base.js b/www/manager6/sdn/zones/Base.js
index 602e4c16b..80ce51bac
From: Alexandre Derumier
Signed-off-by: Stefan Hanreich
---
PVE/API2/Qemu.pm | 6 ++
PVE/QemuServer.pm | 31 +++
2 files changed, 37 insertions(+)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 38bdaab..a0f8243 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE
On 11/15/23 13:09, DERUMIER, Alexandre wrote:
> I think that this panel could be named "Ipam" instead "Dhcp Mappings"
Yes, good point, I've actually already renamed it locally.
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxm
On 11/15/23 14:09, DERUMIER, Alexandre wrote:
> Creating a new subnet without dhcp range is failing with
>
> "
> Parameter verification failed. (400)
> dhcp-range: type check ('array') failed
Thanks for the report! Already fixed it!
Also, creating a new Zone that is not Simple also failed, t
On 11/15/23 15:21, Alexandre Derumier wrote:
> + if ($have_sdn) {
> +
> PVE::Network::SDN::Vnets::add_next_free_cidr($newnet->{bridge},
> $conf->{hostname}, $newnet->{hwaddr}, "vmid: $vmid", undef, 1);
> + }
Maybe I missed something, but with Containers we
Maybe this [1][2] could be a less intrusive solution for this issue?
[1] https://manpages.ubuntu.com/manpages/focal/en/man1/dhcp_release.1.html
[2] https://packages.debian.org/de/sid/dnsmasq-utils
___
pve-devel mailing list
pve-devel@lists.proxmox.com
On 11/17/23 11:46, DERUMIER, Alexandre wrote:
> The problem is that dbus is only working with 1 instance of dnsmasq. :/
>
> That mean it'll not work if we need mulitple instance, in differents
> zones/vrf for example
You should be able to set the service name via `--enable-dbus` then you
can ha
Co-Authored-By: Alexandre Derumier
Signed-off-by: Stefan Hanreich
---
src/PVE/Network/SDN/Zones/SimplePlugin.pm | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/PVE/Network/SDN/Zones/SimplePlugin.pm
b/src/PVE/Network/SDN/Zones/SimplePlugin.pm
index 4922903..f30278c
x tests
sdn: fix subnets && netbox ipam tests
add add_dhcp_mapping
Stefan Hanreich (12):
sdn: preparations for DHCP plugin
subnet: add dhcp options
sdn: zone: add dhcp option
ipam: plugins: preparations for DHCP
subnet: vnet: refactor IPAM related methods
dhcp: add abstract
Signed-off-by: Stefan Hanreich
---
src/PVE/API2/Network/SDN/Zones.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/PVE/API2/Network/SDN/Zones.pm
b/src/PVE/API2/Network/SDN/Zones.pm
index 4c8b7e1..1c3356e 100644
--- a/src/PVE/API2/Network/SDN/Zones.pm
+++ b/src/PVE/API2/Network/SDN
Signed-off-by: Stefan Hanreich
---
PVE/API2/Network.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/PVE/API2/Network.pm b/PVE/API2/Network.pm
index 00d964a79..f39f04f52 100644
--- a/PVE/API2/Network.pm
+++ b/PVE/API2/Network.pm
@@ -660,6 +660,7 @@ __PACKAGE__->register_met
From: Alexandre Derumier
Signed-off-by: Stefan Hanreich
---
src/test/run_test_subnets.pl | 8 +++-
src/test/run_test_vnets.pl | 4 ++--
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/src/test/run_test_subnets.pl b/src/test/run_test_subnets.pl
index f6564e1..c98359a 100755
Signed-off-by: Stefan Hanreich
---
src/PVE/API2/Network/SDN.pm | 6 +
src/PVE/API2/Network/SDN/Ipam.pm | 221 ++
src/PVE/API2/Network/SDN/Makefile | 2 +-
3 files changed, 228 insertions(+), 1 deletion(-)
create mode 100644 src/PVE/API2/Network/SDN/Ipam.pm
From: Alexandre Derumier
Signed-off-by: Alexandre Derumier
---
PVE/QemuServer.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index b4cb741..5e158b3 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -5339,6 +5339,7 @@ sub vmconfig_update_net
From: Alexandre Derumier
Signed-off-by: Alexandre Derumier
---
src/test/ipams/netbox/expected.add_ip| 2 +-
src/test/ipams/netbox/expected.add_ip_notgateway | 2 +-
src/test/ipams/netbox/expected.add_next_freeip | 2 +-
src/test/ipams/netbox/expected.update_ip | 2 +-
src/
Those methods are used by the DHCP plugins to attain the next free
IP address for a given DHCP range, as well as delete all entries with
a certain MAC address.
Co-Authored-By: Alexandre Derumier
Signed-off-by: Stefan Hanreich
---
src/PVE/Network/SDN/SubnetPlugin.pm | 3 +-
src/PVE/Network
Signed-off-by: Stefan Hanreich
---
www/manager6/Makefile | 1 +
www/manager6/sdn/SubnetEdit.js | 160 -
2 files changed, 160 insertions(+), 1 deletion(-)
diff --git a/www/manager6/Makefile b/www/manager6/Makefile
index dccd2ba1c..093452cd7 100644
--- a
From: Alexandre Derumier
Signed-off-by: Alexandre Derumier
---
src/lxc-pve-prestart-hook | 15 +++
1 file changed, 15 insertions(+)
diff --git a/src/lxc-pve-prestart-hook b/src/lxc-pve-prestart-hook
index 936d0bf..fc577e4 100755
--- a/src/lxc-pve-prestart-hook
+++ b/src/lxc-pve-pre
Adds a new file priv/macs.db for caching the queries to IPAM.
Additionally adds and imeplements methods to the IPAM plugins that
are required for the DHCP functionality.
Co-Authored-By: Alexandre Derumier
Signed-off-by: Stefan Hanreich
---
src/PVE/Network/SDN/Ipams.pm | 80
Additionally add a helper function for parsing the DHCP ranges of a
subnet.
Signed-off-by: Stefan Hanreich
---
src/PVE/Network/SDN/SubnetPlugin.pm | 29 +
src/PVE/Network/SDN/Subnets.pm | 23 +++
2 files changed, 52 insertions(+)
diff --git
From: Alexandre Derumier
use to cache mac-ip list association.
can be use by external ipam, firewall,etc for fast lookup
Signed-off-by: Alexandre Derumier
---
src/PVE/Cluster.pm | 1 +
src/pmxcfs/status.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/PVE/Cluster.pm b/src/PVE/Clus
plugins.
Signed-off-by: Stefan Hanreich
---
src/PVE/Network/SDN/Subnets.pm | 25 +
src/PVE/Network/SDN/Vnets.pm | 27 +--
src/PVE/Network/SDN/Zones.pm | 34 +-
3 files changed, 51 insertions(+), 35 deletions
Signed-off-by: Stefan Hanreich
---
src/PVE/API2/Network/SDN/Subnets.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/PVE/API2/Network/SDN/Subnets.pm
b/src/PVE/API2/Network/SDN/Subnets.pm
index eb6b41b..c263cd5 100644
--- a/src/PVE/API2/Network/SDN/Subnets.pm
+++ b/src/PVE/API2/Network
-by: Stefan Hanreich
---
src/PVE/Network/SDN/Dhcp/Makefile | 8
src/PVE/Network/SDN/Dhcp/Plugin.pm | 65 ++
src/PVE/Network/SDN/Makefile | 1 +
3 files changed, 74 insertions(+)
create mode 100644 src/PVE/Network/SDN/Dhcp/Makefile
create mode 100644 src
Signed-off-by: Stefan Hanreich
---
src/PVE/Network/SDN.pm | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/src/PVE/Network/SDN.pm b/src/PVE/Network/SDN.pm
index 057034f..c306527 100644
--- a/src/PVE/Network/SDN.pm
+++ b/src/PVE/Network/SDN.pm
@@ -12,6 +12,7 @@ use PVE
This helper can be used to create DHCP entries for a specific zone. It
is used by the API to create DHCP leases for VMs/CTs.
Co-Authored-By: Alexandre Derumier
Signed-off-by: Stefan Hanreich
---
src/PVE/Network/SDN/Dhcp.pm | 115 +++
src/PVE/Network/SDN
basis.
Additionally it creates the file /etc/default/dnsmasq. that
provides default options for the dnsmasq service.
Leases are stored in /var/lib/misc/dnsmasq..
Co-Authored-By: Alexandre Derumier
Signed-off-by: Stefan Hanreich
---
debian/control | 1 +
src/PVE/Network
From: Alexandre Derumier
Signed-off-by: Stefan Hanreich
Signed-off-by: Alexandre Derumier
---
vm-network-scripts/pve-bridge | 2 ++
1 file changed, 2 insertions(+)
diff --git a/vm-network-scripts/pve-bridge b/vm-network-scripts/pve-bridge
index d37ce33..e8f8798 100755
--- a/vm-network
From: Alexandre Derumier
Co-Authored-By: Stefan Hanreich
Signed-off-by: Stefan Hanreich
Signed-off-by: Alexandre Derumier
---
PVE/QemuServer.pm | 17 +
1 file changed, 17 insertions(+)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index b92743c..b4cb741 100644
--- a/PVE
From: Alexandre Derumier
Co-Authored-by: Stefan Lendl
Signed-off-by: Stefan Hanreich
Signed-off-by: Alexandre Derumier
---
PVE/QemuServer.pm | 40
1 file changed, 40 insertions(+)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index c465fb6
From: Alexandre Derumier
also delete ips in case of failure
Signed-off-by: Alexandre Derumier
---
src/PVE/API2/LXC.pm | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
index e15de28..ee4fdca 100644
--- a/src/PVE/API2/LXC.pm
+++ b
From: Alexandre Derumier
also delete ips on create failure
Co-Authored-by: Stefan Hanreich
Signed-off-by: Alexandre Derumier
---
src/PVE/API2/LXC.pm | 4
src/PVE/LXC.pm | 13 +
2 files changed, 17 insertions(+)
diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
From: Alexandre Derumier
Co-Authored-by: Stefan Hanreich
Signed-off-by: Alexandre Derumier
---
src/PVE/LXC.pm| 17 +
src/PVE/LXC/Config.pm | 12
2 files changed, 29 insertions(+)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index 8f53b53..b6df6d6 100644
Signed-off-by: Stefan Hanreich
---
pvesdn.adoc | 122
1 file changed, 122 insertions(+)
diff --git a/pvesdn.adoc b/pvesdn.adoc
index b796c5e..24878e2 100644
--- a/pvesdn.adoc
+++ b/pvesdn.adoc
@@ -79,6 +79,9 @@ In addition to this, the
From: Alexandre Derumier
Signed-off-by: Alexandre Derumier
---
src/PVE/LXC.pm | 16
1 file changed, 16 insertions(+)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index b6df6d6..4472e0f 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -46,6 +46,7 @@ use PVE::LXC::Tools;
my
From: Alexandre Derumier
Co-Authored-by: Stefan Hanreich
Signed-off-by: Alexandre Derumier
---
src/PVE/LXC/Config.pm | 15 +++
1 file changed, 15 insertions(+)
diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
index c884313..823a2b9 100644
--- a/src/PVE/LXC/Config.pm
Signed-off-by: Stefan Hanreich
---
www/css/ext6-pve.css | 22 ++-
www/manager6/Makefile | 1 +
www/manager6/dc/Config.js | 12 +-
www/manager6/sdn/IpamEdit.js | 78 ++
www/manager6/tree/DhcpTree.js | 267 ++
5 files changed, 372
From: Alexandre Derumier
Signed-off-by: Alexandre Derumier
---
src/PVE/Network/SDN/Dhcp.pm | 9 ---
src/PVE/Network/SDN/Dhcp/Dnsmasq.pm | 40 -
src/PVE/Network/SDN/Dhcp/Plugin.pm | 2 +-
src/PVE/Network/SDN/Vnets.pm| 15 +++
4 files cha
Co-Authored-by: Stefan Lendl
Signed-off-by: Stefan Hanreich
---
www/manager6/sdn/zones/Base.js | 6 --
www/manager6/sdn/zones/SimpleEdit.js | 10 ++
2 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/www/manager6/sdn/zones/Base.js b/www/manager6/sdn/zones/Base.js
From: Alexandre Derumier
Co-Authored-by: Stefan Lendl
Signed-off-by: Stefan Hanreich
Signed-off-by: Alexandre Derumier
---
PVE/API2/Qemu.pm | 6 ++
PVE/QemuServer.pm | 15 +++
2 files changed, 21 insertions(+)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 38bdaab
From: Alexandre Derumier
We want to notify guest of the change, so it can resubmit dhcp request,
or send gratuitous arp,...
Signed-off-by: Alexandre Derumier
---
PVE/QemuServer.pm | 13 +
1 file changed, 13 insertions(+)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 5e1
On 11/17/23 15:13, Stefan Lendl wrote:
> If an IP was found, the loop will just start again.
> This should be (tested):
>
> last if $ip;
Ah yes, I fixed the symptom of this already elsewhere but here it makes
a lot more sense!
___
pve-devel mailing
On 11/17/23 16:04, DERUMIER, Alexandre wrote:
> I wonder if this panel could be integrated in zone panel (accessible
> from the tree).
I fear that this might overload the panel a bit.
> as It's not related to the sdn configuration itself. (and don't need
> sdn reload)
>
> I think yhis could a
On 11/17/23 16:47, DERUMIER, Alexandre wrote:
>>> * dnsmasq and IPv6 (and DHCP in general) do not really play well
>>> together,
>>> so using subnets with IPv6 configured is wonky
>
> I didn't have tested yet, but it's seem that dnsmasq only support old
> classic duid reservation and not m
On 11/17/23 17:05, Stefan Hanreich wrote:
> Maybe the issue here are the respective fwbr interfaces inbetween?
I guess that's unlikely since that would affect VMs as well I suppose
___
pve-devel mailing list
pve-devel@lists.proxmox.c
On 11/18/23 17:27, Thomas Lamprecht wrote:
> what's the deal with Ipam vs. Ipams?
>
> I did not looked to closely into it but it seems like the existing Ipams,
> plural,
> is for managing ipam plugins and Ipam, singular, here is for getting the
> current
> state? That should really be better
On 11/20/23 13:28, DERUMIER, Alexandre wrote:
> Hi,
>
>>> I'll look again into this, maybe POST / PUT / DELETE
>>> `/ipams/pve/mapping` or `/ipams/pve/ip` would be a good alternative
>>> here? We need to move away from MAC addresses as a unique identifier
>>> anyway (since with dual-stack there ca
On 11/20/23 13:34, Stefan Hanreich wrote:
> Not sure about this, since the endpoint returns the state of the PVE
> IPAM and never returns the state of Netbox IPAM, for instance. Since if
> you want to inspect that state you would use the Netbox API / Web UI.
> For that reason i
: Stefan Hanreich
---
src/PVE/API2/Network/SDN.pm | 6 --
src/PVE/API2/Network/SDN/Ipams.pm| 83 +
src/PVE/API2/Network/SDN/{Ipam.pm => Ips.pm} | 97 ++--
src/PVE/API2/Network/SDN/Makefile| 2 +-
src/PVE/API2/Network/SDN/Vnets
the create / update / delete methods to the Zone endpoint and then it would be
possible to show a proper child relation.
pve-network:
Stefan Hanreich (1):
api: refactor URL structure for Ipam
src/PVE/API2/Network/SDN.pm | 6 --
src/PVE/API2/Network/SDN/Ipams.pm
The IPAM-related API endpoints were moved, reflect those changes in
the UI as well.
Signed-off-by: Stefan Hanreich
---
www/manager6/sdn/IpamEdit.js | 4 +++-
www/manager6/tree/DhcpTree.js | 15 +++
2 files changed, 14 insertions(+), 5 deletions(-)
diff --git a/www/manager6/sdn
lines in the container configuration.
pve-container:
Stefan Hanreich (3):
hotplug network: Only change IPAM when MAC or bridge changes
network: Do not always reserve new IP in IPAM
config: Use LXC Config instead of QemuServer for parsing net
src/PVE/LXC.pm| 26
Currently a new IPAM entry is created everytime a NIC config changes.
When editing properties other than MAC or Bridge this could lead to
duplicated entries in the IPAM. Only reserve a new IP when the bridge
or MAC changes or the NIC is completely new.
Signed-off-by: Stefan Hanreich
---
src/PVE
Signed-off-by: Stefan Hanreich
---
src/PVE/LXC.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index c239715..071faca 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -2771,7 +2771,7 @@ sub create_ifaces_ipams_ips {
for my $opt
Currently when updating the network configuration of a container, SDN
would always create a new entry in the IPAM. Only create a new entry
when the bridge or MAC changes or the NIC is completely new.
Signed-off-by: Stefan Hanreich
---
src/PVE/LXC/Config.pm | 6 --
1 file changed, 4
Currently when updating the network configuration of a container, SDN
would always create a new entry in the IPAM. Only create a new entry
when the bridge or MAC changes or the NIC is completely new.
Signed-off-by: Stefan Hanreich
---
src/PVE/LXC/Config.pm | 6 --
1 file changed, 4
Currently a new IPAM entry is created everytime a NIC config changes.
When editing properties other than MAC or Bridge this could lead to
duplicated entries in the IPAM. Only reserve a new IP when the bridge
or MAC changes or the NIC is completely new.
Signed-off-by: Stefan Hanreich
---
src/PVE
Signed-off-by: Stefan Hanreich
---
src/PVE/LXC.pm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index c239715..847b8c8 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -2771,9 +2771,9 @@ sub create_ifaces_ipams_ips {
for my
lines in the container configuration.
pve-container:
Stefan Hanreich (4):
hotplug network: Only change IPAM when MAC or bridge changes
network: Do not always reserve new IP in IPAM
config: Use LXC Config instead of QemuServer for parsing net
create: Do not call create_ifaces_ipams_ips
src
Since create_vm already calls update_pct_config, which in turn calls
vmconfig_apply_pending we do not need to explicitly create the IPAM
entries when creating a container from scratch.
Signed-off-by: Stefan Hanreich
---
src/PVE/API2/LXC.pm | 1 -
1 file changed, 1 deletion(-)
diff --git a/src
1 - 100 of 798 matches
Mail list logo
