On 11/15/23 15:21, Alexandre Derumier wrote:
> +             if ($have_sdn) {
> +                 
> PVE::Network::SDN::Vnets::add_next_free_cidr($newnet->{bridge}, 
> $conf->{hostname}, $newnet->{hwaddr}, "vmid: $vmid", undef, 1);
> +             }

Maybe I missed something, but with Containers we can select either
Static or DHCP. How is this handled?

How should we actually handle this? I would suppose it would make sense
that this logic only kicks in when the NIC is actually set to DHCP,
otherwise we shouldn't do anything?

Also, this is still passing $description rather an a $vmid

> +     PVE::Network::SDN::Vnets::add_next_free_cidr($newnet->{bridge}, 
> $conf->{hostname}, $newnet->{hwaddr}, "vmid: $vmid", undef, 1);

^ description instead of vmid as well


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to