--- Begin Message ---
Hi everyone,
Something I've been running into with PVE is that VM IDs may be re-used
and that the UI will in fact suggest the smallest available ID (via the
`/cluster/nextid` endpoint), regardless of whether that ID has
previously been used or not. This can cause issues with
--- Begin Message ---
Add a 'suggest unique VMIDs' row to the datacenter options page that
allows choosing whether the `/cluster/nextid` API endpoint (and thereby
any UI elements that suggest IDs) should avoid suggesting previously
used IDs. This option defaults to off to ensure that this change in
--- Begin Message ---
At the moment, the `/cluster/nextid` API endpoint will return the lowest
available VM/CT ID, which means that it will suggest re-using VM IDs.
This can be undesirable, so add an optional check to ensure that it
chooses an ID which is not and has never been in use.
This option
--- Begin Message ---
Hi everyone,
This patch series is an updated version of my previous series [1] adding
optional support for preventing PVE from suggesting previously used
VM/CT IDs.
The ID list is now read into a hash rather than an array so that O(1)
membership tests can be used when `/clus
--- Begin Message ---
After a container is destroyed, record that its ID has been used via the
`PVE::UsedVmidList` module so that the `/cluster/nextids` endpoint can
later optionally avoid suggesting previously used IDs.
Co-authored-by: Daniel Krambrock
Signed-off-by: Severen Redwood
---
src/PV
--- Begin Message ---
Add `/etc/pve/used_vmids.list` to the list of cluster files, which will
be used for recording previously used VM/CT IDs. This is required so
that we can optionally ensure that such IDs are not suggested by the
`/cluster/nextid` API endpoint.
Co-authored-by: Daniel Krambrock
--- Begin Message ---
Add the `unique-next-id` property to the datacentre config schema to
track whether only unique (ie. neither currently nor previously in use)
VM/CT IDs should be suggested by the `/cluster/nextid` API endpoint.
Co-authored-by: Daniel Krambrock
Signed-off-by: Severen Redwood
--- Begin Message ---
After a virtual machine is destroyed, record that its ID has been used
via the `PVE::UsedVmidList` module so that the `/cluster/nextids`
endpoint can later optionally avoid suggesting previously used IDs.
Co-authored-by: Daniel Krambrock
Signed-off-by: Severen Redwood
---
--- Begin Message ---
On Fri Sep 27, 2024 at 5:48 AM NZST, Thomas Lamprecht wrote:
> at this point the CT is not yet destroyed, only the worker that tries to
> destroy
> it is started, destruction can still fail.
>
> It'd be better to place it inside the $realcmd, or even the $code, ideally
> befo
--- Begin Message ---
On Sun, Sep 29, 2024 at 01:47:31PM GMT, DERUMIER, Alexandre via pve-devel wrote:
> Couldn't we simply move the deleted vm config file
> to a trash/tombstone directory ?
>
> /etc/pve/.deleted/.conf ?
>
>
> (I could be great to be able to mass delete vms in // without having
--- Begin Message ---
Hi,
Is someone able to review this updated patch series? I think
the previous comments should be addressed.
Also, the actual patches seem to have ended up disconnected
from the cover letter, so for reference, you can find them
here:
https://lore.proxmox.com/pve-devel/mailman
--- Begin Message ---
Hi Aaron,
On Thu, Oct 31, 2024 at 06:27:43PM +0100, Aaron Lauterer wrote:
> This is missing a
>
> use PVE::UsedVmidList;
>
> at the top of the file. Otherwise running
>
> pct destroy {vmid}
>
> will result in the following error:
>
> Undefined subroutine &PVE::UsedVmidLi
--- Begin Message ---
Hi everyone,
This is a small update to my previous patch series [1, 2]
adding optional support for preventing PVE from suggesting
previously used VM/CT IDs.
In particular, missing use statements have been added to the
patches for marking VM/CT IDs as used, as noticed by Aaro
--- Begin Message ---
After a container is destroyed, record that its ID has been used via the
`PVE::UsedVmidList` module so that the `/cluster/nextids` endpoint can
later optionally avoid suggesting previously used IDs.
Co-authored-by: Daniel Krambrock
Signed-off-by: Severen Redwood
---
Changed
--- Begin Message ---
Add a 'suggest unique VMIDs' row to the datacenter options page that
allows choosing whether the `/cluster/nextid` API endpoint (and thereby
any UI elements that suggest IDs) should avoid suggesting previously
used IDs. This option defaults to off to ensure that this change in
--- Begin Message ---
After a virtual machine is destroyed, record that its ID has been used
via the `PVE::UsedVmidList` module so that the `/cluster/nextids`
endpoint can later optionally avoid suggesting previously used IDs.
Co-authored-by: Daniel Krambrock
Signed-off-by: Severen Redwood
---
C
--- Begin Message ---
Add `/etc/pve/used_vmids.list` to the list of cluster files, which will
be used for recording previously used VM/CT IDs. This is required so
that we can optionally ensure that such IDs are not suggested by the
`/cluster/nextid` API endpoint.
Co-authored-by: Daniel Krambrock
--- Begin Message ---
Add the `unique-next-id` property to the datacentre config schema to
track whether only unique (ie. neither currently nor previously in use)
VM/CT IDs should be suggested by the `/cluster/nextid` API endpoint.
Co-authored-by: Daniel Krambrock
Signed-off-by: Severen Redwood
--- Begin Message ---
At the moment, the `/cluster/nextid` API endpoint will return the lowest
available VM/CT ID, which means that it will suggest re-using VM IDs.
This can be undesirable, so add an optional check to ensure that it
chooses an ID which is not and has never been in use.
This option
--- Begin Message ---
At the moment, the `/cluster/nextid` API endpoint will return the lowest
available VM/CT ID, which means that it will suggest re-using VM IDs.
This can be undesirable, so add an optional check to ensure that it
chooses an ID which is not and has never been in use.
This option
--- Begin Message ---
Hi everyone,
This patch series is a reworking of Daniel Krambrock's patches [1] which
allow for configuring the strategy used for suggesting VM IDs. As
discussed with him [2], I have removed the 'max + 1' strategy as it is
fundamentally flawed given that the goal is preventin
--- Begin Message ---
After a virtual machine is destroyed, record that its ID has been used
via the `PVE::UsedVmidList` module so that the `/cluster/nextids`
endpoint can later optionally avoid suggesting previously used IDs.
Co-authored-by: Daniel Krambrock
Signed-off-by: Severen Redwood
---
--- Begin Message ---
Add a 'suggest unique VMIDs' row to the datacenter options page that
allows choosing whether the `/cluster/nextid` API endpoint (and thereby
any UI elements that suggest IDs) should avoid suggesting previously
used IDs. This option defaults to off to ensure that this change in
--- Begin Message ---
After a container is destroyed, record that its ID has been used via the
`PVE::UsedVmidList` module so that the `/cluster/nextids` endpoint can
later optionally avoid suggesting previously used IDs.
Co-authored-by: Daniel Krambrock
Signed-off-by: Severen Redwood
---
src/PV
--- Begin Message ---
Add `/etc/pve/used_vmids.list` to the list of cluster files, which will
be used for recording previously used VM/CT IDs. This is required so
that we can optionally ensure that such IDs are not suggested by the
`/cluster/nextid` API endpoint.
Co-authored-by: Daniel Krambrock
--- Begin Message ---
Add the `unique-next-id` property to the datacentre config schema to
track whether only unique (ie. neither currently nor previously in use)
VM/CT IDs should be suggested by the `/cluster/nextid` API endpoint.
Co-authored-by: Daniel Krambrock
Signed-off-by: Severen Redwood
--- Begin Message ---
Hi Aaron,
Thanks for the review and testing! I'll post v4 today to
address your comments and add those commit trailers.
Thanks,
Severen
--- End Message ---
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxm
--- Begin Message ---
Hi everyone,
This is another small update to my previous patch series [1]
adding optional support for preventing PVE from suggesting
previously used VM/CT IDs. Aaron had some small style nits, so
I've addressed those and also added the Reviewed-by and
Tested-by commit trailer
--- Begin Message ---
Add a 'suggest unique VMIDs' row to the datacenter options page that
allows choosing whether the `/cluster/nextid` API endpoint (and thereby
any UI elements that suggest IDs) should avoid suggesting previously
used IDs. This option defaults to off to ensure that this change in
--- Begin Message ---
After a container is destroyed, record that its ID has been used via the
`PVE::UsedVmidList` module so that the `/cluster/nextids` endpoint can
later optionally avoid suggesting previously used IDs.
Co-authored-by: Daniel Krambrock
Signed-off-by: Severen Redwood
Tested-by:
--- Begin Message ---
After a virtual machine is destroyed, record that its ID has been used
via the `PVE::UsedVmidList` module so that the `/cluster/nextids`
endpoint can later optionally avoid suggesting previously used IDs.
Co-authored-by: Daniel Krambrock
Signed-off-by: Severen Redwood
Teste
--- Begin Message ---
Add `/etc/pve/used_vmids.list` to the list of cluster files, which will
be used for recording previously used VM/CT IDs. This is required so
that we can optionally ensure that such IDs are not suggested by the
`/cluster/nextid` API endpoint.
Co-authored-by: Daniel Krambrock
--- Begin Message ---
At the moment, the `/cluster/nextid` API endpoint will return the lowest
available VM/CT ID, which means that it will suggest re-using VM IDs.
This can be undesirable, so add an optional check to ensure that it
chooses an ID which is not and has never been in use.
This option
--- Begin Message ---
Add the `unique-next-id` property to the datacentre config schema to
track whether only unique (ie. neither currently nor previously in use)
VM/CT IDs should be suggested by the `/cluster/nextid` API endpoint.
Co-authored-by: Daniel Krambrock
Signed-off-by: Severen Redwood
--- Begin Message ---
Hi everyone,
Just bumping this patch series since it's been a few weeks :)
Is there anything blocking these patches from being accepted?
I'm happy to address any feedback if so.
Thanks,
Severen
--- End Message ---
___
pve-devel m
--- Begin Message ---
Hi everyone,
Hope you've all had a great break over the holidays.
I don't want to be a pain, but just bumping this again as it's nearing
a couple months since there was movement on this patch series. I received
a Reviewed-by trailer from Aaron, so it seems that these patches
--- Begin Message ---
On 26/03/2025 20:22, Thomas Lamprecht wrote:
> Am 26.03.25 um 04:51 schrieb Severen Redwood:
>> No problem, I've changed it to `/etc/pve/used-ids` now. Slightly more
>> generic than `used-vmids` since there are also container IDs.
>
> Hmm, I see where you come from, but that
--- Begin Message ---
On 29/01/2025 03:57, Thomas Lamprecht wrote:
> Am 27.01.25 um 13:18 schrieb Fabian Grünbichler:
>>> Severen Redwood via pve-devel hat am
>>> 08.11.2024 02:46 CET geschrieben:
>>
>>> Add `/etc/pve/used_vmids.list` to the list of clust
--- Begin Message ---
On 28/01/2025 01:16, Fabian Grünbichler wrote:
> Hi!
>
> sorry it took so long to get back at this series! next will be faster :)
No worries! As you can see it took me a while to get back to this too... I've
implemented all the suggestions around style and will post the upd
--- Begin Message ---
On 28/01/2025 01:16, Fabian Grünbichler wrote:
> if we only add it when the VM is removed via the API, we might miss those
> where an admin just does "rm /etc/pve/../XXX.conf" (which might happen if
> something is blocking regular removal)? wouldn't it be safer to add them w
40 matches
Mail list logo
