uot;duplicate" instead of "copy"?
* But that means it doesn't fit in the same row as the "add" button
- Put the copy button next to the little icon for the delete button
instead, displaying it for each list item?
Max Carrara (1):
input panel: add `raw` parameter
This parameter may be used to circumvent calls to `onGetValues`.
Also adds a docstring for the function.
Signed-off-by: Max Carrara
---
src/panel/InputPanel.js | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/src/panel/InputPanel.js b/src/panel/InputPanel.js
Add a copy button that copies the configuration of one disk to a new
one.
Signed-off-by: Max Carrara
---
www/manager6/panel/MultiDiskEdit.js | 78 +
1 file changed, 68 insertions(+), 10 deletions(-)
diff --git a/www/manager6/panel/MultiDiskEdit.js
b/www/manager6
On 12/6/23 10:13, Dominik Csapak wrote:
> hi, some comment inline
>
> On 12/5/23 16:44, Max Carrara wrote:
>> This parameter may be used to circumvent calls to `onGetValues`.
>>
>> Also adds a docstring for the function.
>>
>> Signed-off-by: Max Carrara
&
ll)
> 3. make the code uglier (you'd have to call something in the parent class)
>
> the idea is nice, otherwise see some comments inline
>
> On 12/5/23 16:44, Max Carrara wrote:
>> Add a copy button that copies the configuration of one disk to a new
&g
/ceph-warning-post-upgrade-to-v8.129371/
[1]: https://github.com/ceph/ceph/pull/54710
Signed-off-by: Max Carrara
---
...hboard-Simplify-authentication-proto.patch | 276 ++
patches/series| 1 +
2 files changed, 277 insertions(+)
create mode 100644
/ceph-warning-post-upgrade-to-v8.129371/
[1]: https://github.com/ceph/ceph/pull/54710
Signed-off-by: Max Carrara
---
...hboard-Simplify-authentication-proto.patch | 276 ++
patches/series| 1 +
2 files changed, 277 insertions(+)
create mode 100644
Disregard this one; forgot to rebase on master.
Actual patch is over here:
https://lists.proxmox.com/pipermail/pve-devel/2024-January/061198.html
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo
does not yet allow the dashboard to run
with TLS enabled.
[0]: https://forum.proxmox.com/threads/ceph-warning-post-upgrade-to-v8.129371/
[1]: https://github.com/ceph/ceph/pull/54710
Signed-off-by: Max Carrara
---
...hboard-simplify-authentication-proto.patch | 279 ++
patches/series
https://docs.ceph.com/en/reef/mgr/dashboard/#ssl-tls-support
Signed-off-by: Max Carrara
---
...move-ability-to-create-and-check-TLS.patch | 101 ++
patches/series| 1 +
2 files changed, 102 insertions(+)
create mode 100644
patches/0013-mgr-dashboard-r
mmand. [4]
[0]: https://github.com/ceph/ceph/pull/54710
[1]: https://github.com/jpadilla/pyjwt
[2]: https://github.com/pyca/pyopenssl
[3]: https://tracker.ceph.com/issues/63529
[4]: `ceph dashboard create-self-signed-cert`
Max Carrara (2):
mgr/dashboard: add backport that allows the dashboard to
This patch is to be ignored; just sent in a new series:
https://lists.proxmox.com/pipermail/pve-devel/2024-January/061242.html
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Signed-off-by: Max Carrara
---
Note: This is just for convenience and can be ignored if not desired.
.gitignore | 5 +
1 file changed, 5 insertions(+)
create mode 100644 .gitignore
diff --git a/.gitignore b/.gitignore
new file mode 100644
index 0..5bec39c9d
--- /dev/null
+++ b
eseen exceptions that occur in regards to TLS as one
of Ceph's internal exception types, which are then handled by the
dashboard itself. This is akin to how these cases were handled
originally.
Also fixes a typo in the `ceph dashboard create-self-signed-cert`
command output.
Signed-off-by: M
dated
correspondingly.
A very minor adaptation has been made to the patch added by commit
f35168f6713d5f3fa1aaa8c572d754b61c458d91 in order to get it to apply
correctly.
Signed-off-by: Max Carrara
---
...hboard-simplify-authentication-proto.patch | 279 ++
patches/0021-debian-rule
eseen exceptions that occur in regards to TLS as one of
Ceph's internal exception types, which are then handled by the
dashboard itself. This is akin to how these cases were handled
originally.
Signed-off-by: Max Carrara
---
...move-ability-to-create-and-check-TLS.patch | 53 ++-
1 fi
dated
correspondingly.
A very minor adaptation has been made to the patch added by commit
f35168f6713d5f3fa1aaa8c572d754b61c458d91 in order to get it to apply
correctly.
Signed-off-by: Max Carrara
---
Changes v1 --> v2:
* None
...hboard-simplify-authentication-proto.pat
Updated series that includes an unstaged change I had missed to amend
regarding the corrected typo mentioned in the recent patch for master [0].
Woops!
[0]: https://lists.proxmox.com/pipermail/pve-devel/2024-January/061499.html
Max Carrara (2):
patches: include patches regarding RocksDB and
eseen exceptions that occur in regards to TLS as one of
Ceph's internal exception types, which are then handled by the
dashboard itself. This is akin to how these cases were handled
originally.
Also fixes a typo in the `ceph dashboard create-self-signed-cert`
command output.
Signed-off-by: M
Ceph has a postinst hook that sets the ownership of '/var/lib/ceph/*'
to ceph:ceph (in our case), but misses out on '/var/lib/ceph/crash/posted'.
This patch therefore also updates the permissions of '/var/lib/ceph/*/*'.
Signed-off-by: Max Carrara
---
...rmis
SC3043 (warning): In POSIX sh, 'local' is undefined.
Signed-off-by: Max Carrara
---
debian/postinst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/debian/postinst b/debian/postinst
index 6138ef6d..00d5f2cc 100755
--- a/debian/postinst
+++ b/debian/postinst
@@
when creating the cluster's first monitor.
Signed-off-by: Max Carrara
---
PVE/API2/Ceph/MON.pm | 28 +++-
PVE/Ceph/Services.pm | 12 ++--
PVE/Ceph/Tools.pm| 38 ++
3 files changed, 75 insertions(+), 3 deletions(-)
x27; section in '/etc/pve/ceph.conf'
* A '[client.crash]' section in '/etc/pve/ceph.conf' which doesn't
reference any key or references a different key
[0]: https://bugzilla.proxmox.com/show_bug.cgi?id=4759
ceph (master):
Max Carrara (1):
debian: add p
Signed-off-by: Max Carrara
---
src/PVE/CephConfig.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/PVE/CephConfig.pm b/src/PVE/CephConfig.pm
index 6b10d46..46b92ea 100644
--- a/src/PVE/CephConfig.pm
+++ b/src/PVE/CephConfig.pm
@@ -77,6 +77,7 @@ sub write_ceph_config
Having a file named e.g. "60" in your current directory will cause it
to be deleted when executind `pveceph purge`. This commit fixes that
by making the config hash differ between which values represent file
paths and which don't.
Signed-off-by: Max Carrara
---
PVE/Cep
Signed-off-by: Max Carrara
---
PVE/API2/Ceph.pm | 5 +
1 file changed, 5 insertions(+)
diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm
index 81c17d6e..7fedb87a 100644
--- a/PVE/API2/Ceph.pm
+++ b/PVE/API2/Ceph.pm
@@ -192,6 +192,11 @@ __PACKAGE__->register_method ({
PVE::C
Ceph has a postinst hook that sets the ownership of '/var/lib/ceph/*'
to ceph:ceph (in our case), but misses out on '/var/lib/ceph/crash/posted'.
This patch therefore also updates the permissions of '/var/lib/ceph/*/*'.
Signed-off-by: Max Carrara
---
...rmis
roup
[0], it may access the file without requiring any additional
privileges.
Thus, the configuration for the Ceph crash daemon is safely adapted as
expected by PVE tooling and also shared via pmxcfs across one's
cluster.
[0]:
https://git.proxmox.com/?p=ceph.
On 1/31/24 14:18, Fabian Grünbichler wrote:
> On January 30, 2024 7:40 pm, Max Carrara wrote:
>> Ceph has a postinst hook that sets the ownership of '/var/lib/ceph/*'
>> to ceph:ceph (in our case), but misses out on '/var/lib/ceph/crash/posted'.
>>
On 1/31/24 14:18, Fabian Grünbichler wrote:
> On January 30, 2024 7:40 pm, Max Carrara wrote:
>> Signed-off-by: Max Carrara
>> ---
>> src/PVE/CephConfig.pm | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/src/PVE/CephConfig.pm b/src/PVE/CephCon
On 1/31/24 14:16, Fabian Grünbichler wrote:
> On January 30, 2024 7:40 pm, Max Carrara wrote:
>> SC3043 (warning): In POSIX sh, 'local' is undefined.
>
> while I get why you sent this here, it's not related at all to this
> series, please send such changes o
On 1/31/24 14:15, Fabian Grünbichler wrote:
> On January 30, 2024 7:40 pm, Max Carrara wrote:
>> This commit adds the `set_ceph_crash_conf` function, which dynamically
>> adapts the host's Ceph configuration in order to allow the Ceph crash
>> module's daemon to
On 1/31/24 14:18, Fabian Grünbichler wrote:
> On January 30, 2024 7:40 pm, Max Carrara wrote:
>> Having a file named e.g. "60" in your current directory will cause it
>> to be deleted when executind `pveceph purge`. This commit fixes that
>> by making the config h
On 1/31/24 14:17, Fabian Grünbichler wrote:
> On January 30, 2024 7:40 pm, Max Carrara wrote:
>> when creating the cluster's first monitor.
>>
>> Signed-off-by: Max Carrara
>> ---
>> PVE/API2/Ceph/MON.pm | 28 +++-
>> PVE/Cep
y after the '[client]' section.
Sections associated with 'mds', 'mon', 'osd' and 'mgr' are also
written directly after their associated section.
Signed-off-by: Max Carrara
---
NOTE: This amend really just changes the order of the sections below and
This patch makes it so that `ceph-crash` attempts to use the
non-host-specific keyring before anything else, which avoids
unnecessary error messages landing in the systemd-journal in our case.
Signed-off-by: Max Carrara
---
Changes v1 --> v2:
* new
...h-crash-change-order-of-cli
e;hb=refs/heads/master#l178
[1]:
https://git.proxmox.com/?p=ceph.git;a=blob;f=ceph/src/common/ConfUtils.cc;h=2f78fd02bf9e27467275752e6f3bca0c5e3946ce;hb=refs/heads/master#l194
[2]:
https://git.proxmox.com/?p=ceph.git;a=blob;f=ceph/src/common/ConfUtils.cc;h=2f78fd02bf9e27467275752e6f3bca0c5e3946c
Having a file named e.g. "60" in your current directory will cause it
to be deleted when executing `pveceph purge`. This commit fixes that
by making the config hash differ between which values represent file
paths and which don't.
Signed-off-by: Max Carrara
---
Changes v1 -->
Signed-off-by: Max Carrara
---
Changes v1 --> v2:
* none
PVE/API2/Ceph.pm | 5 +
1 file changed, 5 insertions(+)
diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm
index 81c17d6e..7fedb87a 100644
--- a/PVE/API2/Ceph.pm
+++ b/PVE/API2/Ceph.pm
@@ -192,6 +192,11 @@ __PACKAG
This adds support for writing arbitrary sections to 'ceph.conf' while
ensuring that already written sections are not duplicated.
Sections that are associated with the client, for example
'[client.foo]', are written directly after the '[client]' section.
Signed-off-b
roup
[0], it may access the file without requiring any additional
privileges.
Thus, the configuration for the Ceph crash daemon is safely adapted as
expected by PVE tooling and also shared via pmxcfs across one's
cluster.
[0]:
https://git.proxmox.com/?p=ceph.git;a=commitdiff;h=f72c698a55905d93e
when creating the cluster's first monitor.
Signed-off-by: Max Carrara
---
Changes v1 --> v2:
* do not enable/restart `ceph-crash` anymore when creating first mon
* drop changes to function `ceph_service_cmd` as they are no longer
needed
* create keyring for `ceph-crash
Ceph has a postinst hook that sets the ownership of '/var/lib/ceph/*'
to ceph:ceph (in our case), but misses out on '/var/lib/ceph/crash/posted'.
This patch therefore also updates the permissions of '/var/lib/ceph/*/*'.
Signed-off-by: Max Carrara
---
Changes v1 --&
Ceph has a postinst hook that sets the ownership of '/var/lib/ceph/*'
to ceph:ceph (in our case), but misses out on '/var/lib/ceph/crash/posted'.
This patch therefore also updates the permissions of '/var/lib/ceph/*/*'.
Signed-off-by: Max Carrara
---
Changes v1 --&
2024-January/061566.html
[3]:
https://docs.ceph.com/en/reef/rados/configuration/auth-config-ref/#enabling-cephx
[4]: https://docs.ceph.com/en/quincy/mgr/crash/#enabling
ceph (master):
Max Carrara (2):
debian: add patch to fix ceph crash dir permissions in postinst hook
patche
This patch makes it so that `ceph-crash` attempts to use the
non-host-specific keyring before anything else, which avoids
unnecessary error messages landing in the systemd-journal in our case.
Signed-off-by: Max Carrara
---
Changes v1 --> v2:
* new
...h-crash-change-order-of-cli
On 2/12/24 14:32, Fabian Grünbichler wrote:
> On February 5, 2024 6:54 pm, Max Carrara wrote:
>> Ceph has a postinst hook that sets the ownership of '/var/lib/ceph/*'
>> to ceph:ceph (in our case), but misses out on '/var/lib/ceph/crash/posted'.
>>
On 2/12/24 14:33, Fabian Grünbichler wrote:
> On February 5, 2024 6:54 pm, Max Carrara wrote:
>> 1. Comments, irrespective of whether they start with '#' or ';' are
>> now treated the same. Otherwise, sections and key-value pairs with
>> a tra
On 2/12/24 14:33, Fabian Grünbichler wrote:
> On February 5, 2024 6:54 pm, Max Carrara wrote:
>> This adds support for writing arbitrary sections to 'ceph.conf' while
>> ensuring that already written sections are not duplicated.
>>
>> Sections that are as
On 2/12/24 14:33, Fabian Grünbichler wrote:
> On February 5, 2024 6:54 pm, Max Carrara wrote:
>> cephconfig: allow writing arbitrary sections
>>
>> This adds support for writing arbitrary sections to 'ceph.conf' while
>> ensuring that already written sectio
On 2/12/24 14:34, Fabian Grünbichler wrote:
> On February 5, 2024 6:54 pm, Max Carrara wrote:
>> when creating the cluster's first monitor.
>>
>> Signed-off-by: Max Carrara
>> ---
>> Changes v1 --> v2:
>> * do not enable/restart `ceph-crash` anym
On 2/12/24 14:34, Fabian Grünbichler wrote:
> On February 5, 2024 6:54 pm, Max Carrara wrote:
>> This commit adds the `set_ceph_crash_conf` function, which dynamically
>> adapts the host's Ceph configuration in order to allow the Ceph crash
>> module's daemon to
On 2/13/24 10:09, Max Carrara wrote:
> On 2/12/24 14:34, Fabian Grünbichler wrote:
>> On February 5, 2024 6:54 pm, Max Carrara wrote:
>>> when creating the cluster's first monitor.
>>>
>>> Signed-off-by: Max Carrara
>>> ---
>>> Changes v1
On 2/15/24 14:09, Thomas Lamprecht wrote:
> Am 26/01/2024 um 16:44 schrieb Max Carrara:
>> This commit essentially contains all changes from the following
>> commits (most recent last):
>> * f35168f6713d5f3fa1aaa8c572d754b61c458d91
>> * 86a553d66e691
This patch makes it so that `ceph-crash` attempts to use the
non-host-specific keyring before anything else, which avoids
unnecessary error messages landing in the systemd-journal in our case.
Signed-off-by: Max Carrara
Reviewed-by: Fabian Grünbichler
---
Changes v1 --> v2:
* new
Changes
in order to group related sections together.
Signed-off-by: Max Carrara
---
Changes v2 --> v3:
* new; originally patch 07 of series v2, now adapted to this series
src/PVE/CephConfig.pm | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/src/PVE/CephConfig.p
Ceph has a postinst hook that sets the ownership of '/var/lib/ceph/*'
to ceph:ceph (in our case), but misses out on the contents of
'/var/lib/ceph/crash'.
This patch therefore also recursively updates the permissions of
'/var/lib/ceph/crash'.
Signed-off-by: Max
4
[2]:
https://git.proxmox.com/?p=ceph.git;a=blob;f=ceph/src/common/ConfUtils.cc;h=2f78fd02bf9e27467275752e6f3bca0c5e3946ce;hb=refs/heads/master#l294
[3]:
https://git.proxmox.com/?p=ceph.git;a=blob;f=ceph/src/common/ConfUtils.cc;h=2f78fd02bf9e27467275752e6f3bca0c5e3946ce;hb=refs/heads/master#
This patch makes it so that `ceph-crash` attempts to use the
non-host-specific keyring before anything else, which avoids
unnecessary error messages landing in the systemd-journal in our case.
Signed-off-by: Max Carrara
Reviewed-by: Fabian Grünbichler
---
Changes v1 --> v2:
* new
Changes
script instead of doing everything
in BASH
Older Versions
--
v1: https://lists.proxmox.com/pipermail/pve-devel/2024-January/061546.html
v2: https://lists.proxmox.com/pipermail/pve-devel/2024-February/061646.html
ceph (master):
Max Carrara (2):
debian: add patch to fix cep
-
If a key named 'client.crash' already exists within the cluster, it is
reused and not regenerated.
[0]: https://github.com/ceph/ceph/pull/48713
[1]:
https://git.proxmox.com/?p=ceph.git;a=commitdiff;h=f72c698a55905d93e9a0b7b95674616547deba8a
Signed-off-by: Max Carrara
---
Chan
Ceph has a postinst hook that sets the ownership of '/var/lib/ceph/*'
to ceph:ceph (in our case), but misses out on the contents of
'/var/lib/ceph/crash'.
This patch therefore also recursively updates the permissions of
'/var/lib/ceph/crash'.
Signed-off-by: Max
This adds support for writing arbitrary sections to 'ceph.conf' while
ensuring that already written sections are not duplicated.
Sections that are associated with the client, for example
'[client.foo]', are written directly after the '[client]' section.
Signed-off-b
Signed-off-by: Max Carrara
---
Changes v2 --> v3:
* new
bin/Makefile | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/bin/Makefile b/bin/Makefile
index b221e4b1..180a91b5 100644
--- a/bin/Makefile
+++ b/bin/Makefile
@@ -25,6 +25,10 @@ SCRI
-quotings in the
future.
[0]: https://pve.proxmox.com/wiki/Perl_Style_Guide
Signed-off-by: Max Carrara
---
Changes v2 --> v3:
* new; initial style changes moved from patch 06 of series v2
* `qr` operator for regexes to avoid character escaping issues
* call `$cond_write_sec` in loop
src/
https://git.proxmox.com/?p=ceph.git;a=blob;f=ceph/src/common/ConfUtils.cc;h=2f78fd02bf9e27467275752e6f3bca0c5e3946ce;hb=refs/heads/master#l262
Signed-off-by: Max Carrara
---
Changes v2 --> v3:
* new
src/PVE/CephConfig.pm | 27 +++
1 file changed, 23 insertions(+), 4 d
to whitespace being preserved, continued lines cannot be on the
same indentation level as `some_key`. Furthermore, the indentation
level might lead some users to mistakenly believe that leading
whitespace is ignored.
Thus, this commit removes the leading whitespace that is added by our
config write
ates '/etc/pve/ceph' when
called.
For existing clusters: The 'postinst' hook this commit adds ensures
that '/etc/pve/ceph' is created upon update.
The 'postinst' hook is also version-guarded and does not run when
upgrading from pve-manager version 8.1.5 and a
Signed-off-by: Max Carrara
---
As the old inline comment notes, this should've been removed in
PVE 7.0 already.
src/PVE/Ticket.pm | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/src/PVE/Ticket.pm b/src/PVE/Ticket.pm
index ce8d5c8..c5508ed 100644
--- a/sr
run it again
manually to adapt the config.
That being said, this reminds me that the '[ceph.crash]' section, the location
of the keyring file, etc. should probably be in our docs as well, so I will
send in a follow-up series for that (unless this series ends up needing a v4,
then I
On 2/23/24 17:19, Friedrich Weber wrote:
> On 21/02/2024 14:15, Max Carrara wrote:
>> On 2/21/24 12:55, Friedrich Weber wrote:
>>> [...]
>>>
>>> - the `ceph-crash` service does not restart after installing the patched
>>> ceph-base package, so the r
This patch makes it so that `ceph-crash` attempts to use the
non-host-specific keyring before anything else, which avoids
unnecessary error messages landing in the systemd-journal in our case.
Signed-off-by: Max Carrara
Reviewed-by: Fabian Grünbichler
---
Changes v1 --> v2:
* new
Changes
Ceph has a postinst hook that sets the ownership of '/var/lib/ceph/*'
to ceph:ceph (in our case), but misses out on the contents of
'/var/lib/ceph/crash'.
This patch therefore also recursively updates the permissions of
'/var/lib/ceph/crash'.
Signed-off-by: Max
This patch makes it so that `ceph-crash` attempts to use the
non-host-specific keyring before anything else, which avoids
unnecessary error messages landing in the systemd-journal in our case.
Signed-off-by: Max Carrara
Reviewed-by: Fabian Grünbichler
---
Changes v1 --> v2:
* new
Changes
Signed-off-by: Max Carrara
---
Changes v3 --> v4:
* new
src/PVE/CephConfig.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/PVE/CephConfig.pm b/src/PVE/CephConfig.pm
index 6b7bbd4..da28940 100644
--- a/src/PVE/CephConfig.pm
+++ b/src/PVE/CephConfig.pm
@@ -70,6 +70,8 @@
https://git.proxmox.com/?p=ceph.git;a=blob;f=ceph/src/common/ConfUtils.cc;h=2f78fd02bf9e27467275752e6f3bca0c5e3946ce;hb=refs/heads/master#l262
Signed-off-by: Max Carrara
---
Changes v2 --> v3:
* new
Changes v3 --> v4:
* none
src/PVE/CephConfig.pm | 28
1 f
to whitespace being preserved, continued lines cannot be on the
same indentation level as `some_key`. Furthermore, the indentation
level might lead some users to mistakenly believe that leading
whitespace is ignored.
Thus, this commit removes the leading whitespace that is added by our
config write
html
v3: https://lists.proxmox.com/pipermail/pve-devel/2024-February/061802.html
Summary of Changes
--
ceph (master):
Max Carrara (2):
debian: add patch to fix ceph crash dir permissions in postinst hook
patches: add patch that reorders clients used by ceph-crash
...ly-adjust-permissio
ng
hash matches the expected hash, it is consequently passed into the
writer. The writer's result is then parsed another time and compared
against the expected hash once more.
[0]:
https://git.proxmox.com/?p=ceph.git;a=blob;f=ceph/src/common/ConfUtils.cc;h=2f78fd02bf9e27467275752e6f3bca0c5e394
-init-ceph-crash'.
Existing `client.crash` Key
---
If a key named 'client.crash' already exists within the cluster, it is
reused and not regenerated.
[0]: https://github.com/ceph/ceph/pull/48713
[1]:
https://git.proxmox.com/?p=ceph.git;a=commitdiff;h
#l179
Signed-off-by: Max Carrara
---
Changes v3 --> v4:
* new
src/PVE/CephConfig.pm | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/src/PVE/CephConfig.pm b/src/PVE/CephConfig.pm
index 32ea544..6b7bbd4 100644
--- a/src/PVE/CephConfig.pm
+++ b/src/PVE/CephConfig.p
Ceph has a postinst hook that sets the ownership of '/var/lib/ceph/*'
to ceph:ceph (in our case), but misses out on the contents of
'/var/lib/ceph/crash'.
This patch therefore also recursively updates the permissions of
'/var/lib/ceph/crash'.
Signed-off-by: Max
in order to group related sections together.
Signed-off-by: Max Carrara
---
Changes v2 --> v3:
* new; originally patch 07 of series v2, now adapted to this series
Changes v3 --> v4:
* none
src/PVE/CephConfig.pm | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff
This adds support for writing arbitrary sections to 'ceph.conf' while
ensuring that already written sections are not duplicated.
Sections that are associated with the client, for example
'[client.foo]', are written directly after the '[client]' section.
Signed-off-b
Signed-off-by: Max Carrara
---
Changes v2 --> v3:
* new
Changes v3 --> v4:
* none
bin/Makefile | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/bin/Makefile b/bin/Makefile
index b221e4b1..180a91b5 100644
--- a/bin/Makefile
+++ b/bin/Makefile
@@ -25,6
-quotings in the
future.
[0]: https://pve.proxmox.com/wiki/Perl_Style_Guide
Signed-off-by: Max Carrara
---
Changes v2 --> v3:
* new; initial style changes moved from patch 06 of series v2
* `qr` operator for regexes to avoid character escaping issues
* call `$cond_write_sec` in loop
Changes
t;a=blob;f=ceph/src/common/ConfUtils.cc;h=2f78fd02bf9e27467275752e6f3bca0c5e3946ce;hb=refs/heads/master#l194
[2]:
https://git.proxmox.com/?p=ceph.git;a=blob;f=ceph/src/common/ConfUtils.cc;h=2f78fd02bf9e27467275752e6f3bca0c5e3946ce;hb=refs/heads/master#l294
Signed-off-by: Max Carrara
---
Chan
ates '/etc/pve/ceph' when
called.
For existing clusters: The 'postinst' hook this commit adds ensures
that '/etc/pve/ceph' is created upon update.
The 'postinst' hook is also version-guarded and does not run when
upgrading from pve-manager version 8.1.5 and a
D#l112
[1]: https://perldoc.perl.org/perldata#Scalar-values
Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=5198
Signed-off-by: Max Carrara
---
PVE/API2/Ceph/MON.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/PVE/API2/Ceph/MON.pm b/PVE/API2/Ceph/MON.pm
index 1e959e
Signed-off-by: Max Carrara
---
PVE/API2/Ceph/MON.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/PVE/API2/Ceph/MON.pm b/PVE/API2/Ceph/MON.pm
index 1737c294..f13115a0 100644
--- a/PVE/API2/Ceph/MON.pm
+++ b/PVE/API2/Ceph/MON.pm
@@ -148,13 +148,13 @@ my
On Thu Mar 14, 2024 at 8:56 AM CET, Fiona Ebner wrote:
> Am 13.03.24 um 16:42 schrieb Stefan Sterz:
> > On Wed Mar 13, 2024 at 3:53 PM CET, Max Carrara wrote:
> >> The Ceph monitor removal assertion contains a condition that checks
> >> whether the given mon ID actu
D#l112
[1]: https://perldoc.perl.org/perldata#Scalar-values
Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=5198
Signed-off-by: Max Carrara
---
PVE/API2/Ceph/MON.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/PVE/API2/Ceph/MON.pm b/PVE/API2/Ceph/MON.pm
index 1e959e
Signed-off-by: Max Carrara
---
PVE/API2/Ceph/MON.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/PVE/API2/Ceph/MON.pm b/PVE/API2/Ceph/MON.pm
index 057ca70d..d5b219bf 100644
--- a/PVE/API2/Ceph/MON.pm
+++ b/PVE/API2/Ceph/MON.pm
@@ -148,13 +148,13 @@ my
On Wed Jan 3, 2024 at 4:37 PM CET, Stefan Lendl wrote:
> Add several tests for Vnets. State setup as well as testing results is
> done only via the API to test on the API boundaries not not against the
> internal state. Internal state is mocked to avoid requiring access to
> system files or pmxcfs.
On Wed Jan 3, 2024 at 4:37 PM CET, Stefan Lendl wrote:
> Add several tests for Vnets. State setup as well as testing results is
> done only via the API to test on the API boundaries not not against the
> internal state. Internal state is mocked to avoid requiring access to
> system files or pmxcfs.
On Mon Mar 18, 2024 at 3:14 PM CET, Stefan Lendl wrote:
> "Max Carrara" writes:
>
> > On Wed Jan 3, 2024 at 4:37 PM CET, Stefan Lendl wrote:
> >> Add several tests for Vnets. State setup as well as testing results is
> >> done only via the API to test o
Signed-off-by: Max Carrara
---
listvms.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/listvms.py b/listvms.py
index 8666742..cc3209f 100755
--- a/listvms.py
+++ b/listvms.py
@@ -1,9 +1,11 @@
#!/usr/bin/python3
-from typing import List, Dict, Optional
import json
stalled it on my local
system, and re-added my virtual ESXi host in the storage settings. The
plugin worked as expected - all my VMs on the ESXi hosts showed up and
were able to be live-imported.
[0]: https://docs.python.org/3.11/library/argparse.html
Max Carrara (5):
listvms: remove unused imp
tps://docs.python.org/3.11/library/dataclasses.html
Signed-off-by: Max Carrara
---
listvms.py | 99 --
1 file changed, 73 insertions(+), 26 deletions(-)
diff --git a/listvms.py b/listvms.py
index cc3209f..cdea95a 100755
--- a/listvms.py
+++ b/listvms.py
@@ -1
Signed-off-by: Max Carrara
---
listvms.py | 2 --
1 file changed, 2 deletions(-)
diff --git a/listvms.py b/listvms.py
index 97bb368..8666742 100755
--- a/listvms.py
+++ b/listvms.py
@@ -2,7 +2,6 @@
from typing import List, Dict, Optional
import json
-import os
import ssl
import sys
from
1 - 100 of 419 matches
Mail list logo
