This series adds a bunch of improvements for listvms.py, most notably better typing (and thus better linting support) as well as parsing arguments via the Python STL's `argparse` [0]. For more information, please see the individual patches.
All patches were additionally tested in order to ensure that the JSON output on successful invocations remains unchanged. This was done as follows: # on master ./listvms.py $ARGS | jq > ref.json # after each patch ./listvms.py $ARGS | jq > output.json diff -u ref.json output.json Furthermore, I built the repo's package and installed it on my local system, and re-added my virtual ESXi host in the storage settings. The plugin worked as expected - all my VMs on the ESXi hosts showed up and were able to be live-imported. [0]: https://docs.python.org/3.11/library/argparse.html Max Carrara (5): listvms: remove unused import and variable listvms: reorder imports listvms: improve typing and add dataclasses to represent dicts listvms: add arg parser, context manager for connections, fetch helper listvms: run formatter listvms.py | 296 ++++++++++++++++++++++++++++++++++++++++------------- 1 file changed, 225 insertions(+), 71 deletions(-) -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
