[pve-devel] [PATCH pve-qemu-kvm] patch: pbs block driver: correct a data type

2024-06-07 Thread Jing Luo via pve-devel
--- Begin Message --- gcc warns (-Werror=type-limits) that it will always be false for the if statement. This is because here s->aid is defined as char, while proxmox_restore_open_image() returns an int. Change the type to int. Strangely gcc warns it on arm64 build but not amd64 build... Signed-of

[pve-devel] [PATCH pve-common] tools: fix syscall mknod()

2024-06-07 Thread Jing Luo via pve-devel
--- Begin Message --- b792e8df81 introduced a bug that can cause this: Undefined subroutine &PVE::Syscall::SYS_mknod called at /usr/share/perl5/PVE/Syscall.pm line 11 It should be mknod, not SYS_mknod. This caused other pve perl lib failing to build. I couldn't reproduce this on amd64 build, but

Re: [pve-devel] [PATCH pve-qemu-kvm] patch: pbs block driver: correct a data type

2024-06-11 Thread Jing Luo via pve-devel
--- Begin Message --- On 2024-06-07 20:49, Fiona Ebner wrote: Hi, if you haven't already done so, please send a signed copy of the Harmony CLA to off...@proxmox.com, see [0]. Hi, thanks for letting me know, this was done some time last week. Am 07.06.24 um 11:43 schrieb Jing Luo: gcc warn

[pve-devel] [PATCH v2 pve-qemu-kvm] patches: pbs block driver: correct a data type

2024-06-11 Thread Jing Luo via pve-devel
--- Begin Message --- gcc warns (-Werror=type-limits) that it will always be false for the if statement. This is because here s->aid is defined as char, while proxmox_restore_open_image() returns an int. This is probably because chars are treated as unsigned on arm arch but signed on x86 arch: ht

Re: [pve-devel] [PATCH pve-manger] test: remove logs and add a .gitignore file

2024-09-12 Thread Jing Luo via pve-devel
--- Begin Message --- Oops sorry. This is for pve-manger. On 2024-09-12 20:49, Jing Luo wrote: Through out the years there are 3 log files committed to the git repo. Let's remove those and add a .gitignore file. Signed-off-by: Jing Luo --- test/.gitignore| 1 + test/replication_

[pve-devel] [PATCH pve-manager] d/control: change binary package architecture from `any` to `all`

2024-09-12 Thread Jing Luo via pve-devel
--- Begin Message --- There is no architecture dependent binary files in the final deb package. There is no shared libs either (says debhelper), so let's remove that too. Signed-off-by: Jing Luo --- debian/control | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/debian/contr

[pve-devel] [PATCH] test: remove logs and add a .gitignore file

2024-09-12 Thread Jing Luo via pve-devel
--- Begin Message --- Through out the years there are 3 log files committed to the git repo. Let's remove those and add a .gitignore file. Signed-off-by: Jing Luo --- test/.gitignore| 1 + test/replication_test4.log | 25 --- test/replication_test5.log | 64 -

[pve-devel] [PATCH] patches: upstream: python3.12 compat

2024-11-12 Thread Jing Luo via pve-devel
--- Begin Message --- Prepare for debian trixie. Upstream has not yet made a new release since Dec 2023, backporting this commit to make ifupdown2 work on trixie. Also fixes an RC bug on debian (#1074250). Also fixed a typo in the commit msg. upstream: https://github.com/CumulusNetworks/ifupdown2

[pve-devel] [PATCH proxmox-perl-rs] common: d/control: change binary package architecture from `any` to `all`

2024-10-01 Thread Jing Luo via pve-devel
--- Begin Message --- There is no architecture dependent binary files in the libproxmox-rs-perl deb package. There is no shared libs either (says debhelper), so let's remove that too. Slight adjustment for Makefile too. Signed-off-by: Jing Luo --- This can improve portability. Let's go baby ---

[pve-devel] [PATCH proxmox-perl-rs] common: buildsys: Makefile: drop `--no-pre-clean`

2024-10-01 Thread Jing Luo via pve-devel
--- Begin Message --- There is no difference in the source or binary packge running with or without `--no-pre-clean`. On the other hand, dpkg-buildpackge complains loudly when `--no-pre-clean` is specified, so let's remove it. Signed-off-by: Jing Luo --- common/pkg/Makefile | 2 +- 1 file change

[pve-devel] Fwd: [RESEND PATCH pve-manager v2] d/control: change binary package architecture from `any` to `all`

2024-10-01 Thread Jing Luo via pve-devel
--- Begin Message --- Resend, without a link to the mailing list archive Original Message Subject: [PATCH pve-manager v2] d/control: change binary package architecture from `any` to `all` Date: 2024-09-13 19:55 From: Jing Luo To: pve-devel@lists.proxmox.com Cc: Jing Luo , Fab

[pve-devel] [PATCH pve-manager v2] d/control: change binary package architecture from `any` to `all`

2024-09-18 Thread Jing Luo via pve-devel
--- Begin Message --- There is no architecture dependent binary files in the final deb package. There is no shared libs either (says debhelper), so let's remove that too. Signed-off-by: Jing Luo Reviewed-by: Fabian Grünbichler --- Changes since v1: Change the $(DEB) in Makefile too, forgot to ad

[pve-devel] [PATCH pve-network] d/control: break the circular build-dependency with pve-firewall

2024-11-22 Thread Jing Luo via pve-devel
--- Begin Message --- Currently pve-network has a (versioned) build-dep of pve-firewall, which has a (versioned) runtime dependency of a newer version of libpve-network-perl, which is not available because it has not been built. It turns out that pve-firewall is only needed in testing, so let's onl

[pve-devel] [PATCH qemu-server] query-machine-capabilities: make it work on non-x86 arch

2024-11-22 Thread Jing Luo via pve-devel
--- Begin Message --- This little program has inline assembly code that won't work on non-x86 arch: query-machine-capabilities.c: In function 'query_cpu_capabilities': query-machine-capabilities.c:29:5: error: impossible constraint in 'asm' 29 | asm volatile("cpuid" | ^~~ So let'

Re: [pve-devel] [PATCH ifupdown2] patches: upstream: python3.12 compat

2024-11-15 Thread Jing Luo via pve-devel
--- Begin Message --- Forgot to add "ifupdown2" to [PATCH], so resend. Oops On 2024-11-13 04:06, Jing Luo wrote: Prepare for debian trixie. Upstream has not yet made a new release since Dec 2023, backporting this commit to make ifupdown2 work on trixie. Also fixes an RC bug on debian (#1074250)

[pve-devel] [PATCH proxmox-backup] python3.12 compat: docs/_ext/proxmox-scanrefs.py: cast to string for re.sub()

2024-12-16 Thread Jing Luo via pve-devel
--- Begin Message --- This fixes a FTBFS with python 3.12. We need to cast "filename" to string. Sphinx version: 8.1.3 Python version: 3.12.8 (CPython) Docutils version: 0.21.2 Jinja2 version: 3.1.3 Pygments version: 2.18.0 Last messages: copying assets... copying assets: done writin

[pve-devel] [PATCH proxmox-ve-rs 3/3] d/control: include a revision in the package version

2024-11-21 Thread Jing Luo via pve-devel
--- Begin Message --- The "dsc" target also fails because of this: error: can't build with source format '3.0 (quilt)': non-native package version does not contain a revision d/source/format is automatically generated as '3.0 (quilt)', let's keep it that way. Include a dch entry so no one will

[pve-devel] [PATCH proxmox-ve-rs 2/3] d/control: specify the build-deps not needed for "nocheck" profile

2024-11-21 Thread Jing Luo via pve-devel
--- Begin Message --- These rust libs are not needed if using DEB_BUILD_PROFILES="nocheck". This helps bootstrap proxmox to another arch in the future. Signed-off-by: Jing Luo --- proxmox-ve-config/debian/control | 32 1 file changed, 16 insertions(+), 16 deletio

[pve-devel] [PATCH proxmox-ve-rs 1/3] d/control: correct source package name

2024-11-21 Thread Jing Luo via pve-devel
--- Begin Message --- Currently the "dsc" target fails and dpkg-buildpackage complains: error: can't build with source format '3.0 (quilt)': no upstream tarball found at ../proxmox-ve-config_0.2.0.orig.tar.{bz2,gz,lzma,xz} but there is a "rust-proxmox-ve-config_0.2.0.orig.tar.gz". Usually a rust

[pve-devel] [PATCH qemy-server v2] query-machine-capabilities: make it work on non-x86 arch

2024-11-22 Thread Jing Luo via pve-devel
--- Begin Message --- This little program has inline assembly code that won't work on non-x86 arch: query-machine-capabilities.c: In function 'query_cpu_capabilities': query-machine-capabilities.c:29:5: error: impossible constraint in 'asm' 29 | asm volatile("cpuid" | ^~~ So let'

[pve-devel] [PATCH pve-network v2] d/control: break the circular build-dependency with pve-firewall, and more

2024-11-22 Thread Jing Luo via pve-devel
--- Begin Message --- Currently pve-network has a (versioned) build-dep of pve-firewall, which has a (versioned) runtime dependency of a newer version of libpve-network-perl, which is not available because it has not been built. It turns out that pve-firewall is only needed in testing, so let's onl

[pve-devel] [PATCH pve-network] SDN: Dhcp: perl 5.40 compat

2024-11-22 Thread Jing Luo via pve-devel
--- Begin Message --- On trixie with perl 5.40 we see these errors: Nov 14 06:28:54 pi16 pve-firewall[932]: Attempt to call undefined import method with arguments ("config") via package "PVE::Network::SDN::Dhcp" (Perhaps you forgot to load the package?) at /usr/share/perl5/PVE/Network/SDN/Dhcp.p

[pve-devel] [PATCH dab] fix an error on creating a debian trixie image

2024-12-07 Thread Jing Luo via pve-devel
--- Begin Message --- debian trixie no longer ships "/etc/sysctl.conf", so this fix is needed. Signed-off-by: Jing Luo --- PVE/DAB.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/PVE/DAB.pm b/PVE/DAB.pm index f318be5..9e80d6e 100644 --- a/PVE/DAB.pm +++ b/PVE/DAB.pm @@

[pve-devel] [PATCH dab] fix a few typos

2025-01-13 Thread Jing Luo via pve-devel
--- Begin Message --- complained by lintian. Signed-off-by: Jing Luo --- dab | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/dab b/dab index 7771771..d79afe6 100755 --- a/dab +++ b/dab @@ -268,7 +268,7 @@ yourself. =item I<--exclude -A comma-separated list of pa

[pve-devel] [PATCH pve-manager] tree-wide: change /var/run to /run and /var/lock to /run/lock

2025-03-22 Thread Jing Luo via pve-devel
--- Begin Message --- "/var/run" and "/var/lock" are deprecated. This is to comply with Debian Policy 9.1.4 "/run and /run/lock". (https://www.debian.org/doc/debian-policy/ch-opersys.html#run-and-run-lock) Signed-off-by: Jing Luo --- PVE/API2/Nodes.pm | 4 ++-- PVE/API2/Replication.

[pve-devel] [PATCH pve-manager 2/2] move /run/vzdump.lock to /run/lock/vzdump.lock

2025-03-22 Thread Jing Luo via pve-devel
--- Begin Message --- It's more appropriate under Debian, and vzdump.lock doesn't seem to be used by any other package. Signed-off-by: Jing Luo --- PVE/API2/Nodes.pm | 2 +- PVE/VZDump.pm | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Node

[pve-devel] [PATCH pve-container] tree-wide: change /var/run to /run

2025-03-22 Thread Jing Luo via pve-devel
--- Begin Message --- "/var/run" is deprecated. This is to comply with Debian Policy 9.1.4 "/run and /run/lock". (https://www.debian.org/doc/debian-policy/ch-opersys.html#run-and-run-lock) Signed-off-by: Jing Luo --- src/PVE/API2/LXC.pm | 6 +++--- src/test/test-debian-009/e

[pve-devel] [PATCH qemu-server] tree-wide: change /var/run to /run and /var/lock to /run/lock

2025-03-22 Thread Jing Luo via pve-devel
--- Begin Message --- "/var/run" and "/var/lock" are deprecated. This is to comply with Debian Policy 9.1.4 "/run and /run/lock". (https://www.debian.org/doc/debian-policy/ch-opersys.html#run-and-run-lock) Signed-off-by: Jing Luo --- PVE/CLI/qm.pm | 2 +- PVE/QemuConfig.pm

[pve-devel] [PATCH pve-firewall] tree-wide: change /var/run to /run and /var/lock to /run/lock

2025-03-22 Thread Jing Luo via pve-devel
--- Begin Message --- "/var/run" and "/var/lock" are deprecated. This is to comply with Debian Policy 9.1.4 "/run and /run/lock". (https://www.debian.org/doc/debian-policy/ch-opersys.html#run-and-run-lock) Signed-off-by: Jing Luo --- src/PVE/Firewall.pm | 2 +- src/pvefw-logger.c | 4 ++-- 2 f

[pve-devel] [PATCH pve-storage] tree-wide: change /var/lock to /run/lock

2025-03-22 Thread Jing Luo via pve-devel
--- Begin Message --- Let's use /run/lock for lock files. Also, pve-iscsi-rescan.lock doesn't seem to be used by any other package. "/var/lock" is deprecated. Signed-off-by: Jing Luo --- src/PVE/Storage/ISCSIPlugin.pm | 2 +- src/PVE/Storage/Plugin.pm | 2 +- 2 files changed, 2 insertions(+

[pve-devel] [PATCH pve-guest-common] tree-wide: change /var/lock to /run/lock

2025-03-22 Thread Jing Luo via pve-devel
--- Begin Message --- "/var/run" and "/var/lock" are deprecated. This is to comply with Debian Policy 9.1.4 "/run and /run/lock". (https://www.debian.org/doc/debian-policy/ch-opersys.html#run-and-run-lock) Signed-off-by: Jing Luo --- src/PVE/GuestHelpers.pm | 2 +- 1 file changed, 1 insertion(+

[pve-devel] [PATCH] rust-proxmox-network-api: change /var/lock to /run/lock

2025-03-22 Thread Jing Luo via pve-devel
--- Begin Message --- "/var/lock" is deprecated. Signed-off-by: Jing Luo --- proxmox-network-api/src/config/mod.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proxmox-network-api/src/config/mod.rs b/proxmox-network-api/src/config/mod.rs index 054f53c8..5e361e55 100644 --

[pve-devel] [PATCH pmg-api] tree-wide: change /var/run to /run and /var/lock to /run/lock

2025-03-22 Thread Jing Luo via pve-devel
--- Begin Message --- "/var/run" and "/var/lock" are deprecated. This is to comply with Debian Policy 9.1.4 "/run and /run/lock". (https://www.debian.org/doc/debian-policy/ch-opersys.html#run-and-run-lock) Signed-off-by: Jing Luo --- src/PMG/API2/ACMEPlugin.pm | 2 +- src/PMG/API2/SACusto

[pve-devel] [PATCH] rust-proxmox-backup: change /var/lock to /run/lock

2025-03-22 Thread Jing Luo via pve-devel
--- Begin Message --- "/var/lock" is deprecated. Signed-off-by: Jing Luo --- pbs-config/src/network/mod.rs| 2 +- src/tape/drive/mod.rs| 2 +- src/tools/shared_rate_limiter.rs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pbs-config/src/network/mod.rs b/p

[pve-devel] [PATCH pve-common] tree-wide: change /var/run to /run and /var/lock to /run/lock

2025-03-22 Thread Jing Luo via pve-devel
--- Begin Message --- "/var/run" and "/var/lock" are deprecated. This is to comply with Debian Policy 9.1.4 "/run and /run/lock". (https://www.debian.org/doc/debian-policy/ch-opersys.html#run-and-run-lock) Signed-off-by: Jing Luo --- src/PVE/Daemon.pm | 4 ++-- src/PVE/Network.pm | 2 +- src/P

[pve-devel] [PATCH pve-cluster] tree-wide: change /var/run to /run and /var/lock to /run/lock

2025-03-22 Thread Jing Luo via pve-devel
--- Begin Message --- "/var/run" and "/var/lock" are deprecated. This is to comply with Debian Policy 9.1.4 "/run and /run/lock". (https://www.debian.org/doc/debian-policy/ch-opersys.html#run-and-run-lock) Signed-off-by: Jing Luo --- src/PVE/API2/ClusterConfig.pm | 4 ++-- src/PVE/CLI/pvecm.pm

Re: [pve-devel] [PATCH pve-manager 2/2] move /run/vzdump.lock to /run/lock/vzdump.lock

2025-03-24 Thread Jing Luo via pve-devel
--- Begin Message --- On 2025-03-24 20:56, Thomas Lamprecht wrote: [...] Yeah, that I noticed later too, but it would be indeed good to check if this is a guarantee (i.e., by Debian policy) for all systems now, even if they got created with a very ancient PVE/Debian version. I only did a quick c

[pve-devel] [PATCH pve-manager] [multiarch] pvestatd: don't query supported CPU flags if we are not x86_64

2025-03-30 Thread Jing Luo via pve-devel
--- Begin Message --- Only qemu-system-x86_64 will output a list of cpuflags, so let's only do it on x86_64. For now, we don't consider the case of non-x86, and it silences warnings on non-x86: (e.g. on aarch64, riscv64) Mar 31 00:20:24 debian1 pvestatd[58071]: warning: failed querying supported t

Re: [pve-devel] [PATCH pve-manager 2/2] move /run/vzdump.lock to /run/lock/vzdump.lock

2025-03-24 Thread Jing Luo via pve-devel
--- Begin Message --- On 2025-03-24 17:02, Thomas Lamprecht wrote: Am 22.03.25 um 16:17 schrieb Jing Luo: It's more appropriate under Debian, and vzdump.lock doesn't seem to be used by any other package. This is very dangerous and needs a ton of work to be done right. As any vzdump job that s