options hash:
it's not needed anymore to specify options that are specified in the
type specific propertyList, except if it's 'fixed => 1' (since that does
not exist in the schema)
Signed-off-by: Dominik Csapak
---
changes from v2:
* split out compare_deeply
* incorporated th
more or less a copy from the normal section config test, but now with
properties defined multiple times as well as conflicting options
Signed-off-by: Dominik Csapak
---
test/Makefile | 1 +
test/section_config_separated_test.pl | 489 ++
2 files
Signed-off-by: Dominik Csapak
---
src/PVE/Cluster.pm | 1 +
src/pmxcfs/status.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm
index cfa2583..c01bf89 100644
--- a/src/PVE/Cluster.pm
+++ b/src/PVE/Cluster.pm
@@ -80,6 +80,7 @@ my $observed
simply uses the json_config_properties for the vm config and maps them
to "vm_${opt}"
Signed-off-by: Dominik Csapak
---
PVE/Makefile | 1 +
PVE/Profiles/Makefile | 5 +
PVE/Profiles/VM.pm| 28
3 files changed, 34 insertions(+)
create m
one, else
we'd get a cyclic dependency, and without that we need to ignore
unknown sections
* we add the 'profile-description' to the options of all registered
plugins (so we don't have to do it manually)
* we always call 'init(1)' of the SectionConfig so we ca
simply uses the json_config_properties for the ct config and maps them
to "ct_${opt}"
Signed-off-by: Dominik Csapak
---
src/PVE/Makefile | 1 +
src/PVE/Profiles/CT.pm| 28
src/PVE/Profiles/Makefile | 4
3 files changed, 33 insertions(
we use the profile cfg as the 'param' hash, but overwrite the values
with the ones from the api call, so one can overwrite options from
the profile easily
Signed-off-by: Dominik Csapak
---
changes from v2:
* adapt to load_profile name change
src/PVE/API2/LXC.pm | 23
o the 'meta' option, but log it instead
0: https://lists.proxmox.com/pipermail/pve-devel/2023-November/060300.html
pve-cluster:
Dominik Csapak (1):
add profiles.cfg to cluster fs
src/PVE/Cluster.pm | 1 +
src/pmxcfs/status.c | 1 +
2 files changed, 2 insertions(+)
pve-guest-c
we use the the profile cfg as the 'param' hash, but overwrite the values
with the ones from the api call, so one can overwrite options from the
profile easily
also we add the used profile to the meta info in the config, since
it might be interesting which one was used
Signed-off-b
we have to that here, so the properties/options are correctly configured
when using that feature on the cli
Signed-off-by: Dominik Csapak
---
changes from v2:
* call init() instead of init(1) since the plugin does that already for us
PVE/CLI/qm.pm | 6 ++
1 file changed, 6 insertions
we have to that here, so the properties/options are correctly configured
when using that feature on the cli
Signed-off-by: Dominik Csapak
---
changes from v2:
* call init() instead of init(1) since the plugin already does that for us
src/PVE/CLI/pct.pm | 6 ++
1 file changed, 6 insertions
basic CRUD for the profile section config
Signed-off-by: Dominik Csapak
---
changes from v2:
* add type parameter so we can filter the list
(useful for the ui)
PVE/API2/Cluster.pm | 7 +
PVE/API2/Cluster/Makefile| 1 +
PVE/API2/Cluster/Profiles.pm | 239
: Dominik Csapak
---
src/api-viewer/APIViewer.js | 34 +++---
1 file changed, 31 insertions(+), 3 deletions(-)
diff --git a/src/api-viewer/APIViewer.js b/src/api-viewer/APIViewer.js
index d9753b2..26a1c08 100644
--- a/src/api-viewer/APIViewer.js
+++ b/src/api-viewer
this series implementes the oneOf schema for the api, see the individual
patches for more details and changelog
only change is the fixed test for pve-common 3/3
(did accidentally include the wrong file when sending the patches)
pve-common:
Dominik Csapak (5):
section config: add test for the
by simply doing an 'is_deeply' on the generated schema with
the current generated schema
Signed-off-by: Dominik Csapak
---
test/section_config_test.pl | 133
1 file changed, 133 insertions(+)
diff --git a/test/section_config_test
to compare nested hashes/lists and scalar values recursively.
Also includes some tests
Signed-off-by: Dominik Csapak
---
changes from v3:
* rename the testfile is_deeply_test to match Makefile
src/PVE/Tools.pm | 31 +
test/Makefile | 1 +
test/is_deeply_test.pl | 142
a schema can now have the 'oneOf' property which is an array of regular
schemas. In the default case any of that has to match. If the
'type-property'/'instance-types' are given, only the schema for the specific
type will be checked (and handles as 'additionalProperties' if there is
no matching type
options hash:
it's not needed anymore to specify options that are specified in the
type specific propertyList, except if it's 'fixed => 1' (since that does
not exist in the schema)
Signed-off-by: Dominik Csapak
---
src/PVE/SectionConfig.pm | 312 +
more or less a copy from the normal section config test, but now with
properties defined multiple times as well as conflicting options
Signed-off-by: Dominik Csapak
---
test/Makefile | 1 +
test/section_config_separated_test.pl | 489 ++
2 files
one additional comment to the ux:
the match field could use a bit of improvement:
the docs describe the current fields, but for users that
don't deep dive into the docs first it may be confusing having
a simple text input field for that
at least when the type is 'exact' we could offer a
dropdow
simply uses the json_config_properties for the vm config and maps them
to "vm_${opt}"
Signed-off-by: Dominik Csapak
---
PVE/Makefile | 1 +
PVE/Profiles/Makefile | 5 +
PVE/Profiles/VM.pm| 28
3 files changed, 34 insertions(+)
create m
vember/060300.html
pve-cluster:
Dominik Csapak (1):
add profiles.cfg to cluster fs
src/PVE/Cluster.pm | 1 +
src/pmxcfs/status.c | 1 +
2 files changed, 2 insertions(+)
pve-guest-common:
Dominik Csapak (1):
add profiles section config plugin
src/Makefile | 2 +
we use the the profile cfg as the 'param' hash, but overwrite the values
with the ones from the api call, so one can overwrite options from the
profile easily
also we add the used profile to the meta info in the config, since
it might be interesting which one was used
Signed-off-b
we have to that here, so the properties/options are correctly configured
when using that feature on the cli
Signed-off-by: Dominik Csapak
---
PVE/CLI/qm.pm | 6 ++
1 file changed, 6 insertions(+)
diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm
index b17b4fe2..82240ba3 100755
--- a/PVE/CLI/qm.pm
the SectionConfig so we
cannot forget that
Signed-off-by: Dominik Csapak
---
src/Makefile | 2 +
src/PVE/Profiles/Plugin.pm | 83 ++
2 files changed, 85 insertions(+)
create mode 100644 src/PVE/Profiles/Plugin.pm
diff --git a/src/Makefile b/src/M
we use the profile cfg as the 'param' hash, but overwrite the values
with the ones from the api call, so one can overwrite options from
the profile easily
Signed-off-by: Dominik Csapak
---
src/PVE/API2/LXC.pm | 23 +++
1 file changed, 23 insertions(+)
diff --git
Signed-off-by: Dominik Csapak
---
src/PVE/Cluster.pm | 1 +
src/pmxcfs/status.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm
index cfa2583..c01bf89 100644
--- a/src/PVE/Cluster.pm
+++ b/src/PVE/Cluster.pm
@@ -80,6 +80,7 @@ my $observed
simply uses the json_config_properties for the ct config and maps them
to "ct_${opt}"
Signed-off-by: Dominik Csapak
---
src/PVE/Makefile | 1 +
src/PVE/Profiles/CT.pm| 28
src/PVE/Profiles/Makefile | 4
3 files changed, 33 insertions(
we have to that here, so the properties/options are correctly configured
when using that feature on the cli
Signed-off-by: Dominik Csapak
---
src/PVE/CLI/pct.pm | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm
index a0b9bce..e579b7a 100755
--- a
basic CRUD for the profile section config
Signed-off-by: Dominik Csapak
---
PVE/API2/Cluster.pm | 7 +
PVE/API2/Cluster/Makefile| 1 +
PVE/API2/Cluster/Profiles.pm | 239 +++
3 files changed, 247 insertions(+)
create mode 100644 PVE/API2/Cluster
and make it into a proper field
it's intended to be used like a single field and exactly as before
Signed-off-by: Dominik Csapak
---
www/manager6/Makefile| 1 +
www/manager6/form/IsoSelector.js | 107 +++
www/manager6/qemu/CDEdit.js
This is useful for adding the virtio-win iso for new installs, and thus
we change the default disk type to scsi and network type to virtio.
Signed-off-by: Dominik Csapak
---
there is still a bug (can look into it monday) where when the the
checkbox is unselected again, the default disk is ide1
one minor nit inline, but not a blocker for me
did not test again, but the changes are small enough imho
aside from that, this patch (and the series since i already
reviewed the previous versions and there did not change anything)
Reviewed-by: Dominik Csapak
On 11/14/23 10:22, Markus Frank
nctionally invisible.
To prevent that, check that the 'viewWidth'/'viewHeight' is big enough
so that the panels still have least 50 pixels left before setting their
size.
reported on the pve-user list:
https://lists.proxmox.com/pipermail/pve-user/2023-November/017292.html
Signed
On 11/20/23 09:02, Dominik Csapak wrote:
it seems in new versions of chrome , this triggers too early on a fresh
start (when autostarting a pve tab), resulting in the
'viewWidth'/'viewHeight' being zero pixels. This means we set the width
of the left and the height of the
On 11/20/23 09:26, Thomas Lamprecht wrote:
Am 20/11/2023 um 09:07 schrieb Dominik Csapak:
On 11/20/23 09:02, Dominik Csapak wrote:
it seems in new versions of chrome , this triggers too early on a fresh
start (when autostarting a pve tab), resulting in the
'viewWidth'/'viewHei
On 11/20/23 10:03, Lukas Wagner wrote:
On 11/17/23 09:41, Dominik Csapak wrote:
one additional comment to the ux:
the match field could use a bit of improvement:
the docs describe the current fields, but for users that
don't deep dive into the docs first it may be confusing having
a s
hi, a few issues here:
high level:
adding/modifying/deleting dhcp ranges does not trigger form 'isDirty'
check properly, leading to me unable to add dhcp ranges
to an existing subnet without also changing something else on
the first tab (there are probably some 'checkChange' triggers missing?)
generally looks ok, but i couldn't edit a manual dhcp
mapping with the error:
vmid: type check ('integer') failed - got ''
did not look too deep so i'm not sure where the empty vmid value
is coming from
also i like alexandres idea to put it into the main tree in the zone
panel as new panel tha
he selection of backup storages namely in:
* backup grid
* "backup now" edit window
* backup job edit window
in the future we could use that to have a 'last used disk image' or
'last used iso' storage too if this approach fits
Signed-off-by: Dominik Csapak
---
th
yes, this fixes setting/loading the inverted modes
it seems i have sent a hunk too much with my followup
thanks for fixing!
Reviewed-by: Dominik Csapak
Tested-by: Dominik Csapak
On 11/20/23 15:53, Fiona Ebner wrote:
The 'not' prefix is already stripped in the set() method o
This is useful for adding the virtio-win iso for new installs, and thus
we change the default disk type to scsi and network type to virtio.
we add special logic to the OSTypeInputPanel when 'insideWizard' is
true to add an additional checkbox + iso selector
Signed-off-by: Domi
and make it into a proper field
it's intended to be used like a single field and exactly as before
Signed-off-by: Dominik Csapak
---
no changes
www/manager6/Makefile| 1 +
www/manager6/form/IsoSelector.js | 107 +++
www/manager6/qemu/CDEd
rwise let the backend decide like before
Signed-off-by: Dominik Csapak
---
this is a follow up to "ui: vm wizard: allow second iso for windows vms":
https://lists.proxmox.com/pipermail/pve-devel/2023-November/060546.html
www/manager6/qemu/CreateWizard.js | 49
Signed-off-by: Dominik Csapak
---
pve-gui.adoc | 1 +
1 file changed, 1 insertion(+)
diff --git a/pve-gui.adoc b/pve-gui.adoc
index bda370f..9e4650d 100644
--- a/pve-gui.adoc
+++ b/pve-gui.adoc
@@ -383,6 +383,7 @@ and the corresponding interfaces for each menu item on the
right
in the tag view, we have a custom 'full' style in a place where we
can have another tagstyle class above. to compensate for that, we have
to add another condition to those styles, namely that there is not the
'proxmox-tags-full' in between.
Signed-off-by: Dominik Csapak
---
this adds a 'tagview' to the web ui, organizing guests by their tags
(for details see the pve-manager patch)
changes from v1:
* rebase on master
* adapt to recent tooltip changes
* add a comment to TagConfig class to better explain what it does
pve-docs:
Dominik Csapak (1):
gui:
the resource store)
since we also don't want tooltips for the already expanded tag groups,
we have to add the special condition that the element directly above
the tag should not have the 'full' class (like it is in tag group case)
Signed-off-by: Dominik Csapak
---
www/manager6/Make
ligned.
Signed-off-by: Dominik Csapak
---
www/manager6/tree/ResourceTree.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/www/manager6/tree/ResourceTree.js
b/www/manager6/tree/ResourceTree.js
index acfa545a..7b2934ae 100644
--- a/www/manager6/tree/ResourceTree.js
+++
e' in the 'changedFields' array, so they get only changed when the
name changes. The text changing from the backend can only happen for
guests anyway and the name field is the correct one for this.
Also change it so that the nodes get their tooltip also when they are
the groupin
the first patch fixes the jumping node text.
the second patch makes tooltips and the generated markup text more
consistent (and should also avoid calling 'setText' in various
circumstances).
the third patch is just a comment cleanup
Dominik Csapak (3):
ui: resource tree: fix nodes t
that function is not only there for the storage indicators, but
generally for adding additional information, such as tags, and for
wrapping in a span for making tooltip selection easier.
Signed-off-by: Dominik Csapak
---
www/manager6/tree/ResourceTree.js | 1 -
1 file changed, 1 deletion
not only when we're in the folder view
Signed-off-by: Dominik Csapak
---
changes from v1:
* split out the node logic
* removed the unnecessary 'setText' calls (they did not do anything in
those cases anyway)
requires the previous patch, otherwise the text for nodes in the serv
correct colors, listen to the 'loadedUiOptions' event and
mark every node changed for the next update cycle.
This way the calls to setText, etc. should be drastically reduced.
Signed-off-by: Dominik Csapak
---
this is a partial replacement for:
https://lists.proxmox.com/pipermail/pve-devel/20
for nested pools we have to provide the pool id via a get parameter
instead of in the path, and also we have to extract the data from the
returned array.
To do this, changet the cbind url handler, remove the autoLoad one,
and handle the load ourselves.
Signed-off-by: Dominik Csapak
---
www
ta from it.
Signed-off-by: Dominik Csapak
---
www/manager6/form/IsoSelector.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/form/IsoSelector.js b/www/manager6/form/IsoSelector.js
index 0bc6346c..408c1fa3 100644
--- a/www/manager6/form/IsoSelector.js
+++ b/www/man
hi, some comment inline
On 12/5/23 16:44, Max Carrara wrote:
This parameter may be used to circumvent calls to `onGetValues`.
Also adds a docstring for the function.
Signed-off-by: Max Carrara
---
src/panel/InputPanel.js | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
high level, i think i'd find it better to put the button next to the
remove button (as you suggested in the cover letter)
my rationale is that the place where the add button is, is a 'neutral'
place without connection to an existing disk, but the copy is an
action related to a specific disk so
translating ACME does not make sense to me since it's
the name of the protocol and stands for
Automatic Certificate Management Environment
i don't think/believe this should be translated
into other languages as a standalone word
rest looks fine to me though
On 11/29/23 14:21, Maximiliano Sando
On 12/6/23 11:21, Maximiliano Sandoval wrote:
Dominik Csapak writes:
translating ACME does not make sense to me since it's
the name of the protocol and stands for
Automatic Certificate Management Environment
i don't think/believe this should be translated
into other lang
On 12/6/23 12:13, Maximiliano Sandoval wrote:
Dominik Csapak writes:
the translator must make sure the terms are consistent anyway...
This is the heart of the issue. The translator cannot know there are
more uses of the string if it is not marked as translatable.
yes he can, because
On 12/6/23 12:20, Fiona Ebner wrote:
Am 06.12.23 um 12:00 schrieb Dominik Csapak:
On 12/6/23 11:21, Maximiliano Sandoval wrote:
Dominik Csapak writes:
translating ACME does not make sense to me since it's
the name of the protocol and stands for
Automatic Certificate Manag
On 12/6/23 15:04, Maximiliano Sandoval wrote:
Dominik Csapak writes:
it's more like DHCP, SLAAC or IPv4. those are names of protocols (like ACME)
that shouldn't change across translations
and we removed those gettexts (mostly) a while ago
e.g. see lxc/Network.js in pve-mana
this has the advantage that the title is now completely visible when the
column is too narrow when expanded, although it is duplicated (since
it's already contained in the non expanded row) even if the original
value may be cutoff.
Signed-off-by: Dominik Csapak
---
not sure about this, be
with this the title is now completely visible when the column is
expanded, even if it's originally too narrow.
Suggested-by: Thomas Lamprecht
Signed-off-by: Dominik Csapak
---
changes from v1:
* wrap the text in the column, instead of duplicating it in the expanded
body
thanks @thoma
and other
browsers.
Signed-off-by: Dominik Csapak
---
xterm.js/src/main.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xterm.js/src/main.js b/xterm.js/src/main.js
index 1575697..289032c 100644
--- a/xterm.js/src/main.js
+++ b/xterm.js/src/main.js
@@ -99,7 +99,6 @@
classes by removing the overrides
(i couldn't find where we would need those)
we still cannot handle u2f or recovery methods though
Signed-off-by: Dominik Csapak
---
www/mobile/Login.js | 8 ++--
www/mobile/Toolkit.js | 5 -
2 files changed, 6 insertions(+), 7 deletions(-)
diff --
not sure if this was lost at some point or never implemented, but we
want to be consistent with the remaining web ui and apps, so show
the subscription popup here too.
Signed-off-by: Dominik Csapak
---
www/mobile/Workspace.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/www/mobile
On 1/12/24 21:08, Alexandre Derumier wrote:
New epyc cpu already support 168 threads
qemu 8.1 support 1024 cores with q35
---
www/manager6/qemu/ProcessorEdit.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/qemu/ProcessorEdit.js
b/www/manager6/qemu/Processo
On 2/19/24 14:57, Thomas Lamprecht wrote:
Am 07/12/2023 um 14:35 schrieb Dominik Csapak:
with this the title is now completely visible when the column is
expanded, even if it's originally too narrow.
Suggested-by: Thomas Lamprecht
Signed-off-by: Dominik Csapak
---
changes from v1:
* wra
On 2/16/24 15:42, Fiona Ebner wrote:
No real issues found during testing, but there is one thing that bugs
me: if I have selected a guest either:
- without tags and add a tag
or
- within the current tag group and remove that tag
then the selections for the guest is lost. Since it's the selectio
On 2/18/24 09:32, Jackson Pfeffer via pve-devel wrote:
Hello,
Hi, sorry for the late answer. I'll try to answer your points
as good as possible, but just ask if you have any concrete questions
left.
As a newcomer to the Proxmox VE community, I'd love to contribute. Being
new I would appreci
l of them simultaneously
0:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/setFullYear
Signed-off-by: Dominik Csapak
---
src/form/DateTimeField.js | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/form/DateTimeField.js b/src/form/DateTimeField
The `_ZFS_over_iSCSI` wiki page is redirected to the legacy page
(for historical reasons), but we want to link to the reference docs
instead.
for the wiki add the legacy link in a `see also` section, so users can
still reach that page easily should they need to
Signed-off-by: Dominik Csapak
can clean it up in the meantime.
Further, add a bit of logging, so we can properly see in the (task) log
what is happening when.
Fixes: 49c51a60 (pci: workaround nvidia driver issue on mdev cleanup)
Signed-off-by: Dominik Csapak
---
PVE/CLI/qm.pm | 3 ++-
PVE/QemuServer.pm | 16 ++
'$entry->{host}' can be empty, so we have to check for that before
doing a regex check, otherwise we get ugly errors in the log
Signed-off-by: Dominik Csapak
---
PVE/QemuServer.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuSe
the default is 'auto', but for those which are marked as capable for
live migration, we want to explicitly enable that, so we get an early
error on start if the driver does not support that.
Signed-off-by: Dominik Csapak
---
PVE/QemuServer/PCI.pm | 8 +++-
1 file changed, 7 insert
Signed-off-by: Dominik Csapak
---
qm.adoc | 6 ++
1 file changed, 6 insertions(+)
diff --git a/qm.adoc b/qm.adoc
index c146ce9..c77cb7b 100644
--- a/qm.adoc
+++ b/qm.adoc
@@ -1746,6 +1746,12 @@ Currently there are the following options:
the mapping, the mediated device will be create on
They have to be marked as 'live-migration-capable' in the mapping
config, and the driver and qemu must support it.
For the gui checks, we now return a list of 'mapped-with-live-migration'
entries in the migration preflight api call too.
Signed-off-by: Dominik Csapak
---
PVE
in a new section about additional options
Signed-off-by: Dominik Csapak
---
qm.adoc | 13 +
1 file changed, 13 insertions(+)
diff --git a/qm.adoc b/qm.adoc
index 1170dd1..c146ce9 100644
--- a/qm.adoc
+++ b/qm.adoc
@@ -1734,6 +1734,19 @@ To create mappings `Mapping.Modify` on
if the hardware/driver is capable, the admin can now mark a pci device
as 'live-migration-capable', which then tries enabling live migration
for such devices.
mark it as experimental when configuring and in the migrate window
Signed-off-by: Dominik Csapak
---
www/manager6/window/
this is useful to get to the config without having to parse it again
Signed-off-by: Dominik Csapak
---
src/PVE/Mapping/PCI.pm | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/PVE/Mapping/PCI.pm b/src/PVE/Mapping/PCI.pm
index 0866175..9d8a4a7 100644
--- a/src/PVE
so that we can decide in qemu-server to allow live-migration.
the driver and qemu must be capable of that, and it's the
admins responsibility to know and configure that
Mark the option as experimental in the description.
Signed-off-by: Dominik Csapak
---
src/PVE/Mapping/PCI.pm | 9 +++
testing and can be applied independently
pve-guest-common:
Dominik Csapak (2):
mapping: pci: add 'live-migration-capable' flag to mappings
mapping: pci: optionally return the config in 'find_on_current_node'
src/PVE/Mapping/PCI.pm | 16 +++++---
1 file changed, 13
such as the mapping name and if it's marked for live-migration (pci only)
Signed-off-by: Dominik Csapak
---
PVE/API2/Qemu.pm | 2 +-
PVE/QemuMigrate.pm | 5 +++--
PVE/QemuServer.pm | 10 ++
3 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE
Target that is delted when the loading is done, and only trigger
the masking if this marker is still there. (thankfully javascript is
single threaded so this should not end up being a data race)
Signed-off-by: Dominik Csapak
---
sending as RFC because i'm unsure if we accidentally broke the mask
On 3/18/24 16:50, Thomas Lamprecht wrote:
On 18/03/2024 14:44, Dominik Csapak wrote:
since some time (not sure when exactly), the 'load()' method of the edit
window did not correctly mask the window anymore
the reason seems to be that the API2Request tries to mask the component
b
sending as RFC because i'm unsure if we accidentally broke the masking
somewhere along the way. AFAICS from the current code, this never could have
worked properly? anyway, i'll be looking into that sometimes soon, and
this patch should be correct anyway...
it surely did sometimes in the past
oads, and only
ever unmask the component when the counter reaches zero again.
Since we're strictly in non-async code here and javascript is
single-threaded, this should not result in a data race.
Signed-off-by: Dominik Csapak
---
changes from v1:
* use a counter for all loads instead of a u
we cannot import the state of the efivars (e.g. boot order)
so add a warning for that
Signed-off-by: Dominik Csapak
---
src/PVE/Storage/ESXiPlugin.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage/ESXiPlugin.pm
index 3f47577..e448760 100644
and add a link to recreate the boot entries in ovmf
Signed-off-by: Dominik Csapak
---
www/manager6/window/GuestImport.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/manager6/window/GuestImport.js
b/www/manager6/window/GuestImport.js
index 297e2198..83288dad 100644
--- a/www
some sensible improvements for the guest import
pve-storage:
Dominik Csapak (2):
esxi: add warning for losing efi state
esxi: only add scsihw if it's defined
src/PVE/Storage/ESXiPlugin.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
pve-manager:
Dominik Csapak (4):
ui:
otherwise we get `scsihw: null` from the api, which is not a valid
value, so just omit it.
Signed-off-by: Dominik Csapak
---
src/PVE/Storage/ESXiPlugin.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage/ESXiPlugin.pm
index
while most of our 'windiows' ostypes start with 'win' not all of them do
(wxp, wvista), so just shorten the condition to 'starts with `w`', this
covers all our windows ostypes, while not including others.
Signed-off-by: Dominik Csapak
---
www/manager6/window/Gue
it seems on esxi, most windows vms with uefi are automatically
configured with an lsi scsi controller, which we can't currently support
(ovmf driver issue) so automatically activate the sata mapping + virtio
preparation in this case
Signed-off-by: Dominik Csapak
---
www/manager6/w
we have to set it to '__default__' if we didn't get one from the api
Signed-off-by: Dominik Csapak
---
www/manager6/window/GuestImport.js | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/www/manager6/window/GuestImport.js
b/www/manager6/window/Guest
tpmstate0 is already included in `get_vm_volumes`, and our only storage
plugin that has unmap_volume implemented is the RBDPlugin, where we call
unmap in `deactivate_volume`. So it's already ummapped by the
`deactivate_volumes` calls above.
Signed-off-by: Dominik Csapak
---
PVE/QemuServ
-off-by: Dominik Csapak
---
PVE/QemuMigrate.pm | 12 ++--
PVE/QemuServer.pm | 12 ++--
2 files changed, 16 insertions(+), 8 deletions(-)
diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm
index b3570770..1be12bf1 100644
--- a/PVE/QemuMigrate.pm
+++ b/PVE/QemuMigrate.pm
@@ -5,6
we now return the 'not_allowed_nodes' also if the vm is running, when it
has mapped resources. So do that checks independently so that the
user has instant feedback where those resources exist.
Signed-off-by: Dominik Csapak
---
www/manager6/window/Migrate.js | 24 -
exist on the target node.
This now also includes unavailable storages on target nodes.
Signed-off-by: Dominik Csapak
---
PVE/API2/Nodes.pm | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
index cc5ee65e..1d5c68f5 100644
---
101 - 200 of 2437 matches
Mail list logo
