[pve-devel] [RFC pve-container] backup: do not delete not backed-up mps on restore

2023-10-17 Thread Christian Ebner
archive for each individual mountpoint, while remaining backwards compatible. Signed-off-by: Christian Ebner --- I'm sending this as RFC since backwards compatibility for restore still suffers from the fact, that mountpoints are now expected to have their corresponding pxar archive for PBS ba

[pve-devel] [RFC v2 pve-container pve-manager 2/3] api: allow to exclude mountpoins from restore

2023-10-23 Thread Christian Ebner
Adds an optional parameter which allows to specify the names of mountpoints which should be excluded from restore. These mountpoints are not (re-)created and files located below the mountpoint are not restored from backup. Signed-off-by: Christian Ebner --- changes since v1: not present in

[pve-devel] [RFC v2 pve-container pve-manager 0/3] add partial restore

2023-10-23 Thread Christian Ebner
. Restore of the files is than handled directly from the main root.pxar archive. Any feedback is highly appreciated. pve-container: Christian Ebner (2): backup: do not delete not backed-up mps on restore api: allow to exclude mountpoins from restore src/PVE/API2/LXC.pm | 44

[pve-devel] [RFC v2 pve-container pve-manager 3/3] ui: lxc restore: add selective mountpoint restore

2023-10-23 Thread Christian Ebner
Adds a grid to the lxc backup restore window allowing the user to select mountpoints which should be included/excluded from a restore. Signed-off-by: Christian Ebner --- changes since v1: not present in v1 www/manager6/Makefile | 1 + www/manager6/grid

[pve-devel] [RFC v2 pve-container pve-manager 1/3] backup: do not delete not backed-up mps on restore

2023-10-23 Thread Christian Ebner
archive for each individual mountpoint, while remaining backwards compatible. Signed-off-by: Christian Ebner --- changes since v1: - deep clone of orig_mp_param, otherwise the variable points to the same data. - refactor restore_archive params src/PVE/API2/LXC.pm | 34 +++- src

Re: [pve-devel] [RFC pve-container] backup: do not delete not backed-up mps on restore

2023-10-23 Thread Christian Ebner
There is an newer version of the patch, see https://lists.proxmox.com/pipermail/pve-devel/2023-October/059566.html Please ignore this one. > On 17.10.2023 14:38 CEST Christian Ebner wrote: > > > The current behaviour of the restore is to recreate all backed up > mountpoints

Re: [pve-devel] [RFC v2 pve-container pve-manager 0/3] add partial restore

2023-10-23 Thread Christian Ebner
3:18 schrieb Christian Ebner: > > This patch series adds functionality to partially restore containers > > from backup, by allowing the user to selectively include/exclude > > mountpoints for restore. Mountpoints not included in the backup will not > > be deleted and recreated but

Re: [pve-devel] [PATCH v2 proxmox-widget-toolkit manager pmg-gui 0/4] #4442: impl firewall log filtering

2023-11-09 Thread Christian Ebner
Ping, still applies > On 09.08.2023 12:55 CEST Christian Ebner wrote: > > > This series is send to pmg-devel and pve-devel list, as it changes the > DateTimeField used by Proxmox Virtual Environment and Proxmox Mail > Gateway. > > This series of patches implements fun

[pve-devel] [PATCH pve-container pve-manager 0/2] add config option for metadata based PBS backup

2023-11-15 Thread Christian Ebner
Christian Ebner (1): lxc: options: add PBS change detecion mode selector www/manager6/lxc/Options.js | 19 +++ 1 file changed, 19 insertions(+) -- 2.39.2 ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com

[pve-devel] [PATCH pve-container 1/2] config: backup: add PBS change detection mode

2023-11-15 Thread Christian Ebner
Adds the config option to switch from regular to metadata based change detection mode when using PBS as backend. Signed-off-by: Christian Ebner --- src/PVE/LXC/Config.pm | 7 +++ src/PVE/VZDump/LXC.pm | 5 + 2 files changed, 12 insertions(+) diff --git a/src/PVE/LXC/Config.pm b/src/PVE

[pve-devel] [PATCH pve-manager 2/2] lxc: options: add PBS change detecion mode selector

2023-11-15 Thread Christian Ebner
Add selector to switch between default and metadata based change detection mode for backups using PBS as backend. Signed-off-by: Christian Ebner --- www/manager6/lxc/Options.js | 19 +++ 1 file changed, 19 insertions(+) diff --git a/www/manager6/lxc/Options.js b/www/manager6

Re: [pve-devel] [PATCH storage v2 2/4] pbs: Make it possible to reuse PBS connection for datastore API call

2023-11-16 Thread Christian Ebner
> On 15.11.2023 17:00 CET Philipp Hufnagl wrote: > > > It would be nice to reuse an existing PBS connection for scan_datastore. > Because scan_datastore is used multiple in the code, it can not be > canged without breaking existing code. Typo s/canged/changed. > > This change add an optio

Re: [pve-devel] [PATCH storage v2 3/4] pbs: Extraxt check_datastore_exists from activate_storage

2023-11-16 Thread Christian Ebner
Typi in heading s/Extraxt/Extract, maybe call it factor out instead. > On 15.11.2023 17:00 CET Philipp Hufnagl wrote: > > > Parts contained in activate_storage are needed to be run to fix #5008, > however, implementing a namespace check there would cause unneded > overhead. Typo s/unneded/unn

Re: [pve-devel] [PATCH storage v2 4/4] pbs: fix #5008: Check if datastore and namespace is valid on add- and update hooks

2023-11-16 Thread Christian Ebner
> On 15.11.2023 17:00 CET Philipp Hufnagl wrote: > > > This adds a check if the datastore and the namespace is valid when a > user attempts to add a new PBS datastore. > > Since the namespace only can be checked after the datastore is > validated, the datastore will be checked as well, regar

[pve-devel] [PATCH proxmox-i18n] update Italian translation

2023-11-20 Thread Christian Ebner
Signed-off-by: Christian Ebner --- it.po | 556 -- 1 file changed, 187 insertions(+), 369 deletions(-) diff --git a/it.po b/it.po index ca149df..6ae242d 100644 --- a/it.po +++ b/it.po @@ -96,9 +96,8 @@ msgid "API Data" msgstr &q

[pve-devel] [PATCH pve-manager] ui: node summary: use SI units for HD usage

2023-11-21 Thread Christian Ebner
SI units are used for storage size information, as typically used by hard disk manufacturers. Change the root filesystem usage values in the node summary to be consistent. Signed-off-by: Christian Ebner --- www/manager6/node/StatusView.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion

Re: [pve-devel] [PATCH pve-manager] ui: node summary: use SI units for HD usage

2023-11-21 Thread Christian Ebner
> On 21.11.2023 11:05 CET Fiona Ebner wrote: > > > Am 21.11.23 um 10:00 schrieb Christian Ebner: > > diff --git a/www/manager6/node/StatusView.js > > b/www/manager6/node/StatusView.js > > index d34724f7..a6975b6e 100644 > > --- a/www/manager6/node/Statu

Re: [pve-devel] [PATCH pve-manager] ui: node summary: use SI units for HD usage

2023-11-21 Thread Christian Ebner
> On 21.11.2023 12:03 CET Christian Ebner wrote: > > > > On 21.11.2023 11:05 CET Fiona Ebner wrote: > > > > > > Am 21.11.23 um 10:00 schrieb Christian Ebner: > > > diff --git a/www/manager6/node/StatusView.js > > > b/www/manager6/node/

[pve-devel] [PATCH v2 pve-manager] ui: node summary: use SI units for HD usage

2023-11-21 Thread Christian Ebner
SI units are used for storage size information, as typically used by hard disk manufacturers. Change the root filesystem usage values in the node summary to be consistent. Signed-off-by: Christian Ebner --- Will also send a patch for PMG to be consistent across all of them. changes since v1

Re: [pve-devel] [PATCH storage v3 0/4] pbs: fix #5008: Prevent adding pbs storage with invalid namespace

2023-11-21 Thread Christian Ebner
> On 16.11.2023 11:35 CET Philipp Hufnagl wrote: > > > Currently, when adding a PBS storage with a namespace that does not > exist, the storage gets added normally, but browsing/using it only > returns a cryptic error message. > > This change checks if the namespace entered when adding is vali

Re: [pve-devel] [PATCH storage v3 0/4] pbs: fix #5008: Prevent adding pbs storage with invalid namespace

2023-11-21 Thread Christian Ebner
> On 21.11.2023 14:12 CET Philipp Hufnagl wrote: > > > Hmmm... thats very curios. I tried that on my end and it worked fine. > > What datastore did you try to delete? Did you have a valid > configuration for it? Not deleting a datastore (that works fine), I was testing if I am able to deact

[pve-devel] [PATCH pve-docs] pvesdn: remove double occurrence of 'external'

2023-11-22 Thread Christian Ebner
Signed-off-by: Christian Ebner --- pvesdn.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pvesdn.adoc b/pvesdn.adoc index 5d87d09..f362da4 100644 --- a/pvesdn.adoc +++ b/pvesdn.adoc @@ -423,7 +423,7 @@ Controllers --- Some zones implement a separated control

[pve-devel] [PATCH pve-docs] pvesdn: Fix heading for NetBox IPAM plugin section

2023-11-22 Thread Christian Ebner
Signed-off-by: Christian Ebner --- pvesdn.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pvesdn.adoc b/pvesdn.adoc index f362da4..fdc6ea7 100644 --- a/pvesdn.adoc +++ b/pvesdn.adoc @@ -538,7 +538,7 @@ stack of the guest or rebooting it. [[pvesdn_ipam_plugin_netbox

[pve-devel] [PATCH pve-manager] ui: sdn: use all upper case for acronyms

2023-11-22 Thread Christian Ebner
Signed-off-by: Christian Ebner --- www/manager6/sdn/ZoneView.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/www/manager6/sdn/ZoneView.js b/www/manager6/sdn/ZoneView.js index 71890dd3..67e86e16 100644 --- a/www/manager6/sdn/ZoneView.js +++ b/www/manager6/sdn

[pve-devel] [PATCH pve-manager] ui: lxc: add firewall log view filtering

2023-12-05 Thread Christian Ebner
Allow to filter firewall logs analogous to node and VM firewall logs. Signed-off-by: Christian Ebner --- www/manager6/lxc/Config.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/www/manager6/lxc/Config.js b/www/manager6/lxc/Config.js index 4516ee8f..8ef66f39 100644 --- a/www/manager6

[pve-devel] [PATCH pve-docs] notifications: fix typos and improve reading flow

2024-01-10 Thread Christian Ebner
Signed-off-by: Christian Ebner --- notifications.adoc | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/notifications.adoc b/notifications.adoc index cddb8ca..9be23f8 100644 --- a/notifications.adoc +++ b/notifications.adoc @@ -172,11 +172,11 @@ Notification Matchers

Re: [pve-devel] [PATCH pve-docs] notifications: fix typos and improve reading flow

2024-01-10 Thread Christian Ebner
> On 10.01.2024 14:37 CET Lukas Wagner wrote: > > > On 1/10/24 14:14, Christian Ebner wrote: > > Signed-off-by: Christian Ebner > > --- > > notifications.adoc | 10 +- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff

[pve-devel] [PATCH v2 pve-docs] notifications: fix typos and improve reading flow

2024-01-10 Thread Christian Ebner
Signed-off-by: Christian Ebner --- changes since v1: - fix an additional typo spotted Lukas notifications.adoc | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/notifications.adoc b/notifications.adoc index cddb8ca..46aff6a 100644 --- a/notifications.adoc +++ b

[pve-devel] [PATCH proxmox stable-2 2/2] apt: repos: Remove unneeded unwrap for codename variant

2024-02-05 Thread Christian Ebner
://forum.proxmox.com/threads/141004/ Signed-off-by: Christian Ebner --- proxmox-apt/src/repositories/mod.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/proxmox-apt/src/repositories/mod.rs b/proxmox-apt/src/repositories/mod.rs index 6588b90..ccb49cd 100644 --- a/proxmox-apt

Re: [pve-devel] [PATCH proxmox master stable-2 1/2] apt: repos: extend `Codename` by `Unknown` variant

2024-02-06 Thread Christian Ebner
> > > > -if Some(codename) == current_codename.next() { > > -add_info("ignore-pre-upgrade-warning", > > message_new(base_suite)); > > -} else if codename > current_codename { > > -add_info("warning", message_new(base_suite

Re: [pve-devel] [PATCH proxmox master stable-2 1/2] apt: repos: extend `Codename` by `Unknown` variant

2024-02-06 Thread Christian Ebner
> You only match the current codename and DebianCodename::Unknown(_, _). > Any known newer codename will just fall through to the default arm (and > the default arm can/should be avoided by pulling in the check for the > older codename from above). Ah now I see, thanks for noticing and for clarifi

[pve-devel] [PATCH v2 proxmox stable-2 2/2] apt: repos: Remove unneeded unwrap for codename variant

2024-02-06 Thread Christian Ebner
://forum.proxmox.com/threads/141004/ Signed-off-by: Christian Ebner --- Changes since v1: - No changes proxmox-apt/src/repositories/mod.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/proxmox-apt/src/repositories/mod.rs b/proxmox-apt/src/repositories/mod.rs index 6588b90

[pve-devel] [PATCH proxmox-i18n] update Italian translations

2024-02-27 Thread Christian Ebner
Signed-off-by: Christian Ebner --- it.po | 1028 - 1 file changed, 351 insertions(+), 677 deletions(-) diff --git a/it.po b/it.po index 40d0c7f..e073711 100644 --- a/it.po +++ b/it.po @@ -323,9 +323,8 @@ msgid "Add Remote&quo

Re: [pve-devel] [PATCH pve-manager] ui: lxc: add firewall log view filtering

2024-03-05 Thread Christian Ebner
ping, still applies! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager 1/3] fix #5255: node: wol: add optional bind interface

2024-03-05 Thread Christian Ebner
Allows to optionally configure a local interface name to which to bind to when sending a wake on lan packet to wake a remote node. Default behaviour remains to send the packet via the interface for the default gateway. Signed-off-by: Christian Ebner --- PVE/API2/Nodes.pm | 13

[pve-devel] [PATCH docs 3/3] pvenode/wake-on-lan: mention optional config options

2024-03-05 Thread Christian Ebner
Show how to configure the optional bind interface and broadcast address options via `pvenode`. Signed-off-by: Christian Ebner --- pvenode.adoc | 14 ++ 1 file changed, 14 insertions(+) diff --git a/pvenode.adoc b/pvenode.adoc index 59eeecb..8a1da08 100644 --- a/pvenode.adoc +++ b

[pve-devel] [PATCH manager 2/3] fix #5255: node: wol: configurable broadcast address

2024-03-05 Thread Christian Ebner
Allows to configure a custom broadcast address to use when sending a wake on lan packet to wake a remote node. Default behaviour remains to fallback to 255.255.255.255. Signed-off-by: Christian Ebner --- PVE/API2/Nodes.pm | 3 ++- PVE/NodeConfig.pm | 6 ++ 2 files changed, 8 insertions

[pve-devel] [PATCH manager docs 0/3] add optional WoL config options

2024-03-05 Thread Christian Ebner
`. See also the thread in the community forum https://forum.proxmox.com/threads/123459/ pve-manager: Christian Ebner (2): fix #5255: node: wol: add optional bind interface fix #5255: node: wol: configurable broadcast address PVE/API2/Nodes.pm | 16 ++-- PVE/NodeConfig.pm | 12

Re: [pve-devel] [PATCH manager 1/3] fix #5255: node: wol: add optional bind interface

2024-03-22 Thread Christian Ebner
> On 21.03.2024 18:27 CET Thomas Lamprecht wrote: > > > On 05/03/2024 13:54, Christian Ebner wrote: > > +'wakeonlan-bind-interface' => { > > + type => 'string', > > + description => 'Bind to this interfac

[pve-devel] [PATCH v2 pve-manager 1/4] node: config: make wakeonlan a property string

2024-03-26 Thread Christian Ebner
. Signed-off-by: Christian Ebner --- changes since version 1: - not present in previous version PVE/API2/Nodes.pm | 6 -- PVE/NodeConfig.pm | 39 +-- 2 files changed, 37 insertions(+), 8 deletions(-) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index

[pve-devel] [PATCH v2 pve-manager pve-docs 0/4] add optional WoL config options

2024-03-26 Thread Christian Ebner
XX:XX:XX:XX:XX:XX,broadcast-address=`. See also the thread in the community forum https://forum.proxmox.com/threads/123459/ pve-manager: Christian Ebner (3): node: config: make wakeonlan a property string fix #5255: node: wol: add optional bind interface fix #5255: node: wol: configurable

[pve-devel] [PATCH v2 pve-manager 2/4] fix #5255: node: wol: add optional bind interface

2024-03-26 Thread Christian Ebner
Allows to optionally configure a local interface name to which to bind to when sending a wake on lan packet to wake a remote node. Default behaviour remains to send the packet via the interface for the default gateway. Signed-off-by: Christian Ebner --- changes since version 1: - Adapted to use

[pve-devel] [PATCH v2 pve-manager 3/4] fix #5255: node: wol: configurable broadcast address

2024-03-26 Thread Christian Ebner
Allows to configure a custom broadcast address to use when sending a wake on lan packet to wake a remote node. Default behaviour remains to fallback to 255.255.255.255. Signed-off-by: Christian Ebner --- changes since version 1: - Adapted to use property string PVE/API2/Nodes.pm | 3 ++- PVE

[pve-devel] [PATCH v2 pve-docs 4/4] pvenode/wake-on-lan: mention optional config options

2024-03-26 Thread Christian Ebner
Show how to configure the optional bind interface and broadcast address options via `pvenode`. Signed-off-by: Christian Ebner --- pvenode.adoc | 14 ++ 1 file changed, 14 insertions(+) diff --git a/pvenode.adoc b/pvenode.adoc index 59eeecb..6cf5bc9 100644 --- a/pvenode.adoc +++ b

Re: [pve-devel] [PATCH manager 1/3] fix #5255: node: wol: add optional bind interface

2024-03-26 Thread Christian Ebner
> On 22.03.2024 15:37 CET Christian Ebner wrote: > > Agreed, will send a new version with the suggested changes to the format > string. Version 2 of the patches: https://lists.proxmox.com/pipermail/pve-devel/2024-March/062397.html _

Re: [pve-devel] applied-series: [PATCH v2 pve-manager pve-docs 0/4] add optional WoL config options

2024-03-29 Thread Christian Ebner
On 3/28/24 18:27, Thomas Lamprecht wrote: applied, thanks! I did some very minor follow-ups mostly to document the current default in the schema and docs and a small style fix (well not even really style wise, but rather making the part with assigning and checking the $bind_interface variable s

[pve-devel] [PATCH pve-manager] ui: node: extend option editor for wake on lan

2024-04-03 Thread Christian Ebner
editor component. The editor is used for the wake on lan record of the grid only, by adding the `handle_editor` function, to calls the required editor based on the selected record of the grid. Signed-off-by: Christian Ebner --- www/manager6/node/NodeOptionsView.js | 87

[pve-devel] [RFC common 0/1] Optional parameters `since` and `until` for firewall log filtering

2023-01-05 Thread Christian Ebner
given. Without optional parameters, `dump_logfile` is used. Christian Ebner (1): tools: Add specialized `dump_fw_logfile` for `since` and `until` filtering of firewall logs src/PVE/Tools.pm | 80 1 file changed, 80 insertions(+) Christian

[pve-devel] [RFC firewall] api: Add optional parameters `since` and `until` for timestamp filter

2023-01-05 Thread Christian Ebner
introduced in the PVE::Tools, with fallback to the previous `dump_logfile` function if none of the parameters is present. This patch depends on the corresponding patch in the pve-common repository. Signed-off-by: Christian Ebner --- src/PVE/API2/Firewall/Host.pm | 15 ++- src/PVE/API2

[pve-devel] [RFC common 1/1] tools: Add specialized `dump_fw_logfile` for `since` and `until` filtering of firewall logs

2023-01-05 Thread Christian Ebner
This furhter includes the contents of rotated logfiles if present. All files are scanned in sequential order, as there is no guarantee that the rotated logs contain only entries for a single day. Signed-off-by: Christian Ebner --- src/PVE/Tools.pm | 80

Re: [pve-devel] [RFC common 1/1] tools: Add specialized `dump_fw_logfile` for `since` and `until` filtering of firewall logs

2023-01-05 Thread Christian Ebner
Okay, I will adapt the code based on your comments. Thx! > On 05.01.2023 14:25 CET Wolfgang Bumiller wrote: > > > On Thu, Jan 05, 2023 at 10:18:04AM +0100, Christian Ebner wrote: > > This furhter includes the contents of rotated logfiles if present. All > &

Re: [pve-devel] [RFC firewall] api: Add optional parameters `since` and `until` for timestamp filter

2023-01-05 Thread Christian Ebner
Okay, I will take your comments into consideration, thx! > On 05.01.2023 14:59 CET Thomas Lamprecht wrote: > > > Am 05/01/2023 um 14:51 schrieb Fiona Ebner: > >> + my($count, $lines) = > >> PVE::Tools::dump_fw_logfile("/var/log/pve-firewall.log", > >> + $param->{start}, $param->{lim

[pve-devel] [PATCH common firewall] Optonal `since` and `until` firewall log filtering

2023-01-09 Thread Christian Ebner
since RFC version: - common: Use callback function filter instead of `since` `until` params - common: code reuse for `dump_logfile` and `dump_fw_logfile` - firewall: Style fixes and use of callback function common: Christian Ebner (1): tools: Add callback based filtering for firewall

[pve-devel] [PATCH firewall 1/1] api: Add optional parameters `since` and `until` for timestamp filter

2023-01-09 Thread Christian Ebner
the corresponding patch in the pve-common repository. Signed-off-by: Christian Ebner --- src/PVE/API2/Firewall/Host.pm | 34 - src/PVE/API2/Firewall/VM.pm | 40 +++ 2 files changed, 69 insertions(+), 5 deletions(-) diff --git a/src/PVE

[pve-devel] [PATCH common 1/1] tools: Add callback based filtering for firewall logfiles

2023-01-09 Thread Christian Ebner
This patch introduces callback based filtering functionality for firewall logs. In addition, the contents of rotated logfiles are included by setting the `include_rotated_logs` flag. Signed-off-by: Christian Ebner --- src/PVE/Tools.pm | 108 +++ 1

Re: [pve-devel] [PATCH common 1/1] tools: Add callback based filtering for firewall logfiles

2023-01-11 Thread Christian Ebner
Thank you for the detailed review Wolfgang, I am still unsure about one of your comments, see below. Maybe you could clarify. Thx. > On 10.01.2023 13:36 CET Wolfgang Bumiller wrote: > > > On Mon, Jan 09, 2023 at 04:07:06PM +0100, Christian Ebner wrote: > > This patch i

[pve-devel] [PATCH v2 common 1/1] tools: Add callback based filtering for logfile dump

2023-01-11 Thread Christian Ebner
-by: Christian Ebner --- src/PVE/Tools.pm | 59 +++- 1 file changed, 38 insertions(+), 21 deletions(-) diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm index cdbee6d..d933503 100644 --- a/src/PVE/Tools.pm +++ b/src/PVE/Tools.pm @@ -1265,29 +1265,25

[pve-devel] [PATCH v2 common firewall] Optonal `since` and `until` firewall log filtering

2023-01-11 Thread Christian Ebner
. - firewall: Avoid error if opening logfile failes with ENOENT - Whitespace cleanup common: Christian Ebner (1): tools: Add callback based filtering for logfile dump src/PVE/Tools.pm | 59 +++- 1 file changed, 38 insertions(+), 21 deletions

[pve-devel] [PATCH v2 firewall 1/1] api: Add optional parameters `since` and `until` for timestamp filter

2023-01-11 Thread Christian Ebner
function passed to `dump_fw_logfile`. This patch depends on the corresponding patch in the pve-common repository. Signed-off-by: Christian Ebner --- src/PVE/API2/Firewall/Host.pm | 34 +++- src/PVE/API2/Firewall/VM.pm | 40 +--- src/PVE/Firewall/Helpers.pm | 59

Re: [pve-devel] [PATCH v2 firewall 1/1] api: Add optional parameters `since` and `until` for timestamp filter

2023-01-18 Thread Christian Ebner
> On 18.01.2023 11:33 CET Wolfgang Bumiller wrote: > > > On Wed, Jan 11, 2023 at 02:32:19PM +0100, Christian Ebner wrote: > > The optional unix epoch timestamps parameters `since` and `until` are > > introduced > > in order to filter firewall logs files. If o

[pve-devel] [PATCH v3 firewall 0/1] Optional `since` and `until` firewall log filtering

2023-01-19 Thread Christian Ebner
Changes since v2: - use `qr//` syntax for regex in filter callback - deduplicate code by moving common filter logic to `dump_fw_logfile` - Fix off by one error in `filecount` for finding final file Christian Ebner (1): api: Add optional parameters `since` and `until` for timestamp filter src

[pve-devel] [PATCH v3 firewall 1/1] api: Add optional parameters `since` and `until` for timestamp filter

2023-01-19 Thread Christian Ebner
function passed to `dump_fw_logfile`. This patch depends on the corresponding patch in the pve-common repository. Signed-off-by: Christian Ebner --- src/PVE/API2/Firewall/Host.pm | 16 ++- src/PVE/API2/Firewall/VM.pm | 26 ++-- src/PVE/Firewall/Helpers.pm | 78

[pve-devel] [RFC manager 1/1] fix #4442: node/qemu: Use firewallLogView panel for firewall logs

2023-01-30 Thread Christian Ebner
Using the firewall log view panel allows to filter not only by date, but also by time (up to minute precision). Signed-off-by: Christian Ebner --- www/manager6/node/Config.js | 5 +++-- www/manager6/qemu/Config.js | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/www

[pve-devel] [RFC widget-toolkit 0/2] fix #4442: Firewall log filtering

2023-01-30 Thread Christian Ebner
, especially regarding the still incorrect update of min/max values of the date and time fields on changes of the other one are highly appreciated. proxmox-widget-toolkit: Christian Ebner (2): DateTimeField: Extend and refactor to make field value bindable fix #4442: panel: Add firewall log view panel

[pve-devel] [RFC widget-toolkit 1/2] DateTimeField: Extend and refactor to make field value bindable

2023-01-30 Thread Christian Ebner
Extends the date time field so that bindings are updated on value changes. Also adds a config to disable child components and avoid modification of current values by cloning the referenced object for min/max value calculation. Signed-off-by: Christian Ebner --- src/form/DateTimeField.js | 104

[pve-devel] [RFC widget-toolkit 2/2] fix #4442: panel: Add firewall log view panel

2023-01-30 Thread Christian Ebner
Adds a custom firewall log view panel, based on the existing log view panel. The firewall log view panel is extended to include `since` and `until` filters with date and time filtering, in contrast to the date only filtering for the log view panel. Signed-off-by: Christian Ebner --- src

[pve-devel] [PATCH storage] api: fix get content call for volumes

2023-03-06 Thread Christian Ebner
`, the latter also being a non-optional return value for the api call. The issue was reported in the forum: https://forum.proxmox.com/threads/pvesh-get-nodes-node-storage-storage-content-volume-returns-error.123747/ Signed-off-by: Christian Ebner --- PVE/API2/Storage/Content.pm | 2 +- PVE

Re: [pve-devel] [PATCH storage] api: fix get content call for volumes

2023-03-06 Thread Christian Ebner
> On 06.03.2023 11:17 CET Fiona Ebner wrote: > > > Am 06.03.23 um 10:37 schrieb Christian Ebner: > > `pvesh get /nodes/{node}/storage/{storage}/content/{volume}` failed for > > several storage types, because the respective storage plugins returned > &

Re: [pve-devel] [PATCH storage] api: fix get content call for volumes

2023-03-06 Thread Christian Ebner
> On 06.03.2023 11:52 CET Fiona Ebner wrote: > > > Am 06.03.23 um 11:36 schrieb Christian Ebner: > > > >> On 06.03.2023 11:17 CET Fiona Ebner wrote: > >> > >> > >> Am 06.03.23 um 10:37 schrieb Christian Ebner: > >>> `pves

[pve-devel] [PATCH v2 storage] api: fix get content call for volumes

2023-03-06 Thread Christian Ebner
possible `used`. The issue was reported in the forum: https://forum.proxmox.com/threads/pvesh-get-nodes-node-storage-storage-content-volume-returns-error.123747/ Signed-off-by: Christian Ebner --- Changes since v1: * Remove errous check for $used being set, rely on fallback to 0 if undef

Re: [pve-devel] [PATCH v2 storage] api: fix get content call for volumes

2023-03-07 Thread Christian Ebner
> On 07.03.2023 09:51 CET Fabian Grünbichler wrote: > > > On March 7, 2023 9:31 am, Fiona Ebner wrote: > > Am 06.03.23 um 14:07 schrieb Christian Ebner: > >> `pvesh get /nodes/{node}/storage/{storage}/content/{volume}` failed for > >> several storage t

[pve-devel] [PATCH v3 storage] api: fix get content call for volumes

2023-03-09 Thread Christian Ebner
possible `used`. The issue was reported in the forum: https://forum.proxmox.com/threads/pvesh-get-nodes-node-storage-storage-content-volume-returns-error.123747/ Signed-off-by: Christian Ebner --- Changes since v1: * Remove errous check for $used being set, rely on fallback to 0 if undef

[pve-devel] [PATCH i18n] add some missing italian translations

2023-03-21 Thread Christian Ebner
Signed-off-by: Christian Ebner --- it.po | 253 +++--- 1 file changed, 134 insertions(+), 119 deletions(-) diff --git a/it.po b/it.po index a87e481..11d4db3 100644 --- a/it.po +++ b/it.po @@ -38,20 +38,23 @@ msgstr "/qualche/path"

Re: [pve-devel] applied: [PATCH i18n] add some missing italian translations

2023-03-21 Thread Christian Ebner
Okay, will have a look at those too then. Thx for clarification. > On 21.03.2023 13:37 CET Thomas Lamprecht wrote: > > > Am 21/03/2023 um 13:04 schrieb Christian Ebner: > > Signed-off-by: Christian Ebner > &

[pve-devel] [PATCH i18n] add/reword some italian translations

2023-03-22 Thread Christian Ebner
Signed-off-by: Christian Ebner --- it.po | 560 +++--- 1 file changed, 219 insertions(+), 341 deletions(-) diff --git a/it.po b/it.po index 458e968..a40f9c2 100644 --- a/it.po +++ b/it.po @@ -43,7 +43,7 @@ msgstr "5 minuti" #: prox

[pve-devel] [PATCH pve-installer] fix typo in error message

2023-03-23 Thread Christian Ebner
Signed-off-by: Christian Ebner --- proxinstall | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proxinstall b/proxinstall index e85dd3e..c275be2 100755 --- a/proxinstall +++ b/proxinstall @@ -3716,7 +3716,7 @@ create_main_window (); my $initial_error = 0; if (!defined

[pve-devel] [PATCH widget-toolkit 1/3] DateTimeField: fix typo in xtype

2023-03-23 Thread Christian Ebner
Signed-off-by: Christian Ebner --- src/form/DateTimeField.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/form/DateTimeField.js b/src/form/DateTimeField.js index a061e15..87bb1ef 100644 --- a/src/form/DateTimeField.js +++ b/src/form/DateTimeField.js @@ -1,6 +1,6

[pve-devel] [PATCH manager 5/5] fix #4442: Add date-time filtering for firewall logs

2023-03-23 Thread Christian Ebner
Extend the current firewall log view to add date time based filtering. The user can switch between live view, which shows logs from the unrotated log file, or to filter mode, where date time based filtering, including rotated logs can be performed. Signed-off-by: Christian Ebner --- www

[pve-devel] [PATCH 0/5] fix #4442: Firewall log filtering

2023-03-23 Thread Christian Ebner
to be updated. pve-manager: Christian Ebner (1): fix #4442: Add date-time filtering for firewall logs www/manager6/node/Config.js | 2 ++ www/manager6/qemu/Config.js | 2 ++ 2 files changed, 4 insertions(+) pmg-gui: Christian Ebner (1): DateTimeField: fix typo in xtype js/MailTracker.js

[pve-devel] [PATCH widget-toolkit 2/3] DateTimeField: Extend and refactor to make field value bindable

2023-03-23 Thread Christian Ebner
Extends the date time field so that bindings are updated on value changes. Also adds a config to disable child components and avoid modification of current values by cloning the referenced object for min/max value calculation. Signed-off-by: Christian Ebner --- src/form/DateTimeField.js | 105

[pve-devel] [PATCH pmg-gui 4/4] DateTimeField: fix typo in xtype

2023-03-23 Thread Christian Ebner
Signed-off-by: Christian Ebner --- js/MailTracker.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/js/MailTracker.js b/js/MailTracker.js index 52641a4..ce1a487 100644 --- a/js/MailTracker.js +++ b/js/MailTracker.js @@ -106,7 +106,7 @@ Ext.define('PMG.MailTrackerF

[pve-devel] [PATCH widget-toolkit 3/3] fix #4442: Extend LogView for firewall datetime filtering

2023-03-23 Thread Christian Ebner
calls. Signed-off-by: Christian Ebner --- src/panel/LogView.js | 83 +++- 1 file changed, 74 insertions(+), 9 deletions(-) diff --git a/src/panel/LogView.js b/src/panel/LogView.js index 44aa8e3..cd17603 100644 --- a/src/panel/LogView.js +++ b/src/panel

[pve-devel] [PATCH qemu-server] net: Skip and warn of interfaces without bridge

2023-04-12 Thread Christian Ebner
Handle and warn about network interfaces which are not attached to any bridge because the user actively removed it from the VM config. Signed-off-by: Christian Ebner --- PVE/QemuServer.pm | 4 1 file changed, 4 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index c1d0fd2

[pve-devel] [PATCH] pve7to8: Improve systemd unified cgroupv2 support check

2023-06-12 Thread Christian Ebner
to the filename, so include that in the regex as well. Signed-off-by: Christian Ebner --- PVE/CLI/pve7to8.pm | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/PVE/CLI/pve7to8.pm b/PVE/CLI/pve7to8.pm index 6b51e98e..3061b691 100644 --- a/PVE/CLI/pve7to8.pm +++ b/PVE/CLI

Re: [pve-devel] [PATCH] pve7to8: Improve systemd unified cgroupv2 support check

2023-06-12 Thread Christian Ebner
Ignore this one, it is still incomplete as Debian 12 stores the shared object at /usr/lib/x86_64-linux-gnu/systemd. Will include that too and send a v2. > On 12.06.2023 12:06 CEST Christian Ebner wrote: > > > Checking /lib/systemd if it is present and a directory is not enou

[pve-devel] [PATCH v2 manager] pve7to8: Improve systemd unified cgroupv2 support check

2023-06-12 Thread Christian Ebner
Linux appends the minor version and release version to the filename, so include that in the regex as well. Signed-off-by: Christian Ebner --- Changes since v1: - Also check for shared object in /usr/lib/x86_64-linux-gnu/systemd PVE/CLI/pve7to8.pm | 11 --- 1 file changed, 8 insertions

[pve-devel] [PATCH storage] plugin: handle invalid storage types

2023-06-21 Thread Christian Ebner
Warn and skip if a storage with unknown storage type is encountered. This might happen by manually editing the storage config. Signed-off-by: Christian Ebner --- src/PVE/Storage/Plugin.pm | 4 1 file changed, 4 insertions(+) diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage

Re: [pve-devel] [PATCH storage] plugin: handle invalid storage types

2023-06-21 Thread Christian Ebner
Oops, I send the wrong patch file here, will send the correct one as v2. Please ignore this one. > On 21.06.2023 15:28 CEST Christian Ebner wrote: > > > Warn and skip if a storage with unknown storage type is encountered. > This might happen by manually editing the

[pve-devel] [PATCH v2 storage] plugin: handle invalid storage types

2023-06-21 Thread Christian Ebner
Warn and skip if a storage with unknown storage type is encountered. This might happen by manually editing the storage config. Signed-off-by: Christian Ebner --- Changes since v1: - v1 contained the wrong diff src/PVE/Storage/Plugin.pm | 4 1 file changed, 4 insertions(+) diff --git a

[pve-devel] [PATCH stable-7 manager] pve7to8: Add check for dkms modules

2023-06-23 Thread Christian Ebner
... and warn if at least one is present. Signed-off-by: Christian Ebner --- PVE/CLI/pve7to8.pm | 35 +++ 1 file changed, 35 insertions(+) diff --git a/PVE/CLI/pve7to8.pm b/PVE/CLI/pve7to8.pm index da1e15bc..ecfb4011 100644 --- a/PVE/CLI/pve7to8.pm +++ b/PVE/CLI

[pve-devel] [PATCH v2 stable-7 manager] pve7to8: Add check for dkms modules

2023-08-01 Thread Christian Ebner
... and warn if at least one is present. Signed-off-by: Christian Ebner --- changes since v1: * do not use which to check for dkms, use exit code directly PVE/CLI/pve7to8.pm | 22 ++ 1 file changed, 22 insertions(+) diff --git a/PVE/CLI/pve7to8.pm b/PVE/CLI/pve7to8.pm

[pve-devel] [PATCH v2 proxmox-widget-toolkit 2/2] fix #4442: Extend LogView for firewall datetime filtering

2023-08-09 Thread Christian Ebner
calls. Signed-off-by: Christian Ebner --- changes since v1: - Also bind labels of input fields to `livemode` state src/panel/LogView.js | 89 +++- 1 file changed, 80 insertions(+), 9 deletions(-) diff --git a/src/panel/LogView.js b/src/panel/LogView.js

[pve-devel] [PATCH v2 proxmox-widget-toolkit 1/2] fix #4442: adapt DateTimeField to be more declarative

2023-08-09 Thread Christian Ebner
Reworks the current implementation of the DateTimeField to be more declarative by using a ViewModel and data bindings as well as formulas, in order to reduce code and unwanted complexity. Signed-off-by: Christian Ebner --- changes since v1: - This patch was not part of the previous series, but

[pve-devel] [PATCH v2 proxmox-widget-toolkit manager pmg-gui 0/4] #4442: impl firewall log filtering

2023-08-09 Thread Christian Ebner
the filters in the panel and the correct submit format for api call. pmg-gui: Revert a commit, introduced to fix a side effect of one of the patches from the previous version of the patches, which got applied. proxmox-widget-toolkit: Christian Ebner (2): fix #4442: adapt DateTimeField to be more

[pve-devel] [PATCH v2 manager 3/3] fix #4442: Add date-time filtering for firewall logs

2023-08-09 Thread Christian Ebner
the submit format for since and until timestamps expected by the api. Signed-off-by: Christian Ebner --- changes since v1: - no changes www/manager6/node/Config.js | 2 ++ www/manager6/qemu/Config.js | 2 ++ 2 files changed, 4 insertions(+) diff --git a/www/manager6/node/Config.js b/www

[pve-devel] [PATCH v2 pmg-gui 4/4] Revert "fix tracking center with newer proxmox-widget-toolkit"

2023-08-09 Thread Christian Ebner
The DateTimeField now defines its own ViewModel, therefore the MailTrackerFilter container doesn't need one to be inherited to the child. This reverts commit 6f3f8ac5cc88ac3c71aed4269688193e5dd6c728. --- changes since v1: - not part of v1, reverts hotfix needed by changes introduced by patch in

[pve-devel] [PATCH pve-docs] website: update external links to www.proxmox.com

2023-08-11 Thread Christian Ebner
During the redesign of www.proxmox.com the menu structure and therefore some url changed. Update the external link in order to avoid an unneccessary redirect. Signed-off-by: Christian Ebner --- These should be backported to stable-7 as well. getting-help.adoc | 2 +- pve

[pve-devel] [PATCH proxmox-widget-toolkit] utils: Remove outdated url in comment

2023-08-11 Thread Christian Ebner
Signed-off-by: Christian Ebner --- src/Utils.js | 1 - 1 file changed, 1 deletion(-) diff --git a/src/Utils.js b/src/Utils.js index 2c27ece..d8c2f3c 100644 --- a/src/Utils.js +++ b/src/Utils.js @@ -151,7 +151,6 @@ utilities: { }, getNoSubKeyHtml: function(url) { - // url http

[pve-devel] [PATCH pve-manager] website: update external links to www.proxmox.com

2023-08-11 Thread Christian Ebner
During the redesign of www.proxmox.com the menu structure and therefore some url changed. Update the external link in order to avoid an unneccessary redirect Signed-off-by: Christian Ebner --- PVE/API2/Subscription.pm | 2 +- aplinfo/aplinfo.dat | 4 ++-- www/manager6

[pve-devel] [PATCH dab-pve-appliances] dab.conf: update external links to www.proxmox.com

2023-08-11 Thread Christian Ebner
During the redesign of www.proxmox.com the menu structure and therefore some url changed. Update the external link in order to avoid an unneccessary redirect. Signed-off-by: Christian Ebner --- archive/debian-10-buster-pmg-64/dab.conf | 2 +- archive/debian-9.0-pmg-64/dab.conf | 2

  1   2   >