This patch series introduces 2 optional api parameters `since` and `until` to firewall log endpoints, in order to make them filterable. Filtering of the firewall logs is performed by a callback function.
If the `include_rotated_logs` flag is set, also rotated logfiles are included. --- Changes since RFC version: - common: Use callback function filter instead of `since` `until` params - common: code reuse for `dump_logfile` and `dump_fw_logfile` - firewall: Style fixes and use of callback function Changes since v1: - common: Store parameters needed for multiple `dump_logfile_by_filehandle` invocations in state hash. - common: Introduce `final` parameter to signal last invocation to `dump_logfile_by_filehandle`. - firewall: Moved `dump_fw_logfile` to firewall helper functions - firewall: Refactor of finding rotated logfiles by use of `dir_glob_foreach` and fixed regex. - firewall: Avoid error if opening logfile failes with ENOENT - Whitespace cleanup common: Christian Ebner (1): tools: Add callback based filtering for logfile dump src/PVE/Tools.pm | 59 +++++++++++++++++++++++++++++++----------------- 1 file changed, 38 insertions(+), 21 deletions(-) firewall: Christian Ebner (1): api: Add optional parameters `since` and `until` for timestamp filter src/PVE/API2/Firewall/Host.pm | 34 +++++++++++++++++++- src/PVE/API2/Firewall/VM.pm | 40 +++++++++++++++++++++--- src/PVE/Firewall/Helpers.pm | 59 +++++++++++++++++++++++++++++++++++ 3 files changed, 128 insertions(+), 5 deletions(-) -- 2.30.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel