The single-letter suffixes are ambiguous and especially in the context
of disks, the powers of ten are usually used. Use exact suffixes
instead when logging the archive file size.
Signed-off-by: Fiona Ebner
---
No changes in v2.
PVE/VZDump.pm | 8
1 file changed, 4 insertions(+), 4 de
On 30/05/2025 16:18, Michael Köppl wrote:
+ my $id_map = (PVE::LXC::parse_id_maps($conf))[0];
+ my $passthrough_device_path = create_passthrough_device_node(
+ "/var/lib/lxc/$vmid/passthrough", $dev, $mode, $rdev, $id_map);
I understand that this path is guaranteed to exist
Add early support for parsing verbose suffixes {K,M,G,T}iB for sizes.
Currently, this is almost exclusively used for guest disks. The plan
is to write disks with the new suffixes starting with Proxmox VE 9 and
having parsing support already in Proxmox VE 8 will help with people
doing accidental (or
> Denis Kanchev hat am 02.06.2025 11:18 CEST
> geschrieben:
>
>
> My bad :) in terms of Proxmox it must be hand-overing the storage control -
> the storage plugin function activate_volume() is called in our case, which
> moves the storage to the new VM.
> So no data is moved across the node
Signed-off-by: Stoiko Ivanov
---
src/submodules/ubuntu-kernel | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/submodules/ubuntu-kernel b/src/submodules/ubuntu-kernel
index 9f8b45f..2591c2a 16
--- a/src/submodules/ubuntu-kernel
+++ b/src/submodules/ubuntu-kernel
@@ -1 +
Am 02.06.25 um 08:33 schrieb Thomas Lamprecht:
> Am 11.04.25 um 11:37 schrieb Fiona Ebner:
>> Proxmox VE will not drop the GlusterFS plugin during the PVE 8.x
>> support lifecycle. Avoid scaring users early.
>
> Those warnings from QEMU come up as standard info in the task log IIRC?
Yes, exactly.
On 02/06/2025 11:37, Christoph Heiss wrote:
On Tue May 20, 2025 at 2:42 PM CEST, Filip Schauer wrote:
This prevents an error during Debian container setup when the
/etc/network directory is missing.
Out of curiosity: Is this actually related to the OCI support in this
series or a separate/indep
Suggested-by: Thomas Lamprecht
Signed-off-by: Fiona Ebner
---
Changes in v2:
* Instead of removing the warning, provide more context.
block/gluster.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/block/gluster.c b/block/gluster.c
index c3a991..71c4a60b02 100644
-
The `getStatus` function was not returning the corresponding
`PveResourceStatusType` when the status was `paused`. This commit adds
the missing status check.
Signed-off-by: Shan Shaji
---
changes since v1:
* Removed all formatting changes
lib/src/models/pve_cluster_resources_model.dart | 2
Short summary about what that file contains and why it can be useful (for us)
would be great to have as context here.
Am 23.05.25 um 18:37 schrieb Aaron Lauterer:
> Signed-off-by: Aaron Lauterer
> ---
> src/PVE/ProcFSTools.pm | 14 ++
> 1 file changed, 14 insertions(+)
>
> diff --gi
A field for OIDC audiences was added, logic to handle these audiences,
and the audiences supplied by an OIDC IDP are validated against
the audiences a user saves in their realm domains
configuration.
Signed-off-by: Alexander Abraham
---
proxmox-openid/src/lib.rs | 20 ++--
1 file
This series adds support for handling Open ID audiences as
described in bug #5076. PVE's API schema was updated to
accept an optional field, an array of strings and the Rust
code was also updated to accordingly handle any incoming
audiences and compare them to the realm config's audiences.
In the r
On 5/20/25 14:42, Filip Schauer wrote:
> This is needed for OCI container images bundled as tar files, as
> generated by `docker save`. OCI images do not need additional
> compression, since the content is usually compressed already.
>
> Signed-off-by: Filip Schauer
> ---
> src/PVE/Storage.pm
when encountering an error (e.g. there was no curser at the wanted
position), the program would close with exitcode 1, but would not
properly finish the json output if in json mode.
To fix that, introduce a `print_error_and_exit` helper that tries to
finish the json output. We set `success` to 0 t
On Tue, 27 May 2025 18:12:38 +0200, Stoiko Ivanov wrote:
> The following patch-series is the result of diffing debian/ with the
> version on salsa, and checking for commits in debian-upstream that might
> make sense to port over (if only to keep our delta to debian small).
>
> most patches are ho
by using json-c and printing the string into a variable via `vasprintf`.
we use a json library to correctly escape and format the error string we
get, since we cannot be sure about the content.
Signed-off-by: Dominik Csapak
---
not sure if it's worth to include json-c here just for the error mess
The API schema was updated so that audiences are treated
as an array of strings. The code for parsing audiences was
updated to also treat audiences like an array of strings
of a certain format.
Signed-off-by: Alexander Abraham
---
src/PVE/API2/OpenId.pm | 5 -
src/PVE/Auth/OpenId.pm | 11 ++
by using json-c and printing the string into a variable via `vasprintf`.
Signed-off-by: Dominik Csapak
---
changes from RFC v1:
* rebase on last patch and also use vfprintf in fallback case
debian/control | 2 +-
src/Makefile | 2 +-
src/mini-journalreader.c | 31 +++
> Denis Kanchev hat am 02.06.2025 15:23 CEST
> geschrieben:
>
>
> We tend to prevent having a volume active on two nodes, as may lead to data
> corruption, so we detach the volume from all nodes ( except the target one )
> via our shared storage system.
> In the sub activate_volume() our log
superseeded by v2, i forgot to include some changes in v1:
https://lore.proxmox.com/pve-devel/20250602143050.3732346-1-d.csa...@proxmox.com/
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-
A field for audiences for OpenId was added for users to supply
Open ID audiences as a space-separated array of strings in their
realm configuration. This array of audiences is then saved in the
realm domains config file.
Signed-off-by: Alexander Abraham
---
www/manager6/Parser.js| 27
Superseded by:
https://lore.proxmox.com/pve-devel/20250602141458.142000-1-a.abra...@proxmox.com/T/#t
> Dominik Csapak hat am 17.02.2025 10:00 CET geschrieben:
>
>
> depending on what restrictions in the backend will be implemented,
> we should add the same here, so users get immediate feedback
Am 23.05.25 um 18:37 schrieb Aaron Lauterer:
> From: Folke Gleumes
>
> Expose buffers and cache as separate metrics instead of including them
> in memfree and memused.
>
> Originally-by: Folke Gleumes
> [AL: rebased and adapted to changes that happened in the meantime]
> Signed-off-by: Aaron La
Am 23.05.25 um 18:37 schrieb Aaron Lauterer:
> From: Folke Gleumes
>
> Originally-by: Folke Gleumes
> [AL: rebased on current master]
> Signed-off-by: Aaron Lauterer
> ---
> src/PVE/ProcFSTools.pm | 22 ++
> 1 file changed, 22 insertions(+)
>
> diff --git a/src/PVE/ProcFST
> Denis Kanchev hat am 02.06.2025 10:35 CEST
> geschrieben:
>
>
> > I thought your storage plugin is a shared storage, so there is no storage
> > migration at all, yet you keep talking about storage migration?It's a
> > shared storage indeed, the issue was that the migration process on the
--- Begin Message ---
> I thought your storage plugin is a shared storage, so there is no storage
migration at all, yet you keep talking about storage migration?
It's a shared storage indeed, the issue was that the migration process on
the destination host got OOM killed and the migration failed, m
options selected with looking through make menuconfig based on current
config-base in kernel 6.14.
Signed-off-by: Stoiko Ivanov
---
src/config-base | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/src/config-base b/src/config-base
index edd95c1..fcebf07 100644
--- a/
The single-letter suffixes are ambiguous and especially in the context
of disks, the powers of ten are usually used. Proxmox VE uses
multiples of 1024 however.
This is in preparation to adapt format_size() to prefer the verbose
suffixes which is planned for Proxmox VE 9.
The single-letter suffixe
Signed-off-by: Stoiko Ivanov
---
src/build_initramfs.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/build_initramfs.sh b/src/build_initramfs.sh
index 52a50c3..0cccb90 100755
--- a/src/build_initramfs.sh
+++ b/src/build_initramfs.sh
@@ -104,6 +104,7 @@ if [ -z "$DOWNLOAD_ONLY" ]; then
--- Begin Message ---
My bad :) in terms of Proxmox it must be hand-overing the storage control -
the storage plugin function activate_volume() is called in our case, which
moves the storage to the new VM.
So no data is moved across the nodes and only the volumes get re-attached.
Thanks for the ple
Am 01.06.25 um 11:51 schrieb Thomas Lamprecht:
> Am 12.05.25 um 15:00 schrieb Fiona Ebner:
>> Am 12.05.25 um 14:41 schrieb Fiona Ebner:
>>> Maybe best is to wait for PVE 9 with this and do a parse+write for all
>>> guest configs (including their snapshots) in the pve8to9 script? The
>>> change also
--- Begin Message ---
We tend to prevent having a volume active on two nodes, as may lead to data
corruption, so we detach the volume from all nodes ( except the target one
) via our shared storage system.
In the sub activate_volume() our logic is to not detach the volume from
other hosts in case o
Am 23.05.25 um 18:00 schrieb Aaron Lauterer:
> For PVE9 there will be additional fields in the metrics that are
> collected. The new columns/fields are added at the end of the current
> ones. Therefore, if we get the new format, we need to cut it.
>
> Paths to rrd filenames needed to be set manual
Signed-off-by: Filip Schauer
---
src/PVE/LXC.pm| 27 +++
src/lxc-pve-prestart-hook | 21 +
2 files changed, 28 insertions(+), 20 deletions(-)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index d929608..098f662 100644
--- a/src/PVE/LXC.pm
++
Signed-off-by: Filip Schauer
---
src/PVE/LXC/Config.pm | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
index 0740e8c..555767f 100644
--- a/src/PVE/LXC/Config.pm
+++ b/src/PVE/LXC/Config.pm
@@ -1364,6 +1364,12 @@ sub print_volume {
retur
This only includes adding devices to a running container. Removing or
editing existing devices is still not implemented.
Signed-off-by: Filip Schauer
---
src/PVE/LXC.pm| 84 ++-
src/PVE/LXC/Config.pm | 19 ++
2 files changed, 102 insertions
Signed-off-by: Filip Schauer
---
src/PVE/LXC.pm | 71 +-
1 file changed, 41 insertions(+), 30 deletions(-)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index a58c997..d929608 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -2010,15 +2010,42 @@
For now this only includes adding devices to a running container.
(not removing or editing existing devices)
Changes since v1:
* Reduce code repetition between lxc-pve-prestart-hook and
device_passthrough_hotplug by extracting passthrough device node
creation to a helper.
Changes since v2:
*
Superseded by:
https://lore.proxmox.com/pve-devel/20250602133213.81979-1-f.scha...@proxmox.com/T
On 23/04/2025 14:56, Filip Schauer wrote:
For now this only includes adding devices to a running container.
(not removing or editing existing devices)
Changes since v1:
* Reduce code repetition betw
This patch splits the `_MobileResourceFilterSheet` into multiple widgets
and since the `main_layout_slim.dart` file is large, the widget has been
moved to it's own file under the widgets folder.
Signed-off-by: Shan Shaji
---
changes since v1:
* Removed all formatting changes.
* Only includes
When the guest status is set to `paused` the guest was not showing in
the resources tab. Also there were no option in the resources
filter to select the `paused` status under the status section.
This commit fixes the issue by adding the `paused` status under the
status section in the resources fil
This patch series includes the fix for guest missing when the status
is `paused`. Additionaly the series also includes the changes from
another patch which can be found here:
https://lore.proxmox.com/pve-devel/20250522130825.79862-1-s.sh...@proxmox.com/
pve_flutter_frontend:
Shan Shaji (2):
when encountering an error (e.g. there was no curser at the wanted
position), the program would close with exitcode 1, but would not
properly finish the json output if in json mode.
To fix that, introduce a `print_error_and_exit` helper that tries to
finish the json output. We set `success` to 0 t
> Andrei Perapiolkin hat am 28.05.2025 16:49
> CEST geschrieben:
>
>
> Hi Fabian,
>
> Thank you for your time dedicated to this issue.
>
> >> My current understanding is that all assets related to snapshots should
> >> to be removed when volume is deactivation, is it correct?
> >> Or all v
--- Begin Message ---
Hi Fiona,
I'm currently finishing my new patch series
>>
>>* Drop $snapshot parameter, currently there is no need to attach
>> snapshots via -blockdev. They would need to be attached read-only
>> too to not fail and this can always be added later.
I need it in different
> Andrei Perapiolkin via pve-devel hat am
> 28.05.2025 17:42 CEST geschrieben:
> Hi Proxmox Community,
>
> I am working on implementing custom storage plugin and after evaluating
> various edge cases related to volume live migration, I have decided to
> create a 'storage assistant service'.
>
> Denis Kanchev hat am 29.05.2025 09:33 CEST
> geschrieben:
>
>
> The issue here is that the storage plugin activate_volume() is called after
> migration cancel which in case of network shared storage can make things bad.
> This is a sort of race condition, because migration_cancel wont stop
On Tue May 20, 2025 at 2:42 PM CEST, Filip Schauer wrote:
> This prevents an error during Debian container setup when the
> /etc/network directory is missing.
Out of curiosity: Is this actually related to the OCI support in this
series or a separate/independent fix?
As this is specific to Debian
Only minor changes this time:
Adapt to changed include paths:
32cad1ffb8 ("include: Rename sysemu/ -> system/")
407bc4bf90 ("qapi: Move include/qapi/qmp/ to include/qobject/")
Adapt to a function signature change:
4822128693 ("migration: Drop inactivate_disk param in
qemu_savevm_state_complete*")
Signed-off-by: Stoiko Ivanov
---
src/submodules/zfsonlinux | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/submodules/zfsonlinux b/src/submodules/zfsonlinux
index 55dd24c..92f430b 16
--- a/src/submodules/zfsonlinux
+++ b/src/submodules/zfsonlinux
@@ -1 +1 @@
-Subprojec
Am 19.05.25 um 14:25 schrieb Maximiliano Sandoval:
> Signed-off-by: Maximiliano Sandoval
> ---
> src/PVE/DataCenterConfig.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm
> index a3db78e..205b784 100644
> --- a/
Some comments inline.
On Tue May 20, 2025 at 2:42 PM CEST, Filip Schauer wrote:
> [..]
> diff --git a/proxmox-oci/src/lib.rs b/proxmox-oci/src/lib.rs
> new file mode 100644
> index ..57bd48b4
> --- /dev/null
> +++ b/proxmox-oci/src/lib.rs
> @@ -0,0 +1,165 @@
> [..]
> +/// Build a mapping f
usr-merged systems are default since bookworm [0].
the proxmox-restore-daemon otoh uses absolute paths to execute
commands inside the initramfs, without having a PATH set (which would
be used by Command::new (and execvpe(2) to resolve a relative
command).
merging all directories as on regular debi
the output of `zpool import` has changed, thus our current parser
failed to find a zpool with zfs userspace in version 2.3.2.
While ZFS 2.3 introduced JSON output for many commands `zpool import`
still lacks the option [0], thus I'd postpone this adapation once all
needed zfs/zpool commands provid
While checking our codebase for potential uses of non-usr-merged paths
for ZFS I noticed the file-restore uses absolute paths for most commands.
As the daemon runs in an isolated environment we provide sticking to
absolute paths, instead of adding a PATH variable for Command::new to
search seems a
Needs a rebase on latest master, FWIW.
On Tue May 20, 2025 at 2:42 PM CEST, Filip Schauer wrote:
> Signed-off-by: Filip Schauer
> ---
> pve-rs/Cargo.toml | 2 ++
> pve-rs/Makefile | 1 +
> pve-rs/src/lib.rs | 1 +
> pve-rs/src/oci.rs | 20
> 4 files changed, 24 insertio
--- Begin Message ---
Signed-off-by: Tiago Sousa
---
PVE/API2/Nodes.pm| 45
www/manager6/Utils.js| 1 +
www/manager6/node/CmdMenu.js | 36 +++--
3 files changed, 80 insertions(+), 2 deletions(-)
diff --git a/PVE/AP
--- Begin Message ---
This patch addresses feature request
https://bugzilla.proxmox.com/show_bug.cgi?id=6144 to add support for
setting a node's maintenance state directly from the UI and API.
This implementation uses Sys.PowerMgmt permission for now, but I'm
unsure if this is the most appropriat
--- Begin Message ---
> >
> > * Drop $snapshot parameter, currently there is no need to attach
> > snapshots via -blockdev. They would need to be attached read-only
> > too to not fail and this can always be added later.
>>I need it in different places in the external snapshot code (to
>>ge
Thanks for tackling this! I tested setting up containers based on
various OCI images. Apart from the UI not allowing upload of .tar files
(see my comment on the pve-storage patch), the uploading worked as
expected. I encountered some problems with various images during my
testing. I used docker sav
Am 02.06.25 um 18:10 schrieb Tiago Sousa:
> Signed-off-by: Tiago Sousa
> ---
> PVE/API2/Nodes.pm| 45
Thanks for your patch, some high level comment:
As the API touches HA it should also go into the pve-ha-manager repo, there it
could directly che
61 matches
Mail list logo
