[pve-devel] [PATCH qemu-server v2 8/13] fix #5180: migrate: integrate helper for live-migrating conntrack info

2025-04-24 Thread Christoph Heiss
Fixes #5180 [0]. This implements for live-migration: a) the dbus-vmstate is started on the target side, together with the VM b) the dbus-vmstate helper is started on the source side c) everything is cleaned up properly, in any case It is currently off-by-default and must be enabled via the option

Re: [pve-devel] [PATCH ha-manager 04/15] add rules section config base plugin

2025-04-24 Thread Fiona Ebner
Am 25.03.25 um 16:12 schrieb Daniel Kral: > Add a rules section config base plugin to allow users to specify > different kinds of rules in a single configuration file. > > The interface is designed to allow sub plugins to implement their own > {decode,encode}_value() methods and also offer a canon

[pve-devel] [PATCH pve_flutter_frontend] gitignore: add generated dart files

2025-04-24 Thread Shan Shaji
Omit `devtools_options.yaml` file and generated dart files from source control. `devtools_options.yaml` file is a config file for storing the extension enablement states of flutter dev tools. By adding `devtools_options.yaml` as an entry in the `.gitignore` file, the configurations will be sepera

Re: [pve-devel] [PATCH ha-manager 03/15] usage: add get_service_node and pin_service_node methods

2025-04-24 Thread Fiona Ebner
Am 25.03.25 um 16:12 schrieb Daniel Kral: > Add methods get_service_node() and pin_service_node() to the Usage class > to retrieve and pin the current node of a specific service. Hmm, not sure about calling it "pin", why not "set"? > > This is used to retrieve the current node of a service for c

Re: [pve-devel] [PATCH qemu-server 06/14] api2: qemu: add module exposing node migration capabilities

2025-04-24 Thread Fiona Ebner
Am 17.03.25 um 15:11 schrieb Christoph Heiss: > diff --git a/PVE/API2/Qemu/Migration.pm b/PVE/API2/Qemu/Migration.pm > new file mode 100644 > index ..34125a15 > --- /dev/null > +++ b/PVE/API2/Qemu/Migration.pm > @@ -0,0 +1,46 @@ > +package PVE::API2::Qemu::Migration; Would be nice to have

Re: [pve-devel] [PATCH qemu-server v2 6/13] api2: qemu: add module exposing node migration capabilities

2025-04-24 Thread Fiona Ebner
Am 24.04.25 um 13:19 schrieb Christoph Heiss: > diff --git a/PVE/API2/Qemu/Migration.pm b/PVE/API2/Qemu/Migration.pm > new file mode 100644 > index ..34125a15 > --- /dev/null > +++ b/PVE/API2/Qemu/Migration.pm > @@ -0,0 +1,46 @@ > +package PVE::API2::Qemu::Migration; (Sorry, answered to v1

[pve-devel] [PATCH proxmox-firewall v2 2/13] firewall: add connmark rule with VMID to all guest chains

2025-04-24 Thread Christoph Heiss
Adds a connmark attribute with the VMID inside to anything flowing in/out the guest, which are also carried over to all conntrack entries. This enables differentiating conntrack entries between VMs for live-migration. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * rebased on latest mas

[pve-devel] [PATCH pve_flutter_frontend v2] gitignore: add generated dart files

2025-04-24 Thread Shan Shaji
Omit `devtools_options.yaml` file and generated Dart files from source control. `devtools_options.yaml` is a config file for storing the extension enablement states of Flutter DevTools. By adding `devtools_options.yaml` as an entry in the `.gitignore` file, the configurations will be for each deve

[pve-devel] [PATCH pve-firewall v2 3/13] firewall: add connmark rule with VMID to all guest chains

2025-04-24 Thread Christoph Heiss
Adds a connmark attribute with the VMID inside to anything flowing in/out the guest, which are also carried over to all conntrack entries. This enables differentiating conntrack entries between VMs for live-migration. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * no changes src/PVE/

[pve-devel] [PATCH proxmox-ve-rs v2 1/13] config: guest: allow access to raw Vmid value

2025-04-24 Thread Christoph Heiss
Needed in proxmox-nftables/-firewall to generate rules depending on the numeric vmid. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * no changes proxmox-ve-config/src/guest/types.rs | 4 1 file changed, 4 insertions(+) diff --git a/proxmox-ve-config/src/guest/types.rs b/proxmox-

[pve-devel] [PATCH pve-firewall v2 4/13] firewall: helpers: add sub for flushing conntrack entries by mark

2025-04-24 Thread Christoph Heiss
A small helper routine for flushing all conntrack table entries which are marked with a specific value. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * no changes debian/control | 3 ++- src/PVE/Firewall/Helpers.pm | 11 +++ 2 files changed, 13 insertions(+), 1 de

[pve-devel] [PATCH manager v2 11/13] api2: capabilities: proxy index endpoints to respective nodes

2025-04-24 Thread Christoph Heiss
Nodes might have different capabilities, depending on their version. This ensures that always the requested is actually queryied. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * no changes PVE/API2/Capabilities.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/API2/Capabilit

[pve-devel] [PATCH qemu-server v2 6/13] api2: qemu: add module exposing node migration capabilities

2025-04-24 Thread Christoph Heiss
Similar to the already existing ones for CPU and QEMU machine support. Very simple for now, only provides one property for now: 'has-dbus-vmstate' - Whether the dbus-vmstate is available/installed Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * no changes PVE/API2/Qemu/Makefile

[pve-devel] [PATCH qemu-server v2 9/13] migrate: flush old VM conntrack entries after successful migration

2025-04-24 Thread Christoph Heiss
After a successful live-migration, the old VM-specific conntrack entries are not needed anymore on the source node and can thus be flushed. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * no changes PVE/QemuMigrate.pm | 5 + 1 file changed, 5 insertions(+) diff --git a/PVE/QemuMig

[pve-devel] [PATCH manager v2 10/13] api2: capabilities: explicitly import CPU capabilities module

2025-04-24 Thread Christoph Heiss
This currently works only by pure chance, as it seems to be already imported somewhere else. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * no changes PVE/API2/Capabilities.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/API2/Capabilities.pm b/PVE/API2/Capabilities.pm index

[pve-devel] [PATCH qemu-server v2 7/13] fix #5180: libexec: add QEMU dbus-vmstate daemon for migrating conntrack

2025-04-24 Thread Christoph Heiss
First part to fixing #5180 [0]. Adds a simple D-Bus server which implements the `org.qemu.VMState1` interface as specified in the QEMU documentation [1]. Using the built-in QEMU VMState machinery saves us from having to worry about transfer and convergence of the data and letl QEMU take care of i

[pve-devel] [PATCH ve-rs/firewall/qemu-server/manager v2 00/13] fix #5180: migrate conntrack state on live migration

2025-04-24 Thread Christoph Heiss
Fixes #5180 [0]. This implements migration of per-VM conntrack state on live-migration. The core of the implementation are in patch #7 & #8. See there for more details. Patch #1 - #3 implement CONNMARK'ing any VM traffic with their unique VMID. This is needed later on to filter conntrack entries

[pve-devel] [PATCH manager] ui: login: display error messages when logging

2025-04-24 Thread Maximiliano Sandoval
This allows to distinguish, for example, the following three cases: - The pvedaemon service is not responding (595) - The pveproxy service is not responding (no error status code) - The authentication credentials are not correct (401) Since different combinations of wrong password and/or wrong

[pve-devel] [PATCH pve_flutter_frontend] widgets: migrate from ButtonBar to OverflowBar

2025-04-24 Thread Shan Shaji
The `ButtonBar` widget has been deprecated as of Flutter v3.21.0-10.0.pre. This patch replaces instance of `ButtonBar` with `OverflowBar`. Signed-off-by: Shan Shaji --- .../pve_task_log_expansiontile_widget.dart| 40 +++ 1 file changed, 23 insertions(+), 17 deletions(-) diff

Re: [pve-devel] [RFC cluster/ha-manager 00/16] HA colocation rules

2025-04-24 Thread Fiona Ebner
Am 25.03.25 um 16:12 schrieb Daniel Kral: > | Canonicalization > -- > > Additionally, colocation rules are currently simplified as follows: > > - If there are multiple positive colocation rules with common services > and the same strictness, these are merged to a single positive > col

Re: [pve-devel] [RFC cluster/ha-manager 00/16] HA colocation rules

2025-04-24 Thread Fiona Ebner
Am 01.04.25 um 11:39 schrieb Daniel Kral: > On 4/1/25 03:50, DERUMIER, Alexandre wrote: >> my 2cents, but everybody in the industry is calling this >> affinity/antiafifnity (vmware, nutanix, hyperv, openstack, ...). >> More precisely, vm affinity rules (vm<->vm)   vs  node affinity rules >> (vm->no

Re: [pve-devel] [RFC cluster/ha-manager 00/16] HA colocation rules

2025-04-24 Thread Fiona Ebner
Am 25.03.25 um 17:47 schrieb Daniel Kral: > On 3/25/25 16:12, Daniel Kral wrote: >> Colocation Rules >> >> >> The two properties of colocation rules, as described in the >> introduction, are rather straightforward. A typical colocation rule >> inside of the config would look like t

[pve-devel] applied: [PATCH esxi-import-tools 1/2] listvms: add check for vCLS test whether vm configuration is present

2025-04-24 Thread Thomas Lamprecht
On Fri, 11 Apr 2025 17:06:33 +0200, Daniel Kral wrote: > It seems that on older ESXi installations, e.g. ESXi 6.7 [0], there are > virtual machines, which do not expose a config property for some VMs. > Therefore, test whether the config is available before checking if the > current entry is a vCLS

[pve-devel] [PATCH manager v2 13/13] ui: window: Migrate: add checkbox for migrating VM conntrack state

2025-04-24 Thread Christoph Heiss
Adds a new checkbox to the migration dialog, if it is a live/online-migration and both the source and target nodes have support for our dbus-vmstate helper. If the checkbox is active, it passes along the `with-conntrack-state` parameter to the migrate API call. Signed-off-by: Christoph Heiss ---

Re: [pve-devel] [PATCH many 00/14] fix #5180: migrate conntrack state on live migration

2025-04-24 Thread Christoph Heiss
v2 available: https://lore.proxmox.com/pve-devel/20250424111941.730528-1-c.he...@proxmox.com/ On Mon Mar 17, 2025 at 3:11 PM CET, Christoph Heiss wrote: > Fixes #5180 [0]. > > This implements migration of per-VM conntrack state on live-migration. > > The core of the implementation are in patch #7

[pve-devel] [PATCH qemu-server v2 5/13] qmp helpers: allow passing structured args via qemu_objectadd()

2025-04-24 Thread Christoph Heiss
No functional changes for existing code. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * no changes PVE/QemuServer/QMPHelpers.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/QemuServer/QMPHelpers.pm b/PVE/QemuServer/QMPHelpers.pm index 5f73b01e..c6a8f166

[pve-devel] [PATCH manager v2 12/13] api2: capabilities: expose new qemu/migration endpoint

2025-04-24 Thread Christoph Heiss
This endpoint provides information about migration capabilities of the node. Currently, only support for dbus-vmstate is indicated. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * no changes PVE/API2/Capabilities.pm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/PVE/API2/Cap

Re: [pve-devel] [PATCH pve_flutter_frontend] gitignore: add generated dart files

2025-04-24 Thread Shannon Sterz
On Thu Apr 24, 2025 at 12:54 PM CEST, Shan Shaji wrote: > Omit `devtools_options.yaml` file and generated dart files > from source control. > > `devtools_options.yaml` file is a config file for storing the > extension enablement states of flutter dev tools. By adding > `devtools_options.yaml` > as

[pve-devel] applied: [PATCH pve_flutter_frontend v2] gitignore: add generated dart files

2025-04-24 Thread Thomas Lamprecht
On Thu, 24 Apr 2025 15:30:58 +0200, Shan Shaji wrote: > Omit `devtools_options.yaml` file and generated Dart files from > source control. > > `devtools_options.yaml` is a config file for storing the extension > enablement states of Flutter DevTools. By adding > `devtools_options.yaml` as an entry

Re: [pve-devel] iscsi and multipathing

2025-04-24 Thread Timo Veith via pve-devel
--- Begin Message --- > Am 18.04.2025 um 10:45 schrieb Mira Limbeck : > > On 4/15/25 16:10, Timo Veith wrote: >> Hello Mira, >> >> thank you very much for your reply. >> >>> Am 15.04.2025 um 11:09 schrieb Mira Limbeck : >>> >>> Hi Timo, >>> >>> At the moment I'm working on storage mapping su