On Fri, 11 Apr 2025 17:06:33 +0200, Daniel Kral wrote: > It seems that on older ESXi installations, e.g. ESXi 6.7 [0], there are > virtual machines, which do not expose a config property for some VMs. > Therefore, test whether the config is available before checking if the > current entry is a vCLS VM. > > [0] https://forum.proxmox.com/threads/164900/ > > [...]
Applied, but I had to make a followup for the second patch, which had a logical error that was even reported on package build: --- mypy listvms.py listvms.py:261: error: "None" has no attribute "extraConfig" [attr-defined] --- Would be great if you could end to end test changes. As reference, I took this patch over the one from Daniel Herzig [0] mostly due timing and the R-b trailer here. [0]: https://lore.proxmox.com/all/20250423130315.360403-1-d.her...@proxmox.com/ [1/2] listvms: add check for vCLS test whether vm configuration is present commit: 3d3c4d60849a706fd3c9ad1402233fb4be09a38f [2/2] listvms: add message when skipping vCLS agent VMs commit: 9fee27b19e4cbd7f68adb0056d2fe8545a309700 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
