[pve-devel] [PATCH proxmox-ve-rs 11/17] frr: add serializer for all FRR types

2025-04-04 Thread Gabriel Goller
This custom serializer will serialize all the FRR types into a string, which is the FRR config. Signed-off-by: Gabriel Goller --- proxmox-frr/src/lib.rs| 2 + proxmox-frr/src/serializer.rs | 192 ++ 2 files changed, 194 insertions(+) create mode 100644

Re: [pve-devel] [PATCH storage v4 09/27] plugin: introduce new_backup_provider() method

2025-04-04 Thread Andreas Rogge
Am 02.04.25 um 10:30 schrieb Wolfgang Bumiller: On Tue, Apr 01, 2025 at 08:21:30PM +0200, Thomas Lamprecht wrote: This sounds pretty inefficient - especially when comparing with qmrestore's ability to just read read from stdin. The reading from stdin is quite limited, does not support sparse f

[pve-devel] [POC storage v5 14/32] Borg example plugin

2025-04-04 Thread Fiona Ebner
Archive names start with the guest type and ID and then the same timestamp format as PBS. Container archives have the following structure: guest.config firewall.config filesystem/ # containing the whole filesystem structure VM archives have the following structure guest.config firewall.config vol

Re: [pve-devel] [PATCH ifupdown2 1/1] Correctly handle IPv6 addresses in vxlan

2025-04-04 Thread Stefan Hanreich
On 3/31/25 06:45, Andrew wrote: > Just noticed I didn’t reply to this before - the patch set in ifupdown2 does > not actually address IPv6 local tunnel IPs at all. 3.9 itself doesn't, but 3.10 should contain the respective patches ___ pve-devel mailin

Re: [pve-devel] About PVE Backup Integration Guide

2025-04-04 Thread Prashant Patil via pve-devel
--- Begin Message --- Basically, the backup/restore tasks will be managed through our backup solution. So, all we needed is VM config which can be fetched through PVE REST API and a API to get access to consistent disk image which can be then transferred to backup storage that we support. But it

Re: [pve-devel] [PATCH qemu-server 1/1] qemu: add offline migration from dead node

2025-04-04 Thread Dominik Csapak
On 4/1/25 12:46, Thomas Lamprecht wrote: Am 01.04.25 um 12:19 schrieb Dominik Csapak: while i also agree to all said here, I have one counter point to offer: In the case that such an operation is necessary (e.g. HA is not wanted/needed/possible for what ever reason), the user will fall back to

Re: [pve-devel] About PVE Backup Integration Guide

2025-04-04 Thread Prashant Patil via pve-devel
--- Begin Message --- Ok, will give plugins a try and see if we can achieve backup/restore management from our backup solution. 1. Can we just implement backup provider plugin and not storage plugin? We can build storage plugin in subsequent releases. 2. What are the steps to configure/d

Re: [pve-devel] [PATCH v4 qemu-server 11/11] qcow2: add external snapshot support

2025-04-04 Thread Fabian Grünbichler
> DERUMIER, Alexandre hat am 04.04.2025 > 13:31 CEST geschrieben: > Hi Fabian, > > >>the first one is the renaming of a blockdev while it is used, which > >>is currently done like this: > >>-- "link" snapshot path to make it available under old and new name > >>-- handle blockdev additions/reo

[pve-devel] applied-series: [PATCH-SERIES v2 qemu-server/storage/guest-common 0/7] slightly improve image format handling

2025-04-04 Thread Thomas Lamprecht
Am 05.03.25 um 11:49 schrieb Fiona Ebner: > v1: > https://lore.proxmox.com/pve-devel/20250207125514.42668-1-f.eb...@proxmox.com/ > > Changes in v2: > * different approach, use existing format > * introduce standard option > * add patches to drop mythological 'cow' format > > Allow using 'vmdk' f

[pve-devel] [PATCH cluster/ha-manager/manager 0/6] preparation for #6143: notification template cleanup

2025-04-04 Thread Lukas Wagner
With [#6143] on the horizon, notification templates, template variables and template helpers become part of our public API and as such we should provide some stability guarantees for them. As a result, we use this opportunity to do a 'final' cleanup. This series: - adds some common template vars

[pve-devel] [PATCH proxmox 2/2] notify: gotify: use constant from http crate for 'Authorization' header

2025-04-04 Thread Lukas Wagner
Signed-off-by: Lukas Wagner --- proxmox-notify/Cargo.toml | 2 +- proxmox-notify/src/endpoints/gotify.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/proxmox-notify/Cargo.toml b/proxmox-notify/Cargo.toml index ddbaacd7..5a54c4a1 100644 --- a/proxmox-notify/C

[pve-devel] [PATCH ha-manager 07/15] manager: read and update rules config

2025-04-04 Thread Daniel Kral
Read the rules configuration in each round and update the canonicalized rules configuration if there were any changes since the last round to reduce the amount of times of verifying the rule set. Signed-off-by: Daniel Kral --- As noted inline already, there's a missing check whether the service c

[pve-devel] applied: [PATCH v2 guest-common 1/1] storage tunnel: check just-imported image files

2025-04-04 Thread Thomas Lamprecht
Am 04.11.24 um 11:42 schrieb Fabian Grünbichler: > remote migration requires elevated privileges already and can thus only be > triggered by trusted sources, but an additional safeguard of checking the > image > for external references doesn't hurt. > > Signed-off-by: Fabian Grünbichler > --- >

[pve-devel] [PATCH qemu-server v15 7/12] disable snapshot (with RAM) and hibernate with virtio-fs devices

2025-04-04 Thread Markus Frank
Reviewed-by: Fiona Ebner Reviewed-by: Laurențiu Leahu-Vlăducu Tested-by: Laurențiu Leahu-Vlăducu Tested-by: Daniel Kral Signed-off-by: Markus Frank --- no changes in v15 PVE/QemuServer.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuSer

Re: [pve-devel] [PATCH guest-common v14 2/12] add dir mapping section config

2025-04-04 Thread Fabian Grünbichler
On March 4, 2025 12:57 pm, Markus Frank wrote: > Adds a config file for directories by using a 'map' property string for > each node mapping. > > Next to node & path, there is the optional announce-submounts parameter > which forces virtiofsd to report a different device number for each > submount

[pve-devel] [PATCH qemu-server v6 19/37] backup: fleecing: use exact size when allocating non-raw fleecing images

2025-04-04 Thread Fiona Ebner
A non-1KiB aligned source image could cause issues when used with qcow2 fleecing images, e.g. for an image with size 4.5 KiB: > Size mismatch for 'drive-tpmstate0-backup-fleecing' - sector count 10 != 9 Raw images are attached to QEMU with an explicit 'size' argument, so rounding up before allocat

[pve-devel] [PATCH-SERIES qemu/common/storage/qemu-server/container/manager v6 00/37] backup provider API

2025-04-04 Thread Fiona Ebner
v5: https://lore.proxmox.com/pve-devel/20250321134852.103871-1-f.eb...@proxmox.com/ v4: https://lore.proxmox.com/pve-devel/20241114150754.374376-1-f.eb...@proxmox.com/ v3: https://lore.proxmox.com/pve-devel/20241107165146.125935-1-f.eb...@proxmox.com/ Changes in v6: * Factor out some helpers in

[pve-devel] [PATCH proxmox v2 1/2] network-types: initial commit

2025-04-04 Thread Stefan Hanreich
This commit moves some IP address and MAC address types from proxmox-ve-config to proxmox, so they can be used re-used across our code base. The code in this commit is mostly the same as in proxmox-ve-config ('bc9253d8'), but I have made a few changes: * Added additional documentation to some of

Re: [pve-devel] [PATCH installer] proxmox-chroot: replace nix::(u)mount calls with external (u)mount

2025-04-04 Thread Thomas Lamprecht
Am 11.03.25 um 14:27 schrieb Christoph Heiss: > Comes with a reduction of 52 -> 40 in terms of crate dependencies for > proxmox-chroot, 198 -> 192 for a full workspace build. > > Currently, this is done inconsistently anyway, i.e. there are calls to > the external mount(8) as well as mount(2) and

Re: [pve-devel] [PATCH proxmox v3 2/2] network-types: add hostname type

2025-04-04 Thread Wolfgang Bumiller
On Fri, Apr 04, 2025 at 09:51:05AM +0200, Stefan Hanreich wrote: > Thanks for your review - comments inline > > On 4/4/25 09:31, Wolfgang Bumiller wrote: > > On Tue, Apr 01, 2025 at 04:52:44PM +0200, Stefan Hanreich wrote: > >> Add a type for representing Linux hostnames. These are the same > >> c

Re: [pve-devel] [PATCH corosync] corosync.service: add patch to reduce log spam in broken network setups

2025-04-04 Thread Friedrich Weber
On 04/04/2025 10:55, Thomas Lamprecht wrote: > Am 04.04.25 um 10:14 schrieb Maximiliano Sandoval: >> Friedrich Weber writes: > > ... > >> An option that might require lower maintenance would be to ship a >> service file override, e.g. at >> /lib/systemd/system/corosync.service.d/set-log-rate-li

[pve-devel] [PATCH qemu] PVE backup: backup access api: simplify bitmap logic

2025-04-04 Thread Fiona Ebner
Currently, only one bitmap name per target is planned to be used. Simply use the target ID itself as the bitmap name. This allows to simplify the logic quite a bit and there also is no need for the backup_access_bitmaps hash table anymore. For the return value, the bitmap names are still passed al

Re: [pve-devel] [PATCH corosync] corosync.service: add patch to reduce log spam in broken network setups

2025-04-04 Thread Thomas Lamprecht
Am 04.04.25 um 11:18 schrieb Friedrich Weber: > On 04/04/2025 10:55, Thomas Lamprecht wrote: >> Would be more fitting if we did not package corosync our self, as is >> this integrated way would be fine to me. That sasid yours could be too. > > Hmm, is this cut off? no, just a few typos that might

Re: [pve-devel] [PATCH ifupdown2 1/1] Correctly handle IPv6 addresses in vxlan

2025-04-04 Thread Andrew via pve-devel
--- Begin Message --- Given the delays in ifupdown2 development (the patches for vxlan IPv6 have been sitting un-reviewed for 5 months now, and this is the 3rd patch set in * 5 years * that has tried to fix this issue without being merged), can we continue waiting years for them to fix? The mos

Re: [pve-devel] [PATCH qemu-server v2 8/8] api: qemu machine capabilities: add description for pveX variants

2025-04-04 Thread Fiona Ebner
Am 07.03.25 um 15:44 schrieb Dominik Csapak: > and retroactively add descriptions for previous bumps. > > Signed-off-by: Dominik Csapak > --- > new in v2 > PVE/API2/Qemu/Machine.pm | 9 + > PVE/QemuServer/Machine.pm | 15 +++ > 2 files changed, 24 insertions(+) > > diff --

Re: [pve-devel] [PATCH qemu-server v15 6/12] migration: check_local_resources for virtiofs

2025-04-04 Thread Daniel Kral
This patch did not apply correctly anymore since there were some other patches applied upstream since last time. A comment about that inline. On 4/3/25 12:34, Markus Frank wrote: add dir mapping checks to check_local_resources Since the VM needs to be powered off for migration, migration shou

Re: [pve-devel] [PATCH docs v2 1/1] qm: pve machine version: add section to explain +pveX versions

2025-04-04 Thread Fiona Ebner
Am 07.03.25 um 15:44 schrieb Dominik Csapak: > and clarify what windows guests will be pinned to. > > Signed-off-by: Dominik Csapak > --- > new in v2 > qm.adoc | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/qm.adoc b/qm.adoc > index 4bb8f2c..16ed870 100644 > --- a/qm.

Re: [pve-devel] [PATCH manager v15 09/12] ui: add edit window for dir mappings

2025-04-04 Thread Daniel Kral
One comment inline. On 4/3/25 12:34, Markus Frank wrote: Signed-off-by: Markus Frank --- v15: * removed announce-submounts www/manager6/Makefile | 1 + www/manager6/window/DirMapEdit.js | 202 ++ 2 files changed, 203 insertions(+) create mode 100

Re: [pve-devel] [PATCH qemu-server v15 5/7] fix #1027: virtio-fs support

2025-04-04 Thread Daniel Kral
Some comments inline about undefined values. Also two small notes about testing the assertions, which both works as expected (die for Windows + POSIX ACLs and memory hotplug + virtiofs). On 4/3/25 12:34, Markus Frank wrote: add support for sharing directories with a guest vm. virtio-fs needs

Re: [pve-devel] [PATCH manager v15 12/12] ui: add options to add virtio-fs to qemu config

2025-04-04 Thread Daniel Kral
On 4/3/25 12:34, Markus Frank wrote: Signed-off-by: Markus Frank --- v15: * moved all options except dirid to an advanced tab * improved field labels Great, looks better with less options up front if Advanced is ticked off. So consider this as: Reviewed-by: Daniel Kral Tested-by: Daniel Kr

Re: [pve-devel] [PATCH docs v15 3/12] add doc section for the shared filesystem virtio-fs

2025-04-04 Thread Daniel Kral
On 4/3/25 12:34, Markus Frank wrote: Signed-off-by: Markus Frank --- v15: * added fstab entry example in the docs * added hyperlinks for websites * removed announce-submounts part I second Lukas' comments about adding some words about the WebGUI and the options being in a table, which would m

Re: [pve-devel] [PATCH qemu-server/docs v2] disable S3/S4 power states by default

2025-04-04 Thread Fiona Ebner
Am 07.03.25 um 15:44 schrieb Dominik Csapak: > since they make some problems (e.g. windows hybrid shutdown is enabled > by default then -> which makes vGPU problem). Libvirt/virsh also > disables that by default (and tries preventing enabling it.) > > This series introduces a new pve1 version for

Re: [pve-devel] [PATCH cluster/docs/manager/network/proxmox{, -ve-rs, -firewall, -perl-rs} 00/52] Add SDN Fabrics

2025-04-04 Thread Stefan Hanreich
On 4/3/25 16:20, Friedrich Weber wrote: > On 03/04/2025 16:03, Stefan Hanreich wrote: >> >> >> On 4/3/25 15:44, Friedrich Weber wrote: > - when removing a fabric, the IP addresses defined on the interfaces > remain until the next reboot. I guess the reason is that ifupdown2 > doesn't

[pve-devel] applied: [PATCH docs] bg: fix typo

2025-04-04 Thread Thomas Lamprecht
Am 26.02.25 um 15:26 schrieb Alexander Zeidler: > Signed-off-by: Alexander Zeidler > --- > bg.po | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks! just fyi: you used the wrong format.subjectprefix here ___ pve-devel maili

Re: [pve-devel] [PATCH cluster/guest-common/docs/qemu-server/manager v15 0/12] virtiofs

2025-04-04 Thread Lukas Wagner
On 2025-04-03 12:34, Markus Frank wrote: > Virtio-fs is a shared file system that enables sharing a directory > between host and guest VMs. It takes advantage of the locality of > virtual machines and the hypervisor to get a higher throughput than > the 9p remote file system protocol. > Some tho

[pve-devel] applied: [PATCH installer] proxmox-chroot: replace nix::(u)mount calls with external (u)mount

2025-04-04 Thread Thomas Lamprecht
Am 11.03.25 um 14:27 schrieb Christoph Heiss: > Comes with a reduction of 52 -> 40 in terms of crate dependencies for > proxmox-chroot, 198 -> 192 for a full workspace build. > > Currently, this is done inconsistently anyway, i.e. there are calls to > the external mount(8) as well as mount(2) and

Re: [pve-devel] [PATCH proxmox v3 2/2] network-types: add hostname type

2025-04-04 Thread Stefan Hanreich
On 4/4/25 09:51, Stefan Hanreich wrote: >>> +/// >>> +/// It checks for the following conditions: >>> +/// * At most 63 characters long. >>> +/// * It must not start or end with a hyphen. >>> +/// * Must only contain ASCII alphanumeric characters as well as hyphens. >>> +/// * It must not be pur

Re: [pve-devel] [PATCH v4 qemu-server 11/11] qcow2: add external snapshot support

2025-04-04 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- Hi Fabian, >>the first one is the renaming of a blockdev while it is used, which >>is currently done like this: >>-- "link" snapshot path to make it available under old and new name >>-- handle blockdev additions/reopening/backing-file updates/deletions >>on the qemu layer >>

Re: [pve-devel] [PATCH cluster/docs/manager/network/proxmox{, -ve-rs, -firewall, -perl-rs} 00/52] Add SDN Fabrics

2025-04-04 Thread Hannes Duerr
On 3/28/25 18:12, Gabriel Goller wrote: This series allows the user to add fabrics such as OpenFabric and OSPF over their clusters. Overview This series allows the user to create routed networks ('fabrics') across their clusters, which can be used as the underlay network for a EVPN c

Re: [pve-devel] [PATCH proxmox v3 2/2] network-types: add hostname type

2025-04-04 Thread Wolfgang Bumiller
On Tue, Apr 01, 2025 at 04:52:44PM +0200, Stefan Hanreich wrote: > Add a type for representing Linux hostnames. These are the same > constraints as the installer enforces [1]. Lowercasing is fine as > well, since practically everything treats hostnames case-insensitively > as RFC 952 stipulates: >

Re: [pve-devel] [PATCH-SERIES qemu/storage/qemu-server/container/manager v7 00/37] backup provider API

2025-04-04 Thread Fiona Ebner
Am 02.04.25 um 17:15 schrieb Friedrich Weber: > - I needed to install nbdfuse and modprobe nbd -- might be nice to do > both automatically somehow (though packages of external backup plugins > could probably add nbdfuse as a dependency?) No, modprobe nbd is really only needed for the POC testing o

[pve-devel] applied: [PATCH installer v2] gui: always set visible-child-name on disk dialog

2025-04-04 Thread Thomas Lamprecht
Am 04.04.25 um 10:39 schrieb Maximiliano Sandoval: > We show the size selection stack page whenever a filesystem is selected > in the dropdown. > > At the moment when one selects certain raid setups (e.g. btrfs RAID10), > then enters the Advanced Options page and then selects certain non-raid > se

Re: [pve-devel] [PATCH proxmox v3 2/2] network-types: add hostname type

2025-04-04 Thread Wolfgang Bumiller
On Fri, Apr 04, 2025 at 01:26:46PM +0200, Stefan Hanreich wrote: > > > On 4/4/25 09:51, Stefan Hanreich wrote: > >>> +/// > >>> +/// It checks for the following conditions: > >>> +/// * At most 63 characters long. > >>> +/// * It must not start or end with a hyphen. > >>> +/// * Must only contain

[pve-devel] [PATCH pve-docs] amd-sev: add SEV-SNP infos and improve documentation

2025-04-04 Thread Markus Frank
add SEV-SNP limitations, example configuration and hyperlinks for more information Signed-off-by: Markus Frank --- qm.adoc | 51 +++ 1 file changed, 39 insertions(+), 12 deletions(-) diff --git a/qm.adoc b/qm.adoc index 2617a7c..3aa0406 100644 ---

Re: [pve-devel] [PATCH qemu-server v2 5/8] machine: add S3/S4 power state properties

2025-04-04 Thread Fiona Ebner
Am 07.03.25 um 15:44 schrieb Dominik Csapak: > So users can disable them (they're enabled by default in QEMU) > > Signed-off-by: Dominik Csapak > --- > changes from v1: > * rework the method with suggestions from fiona > * change way we add flags because we don't have globalflags anymore > > PV

Re: [pve-devel] [PATCH installer] proxmox-chroot: replace nix::(u)mount calls with external (u)mount

2025-04-04 Thread Wolfgang Bumiller
On Tue, Mar 11, 2025 at 02:27:29PM +0100, Christoph Heiss wrote: > Comes with a reduction of 52 -> 40 in terms of crate dependencies for > proxmox-chroot, 198 -> 192 for a full workspace build. > > Currently, this is done inconsistently anyway, i.e. there are calls to > the external mount(8) as we

Re: [pve-devel] [PATCH qemu-server v2 7/8] api: qemu machine capabilities: add custom pveX versions too

2025-04-04 Thread Fiona Ebner
Am 07.03.25 um 15:44 schrieb Dominik Csapak: > Add the pveX variants (where X > 0) to the list too, so one knows they > exits. Also this allows them to be shown and chosen in the UI. > > Signed-off-by: Dominik Csapak > --- > new in v2 > PVE/API2/Qemu/Machine.pm | 24 +++- > 1

[pve-devel] [PATCH corosync] corosync.service: add patch to reduce log spam in broken network setups

2025-04-04 Thread Friedrich Weber
Since c761053 ("Check packets come from the correct interface https://github.com/corosync/corosync/issues/750";) in kronosnet, corosync will produce log messages in certain broken network setups. See inner patch for details. Drawing attention to such setups is desirable because such setups may expe

[pve-devel] applied: [PATCH pve-cluster v2 1/1] notify: add common_template_data

2025-04-04 Thread Thomas Lamprecht
Am 28.03.25 um 11:19 schrieb Lukas Wagner: > This commit add the `common_template_data` sub to PVE::Notify, > providing a convenient way to get a hash with properties that > should be accessible from all templates, namely hostname, fqdn > and cluster-name. > > Signed-off-by: Lukas Wagner > --- >

[pve-devel] [PATCH installer v2] gui: always set visible-child-name on disk dialog

2025-04-04 Thread Maximiliano Sandoval
We show the size selection stack page whenever a filesystem is selected in the dropdown. At the moment when one selects certain raid setups (e.g. btrfs RAID10), then enters the Advanced Options page and then selects certain non-raid setups (e.g ext4), the `raiddisk` page will still be visible sinc

[pve-devel] applied: [PATCH proxmox-ve-rs] config: fix a few clippy warnings

2025-04-04 Thread Thomas Lamprecht
Am 17.01.25 um 08:51 schrieb Christoph Heiss: > .. as newly introduced with 1.84. > > Namely `elided_named_lifetimes` for the change of `SdnConfig` and > `clippy::needless_lifetimes` for the rest. > > Signed-off-by: Christoph Heiss > --- > proxmox-ve-config/src/firewall/parse.rs | 6 +++--- > p

Re: [pve-devel] [PATCH installer] gui: always set visible-child-name on disk dialog

2025-04-04 Thread Maximiliano Sandoval
Thomas Lamprecht writes: > Am 01.04.25 um 15:09 schrieb Maximiliano Sandoval: >> The commit message should be updated, I will do that if there is a need >> for v2. > > Can you please either send out a v2 or propose a new commit message that I > can just copy+paste in full? v2 at https://lore.

[pve-devel] applied: [PATCH installer] proxinstall: replace usage of hacky `mngmt_nic_id` config option

2025-04-04 Thread Thomas Lamprecht
Am 24.03.25 um 14:19 schrieb Christoph Heiss: > The option was more or less a hack from the beginning anyway, introduced > during the split of the GUI and the installation configuration. > > The required information is already there from `mngmt_nic` - which > carries the name of the network interf

[pve-devel] [PATCH v2 qemu] PVE backup: backup access api: simplify bitmap logic

2025-04-04 Thread Fiona Ebner
Currently, only one bitmap name per target is planned to be used. Simply use the target ID itself as the bitmap name. This allows to simplify the logic quite a bit and there also is no need for the backup_access_bitmaps hash table anymore. For the return value, the bitmap names are still passed al

[pve-devel] [PATCH qemu-server 1/2] tests: cfg2cmd: add test for audio device

2025-04-04 Thread Dominik Csapak
this was not covered by any other test Signed-off-by: Dominik Csapak --- test/cfg2cmd/audio.conf | 15 +++ test/cfg2cmd/audio.conf.cmd | 37 + 2 files changed, 52 insertions(+) create mode 100644 test/cfg2cmd/audio.conf create mode 100644 tes

Re: [pve-devel] [PATCH storage v4 09/27] plugin: introduce new_backup_provider() method

2025-04-04 Thread Fabian Grünbichler
> Andreas Rogge hat am 03.04.2025 18:08 CEST > geschrieben: > Am 03.04.25 um 09:24 schrieb Wolfgang Bumiller: > > I *believe* `qemu-nbd` should be able to bind all the storage types we > > want to restore to to /dev/nbdXY devices, which would give the provider > > a bunch of block devices to wr

[pve-devel] applied-series: [PATCH installer 0/2] auto: add option to poweroff system after installation

2025-04-04 Thread Thomas Lamprecht
Am 31.03.25 um 14:20 schrieb Christoph Heiss: > Fixes #5880 [0]. > > This can be useful for certain scenarios, such as being able to > provision a stack of servers using the auto-installer and afterwards > being able to work on the servers without time pressure, such as e.g. > removing the install

[pve-devel] [PATCH qemu-server v3 3/8] machine: correctly select pve machine version for non pinned windows guests

2025-04-04 Thread Dominik Csapak
when we don't have a specific machine version on a windows guest, we use the creation meta info to pin the machine version. Currently we always append the pve machine version from the current installed kvm version, which is not necessarily the version we pinned the guest to. Instead, use the same

[pve-devel] applied: [PATCH installer 3/6] auto: tests: allow testing for serde parse errors of answer files

2025-04-04 Thread Thomas Lamprecht
Am 27.03.25 um 16:17 schrieb Christoph Heiss: > In certain cases, it can be useful for (expected) parse failures, where > the error message then also comes directly from serde. > > Signed-off-by: Christoph Heiss > --- > proxmox-auto-installer/tests/parse-answer.rs | 21 +++- > 1

[pve-devel] applied: [PATCH pve-ha-manager v2 1/1] notifications: overhaul fence notification

2025-04-04 Thread Thomas Lamprecht
Am 28.03.25 um 11:19 schrieb Lukas Wagner: > - try to make template variable names more clear (in preparation > for #6143) > - add common tempate variables (fqdn, hostname, cluster-name) > - Instead of dumping the status-data variable as a JSON blob we > add template variables for the most usef

[pve-devel] [PATCH proxmox-firewall v2 1/1] firewall: nftables: migrate to proxmox-network-types

2025-04-04 Thread Stefan Hanreich
The fabrics patch series moved some generic network types into its own crate, so they can be reused across crates. Migrate proxmox-firewall to use the new proxmox-network-types crate instead of proxmox_ve_config. Signed-off-by: Stefan Hanreich --- Notes: This depends on the changes in the pr

[pve-devel] [PATCH qemu-server v3 5/8] machine: add S3/S4 power state properties

2025-04-04 Thread Dominik Csapak
So users can disable them (they're enabled by default in QEMU) Signed-off-by: Dominik Csapak Reviewed-by: Fiona Ebner --- changes from v2: * different name for function * removed comment intended for next patch * don't put function call inside 'if ()' PVE/QemuServer.pm | 2 ++ PVE/Qem

[pve-devel] applied-series: [PATCH cluster/ha-manager/manager v2 0/6] preparation for #6143: notification template cleanup

2025-04-04 Thread Thomas Lamprecht
Am 28.03.25 um 11:19 schrieb Lukas Wagner: > With [#6143] on the horizon, notification templates, template variables > and template helpers become part of our public API and as such > we should provide some stability guarantees for them. > As a result, we use this opportunity to do a 'final' cleanu

[pve-devel] [PATCH storage v9 04/29] plugin: introduce new_backup_provider() method

2025-04-04 Thread Fiona Ebner
The new_backup_provider() method can be used by storage plugins for external backup providers. If the method returns a provider, Proxmox VE will use callbacks to that provider for backups and restore instead of using its usual backup/restore mechanisms. The backup provider API is split into two pa

Re: [pve-devel] [PATCH qemu-server/docs v2] disable S3/S4 power states by default

2025-04-04 Thread Dominik Csapak
superseeded by v3: https://lore.proxmox.com/pve-devel/20250404125345.3244659-1-d.csa...@proxmox.com/ ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH storage v9 05/29] config api/plugins: let plugins define sensitive properties themselves

2025-04-04 Thread Fiona Ebner
Hard-coding a list of sensitive properties means that custom plugins cannot define their own sensitive properties for the on_add/on_update hooks. Have plugins declare the list of their sensitive properties in the plugin data. For backwards compatibility, return the previously hard-coded list if no

[pve-devel] [PATCH storage v9 06/29] plugin api: bump api version and age

2025-04-04 Thread Fiona Ebner
Changes for version 11: * Allow declaring storage features via plugin data. * Introduce new_backup_provider() plugin method. * Allow declaring sensitive properties via plugin data. See the api changelog file for details. Signed-off-by: Fiona Ebner --- ApiChangeLog | 32 ++

[pve-devel] [PATCH storage v9 03/29] common: add deallocate helper function

2025-04-04 Thread Fiona Ebner
For punching holes via fallocate. This will be useful for the external backup provider API to discard parts of the source. The 'file-handle' mechanism there uses a fuse mount, which does not implement the BLKDISCARD ioctl, but does implement fallocate. Signed-off-by: Fiona Ebner --- src/PVE/Stor

[pve-devel] [PATCH qemu-server v9 14/29] test: qemu img convert: add test cases for snapshots

2025-04-04 Thread Fiona Ebner
Signed-off-by: Fiona Ebner --- test/run_qemu_img_convert_tests.pl | 18 ++ 1 file changed, 18 insertions(+) diff --git a/test/run_qemu_img_convert_tests.pl b/test/run_qemu_img_convert_tests.pl index 20ff387a..29c188d8 100755 --- a/test/run_qemu_img_convert_tests.pl +++ b/test/ru

[pve-devel] [PATCH container v9 27/29] api: add early check against restoring privileged container from external source

2025-04-04 Thread Fiona Ebner
While restore_external_archive() already has a check, that happens after an existing container is destroyed. Signed-off-by: Fiona Ebner --- src/PVE/API2/LXC.pm | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 7cb5122..6cd771c 100

[pve-devel] [PATCH container v9 23/29] backup: implement restore for external providers

2025-04-04 Thread Fiona Ebner
First, the provider is asked about what restore mechanism to use. Currently, 'directory' and 'tar' are possible. The 'directory' mechanism is for restoring from a directory containing the container's full filesystem structure, which is restored by piping from a privileged tar cf - to tar xf - in th

[pve-devel] [PATCH manager v9 29/29] backup: implement backup for external providers

2025-04-04 Thread Fiona Ebner
Call job_{init,cleanup}() and backup_{init,cleanup}() methods so that backup providers can prepare and clean up for the whole backup job and for individual guest backups. It is necessary to adapt some log messages and special case some things like is already done for PBS, e.g. log file handling.

[pve-devel] [PATCH container v9 21/29] add LXC::Namespaces module

2025-04-04 Thread Fiona Ebner
The module includes a run_in_userns() helper to run a Perl subroutine in a user namespace. The first use case is running the container backup subroutine for external providers inside a user namespace. That allows them to see the filesystem to back-up from the containers perspective and also improv

[pve-devel] [PATCH qemu-server v9 18/29] backup: future-proof checks for QEMU feature support

2025-04-04 Thread Fiona Ebner
The features returned by the 'query-proxmox-support' QMP command are booleans, so just checking for definedness is not enough in principle. In practice, a feature is currently always true if defined. Still, fix the checks, should the need to disable support for a feature ever arise in the future an

[pve-devel] [PATCH container v9 26/29] restore tar archive: check potentially untrusted archive

2025-04-04 Thread Fiona Ebner
'tar' itself already protects against '..' in component names and strips absolute member names when extracting (if not used with the --absolute-names option) and in general seems sane for extracting. Additionally, the extraction already happens in the user namespace associated to the container. So

[pve-devel] [PATCH storage v9 02/29] add storage_has_feature() helper function

2025-04-04 Thread Fiona Ebner
Which looks up whether a storage supports a given feature in its 'plugindata'. This is intentionally kept simple and not implemented as a plugin method for now. Should it ever become more complex requiring plugins to override the default implementation, it can later be changed to a method. Suggest

[pve-devel] [PATCH qemu-server v9 10/29] backup: keep track of block-node size for fleecing

2025-04-04 Thread Fiona Ebner
For fleecing, the size needs to match exactly what QEMU sees. In particular, EFI disks might be attached with a 'size=' option, meaning that size can be different from the volume's size. Commit 36377acf ("backup: disk info: also keep track of size") introduced size tracking and it was used for flee

Re: [pve-devel] [PATCH docs v3 1/1] qm: pve machine version: add section to explain +pveX versions

2025-04-04 Thread Stoiko Ivanov
some suggestions for rephrasings inline: On Fri, 4 Apr 2025 14:53:45 +0200 Dominik Csapak wrote: > and clarify what windows guests will be pinned to. > > Signed-off-by: Dominik Csapak > --- > changes from v2: > * mention that windows gets pinned during guest creation > > qm.adoc | 15 +++

[pve-devel] [PATCH cluster/guest-common/docs/qemu-server/manager v16 0/12] virtiofs

2025-04-04 Thread Markus Frank
Virtio-fs is a shared file system that enables sharing a directory between host and guest VMs. It takes advantage of the locality of virtual machines and the hypervisor to get a higher throughput than the 9p remote file system protocol. build-order: 1. cluster 2. guest-common 3. docs 4. qemu-serve

[pve-devel] [PATCH cluster v16 1/12] add mapping/dir.cfg for resource mapping

2025-04-04 Thread Markus Frank
Add it to both the perl side (PVE/Cluster.pm) and pmxcfs side (status.c). This dir.cfg is used to map directory IDs to paths on selected hosts. Signed-off-by: Markus Frank Reviewed-by: Fiona Ebner Reviewed-by: Laurențiu Leahu-Vlăducu Tested-by: Laurențiu Leahu-Vlăducu Tested-by: Daniel Kral T

[pve-devel] [PATCH guest-common v16 2/12] add dir mapping section config

2025-04-04 Thread Markus Frank
Adds a config file for directories by using a 'map' property string for each node mapping. example config: ``` some-dir-id map node=node1,path=/path/to/share/ map node=node2,path=/different/location/ ``` Signed-off-by: Markus Frank --- v16: * renamed verify_path to pve_verify_pat

[pve-devel] [PATCH qemu-server v16 4/12] control: add virtiofsd as runtime dependency for qemu-server

2025-04-04 Thread Markus Frank
Signed-off-by: Markus Frank Reviewed-by: Fiona Ebner Reviewed-by: Laurențiu Leahu-Vlăducu Tested-by: Laurențiu Leahu-Vlăducu Tested-by: Daniel Kral Tested-by: Lukas Wagner --- no changes in v16 debian/control | 1 + 1 file changed, 1 insertion(+) diff --git a/debian/control b/debian/contro

[pve-devel] [PATCH qemu-server v16 5/7] fix #1027: virtio-fs support

2025-04-04 Thread Markus Frank
add support for sharing directories with a guest vm. virtio-fs needs virtiofsd to be started. In order to start virtiofsd as a process (despite being a daemon it is does not run in the background), a double-fork is used. virtiofsd should close itself together with QEMU. There are the parameters

[pve-devel] [PATCH manager v16 09/12] ui: add edit window for dir mappings

2025-04-04 Thread Markus Frank
Signed-off-by: Markus Frank --- v16: * adapted error message and added comment why there is also an error message in the GUI www/manager6/Makefile | 1 + www/manager6/window/DirMapEdit.js | 204 ++ 2 files changed, 205 insertions(+) create mode 100644 w

[pve-devel] [PATCH manager v16 12/12] ui: add options to add virtio-fs to qemu config

2025-04-04 Thread Markus Frank
Signed-off-by: Markus Frank --- v16: * added hint for directory mapping in VirtiofsEdit www/manager6/Makefile | 1 + www/manager6/Utils.js | 1 + www/manager6/qemu/HardwareView.js | 19 www/manager6/qemu/VirtiofsEdit.js | 143 ++ 4 fi

[pve-devel] [PATCH manager v16 10/12] ui: add resource mapping view for directories

2025-04-04 Thread Markus Frank
Signed-off-by: Markus Frank Reviewed-by: Daniel Kral Tested-by: Daniel Kral --- no changes in v16 www/manager6/Makefile | 1 + www/manager6/dc/Config.js | 10 + www/manager6/dc/DirMapView.js | 38 +++ 3 files changed, 49 insertions(+) creat

[pve-devel] [PATCH qemu-server v16 7/12] disable snapshot (with RAM) and hibernate with virtio-fs devices

2025-04-04 Thread Markus Frank
Signed-off-by: Markus Frank Reviewed-by: Fiona Ebner Reviewed-by: Laurențiu Leahu-Vlăducu Tested-by: Laurențiu Leahu-Vlăducu Tested-by: Daniel Kral Tested-by: Lukas Wagner --- no changes in v16 PVE/QemuServer.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/PVE/Qe

[pve-devel] [PATCH docs v16 3/12] add doc section for the shared filesystem virtio-fs

2025-04-04 Thread Markus Frank
Signed-off-by: Markus Frank Reviewed-by: Daniel Kral --- no changes in v16 qm.adoc | 102 ++-- 1 file changed, 100 insertions(+), 2 deletions(-) diff --git a/qm.adoc b/qm.adoc index 2617a7c..63632fc 100644 --- a/qm.adoc +++ b/qm.adoc @@ -1202

[pve-devel] [PATCH manager v16 11/12] ui: form: add selector for directory mappings

2025-04-04 Thread Markus Frank
Signed-off-by: Markus Frank Reviewed-by: Laurențiu Leahu-Vlăducu Tested-by: Laurențiu Leahu-Vlăducu Tested-by: Daniel Kral Tested-by: Lukas Wagner --- no changes in v16 www/manager6/Makefile | 1 + www/manager6/form/DirMapSelector.js | 63 + 2 files

[pve-devel] [PATCH qemu-server v16 6/12] migration: check_local_resources for virtiofs

2025-04-04 Thread Markus Frank
add dir mapping checks to check_local_resources Since the VM needs to be powered off for migration, migration should work with a directory on shared storage with all caching settings. Signed-off-by: Markus Frank --- v16: * rebase to master * replaced push with $mapped_res->{$k} = { name => $entr

[pve-devel] [PATCH manager v16 08/12] api: add resource map api endpoints for directories

2025-04-04 Thread Markus Frank
Signed-off-by: Markus Frank Reviewed-by: Fiona Ebner Reviewed-by: Laurențiu Leahu-Vlăducu Tested-by: Laurențiu Leahu-Vlăducu Tested-by: Daniel Kral Tested-by: Lukas Wagner --- no changes in v16 PVE/API2/Cluster/Mapping.pm | 7 + PVE/API2/Cluster/Mapping/Dir.pm | 308 ++

[pve-devel] applied: [PATCH pve-manager] pve7to8: fix broken pipe warning for dkms status invocation

2025-04-04 Thread Thomas Lamprecht
Am 28.03.25 um 18:48 schrieb Christian Ebner: > The check for dkms kernel modules relies on the output of `dkms > status`. dkms command invocation will perform the following sanity > check: > ``` > if [ ! -e <(echo) ]; then > warn $"dkms will not function properly if /proc is not mounted." > fi

Re: [pve-devel] [PATCH manager v15 10/12] ui: add resource mapping view for directories

2025-04-04 Thread Daniel Kral
On 4/3/25 12:34, Markus Frank wrote: Signed-off-by: Markus Frank --- v15: * removed announce-submounts Changes LGTM here, so consider this as: Reviewed-by: Daniel Kral Tested-by: Daniel Kral ___ pve-devel mailing list pve-devel@lists.proxmox.com

Re: [pve-devel] [PATCH cluster/guest-common/docs/qemu-server/manager v15 0/12] virtiofs

2025-04-04 Thread Daniel Kral
On 4/3/25 12:34, Markus Frank wrote: Virtio-fs is a shared file system that enables sharing a directory between host and guest VMs. It takes advantage of the locality of virtual machines and the hypervisor to get a higher throughput than the 9p remote file system protocol. build-order: 1. cluste

Re: [pve-devel] [PATCH corosync] corosync.service: add patch to reduce log spam in broken network setups

2025-04-04 Thread Friedrich Weber
On 04/04/2025 11:40, Thomas Lamprecht wrote: >> I am starting to lean towards not limiting this here. However, I have >> seen multiple instances at our support portal where logs are rotated >> rather quickly and useful messages are lost. > > In dmesg (kernel ring buffer) sure, but the systemd jour

[pve-devel] [PATCH installer 2/3] tui: bootdisk: always return proper value for default zfs max arc size

2025-04-04 Thread Christoph Heiss
In preparation for fixing #6285 [0]. `0` means to just skip writing the module parameter. But (especially) with the upcoming change in ZFS 2.3 - which makes the size basically that of the system memory minus 1 GiB - we want to always write some value. [0] https://bugzilla.proxmox.com/show_bug.cgi

[pve-devel] [PATCH installer 3/3] fix #6285: install: always set up zfs modprobe configuration

2025-04-04 Thread Christoph Heiss
Fixes #6285 [0]. Came up a few times now in the forum (most recently [0], german) and is a potential source of confusion for users, if the file does not exist on (new) installations. It makes indeed sense to just unconditionally write to /etc/modprobe.d/zfs.conf. Often users create a separate ZFS

[pve-devel] [PATCH installer 1/3] run env: always return proper value for default zfs max arc size

2025-04-04 Thread Christoph Heiss
In preparation for fixing #6285 [0]. `0` means to just skip writing the module parameter. But (especially) with the upcoming change in ZFS 2.3 - which makes the size basically that of the system memory minus 1 GiB - we want to always write some value. [0] https://bugzilla.proxmox.com/show_bug.cgi

[pve-devel] [PATCH qemu-server v3 8/8] api: qemu machine capabilities: add description for pveX variants

2025-04-04 Thread Dominik Csapak
and retroactively add descriptions for previous bumps. Signed-off-by: Dominik Csapak --- changes from v2: * added additional sentence to new machine model description PVE/API2/Qemu/Machine.pm | 9 + PVE/QemuServer/Machine.pm | 15 +++ 2 files changed, 24 insertions(+) dif

[pve-devel] [PATCH qemu-server v3 6/8] machine: bump pve machine version and reverse the s3/s4 defaults

2025-04-04 Thread Dominik Csapak
so new guests (or guests with the 'latest' machine type) have that setting automatically disabled. The previous default (enabling S3/S4), does not make too much sense in a virtual environment, and sometimes makes problems, e.g. Windows defaults to using 'hybrid shutdown' and 'fast startup' when S4

  1   2   3   >