Re: [pve-devel] [PATCH cluster v4 1/2] cluster files: add used_vmids.list

2025-03-27 Thread Severen Redwood via pve-devel
--- Begin Message --- On 26/03/2025 20:22, Thomas Lamprecht wrote: > Am 26.03.25 um 04:51 schrieb Severen Redwood: >> No problem, I've changed it to `/etc/pve/used-ids` now. Slightly more >> generic than `used-vmids` since there are also container IDs. > > Hmm, I see where you come from, but that

[pve-devel] [PATCH installer 5/6] common: options: allow user-supplied domain for network options

2025-03-27 Thread Christoph Heiss
Add an optional parameter to allow specifying a domain, which will take precedence over both the DHCP-supplied domain (if any) and the hardcoded default domain. Signed-off-by: Christoph Heiss --- proxmox-auto-installer/src/utils.rs | 2 +- proxmox-installer-common/src/options.rs | 95 ++

[pve-devel] [PATCH installer 0/6] fix #5811: add option to retrieve FQDN from DHCP configuration

2025-03-27 Thread Christoph Heiss
Fixes #5811 [0]. Adds a new option to the answer file for specifying to use the DHCP-provided hostname and domain. For the domain, an additional fallback/default can be specified, in case the DHCP server only provides hostnames. The hostname is always required in this mode. The addition to the an

[pve-devel] [PATCH installer 4/6] tui, common: move network option tests to correct crate

2025-03-27 Thread Christoph Heiss
The `NetworkOptions` struct was moved here in 5362c05cd ("common: copy common code from tui-installer") and 86c48f76f ("tui: switch to common crate") but the tests were forgotten at the original place. No functional changes. Signed-off-by: Christoph Heiss --- proxmox-installer-common/Ca

[pve-devel] [PATCH installer 2/6] auto: tests: parse-answer: allow per-test runtime env

2025-03-27 Thread Christoph Heiss
This allows to create custom runtime environment files for tests to use instead of the common one, to allow testing codepaths which depend on certain runtime-gathered values. Signed-off-by: Christoph Heiss --- proxmox-auto-installer/tests/parse-answer.rs | 14 -- 1 file changed, 12 i

[pve-devel] [PATCH installer 6/6] fix #5811: auto: add option to retrieve FQDN from DHCP configuration

2025-03-27 Thread Christoph Heiss
Fixes #5811 [0]. Adds a new option to the answer file for specifying to use the DHCP-provided hostname and domain. For the domain, an additional fallback/default can be specified, in case the DHCP server only provides hostnames. The hostname is always required in this mode. The addition to the an

[pve-devel] [PATCH installer 1/6] auto: utils: avoid a force unwrap()

2025-03-27 Thread Christoph Heiss
At this point, this value will definitely be set & valid and *should* never be `None`. Still, better be safe than sorry and just unwrap_or() with a sane default value instead. Signed-off-by: Christoph Heiss --- proxmox-auto-installer/src/utils.rs | 6 +- 1 file changed, 5 insertions(+), 1 de

[pve-devel] [PATCH proxmox-openid v4 1/1] fix #4234: openid: add library functions for optional userinfo endpoint

2025-03-27 Thread Thomas Skinner
Signed-off-by: Thomas Skinner --- proxmox-openid/src/lib.rs | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/proxmox-openid/src/lib.rs b/proxmox-openid/src/lib.rs index fe65fded..b36172c7 100644 --- a/proxmox-openid/src/lib.rs +++ b/proxmox-openid

[pve-devel] applied: [PATCH edk2-firmware] add patch to revert addition of EFI memory attributes protocol for x86_64

2025-03-27 Thread Thomas Lamprecht
Am 27.03.25 um 12:53 schrieb Fiona Ebner: > Because of a long-standing bug in shim [0], booting will fail for > distibutions that do not include the fix yet, like Rocky Linux 9.5 > and other CentOS-based distibutions. This is cased by the addition > of the EFI_MEMORY_ATTRIBUTE_PROTOCOL in edk2 comm

Re: [pve-devel] [PATCH pve-cluster 1/1] notify: add common_template_data

2025-03-27 Thread Thomas Lamprecht
Am 27.03.25 um 15:23 schrieb Lukas Wagner: > This commit add the `common_template_data` sub to PVE::Notify, > providing a convenient way to get a hash with properties that > should be accessible from all templates, namely hostname, fqdn > and cluster-name. > > Signed-off-by: Lukas Wagner > --- >

[pve-devel] applied: [PATCH offline-mirror] pom: add support for ceph squid 19.x release

2025-03-27 Thread Thomas Lamprecht
Am 27.03.25 um 14:12 schrieb Christoph Heiss: > Ceph Squid has been available through all of our Ceph repositories since > October 2024 [0], so it should be mirror-able through POM as well. > > Reported in the forum [1]. > > [0] > https://forum.proxmox.com/threads/ceph-19-2-squid-stable-release-

[pve-devel] [PATCH installer 3/6] auto: tests: allow testing for serde parse errors of answer files

2025-03-27 Thread Christoph Heiss
In certain cases, it can be useful for (expected) parse failures, where the error message then also comes directly from serde. Signed-off-by: Christoph Heiss --- proxmox-auto-installer/tests/parse-answer.rs | 21 +++- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a

[pve-devel] applied: [PATCH common] debian: drop outdated postinst script

2025-03-27 Thread Thomas Lamprecht
Am 27.03.25 um 11:23 schrieb Christoph Heiss: > In the same spirit as [0], drop the old postinst script, since major > upgrades from 6.x to 8.x are not supported/possible, in any case. > > Originally added in commit > > c5c5812e ("add postinst hook to fix /etc/aliases whitespace error") > > [0

Re: [pve-devel] About PVE Backup Integration Guide

2025-03-27 Thread Prashant Patil via pve-devel
--- Begin Message --- Ok, Thanks. I will give it a try. We also have a few questions related to the plugin. So, to fast-track the discussion, can we join over a zoom/teams call based on your availability? Thanks Prashant -Original Message- From: Fiona Ebner Sent: 27 March 2025 02:20 PM

[pve-devel] [PATCH common] debian: drop outdated postinst script

2025-03-27 Thread Christoph Heiss
In the same spirit as [0], drop the old postinst script, since major upgrades from 6.x to 8.x are not supported/possible, in any case. Originally added in commit c5c5812e ("add postinst hook to fix /etc/aliases whitespace error") [0] https://lore.proxmox.com/pve-devel/20250312125906.57953-1-f

Re: [pve-devel] [PATCH storage v5 09/32] plugin: introduce new_backup_provider() method

2025-03-27 Thread Wolfgang Bumiller
On Tue, Mar 25, 2025 at 01:50:20PM +0100, Fiona Ebner wrote: > Am 24.03.25 um 16:43 schrieb Wolfgang Bumiller: > > Just a short high level nit today, will have to look more closely at > > this and the series the next days: > > > > There's a `new()` which takes an $scfg + $storeid. > > > > But lat

[pve-devel] [PATCH edk2-firmware] add patch to revert addition of EFI memory attributes protocol for x86_64

2025-03-27 Thread Fiona Ebner
Because of a long-standing bug in shim [0], booting will fail for distibutions that do not include the fix yet, like Rocky Linux 9.5 and other CentOS-based distibutions. This is cased by the addition of the EFI_MEMORY_ATTRIBUTE_PROTOCOL in edk2 commit efaa102d00 ("UefiCpuPkg: Produce EFI memory att

Re: [pve-devel] About PVE Backup Integration Guide

2025-03-27 Thread Fiona Ebner
Am 26.03.25 um 16:06 schrieb Prashant Patil: > Hi Fiona, > Which proxmox version those patches shared earlier are based off? And are > there any specific steps/sequence to install those patches. I know we can > install package through "dpkg -i". The packages are based on the current master branc

[pve-devel] [PATCH-SERIES qemu/common/storage/qemu-server/container/manager v5 00/32] backup provider API

2025-03-27 Thread Fiona Ebner
v4: https://lore.proxmox.com/pve-devel/20241114150754.374376-1-f.eb...@proxmox.com/ v3: https://lore.proxmox.com/pve-devel/20241107165146.125935-1-f.eb...@proxmox.com/ Changes in v5: * Drop already applied patches. * Rebase on latest master. * Set finishing state and end time in backup state in

[pve-devel] [PATCH offline-mirror] pom: add support for ceph squid 19.x release

2025-03-27 Thread Christoph Heiss
Ceph Squid has been available through all of our Ceph repositories since October 2024 [0], so it should be mirror-able through POM as well. Reported in the forum [1]. [0] https://forum.proxmox.com/threads/ceph-19-2-squid-stable-release-and-ceph-17-2-quincy-soon-to-be-eol.156433/ [1] https://for

Re: [pve-devel] About PVE Backup Integration Guide

2025-03-27 Thread Fiona Ebner
Am 27.03.25 um 10:05 schrieb Prashant Patil: > We also have a few questions related to the plugin. So, to fast-track the > discussion, can we join over a zoom/teams call based on your availability? You can post the questions here. In written form, it should be faster to communicate the precise is

Re: [pve-devel] [PATCH storage v5 09/32] plugin: introduce new_backup_provider() method

2025-03-27 Thread Fiona Ebner
Am 27.03.25 um 12:03 schrieb Wolfgang Bumiller: > On Tue, Mar 25, 2025 at 01:50:20PM +0100, Fiona Ebner wrote: >> Am 24.03.25 um 16:43 schrieb Wolfgang Bumiller: >>> Just a short high level nit today, will have to look more closely at >>> this and the series the next days: >>> >>> There's a `new()`

[pve-devel] [PATCH pve-cluster 1/1] notify: add common_template_data

2025-03-27 Thread Lukas Wagner
This commit add the `common_template_data` sub to PVE::Notify, providing a convenient way to get a hash with properties that should be accessible from all templates, namely hostname, fqdn and cluster-name. Signed-off-by: Lukas Wagner --- src/PVE/Notify.pm | 20 1 file change

[pve-devel] [PATCH pve-ha-manager 1/1] notifications: overhaul fence notification

2025-03-27 Thread Lukas Wagner
- try to make template variable names more clear (in preparation for #6143) - add common tempate variables (fqdn, hostname, cluster-name) - Instead of dumping the status-data variable as a JSON blob we add template variables for the most useful information and render it in a structured manner

[pve-devel] [PATCH pve-manager 2/4] notifications: apt: clean up notification template

2025-03-27 Thread Lukas Wagner
Clean up the notification templates to prepare for user-customizable templates - Change some of the template variable names to improve clarity - Generate the table for available updates in the template itself, not via the 'table' helper. This makes it possible for users to change the style/

[pve-devel] [PATCH pve-manager 1/4] notification templates: vzdump: generate HTML table in template

2025-03-27 Thread Lukas Wagner
Instead of relying on the 'magic' table helper, we generate the guest list in the vzdump HTML notification template using native Handlebars syntax ({{#each}}). The template becomes a bit more ugly, mostly due to HTML email's requirements to use inline CSS styling, but in the context of providing us

[pve-devel] [PATCH pve-manager 4/4] notifications: test: style fixup

2025-03-27 Thread Lukas Wagner
Other commits introduced a consistent style for handlebars expressions, this commit applies the same style to test notification templates. Signed-off-by: Lukas Wagner --- templates/default/test-body.html.hbs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/default/te