Re: [pve-devel] [PATCH widget-toolkit, manager v3 0/3] ui: tasks: add button to

2025-03-24 Thread Friedrich Weber
On 18/11/2024 11:45, Aaron Lauterer wrote: > Especially in the task-log at the bottom in PVE, users might not realize > that they can open the task log with a double-click. By adding an action > column with a button, this should be easier to discover. I agree -- it's also my experience that users

Re: [pve-devel] [PATCH common 04/14] tools: add run_fork_detached() for spawning daemons

2025-03-24 Thread Christoph Heiss
On Tue Mar 18, 2025 at 11:28 AM CET, Wolfgang Bumiller wrote: > On Mon, Mar 17, 2025 at 03:11:41PM +0100, Christoph Heiss wrote: >> This essentially just does a fork() + setsid(). >> Needed to e.g. properly spawn background processes. >> >> Signed-off-by: Christoph Heiss >> --- >> Something simila

Re: [pve-devel] [PATCH] dns: powerdns: correctly handle different records types (A / AAAA)

2025-03-24 Thread Matthieu Pignolet via pve-devel
--- Begin Message --- Thank you for giving my patch a spin. The CLA was already signed under my name. --- Matthieu Pignolet On Thu, Mar 13, 2025 at 8:14 PM Stefan Hanreich wrote: > Thanks for contributing to Proxmox VE! Have you already signed a CLA [1] > with us? Otherwise we cannot accept y

[pve-devel] [PATCH novnc 1/2] upgrade noVNC and patches to 1.6.0

2025-03-24 Thread Dominik Csapak
since we cannot use the bundler to bundle to commonjs/iife anymore (see https://github.com/novnc/noVNC/issues/1943) we now bundle it into an es module and load that in a top level script tag as a module. also removes the rounded corners on panels, and removes a superfluous in the settings list.

[pve-devel] [PATCH novnc 2/2] fix broken 'extra keys' images

2025-03-24 Thread Dominik Csapak
this is currently broken upstream and it's unclear if this is the correct fix, so add it seperately until upstream fixes it themselves. Signed-off-by: Dominik Csapak --- .../patches/0020-fix-broken-extra-keys.patch | 32 +++ debian/patches/series | 1 +

[pve-devel] [PATCH novnc 0/2] upgrade novnc to 1.6.0

2025-03-24 Thread Dominik Csapak
First patch updates the submodule to point to the v1.6.0 tag, rebases the patches and changes some things (details in commit message) Second patch fixes a bug in current upstream where the 'extra key' images are not shown properly. I squashed a few things into the rebasing of the patches since it

[pve-devel] applied: [PATCH docs v2 1/6] ceph: add anchors for use in troubleshooting section

2025-03-24 Thread Aaron Lauterer
On 2025-02-05 11:08, Alexander Zeidler wrote: Signed-off-by: Alexander Zeidler --- v2: * add two missing anchors to be usable via xref pve-disk-health-monitoring.adoc | 1 + pveceph.adoc| 8 pvecm.adoc | 1 + 3 files changed, 10 insert

[pve-devel] [PATCH container v5 24/32] add LXC::Namespaces module

2025-03-24 Thread Fiona Ebner
The module includes a run_in_userns() helper to run a Perl subroutine in a user namespace. The first use case is running the container backup subroutine for external providers inside a user namespace. That allows them to see the filesystem to back-up from the containers perspective and also improv

Re: [pve-devel] [PATCH qemu v5 03/32] PVE backup: implement backup access setup and teardown API for external providers

2025-03-24 Thread Wolfgang Bumiller
On Fri, Mar 21, 2025 at 02:48:23PM +0100, Fiona Ebner wrote: > For external backup providers, the state of the VM's disk images at > the time the backup is started is preserved via a snapshot-access > block node. Old data is moved to the fleecing image when new guest > writes come in. The snapshot-

Re: [pve-devel] [PATCH pve-manager 2/2] move /run/vzdump.lock to /run/lock/vzdump.lock

2025-03-24 Thread Jing Luo via pve-devel
--- Begin Message --- On 2025-03-24 20:56, Thomas Lamprecht wrote: [...] Yeah, that I noticed later too, but it would be indeed good to check if this is a guarantee (i.e., by Debian policy) for all systems now, even if they got created with a very ancient PVE/Debian version. I only did a quick c

[pve-devel] [PATCH installer] proxinstall: replace usage of hacky `mngmt_nic_id` config option

2025-03-24 Thread Christoph Heiss
The option was more or less a hack from the beginning anyway, introduced during the split of the GUI and the installation configuration. The required information is already there from `mngmt_nic` - which carries the name of the network interface - and is easily reused to replace the functionality.

Re: [pve-devel] [PATCH container v2 0/1] close #1543: allow low-level lxc config

2025-03-24 Thread Fabian Grünbichler
> Simon LEONARD hat am 22.03.2025 19:05 CET geschrieben: > I added the validify check for each key. > > I'm not keen to allow only root@pam to change this setting, as it would > kill any attempt at automating the container creation via the API. > But maybe it should be part of a permission? it

Re: [pve-devel] [PATCH docs v1] package repos: revise Ceph section, introduce 2 attributes

2025-03-24 Thread Aaron Lauterer
On 2025-02-10 11:36, Alexander Zeidler wrote: * Remove duplicated text to maintain clarity * Mention available installation methods (web-based wizard, CLI tool) * Create a table to see the support state of Ceph releases I am not sure if having this in the rather static documentation is a

Re: [pve-devel] [PATCH manager v3] ui: vm console: autodetect novnc or xtermjs

2025-03-24 Thread Friedrich Weber
On 25/02/2025 16:47, Aaron Lauterer wrote: > Some users configure their VMs to use serial as their display. The big > benefit is that in combination with the xtermjs remote console, copy & > paste works a lot better than via novnc. I agree that defaulting to xterm.js in the serial terminal case ma

[pve-devel] applied: [PATCH novnc 0/2] upgrade novnc to 1.6.0

2025-03-24 Thread Thomas Lamprecht
Am 24.03.25 um 16:03 schrieb Dominik Csapak: > First patch updates the submodule to point to the v1.6.0 tag, rebases > the patches and changes some things (details in commit message) > > Second patch fixes a bug in current upstream where the 'extra key' > images are not shown properly. > > I squa

Re: [pve-devel] [PATCH pve-manager 2/2] move /run/vzdump.lock to /run/lock/vzdump.lock

2025-03-24 Thread Thomas Lamprecht
Am 24.03.25 um 12:41 schrieb Jing Luo: > On 2025-03-24 17:02, Thomas Lamprecht wrote: >> The same holds for all patches of this series. > > What's wrong with other patches in the series? No lock file path is > moved, b/c > /var/run is a symlink to /run and /var/lock is a symlink to /run/lock, >

Re: [pve-devel] [RFC proxmox] fix #6143: notify: allow overriding notification templates

2025-03-24 Thread Alexander Zeidler
On Mon Mar 17, 2025 at 2:43 PM CET, Lukas Wagner wrote: > Thanks a lot for this patch, much appreciated! Thank you! All of your comments are implemented in the new patch: https://lore.proxmox.com/pve-devel/20250321133341.151340-1-a.zeid...@proxmox.com/ > > On 2025-03-13 16:17, Alexander Zeidler w

Re: [pve-devel] [PATCH pve-manager 2/2] move /run/vzdump.lock to /run/lock/vzdump.lock

2025-03-24 Thread Thomas Lamprecht
Am 22.03.25 um 16:17 schrieb Jing Luo: > It's more appropriate under Debian, and vzdump.lock doesn't seem to > be used by any other package. This is very dangerous and needs a ton of work to be done right. As any vzdump job that started before a package update got installed that includes this (an

Re: [pve-devel] [PATCH pve-manager 2/2] move /run/vzdump.lock to /run/lock/vzdump.lock

2025-03-24 Thread Jing Luo via pve-devel
--- Begin Message --- On 2025-03-24 17:02, Thomas Lamprecht wrote: Am 22.03.25 um 16:17 schrieb Jing Luo: It's more appropriate under Debian, and vzdump.lock doesn't seem to be used by any other package. This is very dangerous and needs a ton of work to be done right. As any vzdump job that s

Re: [pve-devel] [PATCH container v5 24/32] add LXC::Namespaces module

2025-03-24 Thread Wolfgang Bumiller
On Fri, Mar 21, 2025 at 02:48:44PM +0100, Fiona Ebner wrote: > The module includes a run_in_userns() helper to run a Perl subroutine > in a user namespace. > > The first use case is running the container backup subroutine for > external providers inside a user namespace. That allows them to see >

[pve-devel] [PATCH qemu-server 1/1] qemu: add offline migration from dead node

2025-03-24 Thread Alexandre Derumier via pve-devel
--- Begin Message --- verify that node is dead from corosync && ssh and move config file from /etc/pve directly Signed-off-by: Alexandre Derumier --- PVE/API2/Qemu.pm | 56 1 file changed, 52 insertions(+), 4 deletions(-) diff --git a/PVE/API2/Qe

[pve-devel] [RFC qemu-server/pve-manager] Allow offline vm migration from dead nodes

2025-03-24 Thread Alexandre Derumier via pve-devel
--- Begin Message --- Currently, without HA, the only way to move a vm from a dead node, it to manually move the vm config file through ssh. This patch series add support do to it through api, with extra verification to check if the node is really dead. (corosync + ping + ssh). lxc is not yet

[pve-devel] [PATCH pve-manager 1/1] migrate: allow migration from dead node

2025-03-24 Thread Alexandre Derumier via pve-devel
--- Begin Message --- Signed-off-by: Alexandre Derumier --- www/manager6/window/Migrate.js | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/www/manager6/window/Migrate.js b/www/manager6/window/Migrate.js index 78d03921..db63e484 100644 --- a/www/manager6/wi

[pve-devel] [PATCH container v2 1/1] close #1543: allow low-level lxc config update

2025-03-24 Thread Simon LEONARD
Signed-off-by: Simon LEONARD --- src/PVE/API2/LXC/Config.pm | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/src/PVE/API2/LXC/Config.pm b/src/PVE/API2/LXC/Config.pm index 5cbc014..5e48338 100644 --- a/src/PVE/API2/LXC/Config.pm +++ b/src/PVE/API2/LXC/Config.pm

[pve-devel] [PATCH container v2 0/1] close #1543: allow low-level lxc config

2025-03-24 Thread Simon LEONARD
Hello Fabian, I added the validify check for each key. I'm not keen to allow only root@pam to change this setting, as it would kill any attempt at automating the container creation via the API. But maybe it should be part of a permission? Simon LEONARD (1): close #1543: allow low-level lxc

[pve-devel] applied: [PATCH manager v2] ui: lxc: set nesting to false for privileged container during creation

2025-03-24 Thread Thomas Lamprecht
Am 21.03.25 um 11:35 schrieb Michael Köppl: > The current implementation is slightly misleading. When creating a > privileged container, the nesting checkbox is disabled but keeps its > current state. However, nesting is not enabled for privileged containers > even if the checkbox w