Re: [pve-devel] [PATCH pve-network 1/5] controllers: fix maximum value for ASN

2025-03-11 Thread Matthieu Pignolet via pve-devel
--- Begin Message --- According to my testing, when using the `autort` for RT auto-derivation (from the frr patch) causes issues because it doesn't work with 32 bits ASNs, effectively calling the fallback to restarting frr to apply the config (which ignores the autort instruction). Le lun. 10 mars

[pve-devel] [PATCH v4 qemu-server 09/11] blockdev: change aio on target if io_uring is not default.

2025-03-11 Thread Alexandre Derumier via pve-devel
--- Begin Message --- This was a limitation of drive-mirror, blockdev mirror is able to reopen image with a different aio. Do the change when generating the blockdev_format Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 4 PVE/QemuServer/Drive.pm | 30 +++-

[pve-devel] [PATCH v4 qemu-server 07/11] blockdev: nbd_export: block-export-add : use drive-$id for nodename

2025-03-11 Thread Alexandre Derumier via pve-devel
--- Begin Message --- we have fixed nodename now Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index fcfd59b3..a9c8b758 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm

Re: [pve-devel] [PATCH 1/4] frr: bump from 8.5.2 to 10.2.1

2025-03-11 Thread Thomas Lamprecht
Hi Alexandre, On 11/03/2025 11:56, DERUMIER, Alexandre wrote: > Personally, I would wait for major pve9 before bumping frr, > > because from my experience, I had a lot of regression with frr, (really > a lot ^_^) Yeah, it's definitively a bigger jump, but having late PVE 8 and future PVE 9 start

[pve-devel] [PATCH pve_flutter_frontend] Fix #6231: Removed whitespace-trimming from password entry field

2025-03-11 Thread Alexander Abraham
A user reported a bug where they were attempting to login into our app for PVE and they used a password with two spaces at the end. The login failed because of these trailing spaces. I removed the string trimming for the password entry field during login so users can use passwords that have spaces

[pve-devel] [PATCH qemu-server v7 1/9] tests: cfg2cmd: fix mdev tests

2025-03-11 Thread Dominik Csapak
this will fail with the new checks for mdev when we don't have the correct config. namely a device that has mediated devices, should have 'mdev' set in the mapping config Reviewed-by: Christoph Heiss Reviewed-by: Fiona Ebner Signed-off-by: Dominik Csapak --- test/run_config2command_tests.pl |

Re: [pve-devel] [PATCH qemu-server v3 4/5] config: add AMD SEV-SNP support.

2025-03-11 Thread Fiona Ebner
Am 11.03.25 um 14:56 schrieb Philipp Giersfeld: > On 25/03/05 04:35PM, Fiona Ebner wrote: >> Am 24.02.25 um 13:37 schrieb Philipp Giersfeld: >>> This patch is for enabling AMD SEV-SNP support. >>> >>> Where applicable, it extends support for existing SEV(-ES) variables >>> to SEV-SNP. This means th

[pve-devel] [PATCH storage v7 3/9] plugin: allow volume import of iso, snippets, vztmpl and import

2025-03-11 Thread Filip Schauer
Extend volume import functionality to support 'iso', 'snippets', 'vztmpl', and 'import' types, in addition to the existing support for 'images' and 'rootdir'. This is a prerequisite for the ability to move ISOs, snippets and container templates between nodes. Existing behavior for importing VM dis

Re: [pve-devel] [POC storage v3 15/34] WIP Borg plugin

2025-03-11 Thread Fiona Ebner
Am 13.11.24 um 11:52 schrieb Fabian Grünbichler: > On November 7, 2024 5:51 pm, Fiona Ebner wrote: >> +my sub prepare_run_dir { >> +my ($archive, $operation) = @_; >> + >> +my $run_dir = "/run/pve-storage-borg-plugin/${archive}.${operation}"; >> +_remove_tree($run_dir); >> +make_pat

[pve-devel] [PATCH storage v7 2/9] storage migrate: avoid ssh when moving a volume locally

2025-03-11 Thread Filip Schauer
Avoid the overhead of SSH when $target_sshinfo is undefined. Instead move a volume between storages on the same node. Signed-off-by: Filip Schauer --- src/PVE/Storage.pm | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/src/PVE/Storage.pm b/src/PVE/Storage.

[pve-devel] [PATCH storage v7 5/9] introduce $vtype+meta export formats

2025-03-11 Thread Filip Schauer
These new export formats include a JSON metadata header containing the vtype and the format. This allows for future extensibility without breaking backward compatibility when adding additional metadata. Signed-off-by: Filip Schauer --- src/PVE/Storage.pm| 16 ++- src/PVE/Storage/Plug

[pve-devel] [PATCH storage v7 4/9] api: content: implement copying volumes between storages

2025-03-11 Thread Filip Schauer
Add the ability to copy an iso, snippet or vztmpl between storages and nodes. Signed-off-by: Filip Schauer --- src/PVE/API2/Storage/Content.pm | 117 1 file changed, 75 insertions(+), 42 deletions(-) diff --git a/src/PVE/API2/Storage/Content.pm b/src/PVE/API2/St

[pve-devel] [PATCH storage v7 7/9] storage: introduce decompress_archive_into_pipe helper

2025-03-11 Thread Filip Schauer
Extract the file decompression code into its own reusable subroutine. Signed-off-by: Filip Schauer Reviewed-by: Fiona Ebner --- src/PVE/Storage.pm | 64 +- 1 file changed, 40 insertions(+), 24 deletions(-) diff --git a/src/PVE/Storage.pm b/src/PVE/St

[pve-devel] [PATCH storage v7 1/9] storage migrate: remove remnant from rsync-based migration

2025-03-11 Thread Filip Schauer
rsync-based migration was replaced by import/export in commit da72898cc65b ("migrate: only use import/export") Signed-off-by: Filip Schauer --- src/PVE/Storage.pm | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/PVE/Storage.pm b/src/PVE/Storage.pm index 3b4f041..d885882 100755 --- a/src/

Re: [pve-devel] [PATCH storage v6 0/7] support moving volumes between storages

2025-03-11 Thread Filip Schauer
Superseded by: https://lore.proxmox.com/pve-devel/20250311142328.112538-1-f.scha...@proxmox.com/ On 20/01/2025 12:28, Filip Schauer wrote: Add the ability to move a backup, ISO, container template, snippet, or OVA/OVF between storages and nodes via an API method. Moving a VMA backup to a Proxmox

[pve-devel] [PATCH qemu-server v7 7/9] api: include not mapped resources for running vms in migrate preconditions

2025-03-11 Thread Dominik Csapak
so that we can show a proper warning in the migrate dialog and check it in the bulk migrate precondition check the unavailable_storages and should be the same as before, but we now always return (not_)allowed_nodes too. to make the code a bit easier to read, reorganize how we construct the (not_)

Re: [pve-devel] [PATCH zfsonlinux] patches: fix for zvol sync/flush regression

2025-03-11 Thread Stoiko Ivanov
Thanks for analysis and preparing the patch! LGTM - gave it a spin on a VM (with nested guest for testing) on kernel 6.8 - works as expected. Tested-by: Stoiko Ivanov Reviewed-by: Stoiko Ivanov On Tue, 11 Mar 2025 09:44:03 +0100 Fabian Grünbichler wrote: > this broke with 2.2.7, and can pote

[pve-devel] [PATCH guest-common/qemu-server/manager/docs v7] implement experimental vgpu live migration

2025-03-11 Thread Dominik Csapak
== Summmary == This is implemented for mapped resources. This requires driver and hardware support, but aside from nvidia vgpus there don't seem to be many drivers (if any) that do support that. qemu already supports that for vfio-pci devices, so nothing to be done there besides actively enabling

Re: [pve-devel] [PATCH 1/4] frr: bump from 8.5.2 to 10.2.1

2025-03-11 Thread Gabriel Goller
On 11.03.2025 10:56, DERUMIER, Alexandre via pve-devel wrote: Hi, Nice to see that new proxmox developpers are working on it. Personally, I would wait for major pve9 before bumping frr, This seems sensible, also because it's quite a big bump (two major versions). We'd also have to hold back

[pve-devel] [PATCH edk2-firmware/qemu-server/manager v3 0/4] AMD SEV-SNP

2025-03-11 Thread Philipp Giersfeld
This patch series adds support for AMD SEV-SNP. Where possible it mimics the existing support for AMD SEV(-ES). Running SEV-SNP VMs requires a more recent version of edk2 and OVMF firmware image. Contrary to other setups, SEV-SNP does not support loading the firmware via pflash. Instead, the fir

[pve-devel] [PATCH qemu-server v4 3/4] config: add AMD SEV-SNP support.

2025-03-11 Thread Philipp Giersfeld
This patch is for enabling AMD SEV-SNP support. Where applicable, it extends support for existing SEV(-ES) variables to SEV-SNP. This means that it retains no-debug and kernel-hashes options, but the no-key-sharing option is removed. The default policy value is identical to QEMU’s, and the theref

[pve-devel] [PATCH pve-manager v4 4/4] Add configuration options for AMD SEV-SNP

2025-03-11 Thread Philipp Giersfeld
Expand input panel with AMD SEV-SNP selection, and relevant optional parameters similar to existing options for AMD SEV(-ES). Further, upon selecting AMD SEV-SNP, issue a warning that EFI disks are not included when using SEV-SNP. Signed-off-by: Philipp Giersfeld Reviewed-by: Daniel Kral ---

[pve-devel] [PATCH storage v7 6/9] api: content: support copying backups between path based storages

2025-03-11 Thread Filip Schauer
This commit adds support for the "backup+meta" export format. When this format is used, the notes and protection flag of the backup are included in the metadata header. Signed-off-by: Filip Schauer --- src/PVE/API2/Storage/Content.pm | 10 -- src/PVE/Storage/Plugin.pm | 21

Re: [pve-devel] [PATCH qemu-server v3 4/5] config: add AMD SEV-SNP support.

2025-03-11 Thread Philipp Giersfeld
On 25/03/05 04:35PM, Fiona Ebner wrote: > Am 24.02.25 um 13:37 schrieb Philipp Giersfeld: > > This patch is for enabling AMD SEV-SNP support. > > > > Where applicable, it extends support for existing SEV(-ES) variables > > to SEV-SNP. This means that it retains no-debug and kernel-hashes > > optio

[pve-devel] [PATCH storage v7 9/9] pvesm: add a copy-volume command

2025-03-11 Thread Filip Schauer
The method can be called from the PVE shell with `pvesm copy-volume`: ``` pvesm copy-volume [--target-node ] [--delete] ``` For example to copy a VMA backup to a Proxmox Backup Server: ``` pvesm copy-volume \ local:backup/vzdump-qemu-100-2024_06_25-13_08_56.vma.zst pbs ``` Or copy a cont

[pve-devel] [PATCH storage v7 0/9] support copying volumes between storages

2025-03-11 Thread Filip Schauer
Add the ability to copy a backup, ISO, container template, snippet, or OVA/OVF between storages and nodes via an API method. Copying a VMA backup to a Proxmox Backup Server requires the proxmox-vma-to-pbs package to be installed. Currently only VMA backups can be copied to a Proxmox Backup Server a

[pve-devel] [PATCH v4 pve-storage 1/5] qcow2: add external snapshot support

2025-03-11 Thread Alexandre Derumier via pve-devel
--- Begin Message --- Signed-off-by: Alexandre Derumier --- src/PVE/Storage.pm | 4 +- src/PVE/Storage/DirPlugin.pm | 1 + src/PVE/Storage/Plugin.pm| 232 +-- 3 files changed, 196 insertions(+), 41 deletions(-) diff --git a/src/PVE/Storage.pm b/s

[pve-devel] [PATCH v4 qemu-server 04/11] blockdev: vm_devices_list : fix block-query

2025-03-11 Thread Alexandre Derumier via pve-devel
--- Begin Message --- Look at qdev value, as cdrom drives can be empty without any inserted media Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index faa17edb..5ccc026a 10

[pve-devel] [PATCH v4 qemu-server 03/11] replace qemu_block_set_io_throttle with qom-set throttlegroup limits

2025-03-11 Thread Alexandre Derumier via pve-devel
--- Begin Message --- Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 49 ++- 1 file changed, 27 insertions(+), 22 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 9ad12186..faa17edb 100644 --- a/PVE/QemuServer.pm +++ b/P

[pve-devel] [PATCH v4 qemu-server 01/11] blockdev: cmdline: convert drive to blockdev syntax

2025-03-11 Thread Alexandre Derumier via pve-devel
--- Begin Message --- The blockdev chain is: -throttle-group-node (drive-(ide|scsi|virtio)x) - format-node (fmt-drive-x) - file-node (file-drive -x) Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 195 + PVE/QemuServer/Drive.pm

[pve-devel] [PATCH v4 qemu-server 02/11] blockdev : convert qemu_driveadd && qemu_drivedel

2025-03-11 Thread Alexandre Derumier via pve-devel
--- Begin Message --- fixme/testme : PVE/VZDump/QemuServer.pm:eval { PVE::QemuServer::qemu_drivedel($vmid, "tpmstate0-backup"); }; Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 33 + 1 file changed, 13 insertions(+), 20 deletions(-) diff --git a/

[pve-devel] [PATCH v4 pve-storage 4/5] lvm: lvrename helper: allow path

2025-03-11 Thread Alexandre Derumier via pve-devel
--- Begin Message --- Signed-off-by: Alexandre Derumier --- src/PVE/Storage/LVMPlugin.pm | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm index 19dbd7e..2431fcd 100644 --- a/src/PVE/Storage/LVMPlugin.pm +++ b/s

[pve-devel] [PATCH v4 qemu-server 06/11] blockdev: block_resize: convert to blockdev

2025-03-11 Thread Alexandre Derumier via pve-devel
--- Begin Message --- We need to use the top blocknode (throttle) as name-node Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index db95af0a..fcfd59b3 100644 --- a/PVE/QemuServer.pm

[pve-devel] [PATCH v4 qemu-server 08/11] blockdev: convert drive_mirror to blockdev_mirror

2025-03-11 Thread Alexandre Derumier via pve-devel
--- Begin Message --- Signed-off-by: Alexandre Derumier --- PVE/QemuMigrate.pm| 2 +- PVE/QemuServer.pm | 65 ++- test/MigrationTest/QemuMigrateMock.pm | 10 +++-- 3 files changed, 50 insertions(+), 27 deletions(-) diff --git a/PVE

[pve-devel] [PATCH v4 qemu-server 11/11] qcow2: add external snapshot support

2025-03-11 Thread Alexandre Derumier via pve-devel
--- Begin Message --- Signed-off-by: Alexandre Derumier --- PVE/QemuConfig.pm | 4 +- PVE/QemuServer.pm | 226 +--- PVE/QemuServer/Drive.pm | 4 + 3 files changed, 220 insertions(+), 14 deletions(-) diff --git a/PVE/QemuConfig.pm b/PVE/QemuConf

[pve-devel] [PATCH v4 qemu-server 05/11] blockdev: convert cdrom media eject/insert

2025-03-11 Thread Alexandre Derumier via pve-devel
--- Begin Message --- Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 5ccc026a..db95af0a 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -52

Re: [pve-devel] [PATCH storage/zfsonlinux v2 0/3] fix #4997: lvm: avoid autoactivating (new) LVs after boot

2025-03-11 Thread Fabian Grünbichler
On March 10, 2025 3:01 pm, Friedrich Weber wrote: > On 07/03/2025 13:14, Fabian Grünbichler wrote: >>> # LVM-thick/LVM-thin >>> >>> Note that this change affects all LVs on LVM-thick, not just ones on shared >>> storage. As a result, also on single-node hosts, local guest disk LVs on >>> LVM-thick

[pve-devel] [PATCH v4 pve-storage 3/5] storage: vdisk_free: remove external snapshots

2025-03-11 Thread Alexandre Derumier via pve-devel
--- Begin Message --- Signed-off-by: Alexandre Derumier --- src/PVE/Storage.pm | 18 +- src/test/run_test_zfspoolplugin.pl | 18 ++ 2 files changed, 35 insertions(+), 1 deletion(-) diff --git a/src/PVE/Storage.pm b/src/PVE/Storage.pm index 79e5c3a.

[pve-devel] [PATCH zfsonlinux] patches: fix for zvol sync/flush regression

2025-03-11 Thread Fabian Grünbichler
this broke with 2.2.7, and can potentially cause data loss or inconsistency. the patch basically reverts to pre-2.2.7 behaviour, verified via a fio benchmark. reported on our forum: https://forum.proxmox.com/threads/163066 upstream PR: https://github.com/openzfs/zfs/pull/17131 Signed-off-by: Fab

Re: [pve-devel] [PATCH pve-network] controllers: bgp: split v4 && v6 peers in different groups

2025-03-11 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- Hi, just a remember to not lost this patch. could it be possible to apply it ? Message initial De: Alexandre Derumier via pve-devel Répondre à: Proxmox VE development discussion À: pve-devel@lists.proxmox.com Cc: Alexandre Derumier Objet: [pve-devel] [

Re: [pve-devel] [PATCH edk2-firmware v3 2/5] Add OVMF targets for AMD SEV-ES and SEV-SNP

2025-03-11 Thread Philipp Giersfeld
On 25/03/05 03:18PM, Fiona Ebner wrote: > Am 24.02.25 um 13:37 schrieb Philipp Giersfeld: > > AMD SEV-SNP boots with a single volatile firmware image OVMF.fd via the > > -bios option. > > > > Currently, an SEV-enabled VM will not boot with an OVMF > > firmware that was compiled with `SECURE_BOOT_E

Re: [pve-devel] [PATCH 1/4] frr: bump from 8.5.2 to 10.2.1

2025-03-11 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- Hi, Nice to see that new proxmox developpers are working on it. Personally, I would wait for major pve9 before bumping frr, because from my experience, I had a lot of regression with frr, (really a lot ^_^) and this really need a lot of test with different setup to be sur

[pve-devel] [PATCH guest-common v7 1/2] mapping: pci: check the mdev configuration on the device too

2025-03-11 Thread Dominik Csapak
but that lives int he 'global' part of the mapping config, not in a specific mapping. To check that, add it to the $configured_props from there. this requires all call sites to be adapted otherwise the check will always fail for devices that are capable of mediated devices Reviewed-by: Christoph

[pve-devel] [PATCH docs v7 1/2] qm: resource mapping: add description for `mdev` option

2025-03-11 Thread Dominik Csapak
in a new section about additional options Reviewed-by: Christoph Heiss Reviewed-by: Fiona Ebner Signed-off-by: Dominik Csapak --- qm.adoc | 12 1 file changed, 12 insertions(+) diff --git a/qm.adoc b/qm.adoc index 4bb8f2c..6f337fe 100644 --- a/qm.adoc +++ b/qm.adoc @@ -1944,6 +19

[pve-devel] [PATCH qemu-server v7 6/9] api: enable live migration for marked mapped pci devices

2025-03-11 Thread Dominik Csapak
They have to be marked as 'live-migration-capable' in the mapping config, and the driver and qemu must support it. For the gui checks, we now return the whole object of the mapped resources, which includes info like the name and if it's marked as live-migration capable. (while deprecating the old

[pve-devel] [PATCH manager v7 1/4] mapping: pci: include mdev in config checks

2025-03-11 Thread Dominik Csapak
by also providing the global config in assert_valid, and by also adding the mdev config in the 'toCheck' object in the gui For the gui, we extract the mdev property from the global entry, and add it to the individual mapping entries, that way we can reuse the checking logic of the other properties

[pve-devel] [PATCH qemu-server v7 8/9] migrate: show vfio state transferred too

2025-03-11 Thread Dominik Csapak
Show the transferred VFIO state (when there is one), but since there is no total here, so we can't show that, just what was transferred up until now. Reviewed-by: Christoph Heiss Reviewed-by: Fiona Ebner Signed-off-by: Dominik Csapak --- changes from v6: * removed unrelated hunk (added in the p

[pve-devel] [PATCH manager v7 4/4] fix #5175: ui: allow configuring and live migration of mapped pci resources

2025-03-11 Thread Dominik Csapak
if the hardware/driver is capable, the admin can now mark a pci device as 'live-migration-capable', which then tries enabling live migration for such devices. mark it as experimental when configuring and in the migrate window also change 'hideComment' to 'globalEdit' and reverse the logic (so hid

[pve-devel] [PATCH qemu-server v7 2/9] pci: mapping: check mdev config against hardware

2025-03-11 Thread Dominik Csapak
by giving the mapping config to assert_valid, not only the specific mapping Reviewed-by: Christoph Heiss Reviewed-by: Fiona Ebner Signed-off-by: Dominik Csapak --- PVE/QemuServer/PCI.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/PVE/QemuServer/PCI.pm b/PVE/QemuServe

[pve-devel] [PATCH manager v7 2/4] bulk migrate: improve precondition checks

2025-03-11 Thread Dominik Csapak
this now takes into account the 'not_allowed_nodes' hash we get from the api call. With that, we can now limit the 'local_resources' check for online vms only, as for offline guests, the 'unavailable-resources' hash already includes mapped devices that don't exist on the target node. This now also

[pve-devel] [PATCH docs v7 2/2] qm: resource mapping: document `live-migration-capable` setting

2025-03-11 Thread Dominik Csapak
Reviewed-by: Christoph Heiss Reviewed-by: Fiona Ebner Signed-off-by: Dominik Csapak --- qm.adoc | 6 ++ 1 file changed, 6 insertions(+) diff --git a/qm.adoc b/qm.adoc index 6f337fe..0d18d7e 100644 --- a/qm.adoc +++ b/qm.adoc @@ -1955,6 +1955,12 @@ Currently there are the following options:

[pve-devel] [PATCH qemu-server v7 5/9] check_local_resources: allow mapped devices for offline migration

2025-03-11 Thread Dominik Csapak
by not marking them as 'local_resources'. Change the description for the 'migrate' precondition api call, to clarify what 'local_resources' was meant to be (a list of devices that are blockers for migration). It could be argued that this is a breaking change, since some api client might depend on

[pve-devel] [PATCH manager v7 3/4] ui: adapt migration window to precondition api change

2025-03-11 Thread Dominik Csapak
we now return the 'allowed_nodes'/'not_allowed_nodes' also if the vm is running, when it has mapped resources. So do that checks independently so that the user has instant feedback where those resources exist. Reviewed-by: Christoph Heiss Reviewed-by: Fiona Ebner Signed-off-by: Dominik Csapak -

[pve-devel] [PATCH qemu-server v7 9/9] migrate: add transfer summary

2025-03-11 Thread Dominik Csapak
showing a final transfer log line helps with identifying what was actually transferred. E.g. it could happen that the VFIO state was only transferred in the last iteration. In such a case we would not see that information at all. Reviewed-by: Fiona Ebner Signed-off-by: Dominik Csapak --- PVE/Qe

[pve-devel] [PATCH qemu-server v7 4/9] check_local_resources: add more info per mapped device and return as hash

2025-03-11 Thread Dominik Csapak
such as the mapping name and if it's marked for live-migration (pci only) Signed-off-by: Dominik Csapak --- PVE/API2/Qemu.pm | 2 +- PVE/QemuMigrate.pm | 7 --- PVE/QemuServer.pm | 21 ++--- 3 files changed, 19 insertions(+), 11 deletions(-) diff --git a/PVE/API2/Qemu.p

Re: [pve-devel] [PATCH (guest-)common/qemu-server/manager/docs v6] implement

2025-03-11 Thread Dominik Csapak
sent a v7: https://lore.proxmox.com/pve-devel/20250311132055.2826686-1-d.csa...@proxmox.com/ ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH installer] proxmox-chroot: replace nix::(u)mount calls with external (u)mount

2025-03-11 Thread Christoph Heiss
Comes with a reduction of 52 -> 40 in terms of crate dependencies for proxmox-chroot, 198 -> 192 for a full workspace build. Currently, this is done inconsistently anyway, i.e. there are calls to the external mount(8) as well as mount(2) and umount(2) via `nix`. Just switch over to calling the ext

[pve-devel] [PATCH proxmox-perl-rs 1/3] pve: Port to 2024 edition

2025-03-11 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- pve-rs/Cargo.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pve-rs/Cargo.toml b/pve-rs/Cargo.toml index 64a7e92..81a8396 100644 --- a/pve-rs/Cargo.toml +++ b/pve-rs/Cargo.toml @@ -4,7 +4,7 @@ version = "0.9.2" description = "PVE p

Re: [pve-devel] [PATCH storage/zfsonlinux v2 0/3] fix #4997: lvm: avoid autoactivating (new) LVs after boot

2025-03-11 Thread Friedrich Weber
On 07/03/2025 13:14, Fabian Grünbichler wrote: > [...] >> # Mixed 7/8 cluster >> >> Unfortunately, we need to consider the mixed-version cluster between PVE 7 >> and >> PVE 8 because PVE 7/Bullseye's LVM does not know `--setautoactivation`. A >> user >> upgrading from PVE 7 will temporarily have

[pve-devel] [PATCH v4 pve-storage 2/5] lvmplugin: add qcow2 snapshot

2025-03-11 Thread Alexandre Derumier via pve-devel
--- Begin Message --- Signed-off-by: Alexandre Derumier --- src/PVE/Storage/LVMPlugin.pm | 228 --- 1 file changed, 210 insertions(+), 18 deletions(-) diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm index 38f7fa1..19dbd7e 100644 --- a/src/

[pve-devel] [PATCH-SERIES v4 pve-storage/qemu-server/pve-qemu] add external qcow2 snapshot support

2025-03-11 Thread Alexandre Derumier via pve-devel
--- Begin Message --- This patch series implement qcow2 external snapshot support for files && lvm volumes The current internal qcow2 snapshots have bad write performance because no metadatas can be preallocated. This is particulary visible on a shared filesystem like ocfs2 or gfs2. Also other

Re: [pve-devel] [PATCH pve-network 1/8] ipam: netbox: factor out common api methods and unify error handling

2025-03-11 Thread Stefan Hanreich
Superseded-by: https://lore.proxmox.com/pve-devel/20250310085103.30549-1-s.hanre...@proxmox.com/T/ On 3/7/25 18:43, Stefan Hanreich wrote: > Create a helper method that abstracts the common code used in making > netbox requests. Move all api_request incovations over to using the > helper method. T

[pve-devel] [PATCH edk2-firmware v4 1/4] Add OVMF targets for AMD SEV-ES and SEV-SNP

2025-03-11 Thread Philipp Giersfeld
AMD SEV-SNP boots with a single volatile firmware image OVMF.fd via the -bios option. This requires building the `OvmfPkg/OvmfPkgX64.dsc` target. Also, SEV-ES and SEV-SNP do not support SMM [1,2]. Therefore, introduce a new target build-ovmf-cvm that builds OVMF firmware suitable for AMD SEV. [1

Re: [pve-devel] [PATCH manager v6 3/5] bulk migrate: include checks for live-migratable local resources

2025-03-11 Thread Dominik Csapak
On 3/10/25 14:21, Fiona Ebner wrote: Am 10.03.25 um 13:52 schrieb Dominik Csapak: On 3/7/25 14:40, Fiona Ebner wrote: Am 07.03.25 um 14:30 schrieb Fiona Ebner: Am 13.02.25 um 14:17 schrieb Dominik Csapak: those should be able to migrate even for online vms. If the mapping does not exist on th

Re: [pve-devel] [PATCH storage v2] fix #957 iscsi: improve check_connection logic

2025-03-11 Thread Mira Limbeck
Thank you for the v2! some comments inline > +sub iscsi_test_session { > +my ($sid) = @_; > +my $cmd = [$ISCSIADM, '--mode', 'session', '--sid', $sid, '-P1']; > + > +my $res = 0; > +eval { > +run_command($cmd, errmsg => 'iscsi session test failed', outfunc => > sub { > +

[pve-devel] [PATCH storage v7 8/9] support copying VMA backups to PBS

2025-03-11 Thread Filip Schauer
Extend the copy API to support copying VMA backups to a Proxmox Backup Server. Signed-off-by: Filip Schauer --- debian/control | 1 + src/PVE/API2/Storage/Content.pm | 20 --- src/PVE/Storage/PBSPlugin.pm| 59 + 3 files changed, 76 in

[pve-devel] [PATCH guest-common v7 2/2] mapping: pci: add 'live-migration-capable' flag to mappings

2025-03-11 Thread Dominik Csapak
so that we can decide in qemu-server to allow live-migration. The driver and QEMU must be capable of that, and it's the admin's responsibility to know and configure that Mark the option as experimental in the description. Reviewed-by: Christoph Heiss Reviewed-by: Fiona Ebner Signed-off-by: Domi

[pve-devel] [PATCH qemu-server v7 3/9] pci: set 'enable-migration' to on for live-migration marked mapped devices

2025-03-11 Thread Dominik Csapak
the default is 'auto', but for those which are marked as capable for live migration, we want to explicitly enable that, so we get an early error on start if the driver does not support that. Reviewed-by: Christoph Heiss Reviewed-by: Fiona Ebner Signed-off-by: Dominik Csapak --- changes from v6:

[pve-devel] [PATCH qemu-server v4 2/4] Convert policy calculation

2025-03-11 Thread Philipp Giersfeld
Convert policy calculation to use shift operators and OR operation instead of binary numbers and addition. Signed-off-by: Philipp Giersfeld Reviewed-by: Daniel Kral Reviewed-by: Fiona Ebner Tested-by: Markus Frank --- changes since v3: https://lists.proxmox.com/pipermail/pve-devel/2025-Febr

Re: [pve-devel] [PATCH 1/4] frr: bump from 8.5.2 to 10.2.1

2025-03-11 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- >>Yeah, it's definitively a bigger jump, but having late PVE 8 and >>future >>PVE 9 start out with the same FRR version would be nice and should >>make >>backporting fixes easier; also PVE 9 should then start out more >>stable >>w.r.t. FRR and SDN stack. And yes, we looked int

Re: [pve-devel] [PATCH pve-network 1/5] controllers: fix maximum value for ASN

2025-03-11 Thread Shannon Sterz
On Fri Feb 28, 2025 at 3:01 PM CET, Stefan Hanreich wrote: > ASNs are 32-bit unsigned integers where the maximum value is > 4294967295. > > Signed-off-by: Stefan Hanreich > --- > src/PVE/Network/SDN/Controllers/EvpnPlugin.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a

[pve-devel] [PATCH qemu-server 7/8] machine: bump pve machine version and reverse the s3/s4 defaults

2025-03-11 Thread Dominik Csapak
so new guests (or guests with the 'latest' machine type) have that setting automatically disabled. The previous default (enabling S3/S4), does not make too much sense in a virtual environment, and sometimes makes problems, e.g. Windows defaults to using 'hybrid shutdown' and 'fast startup' when S4

Re: [pve-devel] [PATCH manager v6 3/5] bulk migrate: include checks for live-migratable local resources

2025-03-11 Thread Fiona Ebner
Am 10.03.25 um 14:58 schrieb Dominik Csapak: > On 3/10/25 14:21, Fiona Ebner wrote: >> Am 10.03.25 um 13:52 schrieb Dominik Csapak: >>> hmm i can try that, but i have a question on how to handle some >>> situations: >>> >>> there are the following possibilities (if I didn't forget one): >>> * non-m

[pve-devel] [PATCH pve-network v2 7/8] partial fix #5496: ipam: netbox: create / delete ip ranges for dhcp

2025-03-11 Thread Stefan Hanreich
We use the IP ranges of netbox to represent the dhcp ranges. We were already querying the IP ranges for a IP when starting a guest, but we never created the IP ranges in the first place. Additionally implement deleting the IP ranges when the subnet gets deleted. These methods try to check for any

[pve-devel] [PATCH pve-network v2 8/8] partial fix #5496: subnet: ipam: add update_subnet hook

2025-03-11 Thread Stefan Hanreich
Because of how the Netbox IPAM plugin works (utilizing IP ranges to represent DHCP ranges), we need a hook in the IPAM plugin that runs on updates to the subnet because DHCP ranges can be edited. The update hook in Netbox checks which DHCP ranges got added and which got deleted and then performs th

[pve-devel] [PATCH pve-network v2 2/8] ipam: netbox: implement deleting subnets

2025-03-11 Thread Stefan Hanreich
Deleting a subnet did not delete any created entities in Netbox. Implement deletion of a subnet by deleting all entities that are created in Netbox upon creation of a subnet. We are checking for any leftover IP assignments before deleting the prefix, so we do not accidentally delete any manually c

Re: [pve-devel] [PATCH guest-common/qemu-server/manager/docs v5 0/3] implement experimental vgpu live migration

2025-03-11 Thread Eneko Lacunza via pve-devel
--- Begin Message --- Hi Dominik, El 6/3/25 a las 12:06, Dominik Csapak escribió: On 3/5/25 11:34, Eneko Lacunza via pve-devel wrote: Hi Dominik, It is very likely we'll have access to a suitable cluster to test this before summer, provided these patches are in published packages. I can tes

[pve-devel] [PATCH v4 pve-qemu 1/1] add block-commit-replaces option patch

2025-03-11 Thread Alexandre Derumier via pve-devel
--- Begin Message --- This is needed for external snapshot live commit, when the top blocknode is not the fmt-node. (in our case, the throttle-group node is the topnode) Signed-off-by: Alexandre Derumier --- ...051-block-commit-add-replaces-option.patch | 137 ++ debian/patches/s

[pve-devel] [PATCH v4 pve-storage 5/5] lvm: add lvremove helper

2025-03-11 Thread Alexandre Derumier via pve-devel
--- Begin Message --- Signed-off-by: Alexandre Derumier --- src/PVE/Storage/LVMPlugin.pm | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm index 2431fcd..ab3563b 100644 --- a/src/PVE/Storage/LVMPlugin.p

[pve-devel] applied: [PATCH qemu-server v6 01/10] vm stop-cleanup: allow callers to decide error behavior

2025-03-11 Thread Fiona Ebner
Am 13.02.25 um 14:17 schrieb Dominik Csapak: > and keep it the same for all current callers as before by setting the > additional 'noerr' parameter to '1'. > > Signed-off-by: Dominik Csapak applied, thanks! ___ pve-devel mailing list pve-devel@lists.

[pve-devel] applied: [PATCH qemu-server v6 02/10] migrate: call vm_stop_cleanup after stopping in phase3_cleanup

2025-03-11 Thread Fiona Ebner
Am 13.02.25 um 14:17 schrieb Dominik Csapak: > we currently only call deactivate_volumes, but we actually want to call > the whole vm_stop_cleanup, since that is not invoked by the vm_stop > above (we cannot parse the config anymore) and might do other cleanups > we also want to do (like mdev clean

[pve-devel] [PATCH storage v3] fix #957 iscsi: improve check_connection logic

2025-03-11 Thread Victor Seva via pve-devel
--- Begin Message --- don't check tcp connection directly if there are already sessions. Use iscsiadm command to check the sessions status instead. pvestatd is calling check_connection every 10 seconds. This check produces a lot of noise at the iscsi server logging. Signed-off-by: Victor Seva --