Re: [pve-devel] storage plugins: what is plugindata()->{content}[1]

2025-02-25 Thread Max Carrara
On Fri Feb 7, 2025 at 1:34 PM CET, Roland Kammerer wrote: > On Fri, Feb 07, 2025 at 10:18:42AM +0100, Fabian Grünbichler wrote: > > > > > Roland Kammerer via pve-devel hat am > > > 07.02.2025 10:02 CET geschrieben: > > > Hi all, > > > > > > rather simple question I guess, but I could not find t

Re: [pve-devel] [PATCH proxmox-ve-rs] config: fix a few clippy warnings

2025-02-25 Thread Christoph Heiss
Ping, still applies. FWIW, no new warnings popped up with 1.85. On Fri Jan 17, 2025 at 8:51 AM CET, Christoph Heiss wrote: > .. as newly introduced with 1.84. > > Namely `elided_named_lifetimes` for the change of `SdnConfig` and > `clippy::needless_lifetimes` for the rest. > > Signed-off-by: Chri

[pve-devel] [PATCH proxmox-firewall] tests: integration: silence warning about unused variable

2025-02-25 Thread Christoph Heiss
It's just a stub method, so this gets never used. Signed-off-by: Christoph Heiss --- proxmox-firewall/tests/integration_tests.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proxmox-firewall/tests/integration_tests.rs b/proxmox-firewall/tests/integration_tests.rs index 61

Re: [pve-devel] QuantaStor PVE plugin

2025-02-25 Thread Max Carrara
On Mon Feb 24, 2025 at 7:41 PM CET, Seth Cagampang wrote: > To Whom It May Concern, > > My name is Seth, I am a Sr. Engineer at OSNEXUS. We have a storage solution > called QuantaStor that we are developing a storage plug-in for proxmox PVE. > The idea is to serve ZFS volumes from a QuantaStor node

[pve-devel] QuantaStor PVE plugin

2025-02-25 Thread Seth Cagampang via pve-devel
--- Begin Message --- To Whom It May Concern, My name is Seth, I am a Sr. Engineer at OSNEXUS. We have a storage solution called QuantaStor that we are developing a storage plug-in for proxmox PVE. The idea is to serve ZFS volumes from a QuantaStor node to the PVE via iscsi. I have been hacking aw

[pve-devel] [PATCH container 0/1] fix #5496: sdn: fix netbox integration

2025-02-25 Thread jonahz via pve-devel
--- Begin Message --- Hi, This patch fixes several bugs in the netbox SDN plugin. At the moment, the plugin is completely broken and doesn't work at all because it can't assign IPs correctly. Forum discussion: https://forum.proxmox.com/threads/sdn-problems-with-netbox-as-ipam.147395/ In additi

[pve-devel] [PATCH container 1/1] fix #5496: sdn: fix netbox integration

2025-02-25 Thread jonahz via pve-devel
--- Begin Message --- This fixes a bug which currently prevents the netbox plugin from assigning an IP correctly. It also makes sure to create an IP range, if none exists for the configured DHCP range. Signed-off-by: jonahz --- src/PVE/Network/SDN/Ipams/NetboxPlugin.pm | 21 +++-

Re: [pve-devel] [PATCH proxmox-i18n v2 2/2] make: add proxmox-datacenter-manager translations

2025-02-25 Thread Shannon Sterz
On Fri Jan 24, 2025 at 3:37 PM CET, Maximiliano Sandoval wrote: > The catalog-{lang}.mo files are generated only with strings that are > relevant to the proxmox-datacenter-manager instead of the whole > {lang}.po file. The msgmerge command will produce all strings containing > in the {lang}.po file

Re: [pve-devel] [PATCH proxmox-widget-toolkit 2/2] disk list: disable show smart values button if status unknown

2025-02-25 Thread Christian Ebner
On 2/25/25 17:19, Thomas Lamprecht wrote: Am 29.11.24 um 11:41 schrieb Christian Ebner: Do not allow to open the smart values window by either double clicking the record or clicking the show button, if the selected drives status is unknown. Fetching the smart values for such devices might fail.

Re: [pve-devel] [PATCH proxmox-widget-toolkit 2/2] disk list: disable show smart values button if status unknown

2025-02-25 Thread Thomas Lamprecht
Am 29.11.24 um 11:41 schrieb Christian Ebner: > Do not allow to open the smart values window by either double clicking > the record or clicking the show button, if the selected drives status > is unknown. > > Fetching the smart values for such devices might fail. Devices which > do not support thi

Re: [pve-devel] [PATCH proxmox-widget-toolkit 2/2] disk list: disable show smart values button if status unknown

2025-02-25 Thread Thomas Lamprecht
Am 25.02.25 um 17:22 schrieb Christian Ebner: > Acked, will incorporate the suggestions for both patches in a v2, thanks > for feedback! btw before I forget it: This is some nice UX fine-polishing, but IMO the smart status panel is not really ideal as main disk panel that opens on double click an

Re: [pve-devel] [PATCH proxmox-i18n v2 2/2] make: add proxmox-datacenter-manager translations

2025-02-25 Thread Maximiliano Sandoval
Maximiliano Sandoval writes: > Maximiliano Sandoval writes: > >> Maximiliano Sandoval writes: >> >>> Maximiliano Sandoval writes: >>> Maximiliano Sandoval writes: > The catalog-{lang}.mo files are generated only with strings that are > relevant to the proxmox-datacenter-ma

[pve-devel] [PATCH manager v3] ui: vm console: autodetect novnc or xtermjs

2025-02-25 Thread Aaron Lauterer
Some users configure their VMs to use serial as their display. The big benefit is that in combination with the xtermjs remote console, copy & paste works a lot better than via novnc. While the console button in the top right allows to manually choose the console type, the Console in the main subme

Re: [pve-devel] [PATCH manager v2] proxy: ui: vm console: autodetect novnc or xtermjs

2025-02-25 Thread Aaron Lauterer
I sent a v3 that implements the functionality in the UI alone. https://lore.proxmox.com/pve-devel/20250225154706.1108094-1-a.laute...@proxmox.com/T/#u On 2025-02-03 11:01, Fiona Ebner wrote: Am 25.11.24 um 11:04 schrieb Aaron Lauterer: Some users configure their VMs to use serial as their di

[pve-devel] [PATCH proxmox-i18n] update Italian translations

2025-02-25 Thread Fabio Fantoni via pve-devel
--- Begin Message --- Signed-off-by: Fabio Fantoni --- it.po | 48 1 file changed, 28 insertions(+), 20 deletions(-) diff --git a/it.po b/it.po index f591920..ca896fe 100644 --- a/it.po +++ b/it.po @@ -8,7 +8,7 @@ msgstr "" "Project-Id-Version: p

Re: [pve-devel] [PATCH proxmox-i18n v2 2/2] make: add proxmox-datacenter-manager translations

2025-02-25 Thread Maximiliano Sandoval
"Shannon Sterz" writes: > On Fri Jan 24, 2025 at 3:37 PM CET, Maximiliano Sandoval wrote: >> The catalog-{lang}.mo files are generated only with strings that are >> relevant to the proxmox-datacenter-manager instead of the whole >> {lang}.po file. The msgmerge command will produce all strings c

Re: [pve-devel] [PATCH proxmox-widget-toolkit 1/2] panel: disk list: return consistent value for unknown smart status

2025-02-25 Thread Thomas Lamprecht
Am 29.11.24 um 11:41 schrieb Christian Ebner: > Until now, the reported smart value is returned unconditionally, even > if the drive might report an `UNKNOWN` status. > To allow for better handling of the unknown smart state, also return > the utils helper text in that case. This allows for better