[pve-devel] [PATCH proxmox/proxmox-openid] fix #5076: Added extra audience verification checks.

2025-02-06 Thread Alexander Abraham
Two things were added to the proxmox-openid crate to fix bug #5076: i) the function to require strict audience checking was called and ii) an extra verifier function was added to check if the configured audiences match the receieved audiences. Signed-off-by: Alexander Abraham --- proxmox-openid/

[pve-devel] fosdem 2025 feeback

2025-02-06 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- Hi, First, Thanks to all Proxmox Team for the help during the Fosdem! It was 2 long days days for only 2 people, so it have give us some time to rest a little bit && eat. And thanks for the Dinner, it was great to meet you again. Here my notes: users feedback: - a

[pve-devel] applied: [PATCH container] backup: code cleanup: remove unused variable

2025-02-06 Thread Fiona Ebner
Before commit 2e57a9f ("vzdump: replace diskinfo with disks array") the variable was used and while the commit did change the assignment of the variable, the variable is actually unused since then. Note that '$default_mount_point' is the mountpoint of the first disk in the '$disks' array, so the s

Re: [pve-devel] [RFC v1 pve-storage 0/6] RFC: Tighter API Control for Storage Plugins

2025-02-06 Thread Fiona Ebner
Am 05.02.25 um 16:20 schrieb Max Carrara: > On Wed Feb 5, 2025 at 12:17 PM CET, Wolfgang Bumiller wrote: >> I don't think accidentally-public private helpers should be considered >> part of the API. We can just deprecate them immediately, remove them >> "soon". They aren't part of the `PVE::Storage

Re: [pve-devel] [RFC v1 pve-storage 0/6] RFC: Tighter API Control for Storage Plugins

2025-02-06 Thread Thomas Lamprecht
Am 06.02.25 um 15:05 schrieb Fiona Ebner: > Am 05.02.25 um 16:20 schrieb Max Carrara: >> On Wed Feb 5, 2025 at 12:17 PM CET, Wolfgang Bumiller wrote: >>> I don't think accidentally-public private helpers should be considered >>> part of the API. We can just deprecate them immediately, remove them >

[pve-devel] applied: [PATCH patches 1/1] fix #6142: ui: dc options: allow custom CIDRs for migration network

2025-02-06 Thread Fiona Ebner
Am 05.02.25 um 16:03 schrieb Stefan Hanreich: > Sometimes the desired migration network is not configured on any > network interfaces on the node. For instance, if there is a full-mesh > network the CIDR for the router IPs is not configured on any network > interface, but still a valid choice as mi

Re: [pve-devel] [RFC v1 pve-storage 0/6] RFC: Tighter API Control for Storage Plugins

2025-02-06 Thread Thomas Lamprecht
Am 06.02.25 um 15:56 schrieb Fiona Ebner: > There are no such strong reasons, but we didn't have such strong reasons > last time either (IIRC changing snapshot parameter for export for btrfs > or something like that). I thought we need to do that on any breaking > change? We do have a few queued up

[pve-devel] [PATCH pve-manager] fix #5076: Added a field for OpenID audiences to the configuration UI

2025-02-06 Thread Alexander Abraham
A field was added to the configuration prompt for configuring audiences in OpenID realms. Signed-off-by: Alexander Abraham --- www/manager6/dc/AuthEditOpenId.js | 9 + 1 file changed, 9 insertions(+) diff --git a/www/manager6/dc/AuthEditOpenId.js b/www/manager6/dc/AuthEditOpenId.js ind

Re: [pve-devel] [PATCH pve-docs v3] fix #5644: Split the section on creating a swap partition on a ZVol.

2025-02-06 Thread Fiona Ebner
Nit: we usually don't use a dot at the end of a commit title Am 05.02.25 um 13:41 schrieb Alexander Abraham: > The section "SWAP on ZFS" was split into two parts. The first part > contains general instructions on how to create a swap partition and > how to set the level of "swappiness". The second

[pve-devel] [PATCH pve-access-control] fix #5076: Added the "aud" field to the configuration and API schemas

2025-02-06 Thread Alexander Abraham
Added a field for OpenID audiences to the JSON schema and retrieved the data for the audiences the user configured on the frontend. Signed-off-by: Alexander Abraham --- src/PVE/API2/OpenId.pm | 5 - src/PVE/Auth/OpenId.pm | 6 ++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --g

Re: [pve-devel] [RFC v1 pve-storage 0/6] RFC: Tighter API Control for Storage Plugins

2025-02-06 Thread Fiona Ebner
Am 06.02.25 um 15:39 schrieb Thomas Lamprecht: > Am 06.02.25 um 15:05 schrieb Fiona Ebner: >> Am 05.02.25 um 16:20 schrieb Max Carrara: >>> On Wed Feb 5, 2025 at 12:17 PM CET, Wolfgang Bumiller wrote: I don't think accidentally-public private helpers should be considered part of the AP

[pve-devel] [PATCH pve-storage 2/2] iscsidirect plugin: do not use cache in list_images()

2025-02-06 Thread Dmitry Petrov via pve-devel
--- Begin Message --- A static cache key 'directiscsi' was used to cache storeid-specific information. This was causing issues in case of multiple instances. Drop $cache usage instead of fixing the issue as there is no caller using it and the same portal/storeid multiple times. Remove $storeid fr

[pve-devel] [PATCH pve-storage 1/2] rbd plugin: do not use cache in list_images()

2025-02-06 Thread Dmitry Petrov via pve-devel
--- Begin Message --- A static cache key 'rbd' was used to cache pool/storeid-specific information. This was causing issues in case of multiple RBD pools. Drop $cache usage instead of fixing the issue as there is no caller using it and the same pool/storeid multiple times. Remove $pool from rbd_l

[pve-devel] [PATCH pve-storage 0/2] fix cache issues in list_images()

2025-02-06 Thread Dmitry Petrov via pve-devel
--- Begin Message --- The discussion is here: https://bugzilla.proxmox.com/show_bug.cgi?id=6085 Dmitry Petrov (2): rbd plugin: do not use cache in list_images() iscsidirect plugin: do not use cache in list_images() src/PVE/Storage/ISCSIDirectPlugin.pm | 71 src/P