Some typos snuck in the package description and rustdoc, fix them up.
Signed-off-by: Christoph Heiss
---
proxmox-ve-config/debian/control | 2 +-
proxmox-ve-config/src/firewall/types/alias.rs | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/proxmox-ve-config/
Otherwise the callback will run once for each NIC.
Signed-off-by: Maximiliano Sandoval
---
proxinstall | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/proxinstall b/proxinstall
index 8168529..1d22e22 100755
--- a/proxinstall
+++ b/proxinstall
@@ -407,9 +407,9 @@ sub create_ip
We connect to the signal before setting the active device so it triggers.
Signed-off-by: Maximiliano Sandoval
---
proxinstall | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/proxinstall b/proxinstall
index 1d22e22..cb74cc2 100755
--- a/proxinstall
+++ b/proxinst
Instead of relying on the device_change_handler callback (which saves
the config) we manually set the text to the right value.
Signed-off-by: Maximiliano Sandoval
---
proxinstall | 20 +++-
1 file changed, 15 insertions(+), 5 deletions(-)
diff --git a/proxinstall b/proxinstall
i
> Instead of relying on the device_change_handler callback (which saves
> the config) we manually set the text to the right value.
>
> Signed-off-by: Maximiliano Sandoval
> ---
I am not completely sure if this patch series preserves the intentional
UI flow. Some testing would be welcome.
Am 26.11.24 um 16:19 schrieb Fabio Fantoni via pve-devel:
> Checking only vm configuration for choose the shutdown method causes it
> to always fail, after reaching the timeout, if the qemu agent option in
> the vm configuration is enabled but the agent is not installed and
> active in the guest.
>
Previously, the size was rounded down which, in case of an image with
non-1KiB-aligned sze (only possible for external plugins or manually
created images) would lead to errors when attempting to write beyond
the end of the too small allocated target image.
For image allocation, the size is already
Signed-off-by: Fiona Ebner
---
src/PVE/Storage/RBDPlugin.pm | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/src/PVE/Storage/RBDPlugin.pm b/src/PVE/Storage/RBDPlugin.pm
index 680e922..301918c 100644
--- a/src/PVE/Storage/RBDPlugin.pm
+++ b/src/PVE/Storage/RBD
Current export implementations luckily seems to not run into this
issue yet. However, for the upcoming implementation for RBD, mapping a
volume would print the device path to STDOUT, thus messing up the
export stream.
Signed-off-by: Fiona Ebner
---
src/PVE/CLI/pvesm.pm | 5 -
1 file changed,
For now, only 'raw+size' is supported and it's not possible to
export/import with snapshots. The volume or snapshot is mapped using
krbd and then the data is read via 'dd'.
Introducing an 'rbd' transport format might be feasible for more
complete (i.e. with snapshots, incremental) transfer between
From: Max Carrara
This module's purpose is to provide shared functions, constants, etc.
for storage plugins and storage-related operations.
It also contains the `get_deprecation_warning` subroutine that makes
it easier to warn developers and/or plugin authors that a subroutine
will be removed in
Signed-off-by: Fiona Ebner
---
src/PVE/Storage/RBDPlugin.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/PVE/Storage/RBDPlugin.pm b/src/PVE/Storage/RBDPlugin.pm
index f45ad3f..680e922 100644
--- a/src/PVE/Storage/RBDPlugin.pm
+++ b/src/PVE/Storage/RBDPlugin.pm
@@ -389,6 +389,7 @@ sub p
Signed-off-by: Fiona Ebner
---
New in v2.
src/PVE/Storage/ISCSIDirectPlugin.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/Storage/ISCSIDirectPlugin.pm
b/src/PVE/Storage/ISCSIDirectPlugin.pm
index eb329d4..6f02eee 100644
--- a/src/PVE/Storage/ISCSIDirectPlugin.p
Signed-off-by: Fiona Ebner
---
New in v2.
src/PVE/Storage/ISCSIDirectPlugin.pm | 63
1 file changed, 63 insertions(+)
diff --git a/src/PVE/Storage/ISCSIDirectPlugin.pm
b/src/PVE/Storage/ISCSIDirectPlugin.pm
index 6f02eee..e5f6808 100644
--- a/src/PVE/Storage/ISCSI
Changes in v2:
* add fix for path() in iSCSI direct plugin
* add export for iSCSI plugins
* add RFC for improving RBD volume exists helper
For remote migration, export/import functionality is also useful for
storages that are shared within a single cluster. While file-based
network storages alread
Only claim that the image does not exist if the error message
indicates it.
Signed-off-by: Fiona Ebner
---
If we don't want to match the error, I'll switch the helper over to
list volumes and check there.
New in v2.
src/PVE/Storage/RBDPlugin.pm | 6 +-
1 file changed, 5 insertions(+), 1 d
Signed-off-by: Fiona Ebner
---
New in v2.
src/PVE/Storage/ISCSIPlugin.pm | 48 ++
1 file changed, 48 insertions(+)
diff --git a/src/PVE/Storage/ISCSIPlugin.pm b/src/PVE/Storage/ISCSIPlugin.pm
index 6de7610..eb70453 100644
--- a/src/PVE/Storage/ISCSIPlugin.pm
+++
*** Broke down a long sentence and fixed some typos. ***
Alexander Abraham (2):
Section on ZFS and swap corrected.
Split a long sentence and corrected some typos.
local-zfs.adoc | 37 ++---
1 file changed, 2 insertions(+), 35 deletions(-)
--
2.39.5
__
Am 17.12.24 um 12:36 schrieb Christoph Heiss:
> Some typos snuck in the package description and rustdoc, fix them up.
>
> Signed-off-by: Christoph Heiss
> ---
> proxmox-ve-config/debian/control | 2 +-
> proxmox-ve-config/src/firewall/types/alias.rs | 4 ++--
> 2 files changed, 3 in
Am 17.12.24 um 10:32 schrieb Dominik Csapak:
> namely 'cpu' and 'mem'
>
> Signed-off-by: Dominik Csapak
> ---
> PVE/QemuServer.pm | 11 +++
> 1 file changed, 11 insertions(+)
>
>
applied both patches, thanks!
___
pve-devel mailing list
pve-
Am 13.12.24 um 17:34 schrieb Fiona Ebner:
> Am 13.12.24 um 17:30 schrieb Fiona Ebner:
>> +run_command(['dd', "if=$file", "bs=64k", "status=progress"], output =>
>> '>&'.fileno($fh));
>
> ---snip---
>
>> +run_command(['dd', "of=$file", 'bs=64k'], input => '<&'.fileno($fh));
>
>
> Forgot
---
local-zfs.adoc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/local-zfs.adoc b/local-zfs.adoc
index bcd02f7..b662233 100644
--- a/local-zfs.adoc
+++ b/local-zfs.adoc
@@ -627,7 +627,8 @@ You *must reboot* to activate these changes.
SWAP on ZFS
~~~
-It is stron
---
local-zfs.adoc | 36 +---
1 file changed, 1 insertion(+), 35 deletions(-)
diff --git a/local-zfs.adoc b/local-zfs.adoc
index c64fb27..bcd02f7 100644
--- a/local-zfs.adoc
+++ b/local-zfs.adoc
@@ -627,41 +627,7 @@ You *must reboot* to activate these changes.
SWA
*** Broke down a long sentence and fixed some typos. ***
Alexander Abraham (2):
Section on ZFS and swap corrected.
Split a long sentence and corrected some typos.
local-zfs.adoc | 37 ++---
1 file changed, 2 insertions(+), 35 deletions(-)
--
2.39.5
__
namely 'cpu' and 'mem'
Signed-off-by: Dominik Csapak
---
src/PVE/LXC.pm | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index e78e365..4d20645 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -127,6 +127,12 @@ our $vmstatus_return_properties =
---
local-zfs.adoc | 36 +---
1 file changed, 1 insertion(+), 35 deletions(-)
diff --git a/local-zfs.adoc b/local-zfs.adoc
index c64fb27..bcd02f7 100644
--- a/local-zfs.adoc
+++ b/local-zfs.adoc
@@ -627,41 +627,7 @@ You *must reboot* to activate these changes.
SWA
*** Added a warning about using ZFS on swap. ***
Alexander Abraham (1):
Added a warning that using ZFS on swap could lead to crashes and
system freezes. Removed documentation about swappiness.
local-zfs.adoc | 36 +---
1 file changed, 1 insertion(+), 35 deletions
Thanks for tackling this!
But this still doesn't really fix the issue by honoring the
`global.reboot_on_error` flag in any way, but just inverts the current
behaviour?
I.e. now it just always drops into the a shell, w/o ever auto-rebooting,
even if `global.reboot_on_error = true`.
This would need
namely 'cpu' and 'mem'
Signed-off-by: Dominik Csapak
---
PVE/QemuServer.pm | 11 +++
1 file changed, 11 insertions(+)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index b3d5f8f2..98bc07c2 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -2793,6 +2793,12 @@ our $vmstatus_r
On Wed, Nov 13, 2024 at 6:46 AM Fabian Grünbichler
wrote:
>
> this change actually does a lot more, right? it returns *all* claims,
> and also doesn't do anything groups specific at all, so the patch
> subject is not quite correct..
That's correct. I will update the commit message appropriately.
On Wed, Nov 13, 2024 at 6:46 AM Fabian Grünbichler
wrote:
>
> a few nits, mostly style related below
Will get these fixed up and submit in a v2 patch.
> On September 1, 2024 6:55 pm, Thomas Skinner wrote:
> > Signed-off-by: Thomas Skinner
> > ---
> > src/PVE/API2/OpenId.pm | 32 +++
I'm still not really all that convinced that Map.Modify is better suited
over VM.Config.HWType/Mapping.Use. Mainly as it seems reasonable to expect
the requirement/nonrequirement to still be a hw level config to the vm and
that the map should only have the role of saying which device for the
curren
On 12/13/24 11:00, Christoph Heiss wrote:
The "Automated Installation" page needs to be updated though, to
reflect:
a) that either shell-scripts or compiled binaries can be used and
b) that the compiled binaries must be (obviously) x86_64 and best case
statically linked, as there otherwise n
33 matches
Mail list logo
