Am 26.11.24 um 16:19 schrieb Fabio Fantoni via pve-devel:
> Checking only vm configuration for choose the shutdown method causes it
> to always fail, after reaching the timeout, if the qemu agent option in
> the vm configuration is enabled but the agent is not installed and
> active in the guest.
> As I seen in the windows vm the agent also crashes in some cases, so
> shutdown don't fail only if qemu guest agent is not installed or not
> started.
>
> Added check that agent is active when choosing agent shutdown method to
> avoid certain shutdown failure in those cases.
>
> Signed-off-by: Fabio Fantoni <fabio.fant...@m2r.biz>
applied, thanks! But I made a change to not set the $nowarn flag. If the
agent is configured, but not running, I do think a warning makes sense
for informational and debugging purposes.
> ---
> PVE/QemuServer.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index 2046a7c..4b6aac7 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -6341,7 +6341,7 @@ sub _do_vm_stop {
>
> eval {
> if ($shutdown) {
> - if (defined($conf) && get_qga_key($conf, 'enabled')) {
> + if (defined($conf) && get_qga_key($conf, 'enabled') &&
> qga_check_running($vmid, 1)) {
> mon_cmd($vmid, "guest-shutdown", timeout => $timeout);
> } else {
> mon_cmd($vmid, "system_powerdown");
> --
> 2.25.1
>
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
