[pve-devel] [PATCH storage] btrfs: fix handling of non-images volumes

2024-12-11 Thread Fabian Grünbichler
previously, only 'images' returned a format, now other volume types do too, so differentiate where needed. reported on the forum: https://forum.proxmox.com/threads/15/ Signed-off-by: Fabian Grünbichler --- src/PVE/Storage/BTRFSPlugin.pm | 8 1 file changed, 4 insertions(+), 4 delet

[pve-devel] applied: [PATCH storage] btrfs: fix handling of non-images volumes

2024-12-11 Thread Fiona Ebner
Am 11.12.24 um 14:48 schrieb Fabian Grünbichler: > previously, only 'images' returned a format, now other volume types do too, so > differentiate where needed. > > reported on the forum: https://forum.proxmox.com/threads/15/ > > Signed-off-by: Fabian Grünbichler applied, thanks for the quic

Re: [pve-devel] [PATCH container v2 3/3] api: return all addresses of an interface

2024-12-11 Thread Maximiliano Sandoval
Gabriel Goller writes: > + "ip-addresses" => { > + type => 'array', > + description => 'All the Addresses of the interface', > + optional => 0, > + items => { > + type => 'object', I feel 'The addre

[pve-devel] applied-series: [PATCH qemu 0/4] QEMU 9.1.2

2024-12-11 Thread Thomas Lamprecht
Am 25.11.24 um 12:00 schrieb Fiona Ebner:> No issues encountered during initial smoke testing of migration, > snapshot, backup functionality, SPICE, drive-mirror, with a selection > of different VM configs and guests. > > Fiona Ebner (4): > update submodule and patches to QEMU 9.1.2 > async s

[pve-devel] [PATCH installer] fix #5984: unconfigured: do not reboot if auto-installer fails by default

2024-12-11 Thread Daniel Kral
A unintended side effect was introduced in 21ef304, which caused the auto-installer to reboot on error, even though the answer file option `general.reboot_on_error` has been set to `false`. When an error signal is received inside `unconfigured.sh` (after the trap statement `trap 'err_reboot' ERR`)

Re: [pve-devel] [RFC PATCH installer] auto: allow a binary executable as the first boot executable

2024-12-11 Thread Daniel Kral
On 12/9/24 10:57, Christoph Heiss wrote: Why mandate the `Content-Length` header tho? For HTTP/1.1, it is only marked SHOULD [0] and for HTTP2, it is actually completely optional [1]. I've just tested it w/ and w/o the patch, both work just fine if no `Content-Length` header is sent back. Than

[pve-devel] [PATCH installer v2] auto: allow a binary executable as the first boot executable

2024-12-11 Thread Daniel Kral
As the initial use case for the first boot feature request [0] was for running shell scripts, the auto installer retrieved the binary as a `String`. Unfortunately, this tries to interpret binary data as UTF-8 and will transform 'invalid' characters to replacement characters [1]. This causes the au

[pve-devel] [PATCH pve-network] Fix #5496: NetBox add ip range

2024-12-11 Thread nurohman via pve-devel
--- Begin Message --- when ip range not available in the NetBox, function response "can't find free ip in range". Add new ip range if can't find ip range ID and response new ip range ID. Co-authored-by: Jacob Green Co-authored-by: Lou Lecrivain Signed-off-by: Nurohman --- src/PVE/Network/S

[pve-devel] [PATCH manager v2 3/3] fix #5699: pveproxy: add settings for real IP support

2024-12-11 Thread Thomas Skinner
Signed-off-by: Thomas Skinner --- PVE/Service/pveproxy.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/Service/pveproxy.pm b/PVE/Service/pveproxy.pm index ac108545..df3601bd 100755 --- a/PVE/Service/pveproxy.pm +++ b/PVE/Service/pveproxy.pm @@ -115,6 +115,8 @@ sub init {

Re: [pve-devel] [PATCH SERIES openid/access-control/docs/manager] fix #4411: add support for openid groups

2024-12-11 Thread Thomas Skinner
> It seemed to work reliably once Keycloak was configured correctly. One > thing that was confusing, even with `Overwrite Groups` no groups are set > if they aren't already configured on the PVE cluster. This is by design (and mentioned in docs patch) to prevent an arbitrary number of groups being

Re: [pve-devel] [PATCH pve-network] Fix #5496: NetBox add ip range

2024-12-11 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- Hi, I don't remember exactly when I have done the code (because dhcp range has been added after my initial implementation, where I was looking only the full prefix) but shouldn't theses ranges be added when the dhcp ranges are submitted on subnet create/update api call ? (I

[pve-devel] [PATCH docs v2 1/3] fix #5699: pveproxy: add docs for real IP support

2024-12-11 Thread Thomas Skinner
Signed-off-by: Thomas Skinner --- pveproxy.adoc | 29 + 1 file changed, 29 insertions(+) diff --git a/pveproxy.adoc b/pveproxy.adoc index 4b5dac0..29f54d7 100644 --- a/pveproxy.adoc +++ b/pveproxy.adoc @@ -198,6 +198,35 @@ content, if the client supports it. This can

[pve-devel] [PATCH http-server v2 2/3] fix #5699: pveproxy: add library methods for real IP support

2024-12-11 Thread Thomas Skinner
Signed-off-by: Thomas Skinner --- src/PVE/APIServer/AnyEvent.pm | 38 ++- src/PVE/APIServer/Utils.pm| 15 ++ 2 files changed, 52 insertions(+), 1 deletion(-) diff --git a/src/PVE/APIServer/AnyEvent.pm b/src/PVE/APIServer/AnyEvent.pm index 24209a1..

[pve-devel] [PATCH SERIES manager/http-server/docs v2 0/3] fix #5699: add support for real IP

2024-12-11 Thread Thomas Skinner
This v2 patch series continues adding support for setting a HTTP header for passing through a client IP address for logging purposes. Changes since v1: * fixed styling issues * renamed fields to clearer, more appropriate names * adjusted logging format back to previous, made option opt-in pve-d