Am 28/10/2024 um 16:58 schrieb Daniel Herzig:
> As reported here [0], statically assigned IPv6 addresses get lost
> after a short while for Rocky and Almalinux 9 containers.
>
> As pointed out by Andres, the additional option `IPV6_AUTOCONF=no`
> for the corresponding network interface seems to pr
Ping, as there are still new affected users showing up in the forum thread.
Am 30.10.24 um 10:52 schrieb Fiona Ebner:
> In the community forum, users reported issues about RCU stalls and
> sluggish VMs after taking a snapshot with RAM in Proxmox VE [0]. Mario
> was also experiencing similar issues
Am 09.09.24 um 14:39 schrieb Fabian Grünbichler:
> not that obvious behaviour on the systemd side, and missing cert renewal can
> have wide-reaching consequences.
>
> Signed-off-by: Fabian Grünbichler
> ---
> certificate-management.adoc | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git
Thanks for the review!
On Thu, Nov 07, 2024 at 04:28:25PM +0100, Aaron Lauterer wrote:
> only small nits inline
>
> Tested-By: Aaron Lauterer
> Reviewed-By: Aaron Lauterer
>
> On 2024-10-18 13:59, Christoph Heiss wrote:
> > [..]
> > diff --git a/proxmox-fetch-answer/src/fetch_plugins/partition
when starting a vm with passthrough, we have to bind all normal pci
devices to vfio-pci. This happens by
* unbinding from current driver
* telling vfio-pci the 'vendorid modelid' combo to it know this device
class can use the driver (by writing to 'new_id')
* actually binding the device to vfio-
and fix passthrough regressions
As i feared previously in [0], making it a hard error when encountering
errors during sysfs writes uncovered some situations where our code was
too strict to keep some setups working.
One such case is resetting devices, which is seemingly not necessary
at all times
the actual error and path is useful to know when trying to debug or
figure out what did not work, so warn here if there was an error.
Also takes now an optional error list that can be ignored. If
encountering such an error, returns success instead of failure.
Signed-off-by: Dominik Csapak
---
s
Since pve-common commit:
eff5957 (sysfstools: file_write: properly catch errors)
this check here fails now when the reset does not work. It turns out
that resetting the device is not always necessary, and we previously
ignored most errors when trying to do so.
To restore that functionality, dow
On 2024-11-08 10:28, Christoph Heiss wrote:
Thanks for the review!
On Thu, Nov 07, 2024 at 04:28:25PM +0100, Aaron Lauterer wrote:
only small nits inline
Tested-By: Aaron Lauterer
Reviewed-By: Aaron Lauterer
On 2024-10-18 13:59, Christoph Heiss wrote:
[..]
diff --git a/proxmox-fetch
Dominik Csapak writes:
> On 11/7/24 14:52, Aaron Lauterer wrote:
>> gave this a quick test.
>> two things I noticed:
>> * root element in tree per tag: wouldn't it be better to override
>> the display style to 'full'? Otherwise I might have a lot of
>> colorful dots, but don't know what the tags
On Fri, Nov 08, 2024 at 10:30:18AM +0100, Aaron Lauterer wrote:
> On 2024-11-08 10:28, Christoph Heiss wrote:
> > [..]
> > Also, while reading this, seems nowhere is checked whether the
> > user-supplied value is at max 11 characters long -- I'll add that for v2
> > too.
>
> Too be honest, do we
Allow four-octet MAC prefixes in Web UI validation
update the MAC prefix validation in the Web UI to support four-octet
prefixes.
Signed-off-by: Moayad Almalat
---
src/Toolkit.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/Toolkit.js b/src/Toolkit.js
index 8a0138d..
While some filesystems - such as FAT(32) - might not supported/allow
mixed-case labels, some implementations still handle them correctly,
such as Linux. Thus, also search for that variant.
Tested-By: Aaron Lauterer
Reviewed-By: Aaron Lauterer
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
This has been requested by at least one user one user [0] and definitely
makes sense, esp. for BMCs/IPMIs where one might not be able to control
the partition label.
[0]
https://forum.proxmox.com/threads/proxmox-ais-question-request.153043/post-695689
Tested-By: Aaron Lauterer
Reviewed-By: Aaro
On Fri, Nov 08, 2024 at 01:52:54PM +0100, Timothy Nicholson wrote:
> [..]
> diff --git a/src/Utils.js b/src/Utils.js
> index 7dd034a..23b0db5 100644
> --- a/src/Utils.js
> +++ b/src/Utils.js
> @@ -305,6 +305,17 @@ utilities: {
> return Ext.htmlEncode(username);
> },
>
> +renderSystem
Thanks for giving this a shot!
One comment inline
On 2024-11-08 13:52, Timothy Nicholson wrote:
> With this patch, all systemd states and unit states in the service
> view use gettext to be translated.
>
> Signed-off-by: Timothy Nicholson
> ---
> As stated in the Bugzilla entry [0]: Up until n
Clean up the actual parsing a bit to make it more easily extensible, and
add a proper help menu.
Tested-By: Aaron Lauterer
Reviewed-By: Aaron Lauterer
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
* no changes
proxmox-fetch-answer/src/main.rs | 40 +---
1
.. for the 'partition' fetch method.
Tested-By: Aaron Lauterer
Reviewed-By: Aaron Lauterer
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
* dropped useless "proxmox-ais" explanation from --prepare-iso
command description
proxmox-auto-install-assistant/src/main.rs | 12 ++--
This series allow specifying the partition label the
`proxmox-fetch-answer` tool will search when trying to retrieve an
answer file in the 'partition' fetch mode.
This has been requested by at least one user one user [0] and definitely
makes sense, esp. for BMCs/IPMIs where one might not be able t
Am 08/11/2024 um 14:18 schrieb Fabian Grünbichler:
> modelled after setup_systemd_preset, which unfortunately doesn't work for
> static units, since those are skipped by `systemctl preset-all` which runs on
> first boot.
>
> our Debian-based templates already come with those masking symlinks in pl
> Thomas Lamprecht hat am 08.11.2024 14:40 CET
> geschrieben:
>
>
> Am 08/11/2024 um 14:18 schrieb Fabian Grünbichler:
> > modelled after setup_systemd_preset, which unfortunately doesn't work for
> > static units, since those are skipped by `systemctl preset-all` which runs
> > on
> > first
Am 08/11/2024 um 14:18 schrieb Fabian Grünbichler:
> openEuler is centOS-derived Linux distribution. the LXC project builds a
> template for it that mostly works out of the box.
>
> Signed-off-by: Fabian Grünbichler
> ---
>
> Notes:
> did some basic smoke testing using
> openeuler-24.09-
Am 28/10/2024 um 16:58 schrieb Daniel Herzig:
> As reported here [0], statically assigned IPv6 addresses get lost
> after a short while for Rocky and Almalinux 9 containers.
>
> As pointed out by Andres, the additional option `IPV6_AUTOCONF=no`
> for the corresponding network interface seems to pr
On Fri Nov 8, 2024 at 12:30 PM CET, Moayad Almalat wrote:
>
> Allow four-octet MAC prefixes in Web UI validation
> update the MAC prefix validation in the Web UI to support four-octet
> prefixes.
>
> Signed-off-by: Moayad Almalat
> ---
> src/Toolkit.js | 2 +-
> 1 file changed, 1 insertion(+), 1
With this patch, all systemd states and unit states in the service
view use gettext to be translated.
Signed-off-by: Timothy Nicholson
---
As stated in the Bugzilla entry [0]: Up until now, only two
systemd states were translated. This patch changes this so all
systemd states use gettext and are
modelled after setup_systemd_preset, which unfortunately doesn't work for
static units, since those are skipped by `systemctl preset-all` which runs on
first boot.
our Debian-based templates already come with those masking symlinks in place.
Signed-off-by: Fabian Grünbichler
---
Notes:
noti
openEuler is centOS-derived Linux distribution. the LXC project builds a
template for it that mostly works out of the box.
Signed-off-by: Fabian Grünbichler
---
Notes:
did some basic smoke testing using
openeuler-24.09-default_20241028_amd64.tar.xz from
images.linuxcontainers.org
src/
Am 06/11/2024 um 12:37 schrieb Daniel Herzig:
> This patch adds a filter to identify services, which are reported as
> 'not-found' by the api. By default they will not be shown in the UI
> anymore, but visibility can still be toggled using a new checkbox.
>
> Signed-off-by: Daniel Herzig
> ---
>
On Thu, Oct 10, 2024 at 05:56:43PM GMT, Stefan Hanreich wrote:
> Signed-off-by: Stefan Hanreich
> ---
> src/PVE/Firewall.pm | 122 ++--
> src/PVE/Firewall/Helpers.pm | 12
> 2 files changed, 128 insertions(+), 6 deletions(-)
>
> diff --git a/src/PVE/
On Fri, 8 Nov 2024 10:32:59 +0100
Dominik Csapak wrote:
> when starting a vm with passthrough, we have to bind all normal pci
> devices to vfio-pci. This happens by
>
> * unbinding from current driver
> * telling vfio-pci the 'vendorid modelid' combo to it know this device
s/to it know/so it kn
2 cosmetic nits inline:
On Fri, 8 Nov 2024 10:32:58 +0100
Dominik Csapak wrote:
> the actual error and path is useful to know when trying to debug or
> figure out what did not work, so warn here if there was an error.
>
> Also takes now an optional error list that can be ignored. If
> encounter
gave this another spin on my reproducer for the failing device-reset
- still works fine!
2 cosmetic nits for the patches aside - which from my pov can also be left
as is (or maybe fixed up when applying):
Tested-by: Stoiko Ivanov
Reviewed-by: Stoiko Ivanov
On Fri, 8 Nov 2024 10:32:57 +0100
Do
Same information as in pve-docs but translated to restructured text.
Signed-off-by: Lukas Wagner
---
docs/notifications.rst | 100 +
1 file changed, 100 insertions(+)
diff --git a/docs/notifications.rst b/docs/notifications.rst
index 4ba8db86..d059fa76 10
The code was copied and adapted from the gotify target CLI.
Signed-off-by: Lukas Wagner
---
.../notifications/mod.rs | 4 +-
.../notifications/webhook.rs | 94 +++
2 files changed, 97 insertions(+), 1 deletion(-)
create mode 100644 src/bin/
Signed-off-by: Lukas Wagner
---
notifications.adoc | 93 ++
1 file changed, 93 insertions(+)
diff --git a/notifications.adoc b/notifications.adoc
index 2459095..b7470fe 100644
--- a/notifications.adoc
+++ b/notifications.adoc
@@ -178,6 +178,99 @@ gotif
This allows us to drop the impl of that function on the perl side.
Signed-off-by: Lukas Wagner
Tested-By: Stefan Hanreich
---
common/src/notify.rs | 9 +
1 file changed, 9 insertions(+)
diff --git a/common/src/notify.rs b/common/src/notify.rs
index fe192d5..0f8a35d 100644
--- a/common/
This allows users to add/edit new webhook targets.
Signed-off-by: Lukas Wagner
Tested-By: Stefan Hanreich
---
www/Utils.js | 5 +
1 file changed, 5 insertions(+)
diff --git a/www/Utils.js b/www/Utils.js
index 4853be36..b715972f 100644
--- a/www/Utils.js
+++ b/www/Utils.js
@@ -482,6 +482,11
The widgets for editing the headers/secrets were adapted from
the 'Tag Edit' dialog from PVE's datacenter options.
Apart from that, the new dialog is rather standard. I've decided
to put the http method and url in a single row, mostly to
save space and also to make it analogous to how an actual ht
This target type allows users to perform HTTP requests to arbitrary
third party (notification) services, for instance
ntfy.sh/Discord/Slack.
The configuration for these endpoints allows one to freely configure
the URL, HTTP Method, headers and body. The URL, header values and
body support handleba
Copied and adapted from the Gotify ones.
Signed-off-by: Lukas Wagner
Tested-By: Stefan Hanreich
---
src/api2/config/notifications/mod.rs | 2 +
src/api2/config/notifications/webhook.rs | 175 +++
2 files changed, 177 insertions(+)
create mode 100644 src/api2/config/no
All in all pretty similar to other endpoint APIs.
One thing worth noting is how secrets are handled. We never ever
return the values of previously stored secrets in get_endpoint(s)
calls, but only a list of the names of all secrets. This is needed
to build the UI, where we display all secrets that
A recent commit [1] changed the `Display` implementation of `TimeSpan` such
that minutes are now displayed as `20m` instead of `20min`.
This commit adapts the tests for the notification template renderer
accordingly.
[1] 19129960 ("time: display minute/month such that it can be parsed again")
Si
From: Gabriel Goller
Add helper functions to convert from a utf8 string to a base64 string
and vice-versa. Using the TextEncoder/TextDecoder we can support unicode
such as emojis as well [0].
[0]:
https://developer.mozilla.org/en-US/docs/Glossary/Base64#the_unicode_problem
Signed-off-by: Gabri
Signed-off-by: Lukas Wagner
Tested-By: Stefan Hanreich
---
common/src/notify.rs | 63
1 file changed, 63 insertions(+)
diff --git a/common/src/notify.rs b/common/src/notify.rs
index e1b006b..fe192d5 100644
--- a/common/src/notify.rs
+++ b/common/src/
The get_targets API endpoint is now implemented in Rust.
Signed-off-by: Lukas Wagner
Tested-By: Stefan Hanreich
---
PVE/API2/Cluster/Notifications.pm | 34 +--
1 file changed, 1 insertion(+), 33 deletions(-)
diff --git a/PVE/API2/Cluster/Notifications.pm
b/PVE/API2
This series adds support for webhook notification targets to PVE
and PBS.
A webhook is a HTTP API route provided by a third-party service that
can be used to inform the third-party about an event. In our case,
we can easily interact with various third-party notification/messaging
systems and send
These just call the API implementation via the perl-rs bindings.
Signed-off-by: Lukas Wagner
Tested-By: Stefan Hanreich
---
PVE/API2/Cluster/Notifications.pm | 263 +-
1 file changed, 262 insertions(+), 1 deletion(-)
diff --git a/PVE/API2/Cluster/Notifications.pm
b
47 matches
Mail list logo
