dropping the `nomodeset` here makes little sense:
* currently users need to explicitly add it when booting the kernel,
which is probably only done when the system needs it to show any
output when booting
* it was originally removed, because the installer had a grub-entry
that explicitly disab
applied this with a followup to unify the way we document the types
across this entire object (plus line-wrapping fixups and some minor typo
& phrasing fixes...)
On Fri, Oct 25, 2024 at 04:15:10PM GMT, Dominik Csapak wrote:
> Signed-off-by: Dominik Csapak
> ---
> PVE/API2/Cluster.pm | 10 +++
Signed-off-by: Timothy Nicholson
---
changes since v2 [1]:
- renamed new function
- changed function name to camelCase
- removed redundant variable binding
- edited commit message to better convey the contents of the patch
[1]:
https://lore.proxmox.com/pve-devel/20241029103
Hi,
thanks for tackling this!
a few comments inline
On 10/28/24 12:31, Christoph Heiss wrote:
This calls the `nvidia-smi` to retrieve vGPU type properties and parses
them into a property string - much like the old vGPU mdev interface
presented them as description directly.
Unfortunately, `nvi
Am 25/10/2024 um 13:13 schrieb Friedrich Weber:
> When KRBD is enabled for an RBD storage, the storage plugin calls out
> to `rbd map` to map an RBD image as a block device on the host.
> Sometimes it might be necessary to pass custom options to `rbd map`.
> For instance, in some setups with Window
On 10/24/24 18:53, Thomas Lamprecht wrote:
Am 06/08/2024 um 14:22 schrieb Dominik Csapak:
currently when we have a pci resource mapping, we manually check only
the available models for the first pci entry. This often works, but not
always, since one could have completely different devices in one
Am 30/10/2024 um 09:42 schrieb Dominik Csapak:
> I did not find a way, and AFAICT this parameter is always part of the path,
> where we don't can give explicit names
Thanks for checking.
> Of course, we can leave the name of the parameter the same if you'd
> prefer that (with a TODO notice for 9.
Am 29/10/2024 um 13:22 schrieb Christoph Heiss:
> The patch title implies that it only adds a utility function, but the
> patch itself also includes usage for it. Something like
>
> "fix #5787: ui: include guest name in confirmation dialog"
>
> or similar would probably be a better fit.
Yes, t
Thanks for the review!
On Wed, Oct 30, 2024 at 11:13:36AM GMT, Dominik Csapak wrote:
> Hi,
>
> thanks for tackling this!
>
> a few comments inline
>
> On 10/28/24 12:31, Christoph Heiss wrote:
> > [..]
> > And FWIW, these properties could also be retrieved without going through
> > nvidia-smi usin
higher level comment, so CCing also Dominik:
Is pve-common, and possibly even SysFSTools the right place for this?
As in from a quick look this has nothing to do with sysfs directly, and
from recent development it seems like placing such things into a more
specific package, and probably also (bina
The function internally calls
PVE::Certificate::get_certificate_fingerprint which in turn calls:
```
my $fp = Net::SSLeay::X509_get_fingerprint($cert, 'sha256');
```
Signed-off-by: Maximiliano Sandoval
---
PVE/API2/Nodes.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
> Thomas Lamprecht hat am 30.10.2024 09:41 CET
> geschrieben:
>
>
> Am 25/10/2024 um 13:13 schrieb Friedrich Weber:
> > When KRBD is enabled for an RBD storage, the storage plugin calls out
> > to `rbd map` to map an RBD image as a block device on the host.
> > Sometimes it might be necessar
see my comments to the pmg-api patch(es)..
> Maximiliano Sandoval hat am 30.10.2024 13:18 CET
> geschrieben:
>
>
> The function internally calls
> PVE::Certificate::get_certificate_fingerprint which in turn calls:
>
> ```
> my $fp = Net::SSLeay::X509_get_fingerprint($cert, 'sha256');
> `
This adds a regex check for valid fingerprints.
Signed-off-by: Maximiliano Sandoval
---
Diferences from v1:
- Use get_standard_option
PVE/API2/Nodes.pm | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
index 1db148af..8dddf58b 10064
The function internally calls
PVE::Certificate::get_certificate_fingerprint which in turn calls:
```
my $fp = Net::SSLeay::X509_get_fingerprint($cert, 'sha256');
```
Signed-off-by: Maximiliano Sandoval
---
PVE/API2/Nodes.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
Maximiliano Sandoval writes:
I forgot to mark this as v2.
> This adds a regex check for valid fingerprints.
>
> Signed-off-by: Maximiliano Sandoval
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/li
Delete unused sets in nftables. We check if there are existing sets
which will not be recreated on the next iteration and delete them.
Signed-off-by: Gabriel Goller
---
proxmox-firewall/src/bin/proxmox-firewall.rs | 60 +++-
proxmox-nftables/src/client.rs | 9 ++-
Fabian Grünbichler writes:
> see my comments to the pmg-api patch(es)..
Yeah, saw them right after sending this. I sent v2 of the pmg-api patch
already, will do v2 of this one. Thanks.
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://
This is the same regex as used in pmg-api.
Signed-off-by: Maximiliano Sandoval
---
The commit message assumes
https://lists.proxmox.com/pipermail/pmg-devel/2024-October/003003.html.
PVE/API2/Nodes.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
inde
On 30/10/2024 09:41, Thomas Lamprecht wrote:
> Am 25/10/2024 um 13:13 schrieb Friedrich Weber:
>> When KRBD is enabled for an RBD storage, the storage plugin calls out
>> to `rbd map` to map an RBD image as a block device on the host.
>> Sometimes it might be necessary to pass custom options to `rb
Am 30/10/2024 um 09:59 schrieb Dominik Csapak:
> currently when we have a pci resource mapping, we manually check only
> the available models for the first pci entry. This often works, but not
> always, since one could have completely different devices in one
> mapping, or with the new nvidia sysfs
Signed-off-by: Timothy Nicholson
---
This patch introduces a confirmation dialog for applying the SDN configuration.
As stated in the bugzilla entry [1], the main point of this dialog is to warn
the user that any pending network configuration changes on the node level will
also be applied. If t
In the community forum, users reported issues about RCU stalls and
sluggish VMs after taking a snapshot with RAM in Proxmox VE [0]. Mario
was also experiencing similar issues from time to time and recently,
obtained a GDB stacktrace. The stacktrace showed that, in his case,
the vCPU threads were wa
On 2024-10-30 13:02, Timothy Nicholson wrote:
> Signed-off-by: Timothy Nicholson
> ---
> This patch introduces a confirmation dialog for applying the SDN
> configuration. As stated in the bugzilla entry [1], the main point of this
> dialog is to warn the user that any pending network configurat
Virtual cargo workspaces (workspaces without a [package] section)
default to the cargo feature resolver "1" – even though this outputs a
warning on every cargo invocation. To remove the warning, explicitly set
the resolver to version "2".
Signed-off-by: Gabriel Goller
---
Cargo.toml | 1 +
1 fil
Thanks for chiming in!
On Wed, Oct 30, 2024 at 01:08:28PM GMT, Thomas Lamprecht wrote:
> higher level comment, so CCing also Dominik:
>
> Is pve-common, and possibly even SysFSTools the right place for this?
To be honest, that was kinda my thought to when I started implementing
this, but didn't k
Am 29/10/2024 um 16:29 schrieb Aaron Lauterer:
> Does what it says. Will check definedness and not truthyness. Therefore
> values that would evaluate as falsy still end up in the config.
>
> Reviewed-By: Aaron Lauterer
> Tested-By: Aaron Lauterer
Applied this patch with your review trailers, t
currently when we have a pci resource mapping, we manually check only
the available models for the first pci entry. This often works, but not
always, since one could have completely different devices in one
mapping, or with the new nvidia sysfs api we don't get the generally
available models.
To i
Am 24/10/2024 um 11:00 schrieb Christoph Heiss:
> Currently, the TUI does not error out like the GUI if no network
> interfaces are found, so remedy that.
>
> Also, while testing, noticed that if an early/setup error is thrown in
> the installer, no background header gets displayed - since it use
Am 28/10/2024 um 17:29 schrieb Aaron Lauterer:
> Signed-off-by: Aaron Lauterer
> ---
> PVE/CLI/pveceph.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lis
30 matches
Mail list logo
