Re: [pve-devel] [PATCH v2 pve-storage 1/2] add external snasphot support

2024-10-24 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- > > > But even with that, you can still have performance impact. > So yes, I think they are really usecase for workload when you only > need > snapshot time to time (before an upgrade for example), but max > performance with no snaphot exist. >>my main point here is - all o

Re: [pve-devel] Bug 2582 roadmap

2024-10-24 Thread Thomas Lamprecht
Hello, Am 20/09/2024 um 14:32 schrieb Pavel Tide: > 1) Connect via SSH to the PVE node and deploy a helper virtual machine (so > that users don't have to do it manually) > 2) Access the Proxmox VE API to perform other backup-related tasks (those > that cannot be done via SSH) > > In item #1 - t

Re: [pve-devel] applied: [PATCH container 1/1] status: add some missing descriptions for status return properties

2024-10-24 Thread Dominik Csapak
On 10/24/24 14:20, Thomas Lamprecht wrote: Am 21/10/2024 um 11:15 schrieb Dominik Csapak: Signed-off-by: Dominik Csapak --- src/PVE/LXC.pm | 43 ++- 1 file changed, 42 insertions(+), 1 deletion(-) applied, thanks! FYI: I had to fix a duplicate key

Re: [pve-devel] [PATCH qemu-server] fix #5657: allow configuring RNG device as non-root user

2024-10-24 Thread Fabian Grünbichler
On September 3, 2024 3:58 pm, Filip Schauer wrote: > On 02/09/2024 14:21, Fabian Grünbichler wrote: >> IIRC this was intentional, since passing in the hardware RNG can starve >> the host of entropy rather quickly. is this no longer the case, or >> handled by some other check? if so, please include

[pve-devel] applied: [PATCH container] fix #5761: add the "discard" mount option

2024-10-24 Thread Thomas Lamprecht
Am 09/10/2024 um 16:22 schrieb Filip Schauer: > Introduce the "discard" mount option for rootfs and mount points. This > ensures that unused container volume blocks are discarded from the > underlying storage backend when deleting files within the container. > > Signed-off-by: Filip Schauer > ---

Re: [pve-devel] [PATCH manager 1/1] api/ui: improve mdev listing for pci mappings

2024-10-24 Thread Thomas Lamprecht
Am 06/08/2024 um 14:22 schrieb Dominik Csapak: > currently when we have a pci resource mapping, we manually check only > the available models for the first pci entry. This often works, but not > always, since one could have completely different devices in one > mapping, or with the new nvidia sysfs

[pve-devel] partially-applied: [PATCH common/qemu-server/manager] adapt to nvidia vgpu api changes

2024-10-24 Thread Thomas Lamprecht
Am 06/08/2024 um 14:21 schrieb Dominik Csapak: > For many new cards, nvidia changed the kernel interface since kernel > verion 6.8. Instead of using mediated devices, they provide their own > api. > > This series adapts to that, with no required change to the vm config, > and only minimal changes

[pve-devel] applied: [PATCH container] fix #5762: lxc: setup: support `opensuse-slowroll` as OpenSUSE flavor

2024-10-24 Thread Thomas Lamprecht
Am 11/10/2024 um 13:29 schrieb Christoph Heiss: > See the original bug report [0]. OpenSUSE Tumbleweed Slowroll fails to > be detected corrected due to featuring a different ID in > /etc/os-release. > > Simply map that ID to the existing opensuse plugin - much like > Tumbleweed itself. Slowroll is

[pve-devel] applied: [RFC PATCH common] sysfstools: file_write: properly catch errors

2024-10-24 Thread Thomas Lamprecht
Am 23/07/2024 um 10:29 schrieb Dominik Csapak: > since `print` is doing buffered IO, we don't always get an error there, > even if the underlying write does not work. > > To properly catch that, do an unbuffered `syswrite` which circumvents > all buffers and writes directly to the file handle. >

Re: [pve-devel] [PATCH v2 pve-storage 2/2] add lvmqcow2 plugin: (lvm with external qcow2 snapshot)

2024-10-24 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- Thanks Fabian for your time ! I have tried to respond as much as possible. (I'm going to Holiday for 1 week tomorrow, so sorry if I don't reply to all your comments) Message initial De: Fabian Grünbichler À: "DERUMIER, Alexandre" , pve- de...@lists.prox

Re: [pve-devel] [PATCH qemu 1/2] vm-network-scripts: move scripts to /usr/libexec

2024-10-24 Thread Fiona Ebner
It's the "qemu-server" repository, not "qemu". Am 09.10.24 um 14:55 schrieb Maximiliano Sandoval: > Moves the network scripts from /var/lib/qemu-server into > /usr/libexec/qemu-server. > > /usr/libexec is described as binaries run by programs which are not > intended to be directly executed by th

Re: [pve-devel] Bug 2582 roadmap

2024-10-24 Thread Pavel Tide via pve-devel
--- Begin Message --- Hi Fiona et al, Just wanted to follow up on the subject. I think I need some guidance from you and your team members on how we at Veeam could facilitate development of this and some other features in Proxmox VE. Is there any standard protocol for that established, or we sho

[pve-devel] applied: [PATCH container 1/1] status: add some missing descriptions for status return properties

2024-10-24 Thread Thomas Lamprecht
Am 21/10/2024 um 11:15 schrieb Dominik Csapak: > Signed-off-by: Dominik Csapak > --- > src/PVE/LXC.pm | 43 ++- > 1 file changed, 42 insertions(+), 1 deletion(-) > applied, thanks! FYI: I had to fix a duplicate key (see below) and made a few small adjust

Re: [pve-devel] [PATCH v2 pve-storage 1/2] add external snasphot support

2024-10-24 Thread Giotta Simon RUAGH via pve-devel
--- Begin Message --- Hi Everyone > I mean, if we don't allow .raw files to be snapshotted then this problem > doesn't exist ;) Quick comment from the bleacher; Adding a mechanism to shapshot raw disks might solve the TPM (tpmstate) snapshotting issue, as well as allowing containers to be snap

[pve-devel] applied: [PATCH qemu] fix typos in user-visible strings

2024-10-24 Thread Fiona Ebner
Am 08.10.24 um 17:14 schrieb Maximiliano Sandoval: > This includes docs, and strings printed to stderr or stdout. > > These were caught with: > > typos --exclude test --exclude changelog > > Signed-off-by: Maximiliano Sandoval applied, thanks! But please note that it's the "qemu-server" r

[pve-devel] applied: [PATCH manager 1/2] api: subscription: add return schema for 'GET' api

2024-10-24 Thread Thomas Lamprecht
Am 21/10/2024 um 11:15 schrieb Dominik Csapak: > This was missing, but it mostly well defined since we're using the rust > bindings here. I copied most descriptions over from the PBS api, except > the ones only existing here (like sockets and level) > > Signed-off-by: Dominik Csapak > --- > PVE/

Re: [pve-devel] [PATCH pve-network/pve-common/pve-manager] fix #4300 : sdn: add bridge ports isolation

2024-10-24 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- Hi, any news about this patch series ? I think it's still not applied ? (I see a lot of request about it on the forum and on the bugzilla) Regards, Alexandre Message initial De: "DERUMIER, Alexandre" À: pve-devel@lists.proxmox.com , s.hanre...@proxmo

[pve-devel] Bug 4300 update

2024-10-24 Thread Francois Prowse via pve-devel
--- Begin Message --- Is it possible to understand when we can expect to see bugzilla enhancement 4300 incorporated into a production build? Re Francois --- End Message --- ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.co

[pve-devel] [PATCH installer 1/2] tui: show background header on fatal setup error

2024-10-24 Thread Christoph Heiss
This was missing, as it was only applied for the main installation UI - the setup error has its own screen setup codepath entirely. Signed-off-by: Christoph Heiss --- proxmox-tui-installer/src/main.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/proxmox-tui-installer/src/main.rs b/proxmo

[pve-devel] [PATCH installer 0/2] tui: throw setup error if no network interfaces were found

2024-10-24 Thread Christoph Heiss
Currently, the TUI does not error out like the GUI if no network interfaces are found, so remedy that. Also, while testing, noticed that if an early/setup error is thrown in the installer, no background header gets displayed - since it uses a completely different screen setup codepath. Christop

Re: [pve-devel] [PATCH v2 pve-storage 1/2] add external snasphot support

2024-10-24 Thread Fabian Grünbichler
> Fabian Grünbichler hat am 23.10.2024 12:12 CEST > geschrieben: > > > some high level comments: > > I am not sure how much we gain here with the raw support? it's a bit > confusing to have a volid ending with raw, with the current volume and all > but the first snapshot actually being sto

Re: [pve-devel] [PATCH v2 pve-storage 1/2] add external snasphot support

2024-10-24 Thread Fabian Grünbichler
> Giotta Simon RUAGH via pve-devel hat am > 24.10.2024 09:59 CEST geschrieben: > > I mean, if we don't allow .raw files to be snapshotted then this problem > > doesn't exist ;) > > Quick comment from the bleacher; Adding a mechanism to shapshot raw disks > might solve the TPM (tpmstate) snap

Re: [pve-devel] [PATCH v2 pve-storage 1/2] add external snasphot support

2024-10-24 Thread Fabian Grünbichler
> DERUMIER, Alexandre hat am 23.10.2024 > 14:59 CEST geschrieben: > > > Hi Fabian, > > thanks for the review ! > > >> Message initial > >>De: Fabian Grünbichler > >>À: Proxmox VE development discussion > >>Cc: Alexandre Derumier > >>Objet: Re: [pve-devel] [PATCH v2 pve-s