Re: [pve-devel] [RFC qemu/storage/qemu-server/container/manager 00/23] backup provider API

2024-07-29 Thread Fiona Ebner
Hi, Am 26.07.24 um 21:47 schrieb Jonathan Nicklin via pve-devel: > > Hi Fiona, > > Would adding support for offloading incremental difference detection > to the underlying storage be feasible with the API updates? The QEMU > bitmap strategy works for all storage devices but is far from > optimal

[pve-devel] [PATCH manager] ui: pool: separate "Add Virtual Machine" menu into distinct options

2024-07-29 Thread Theodor Fumics via pve-devel
--- Begin Message --- Split the "Add Virtual Machine" menu into separate options for Virtual Machines and Containers to reduce confusion. This change follows feedback from a user in [1], who had difficulty finding the container option. [1] https://forum.proxmox.com/threads/how-to-add-containers-t

Re: [pve-devel] [PATCH widget-toolkit v3] fix #3892: Network: add bridge vids field for bridge_vids

2024-07-29 Thread Aaron Lauterer
On 2024-07-26 14:22, Shannon Sterz wrote: On Wed Jul 3, 2024 at 10:01 AM CEST, Aaron Lauterer wrote: The new optional bridge_vids field allows to set that property via the GUI. Since the backend needs to support it, the field needs to be explicitly enabled. For now, Proxmox VE (PVE) is the

Re: [pve-devel] [PATCH manager] ui: pool: separate "Add Virtual Machine" menu into distinct options

2024-07-29 Thread Shannon Sterz
On Mon Jul 29, 2024 at 11:53 AM CEST, Theodor Fumics wrote: > Split the "Add Virtual Machine" menu into separate options > for Virtual Machines and Containers to reduce confusion. > This change follows feedback from a user in [1], who had difficulty > finding the container option. > > [1] > https:

Re: [pve-devel] [PATCH widget-toolkit v3] fix #3892: Network: add bridge vids field for bridge_vids

2024-07-29 Thread Shannon Sterz
On Mon Jul 29, 2024 at 12:25 PM CEST, Aaron Lauterer wrote: > > > On 2024-07-26 14:22, Shannon Sterz wrote: > > On Wed Jul 3, 2024 at 10:01 AM CEST, Aaron Lauterer wrote: > >> The new optional bridge_vids field allows to set that property via the > >> GUI. Since the backend needs to support it, t

[pve-devel] [PATCH manager v2] ui: pool: separate "Add Virtual Machine" menu into distinct options

2024-07-29 Thread Theodor Fumics via pve-devel
--- Begin Message --- Split the "Add Virtual Machine" menu into separate options for Virtual Machines and Containers to reduce confusion. This change follows feedback from a user in [1], who had difficulty finding the container option. [1] https://forum.proxmox.com/threads/how-to-add-containers-t

[pve-devel] [PATCH common v4 1/7] tools: add check_list_empty function

2024-07-29 Thread Aaron Lauterer
In some situations we don't want a total empty list. I opted for a dedicated function instead of integrating it as error in the `split_list` function. It is used in many places and the potential fallout from unintended behavior changes is too big. Signed-off-by: Aaron Lauterer Tested-By: Stefan H

[pve-devel] [PATCH widget-toolkit v4 4/7] fix #3892: Network: add bridge vids field for bridge_vids

2024-07-29 Thread Aaron Lauterer
The new optional bridge_vids field allows to set that property via the GUI. Since the backend needs to support it, the field needs to be explicitly enabled. For now, Proxmox VE (PVE) is the use case. Signed-off-by: Aaron Lauterer Tested-By: Stefan Hanreich Reviewed-by: Shannon Sterz --- change

[pve-devel] [PATCH manager v4 7/7] fix #3893: ui: network: enable bridge_vids field

2024-07-29 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer Tested-By: Stefan Hanreich Reviewed-by: Shannon Sterz --- changes since v3: none v2: none www/manager6/node/Config.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/node/Config.js b/www/manager6/node/Config.js index d27592ce..7bdfb6d9 100644 ---

[pve-devel] [PATCH widget-toolkit v4 5/7] Network: add explanation for bridge vids field

2024-07-29 Thread Aaron Lauterer
Make clear that it affects only out-/inbound traffic and can be used if the underlying physical NICs support only a limited number of VLANs when offloading is possible. Signed-off-by: Aaron Lauterer Reviewed-by: Shannon Sterz --- changes since v3-follow-up: * reordered inside the patch series *

[pve-devel] [PATCH manager v4 6/7] fix #3893: api: network: add bridge_vids parameter

2024-07-29 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer Tested-By: Stefan Hanreich Reviewed-by: Shannon Sterz --- changes since v3: * changed "vlans" to "VLANs" in description v2: * added checks to handle empty lists PVE/API2/Network.pm | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a

[pve-devel] [PATCH common v4 3/7] inotify: interfaces: make sure bridge_vids use space as separator

2024-07-29 Thread Aaron Lauterer
Because the API accepts multiple possible list separators we need to make sure that we write the bridge_vids with space as separator, no matter which separator was used when passing it to the API. Signed-off-by: Aaron Lauterer Tested-By: Stefan Hanreich Reviewed-by: Shannon Sterz --- changes si

[pve-devel] [PATCH common, widget-toolkit, manager v4 0/7] fix #3893: make bridge vids configurable

2024-07-29 Thread Aaron Lauterer
since I only incorporated smaller suggested changes, I left the r-b and t-b in place. this version reworks a few parts since v3: incorporated @shannons recommendations, in detail: * improve regex with non-capturing group * reworked check if valid VLAN config in UI field check * small code style an

[pve-devel] [PATCH common v4 2/7] fix #3893: network: add vlan id and range parameter definitions

2024-07-29 Thread Aaron Lauterer
This is one step to make it possible to define the VLAN IDs and ranges for bridges. It is expected to be used in combination with the `-list` magic property. Therefore it defines and checks the validity of a single list item that could just be a single VLAN tag ID or a range. Signed-off-by: Aaron

Re: [pve-devel] [PATCH manager v2] ui: pool: separate "Add Virtual Machine" menu into distinct options

2024-07-29 Thread Thomas Lamprecht
Am 29/07/2024 um 13:43 schrieb Theodor Fumics: > Split the "Add Virtual Machine" menu into separate options > for Virtual Machines and Containers to reduce confusion. > This change follows feedback from a user in [1], who had difficulty > finding the container option. > > [1] > https://forum.prox

[pve-devel] [PATCH storage] api: upload: correctly test for result of unlink

2024-07-29 Thread Fiona Ebner
It's not enough to check whether $! is set. From "perldoc perlvar": > Many system or library calls set "errno" if they fail, to > indicate the cause of failure. They usually do not set "errno" > to zero if they succeed and may set "errno" to a non-zero value > on success. This means "errno", hence

[pve-devel] [PATCH v2 qemu-server] fix 4493: cloud-init: fix generated Windows config

2024-07-29 Thread Mira Limbeck
cloudbase-init, a cloud-init reimplementation for Windows, supports only a subset of the configuration options of cloud-init. Some features depend on support by the Metadata Service (ConfigDrive2 here) and have further limitations [0]. To support a basic setup the following changes were made: - p

[pve-devel] [PATCH v2 docs] cloudinit: add Windows cloudbase-init section

2024-07-29 Thread Mira Limbeck
Signed-off-by: Mira Limbeck --- v2: - added metadata_services config option - added Sysprep section - fixed typos and clarified some parts qm-cloud-init.adoc | 147 + 1 file changed, 147 insertions(+) diff --git a/qm-cloud-init.adoc b/qm-cloud-init

Re: [pve-devel] [PATCH v2 docs] cloudinit: add Windows cloudbase-init section

2024-07-29 Thread Shannon Sterz
On Mon Jul 29, 2024 at 5:19 PM CEST, Mira Limbeck wrote: > Signed-off-by: Mira Limbeck > --- > v2: > - added metadata_services config option > - added Sysprep section > - fixed typos and clarified some parts > > qm-cloud-init.adoc | 147 + > 1 file c

Re: [pve-devel] [PATCH storage] api: upload: correctly test for result of unlink

2024-07-29 Thread Thomas Lamprecht
Am 29/07/2024 um 16:29 schrieb Fiona Ebner: > It's not enough to check whether $! is set. From "perldoc perlvar": > >> Many system or library calls set "errno" if they fail, to >> indicate the cause of failure. They usually do not set "errno" >> to zero if they succeed and may set "errno" to a non

[pve-devel] applied: [PATCH qemu 1/2] update submodule and patches to QEMU 9.0.2

2024-07-29 Thread Thomas Lamprecht
Am 25/07/2024 um 11:45 schrieb Fiona Ebner: > Most relevant are some fixes for VirtIO and for ARM and i386 > emulation. There also is a fix for VGA display to fix screen blanking, > which fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=4786 > > Signed-off-by: Fiona Ebner > --- > ...d-support

[pve-devel] applied: [PATCH v2 qemu-server] resume: bump timeout for query-status

2024-07-29 Thread Thomas Lamprecht
Am 25/07/2024 um 14:32 schrieb Fiona Ebner: > As reported in the community forum [0], after migration, the VM might > not immediately be able to respond to QMP commands, which means the VM > could fail to resume and stay in paused state on the target. > > The reason is that activating the block dr

Re: [pve-devel] [PATCH v2 qemu-server] fix 4493: cloud-init: fix generated Windows config

2024-07-29 Thread Thomas Lamprecht
Am 29/07/2024 um 17:19 schrieb Mira Limbeck: > cloudbase-init, a cloud-init reimplementation for Windows, supports only > a subset of the configuration options of cloud-init. Some features > depend on support by the Metadata Service (ConfigDrive2 here) and have > further limitations [0]. > > To su

Re: [pve-devel] [RFC qemu/storage/qemu-server/container/manager 00/23] backup provider API

2024-07-29 Thread Jonathan Nicklin via pve-devel
--- Begin Message --- > On Jul 27, 2024, at 11:20 AM, Dietmar Maurer wrote: > >> Would adding support for offloading incremental difference detection >> to the underlying storage be feasible with the API updates? The QEMU >> bitmap strategy works for all storage devices but is far from >> optima

Re: [pve-devel] [RFC qemu/storage/qemu-server/container/manager 00/23] backup provider API

2024-07-29 Thread Jonathan Nicklin via pve-devel
--- Begin Message --- In hyper-converged deployments, the node performing the backup is sourcing ((nodes-1)/(nodes))*bytes) of backup data (i.e., ingress traffic) and then sending 1*bytes to PBS (i.e., egress traffic). If PBS were to pull the data from the nodes directly, the maximum load on any

Re: [pve-devel] [RFC qemu/storage/qemu-server/container/manager 00/23] backup provider API

2024-07-29 Thread Jonathan Nicklin via pve-devel
--- Begin Message --- I am by no means a CEPH expert. However, my understanding is that other backup solutions (in the OpenStack world) have used rbd diff to enable incremental backups. I was hoping that would be relevant here. Here's the description of `rbd diff` Dump a list of byte extents

[pve-devel] [PATCH manager v3] ui: pool: separate "Add Virtual Machine" menu into distinct options

2024-07-29 Thread Theodor Fumics via pve-devel
--- Begin Message --- Split the "Add Virtual Machine" menu into separate options for Virtual Machines and Containers to reduce confusion This change follows feedback from a user in [1], who had difficulty finding the container option. Reasons for splitting the menu: - Separate VM and Container opt

Re: [pve-devel] [RFC qemu/storage/qemu-server/container/manager 00/23] backup provider API

2024-07-29 Thread Jonathan Nicklin via pve-devel
--- Begin Message --- I 100% concur. I am not suggesting any breaking changes; I was just wondering if this work on the API unlocked any new optimizations to make the interactions between the backup client, PBS, and storage more efficient. And also, bbgeek has pinged me to check out the awesome