--- Begin Message ---
Split the "Add Virtual Machine" menu into separate options
for Virtual Machines and Containers to reduce confusion.
This change follows feedback from a user in [1], who had difficulty
finding the container option.

[1] 
https://forum.proxmox.com/threads/how-to-add-containers-to-a-resource-pool.151946/

Signed-off-by: Theodor Fumics <theodor.fum...@gmx.net>
---
 www/manager6/grid/PoolMembers.js | 25 +++++++++++++++----------
 1 file changed, 15 insertions(+), 10 deletions(-)

diff --git a/www/manager6/grid/PoolMembers.js b/www/manager6/grid/PoolMembers.js
index 75f20cab..417e5d3d 100644
--- a/www/manager6/grid/PoolMembers.js
+++ b/www/manager6/grid/PoolMembers.js
@@ -1,4 +1,4 @@
-Ext.define('PVE.pool.AddVM', {
+Ext.define('PVE.pool.AddGuest', {
     extend: 'Proxmox.window.Edit',

     width: 640,
@@ -37,7 +37,7 @@ Ext.define('PVE.pool.AddVM', {
            ],
            filters: [
                function(item) {
-                   return (item.data.type === 'lxc' || item.data.type === 
'qemu') &&item.data.pool !== me.pool;
+                   return (me.type === 'qemu' ? item.data.type === 'qemu' : 
item.data.type === 'lxc') && item.data.pool !== me.pool;
                },
            ],
        });
@@ -84,15 +84,11 @@ Ext.define('PVE.pool.AddVM', {
                    dataIndex: 'name',
                    flex: 1,
                },
-               {
-                   header: gettext('Type'),
-                   dataIndex: 'type',
-               },
            ],
        });

        Ext.apply(me, {
-           subject: gettext('Virtual Machine'),
+           subject: gettext(me.type === 'qemu' ? 'Virtual Machine' : 'LXC 
Container'),
            items: [
                vmsField,
                vmGrid,
@@ -228,16 +224,25 @@ Ext.define('PVE.grid.PoolMembers', {
                        items: [
                            {
                                text: gettext('Virtual Machine'),
-                               iconCls: 'pve-itype-icon-qemu',
+                               iconCls: 'fa fa-fw fa-desktop',
+                               handler: function() {
+                                   var win = Ext.create('PVE.pool.AddGuest', { 
pool: me.pool, type: 'qemu' });
+                                   win.on('destroy', reload);
+                                   win.show();
+                               },
+                           },
+                           {
+                               text: gettext('Container'),
+                               iconCls: 'fa fa-fw fa-cube',
                                handler: function() {
-                                   var win = Ext.create('PVE.pool.AddVM', { 
pool: me.pool });
+                                   var win = Ext.create('PVE.pool.AddGuest', { 
pool: me.pool, type: 'lxc' });
                                    win.on('destroy', reload);
                                    win.show();
                                },
                            },
                            {
                                text: gettext('Storage'),
-                               iconCls: 'pve-itype-icon-storage',
+                               iconCls: 'fa fa-fw fa-hdd-o',
                                handler: function() {
                                    var win = Ext.create('PVE.pool.AddStorage', 
{ pool: me.pool });
                                    win.on('destroy', reload);
--
2.39.2



--- End Message ---
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to