[pve-devel] [PATCH manager v2] ui: resource mappings: fix editing of mapping for non first node

2024-07-26 Thread Dominik Csapak
when editing the pci mapping, we set the nodename of the pci/usbselector to the selected node. At the same time we disable and hide the node selector, but it still changes it's value to the 'first' node (alphabetically sorted) and that triggers a change event. To prevent that we accidentally set t

Re: [pve-devel] [PATCH manager] ui: resource mappings: fix editing of mapping for non first node

2024-07-26 Thread Dominik Csapak
sent a v2: https://lists.proxmox.com/pipermail/pve-devel/2024-July/064916.html ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH docs] passthrough: viommu: replace host requirement with reference to pcie passthrough

2024-07-26 Thread Markus Frank
Enabling IOMMU on the host is not a requirement for vIOMMU. It is only a requirement for passthrough. Add a sentence to clarify the need for a configured PCI(e) passthrough on the host for passthrough to nested VMs. Suggested-by: Dominik Csapak Signed-off-by: Markus Frank --- This patch replaces

[pve-devel] [PATCH kernel] add fix for regression causing broken power indicators/LEDs

2024-07-26 Thread Fiona Ebner
The issue was reported in the enterprise support. The customer contacted the ledmon maintainer, who found that it is not an issue with ledmon, bisected the kernel and came up with this fix. Signed-off-by: Fiona Ebner --- ...n-Power-Indicator-bits-for-userspace.patch | 56 +++ 1 f

[pve-devel] applied: [PATCH manager v2] ui: resource mappings: fix editing of mapping for non first node

2024-07-26 Thread Fiona Ebner
Am 26.07.24 um 09:40 schrieb Dominik Csapak: > when editing the pci mapping, we set the nodename of the pci/usbselector > to the selected node. At the same time we disable and hide the node > selector, but it still changes it's value to the 'first' node > (alphabetically sorted) and that triggers a

Re: [pve-devel] [RFC storage 10/23] plugin: introduce new_backup_provider() method

2024-07-26 Thread Fiona Ebner
Am 25.07.24 um 17:32 schrieb Max Carrara: > On Thu Jul 25, 2024 at 3:11 PM CEST, Fiona Ebner wrote: >> Am 25.07.24 um 11:48 schrieb Max Carrara: >>> The same goes for backup provider plugins - IMO namespacing them >>> like e.g. `PVE::Backup::Provider::Plugin::Foo` where `Foo` is a >>> (

Re: [pve-devel] [RFC storage 10/23] plugin: introduce new_backup_provider() method

2024-07-26 Thread Max Carrara
On Fri Jul 26, 2024 at 11:52 AM CEST, Fiona Ebner wrote: > Am 25.07.24 um 17:32 schrieb Max Carrara: > > On Thu Jul 25, 2024 at 3:11 PM CEST, Fiona Ebner wrote: > >> Am 25.07.24 um 11:48 schrieb Max Carrara: > >>> The same goes for backup provider plugins - IMO namespacing them > >>> like e

Re: [pve-devel] [PATCH common, widget-toolkit, manager v3 0/3] fix #3893: make bridge vids configurable

2024-07-26 Thread Shannon Sterz
On Wed Jul 3, 2024 at 10:01 AM CEST, Aaron Lauterer wrote: > this version reworks a few parts since v2. > > * renamed format in JSONSchema to a more generic `pve-vlan-id-or-range` > * explicitly use spaces when writing interfaces file. This is one > possible approach to deal with the fact, that t

Re: [pve-devel] [PATCH widget-toolkit v3] fix #3892: Network: add bridge vids field for bridge_vids

2024-07-26 Thread Shannon Sterz
On Wed Jul 3, 2024 at 10:01 AM CEST, Aaron Lauterer wrote: > The new optional bridge_vids field allows to set that property via the > GUI. Since the backend needs to support it, the field needs to be > explicitly enabled. > > For now, Proxmox VE (PVE) is the use case. > > Signed-off-by: Aaron Laute

Re: [pve-devel] [PATCH common v3 2/3] fix #3893: network: add vlan id and range parameter definitions

2024-07-26 Thread Shannon Sterz
On Wed Jul 3, 2024 at 10:01 AM CEST, Aaron Lauterer wrote: > This is one step to make it possible to define the VLAN IDs and ranges > for bridges. > > It is expected to be used in combination with the `-list` magic > property. Therefore it defines and checks the validity of a single list > item tha

Re: [pve-devel] [PATCH widget-toolkit v3 7/6 follow-up] Network: add explanation for bridge vids field

2024-07-26 Thread Shannon Sterz
On Tue Jul 23, 2024 at 3:33 PM CEST, Aaron Lauterer wrote: > Make clear that it affects only out-/inbound traffic and can be used if > the underlying physical NICs support only a limited number of VLANs when > offloading is possible. > > Signed-off-by: Aaron Lauterer > --- > After some off-list di

Re: [pve-devel] [PATCH manager v3 5/6] fix #3893: api: network: add bridge_vids parameter

2024-07-26 Thread Shannon Sterz
On Wed Jul 3, 2024 at 10:01 AM CEST, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > changes since v2: > * added checks to handle empty lists > > PVE/API2/Network.pm | 15 ++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/PVE/API2/Network.pm b/PVE/AP

Re: [pve-devel] [RFC storage 10/23] plugin: introduce new_backup_provider() method

2024-07-26 Thread Fiona Ebner
Am 26.07.24 um 14:02 schrieb Max Carrara: > On Fri Jul 26, 2024 at 11:52 AM CEST, Fiona Ebner wrote: >> Am 25.07.24 um 17:32 schrieb Max Carrara: >>> On Thu Jul 25, 2024 at 3:11 PM CEST, Fiona Ebner wrote: >> >> I don't quite get your point about not needing to update the call sites. >> If you chan

Re: [pve-devel] [PATCH pve-manager] sdn: vnets: Hide irrelevant fields depending on zone type

2024-07-26 Thread Theodor Fumics via pve-devel
--- Begin Message --- I’ve tested the changes thoroughly. The fields in the VnetEdit dialog now correctly hide based on the selected zone type. For the EVPN zone type, the VLAN Aware field is hidden, and for the simple zone type, the tag field is correctly hidden. Everything is working perfectly.

[pve-devel] [PATCH manager] sdn: subnets: hide irrelevant fields depending on zone type

2024-07-26 Thread Theodor Fumics via pve-devel
--- Begin Message --- The SNAT option is only applicable to Simple and EVPN zone types. For other zone types, this field is irrelevant and can cause confusion. This commit hides the SNAT field when it is not applicable to the selected zone type, improving clarity for users. Signed-off-by: Theodor

Re: [pve-devel] [PATCH manager] sdn: subnets: hide irrelevant fields depending on zone type

2024-07-26 Thread Shannon Sterz
On Fri Jul 26, 2024 at 3:27 PM CEST, Theodor Fumics wrote: > The SNAT option is only applicable to Simple and EVPN zone types. > For other zone types, this field is irrelevant and can cause confusion. > This commit hides the SNAT field when it is not applicable to the > selected zone type, improvin

[pve-devel] [PATCH manager v2] sdn: subnets: hide irrelevant fields depending on zone type

2024-07-26 Thread Theodor Fumics via pve-devel
--- Begin Message --- The SNAT option is only applicable to Simple and EVPN zone types. For other zone types, this field is irrelevant and can cause confusion. This commit hides the SNAT field when it is not applicable to the selected zone type, improving clarity for users. Signed-off-by: Theodor

Re: [pve-devel] [PATCH manager] sdn: subnets: hide irrelevant fields depending on zone type

2024-07-26 Thread Theodor Fumics via pve-devel
--- Begin Message --- Hi Shannon, Thanks for catching that! I missed the use of var and have now sent a revised version (v2) using let instead [1]. [1] https://lore.proxmox.com/pve-devel/mailman.701.1722002701.331.pve-de...@lists.proxmox.com/T/#u On 7/26/24 15:42, Shannon Sterz wrote: On Fri