On Wed Jul 3, 2024 at 10:01 AM CEST, Aaron Lauterer wrote: > this version reworks a few parts since v2. > > * renamed format in JSONSchema to a more generic `pve-vlan-id-or-range` > * explicitly use spaces when writing interfaces file. This is one > possible approach to deal with the fact, that the generic `-list` > format will accept quite a few delimiters and we need spaces. > * code style improvements such as naming the regex results. > * add parameter verification to the web ui > > With the changes to the JSONSchema we can then work on using it too for > the guest trunk option. This hasn't been started yet though. > > common: Aaron Lauterer (3): > tools: add check_list_empty function > fix #3893: network: add vlan id and range parameter definitions > inotify: interfaces: make sure bridge_vids use space as separator > > src/PVE/INotify.pm | 2 +- > src/PVE/JSONSchema.pm | 34 ++++++++++++++++++++++++++++++++++ > src/PVE/Tools.pm | 8 ++++++++ > 3 files changed, 43 insertions(+), 1 deletion(-) > > > widget-toolkit: Aaron Lauterer (1): > fix #3892: Network: add bridge vids field for bridge_vids > > src/node/NetworkEdit.js | 62 +++++++++++++++++++++++++++++++++++++++++ > src/node/NetworkView.js | 5 ++++ > 2 files changed, 67 insertions(+) > > > manager: Aaron Lauterer (2): > fix #3893: api: network: add bridge_vids parameter > fix #3893: ui: network: enable bridge_vids field > > PVE/API2/Network.pm | 15 ++++++++++++++- > www/manager6/node/Config.js | 1 + > 2 files changed, 15 insertions(+), 1 deletion(-)
thanks for this, i did a short review of the code. i have a couple of minor issue, but other than that this series: Reviewed-by: Shannon Sterz <s.st...@proxmox.com> _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
