[pve-devel] [PATCH manager] ui: pool members: avoid setting request parameter for all edit windows

2024-03-13 Thread Friedrich Weber
Currently, after adding a storage to a pool, opening any edit window will send a GET request with a superfluous `poolid` parameter and cause a parameter verification error in the GUI. This breaks all edit windows of the current session. A workaround is to reload the current browser session. This h

Re: [pve-devel] [PATCH manager] ui: pool members: avoid setting request parameter for all edit windows

2024-03-13 Thread Friedrich Weber
On 13/03/2024 09:44, Friedrich Weber wrote: > Currently, after adding a storage to a pool, opening any edit window > will send a GET request with a superfluous `poolid` parameter and > cause a parameter verification error in the GUI. This breaks all edit > windows of the current session. A workarou

[pve-devel] [PATCH access-control] api: Prevent TFA from being set up for openid users

2024-03-13 Thread Markus Frank
Currently it is possible to set up TFA for an OpenID user (as root user), but it is never requested during the login process for that user. This patch prevents this and displays an error message with the instruction to set up TFA using the OpenId server. Signed-off-by: Markus Frank --- src/PVE/A

[pve-devel] [PATCH backup-qemu] make capi_types module public

2024-03-13 Thread Filip Schauer
Commit c7077bb3 moved ProxmoxBackupHandle into a separate file and accidentally made it private in the process. Revert this behaviour by making ProxmoxBackupHandle and ProxmoxRestoreHandle accessible from outside of the crate again. These handles are used in the function signatures of several publ

[pve-devel] [PATCH pve-manager 1/2] fix #5198: ceph: mon: fix mon existence check in mon removal assertion

2024-03-13 Thread Max Carrara
The Ceph monitor removal assertion contains a condition that checks whether the given mon ID actually exists and thus may be removed. The first part of the condition checks whether the hash returned by `get_services_info` [0] contains the key "mon.$monid". However, the hash's keys are never prefix

[pve-devel] [PATCH pve-manager 2/2] ceph: mon: adapt code style in mon removal assertion

2024-03-13 Thread Max Carrara
Signed-off-by: Max Carrara --- PVE/API2/Ceph/MON.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Ceph/MON.pm b/PVE/API2/Ceph/MON.pm index 1737c294..f13115a0 100644 --- a/PVE/API2/Ceph/MON.pm +++ b/PVE/API2/Ceph/MON.pm @@ -148,13 +148,13 @@ my $assert_mon_can_re

Re: [pve-devel] [PATCH storage 1/1] storage/plugins: pass scfg to parse_volname

2024-03-13 Thread Wolfgang Bumiller
On Tue, Mar 05, 2024 at 12:13:05PM +0100, Thomas Lamprecht wrote: > Am 23/02/2024 um 10:24 schrieb Roland Kammerer: > > This passes the well known $scfg to parse_volname and bumps the API > > versions accordingly. This allows plugins to access their configuration > > if necessary. > > We discussed

Re: [pve-devel] [PATCH pve-manager 1/2] fix #5198: ceph: mon: fix mon existence check in mon removal assertion

2024-03-13 Thread Stefan Sterz
On Wed Mar 13, 2024 at 3:53 PM CET, Max Carrara wrote: > The Ceph monitor removal assertion contains a condition that checks > whether the given mon ID actually exists and thus may be removed. > > The first part of the condition checks whether the hash returned by > `get_services_info` [0] contains