Re: [pve-devel] [PATCH docs 5/9] package-repos: align wording with pmg-docs

2024-03-05 Thread Gabriel Goller
On Mon Mar 4, 2024 at 2:22 PM CET, Christoph Heiss wrote: > The `root@pam` user is notified via email about available updates. Click the > 'Changelog' button in the GUI to see more details about the selected update. > > -You need a valid subscription key to access the `pve-enterprise` repositor

Re: [pve-devel] [PATCH docs 6/9] installation: iso: improve & align wording with pmg-docs

2024-03-05 Thread Gabriel Goller
On Mon Mar 4, 2024 at 2:22 PM CET, Christoph Heiss wrote: > +When copying and setting up the packages has finished, you can reboot the > +server. This will be done automatically after a few seconds by default. I would remove the `by default` so that the sentence becomes: This will be done aut

Re: [pve-devel] [PATCH pve-manager] ui: lxc: add firewall log view filtering

2024-03-05 Thread Christian Ebner
ping, still applies! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH storage 1/1] storage/plugins: pass scfg to parse_volname

2024-03-05 Thread Roland Kammerer via pve-devel
--- Begin Message --- On Fri, Mar 01, 2024 at 11:14:31AM +0100, Roland Kammerer wrote: > On Fri, Mar 01, 2024 at 10:45:37AM +0100, Dietmar Maurer wrote: > > > > > On 29.2.2024 16:09 CET Roland Kammerer via pve-devel > > > wrote: > > > All in all, yes, this is specific for our use case, otherwise

Re: [pve-devel] [PATCH storage 1/1] storage/plugins: pass scfg to parse_volname

2024-03-05 Thread Thomas Lamprecht
Am 23/02/2024 um 10:24 schrieb Roland Kammerer: > This passes the well known $scfg to parse_volname and bumps the API > versions accordingly. This allows plugins to access their configuration > if necessary. We discussed this another time here and effectively it can be fine, while the need for it

Re: [pve-devel] [PATCH docs 5/9] package-repos: align wording with pmg-docs

2024-03-05 Thread Christoph Heiss
On Tue, Mar 05, 2024 at 09:28:21AM +0100, Gabriel Goller wrote: > On Mon Mar 4, 2024 at 2:22 PM CET, Christoph Heiss wrote: > > The `root@pam` user is notified via email about available updates. Click > > the > > 'Changelog' button in the GUI to see more details about the selected > > update. >

Re: [pve-devel] [PATCH docs 6/9] installation: iso: improve & align wording with pmg-docs

2024-03-05 Thread Christoph Heiss
Thanks for the review! On Tue, Mar 05, 2024 at 09:38:02AM +0100, Gabriel Goller wrote: > On Mon Mar 4, 2024 at 2:22 PM CET, Christoph Heiss wrote: > > +When copying and setting up the packages has finished, you can reboot the > > +server. This will be done automatically after a few seconds by defa

Re: [pve-devel] [PATCH storage 1/1] storage/plugins: pass scfg to parse_volname

2024-03-05 Thread Fabian Grünbichler
Roland Kammerer wrote: > On Thu, Feb 29, 2024 at 02:29:51PM +0100, Fiona Ebner wrote: > > Am 23.02.24 um 10:24 schrieb Roland Kammerer: > > > This passes the well known $scfg to parse_volname and bumps the API > > > versions accordingly. This allows plugins to access their configuration > > > if ne

[pve-devel] [PATCH docs] local-zfs: mention `zfs_arc_max` clamping by the installer

2024-03-05 Thread Christoph Heiss
This was forgotten to be updated when it changed it the installer and now reported in the forum [0] that the docs are a bit outdated in this regard. [0] https://forum.proxmox.com/threads/hat-proxmox-8-neue-zfs_arc_max-settings.142754/ Signed-off-by: Christoph Heiss --- local-zfs.adoc | 19

[pve-devel] [PATCH manager 1/3] fix #5255: node: wol: add optional bind interface

2024-03-05 Thread Christian Ebner
Allows to optionally configure a local interface name to which to bind to when sending a wake on lan packet to wake a remote node. Default behaviour remains to send the packet via the interface for the default gateway. Signed-off-by: Christian Ebner --- PVE/API2/Nodes.pm | 13 - PVE

[pve-devel] [PATCH docs 3/3] pvenode/wake-on-lan: mention optional config options

2024-03-05 Thread Christian Ebner
Show how to configure the optional bind interface and broadcast address options via `pvenode`. Signed-off-by: Christian Ebner --- pvenode.adoc | 14 ++ 1 file changed, 14 insertions(+) diff --git a/pvenode.adoc b/pvenode.adoc index 59eeecb..8a1da08 100644 --- a/pvenode.adoc +++ b/pv

[pve-devel] [PATCH manager 2/3] fix #5255: node: wol: configurable broadcast address

2024-03-05 Thread Christian Ebner
Allows to configure a custom broadcast address to use when sending a wake on lan packet to wake a remote node. Default behaviour remains to fallback to 255.255.255.255. Signed-off-by: Christian Ebner --- PVE/API2/Nodes.pm | 3 ++- PVE/NodeConfig.pm | 6 ++ 2 files changed, 8 insertions(+),

[pve-devel] [PATCH manager docs 0/3] add optional WoL config options

2024-03-05 Thread Christian Ebner
For certain network setups the default values currently used to send a wake on lan magic packet are not correct, e.g. it will get send via the interface for which the default gateway is configured. This patches add optional configuration options to set a bind interface, over which to send the WoL

[pve-devel] [PATCH docs 2/2] installation: document `ARC max size` option for ZFS-on-root installations

2024-03-05 Thread Christoph Heiss
This has been part of the installer since the 8.1 release. Signed-off-by: Christoph Heiss --- pve-installation.adoc | 7 +++ 1 file changed, 7 insertions(+) diff --git a/pve-installation.adoc b/pve-installation.adoc index 6b44fc0..3e12727 100644 --- a/pve-installation.adoc +++ b/pve-install

Re: [pve-devel] [PATCH qemu-server 1/1] fix #1905: Allow moving unused disks

2024-03-05 Thread Filip Schauer
After a bit of research, here is a more descriptive commit message: Allow moving unused disks to another storage In the past, moving unused disks to another storage was prohibited due to oversights in the handling of unused disks. This commit rectifies this limitation by allowing the movement o

[pve-devel] [PATCH v4 master ceph 2/16] patches: add patch that reorders clients used by ceph-crash

2024-03-05 Thread Max Carrara
This patch makes it so that `ceph-crash` attempts to use the non-host-specific keyring before anything else, which avoids unnecessary error messages landing in the systemd-journal in our case. Signed-off-by: Max Carrara Reviewed-by: Fabian Grünbichler --- Changes v1 --> v2: * new Changes v2 --

[pve-devel] [PATCH v4 master ceph 1/16] debian: add patch to fix ceph crash dir permissions in postinst hook

2024-03-05 Thread Max Carrara
Ceph has a postinst hook that sets the ownership of '/var/lib/ceph/*' to ceph:ceph (in our case), but misses out on the contents of '/var/lib/ceph/crash'. This patch therefore also recursively updates the permissions of '/var/lib/ceph/crash'. Signed-off-by: Max Carrara --- Changes v1 --> v2: *

[pve-devel] [PATCH v4 quincy-stable-8 ceph 4/16] patches: add patch that reorders clients used by ceph-crash

2024-03-05 Thread Max Carrara
This patch makes it so that `ceph-crash` attempts to use the non-host-specific keyring before anything else, which avoids unnecessary error messages landing in the systemd-journal in our case. Signed-off-by: Max Carrara Reviewed-by: Fabian Grünbichler --- Changes v1 --> v2: * new Changes v2 --

[pve-devel] [PATCH v4 pve-storage 09/13] cephconfig: emit warning for lines that fail to parse

2024-03-05 Thread Max Carrara
Signed-off-by: Max Carrara --- Changes v3 --> v4: * new src/PVE/CephConfig.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/PVE/CephConfig.pm b/src/PVE/CephConfig.pm index 6b7bbd4..da28940 100644 --- a/src/PVE/CephConfig.pm +++ b/src/PVE/CephConfig.pm @@ -70,6 +70,8 @@ sub parse_ce

[pve-devel] [PATCH v4 pve-storage 06/16] cephconfig: support line-continuations in parser

2024-03-05 Thread Max Carrara
Ceph's docs state the following [0]: > The backslash character `\` is used as the line-continuation marker > that combines the next line with the current one. This commit implements the support of such line-continuations in our parser. The line following a line ending with a '\' has its whitespac

[pve-devel] [PATCH v4 pve-storage 12/16] cephconfig: remove leading whitespace on write to Ceph config

2024-03-05 Thread Max Carrara
Because continued lines (lines following lines that end with '\') preserve whitespace, this commit removes any leading whitespace that is added by our config writer. This is done in order to make continued lines look less "awkward" when manually changing values in 'ceph.conf' after the file has be

[pve-devel] [PATCH v4 ceph master, ceph quincy-stable-8, pve-storage, pve-manager 0/16] Fix #4759: Configure Permissions for ceph-crash.service

2024-03-05 Thread Max Carrara
Fix #4759: Configure Permissions for ceph-crash.service - Version 4 === Notable changes since v3 * Both parser and writer for 'ceph.conf' now have unit tests which run during make targets like e.g. `mak

[pve-devel] [PATCH v4 pve-storage 13/16] test: add tests for 'ceph.conf' parser and writer

2024-03-05 Thread Max Carrara
These tests attempt to cover all syntax quirks that the format of 'ceph.conf' currently allows. One known exception however is the handling of "quoted" and "unquoted" strings, as Ceph's own parser appears to not actually differ between them either. Curiously, if a "quoted string" isn't able to be

[pve-devel] [PATCH v4 pve-manager 15/16] fix #4759: ceph: configure ceph-crash.service and its key

2024-03-05 Thread Max Carrara
Due to Ceph dropping privileges when running the 'ceph-crash' daemon [0], it is necessary to allow the daemon to authenticate with its cluster in a safe manner. In order to avoid exposing sensitive keyrings or somehow escalating its privileges again, 'ceph-crash' is therefore provided with its own

[pve-devel] [PATCH v4 pve-storage 08/16] cephconfig: support escaped comment literals

2024-03-05 Thread Max Carrara
This commit allows our parser and writer implementations to support escaping and un-escaping the comment literals '#' and ';' [0]. [0]: https://git.proxmox.com/?p=ceph.git;a=blob;f=ceph/src/common/ConfUtils.cc;h=2f78fd02bf9e27467275752e6f3bca0c5e3946ce;hb=refs/heads/master#l179 Signed-off-by: Ma

[pve-devel] [PATCH v4 quincy-stable-8 ceph 3/16] debian: add patch to fix ceph crash dir permissions in postinst hook

2024-03-05 Thread Max Carrara
Ceph has a postinst hook that sets the ownership of '/var/lib/ceph/*' to ceph:ceph (in our case), but misses out on the contents of '/var/lib/ceph/crash'. This patch therefore also recursively updates the permissions of '/var/lib/ceph/crash'. Signed-off-by: Max Carrara --- Changes v1 --> v2: *

[pve-devel] [PATCH v4 pve-storage 11/16] cephconfig: change order of written sections

2024-03-05 Thread Max Carrara
in order to group related sections together. Signed-off-by: Max Carrara --- Changes v2 --> v3: * new; originally patch 07 of series v2, now adapted to this series Changes v3 --> v4: * none src/PVE/CephConfig.pm | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a

[pve-devel] [PATCH v4 pve-storage 07/16] cephconfig: allow writing arbitrary sections

2024-03-05 Thread Max Carrara
This adds support for writing arbitrary sections to 'ceph.conf' while ensuring that already written sections are not duplicated. Sections that are associated with the client, for example '[client.foo]', are written directly after the '[client]' section. Signed-off-by: Max Carrara --- Changes v1

[pve-devel] [PATCH v4 pve-manager 16/16] bin/make: gather helper scripts in separate variable

2024-03-05 Thread Max Carrara
Signed-off-by: Max Carrara --- Changes v2 --> v3: * new Changes v3 --> v4: * none bin/Makefile | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/bin/Makefile b/bin/Makefile index b221e4b1..180a91b5 100644 --- a/bin/Makefile +++ b/bin/Makefile @@ -25,6 +25,10 @@ SCRIP

[pve-devel] [PATCH v4 pve-storage 10/16] cephconfig: change code style inside config writer

2024-03-05 Thread Max Carrara
This commit changes the code style of subroutine `write_ceph_config` to match our style guide [0] more. Furthermore, the repeated calls to the inner subroutine are replaced with a loop, while the regular expressions used by the inner sub are now quoted with `qr` to prevent any accidental mis-quoti

[pve-devel] [PATCH v4 pve-storage 05/16] cephconfig: align our parser more with Ceph's parser

2024-03-05 Thread Max Carrara
1. Comments, irrespective of whether they start with '#' or ';' are now treated the same. Otherwise, sections and key-value pairs with a trailing comment starting with ';' are still parsed. Consider this example: [some.section] # inline comment after section foo = bar ; in

[pve-devel] [PATCH v4 pve-manager 14/16] ceph: introduce '/etc/pve/ceph'

2024-03-05 Thread Max Carrara
This commit adds the '/etc/pve/ceph' directory to our overall expected Ceph configuration. This directory is meant to store cluster-wide, non-private configuration files used by Ceph applications and services that are executed with lower privileges, such as 'ceph-crash.service'. The existence of